GitLab

https://pdfium.googlesource.com/pdfium.git/+log/a17a0e219d5f..3b76ebd56054

$ git log a17a0e219..3b76ebd56 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 dsinclair Fixup API check

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ief218c5ffb2b662bb101d028c80a0e6e6b5d8f45
Reviewed-on: https://chromium-review.googlesource.com/985651Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546759}

      level. Confirm that scale of Android app is changed as page zoom
      level is changed in Chrome settings. Note that Android side
      accepts scales from 85% to 150%.

Bug: 810473
Test: Open any Android app. Open Chrome settings and change page zoom
Change-Id: I5af0684f005cfe241c0ad3a7f529ab428f7580c5
Reviewed-on: https://chromium-review.googlesource.com/980073
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546758}

BUG=762641
TBR=afakhry@google.com

Change-Id: I722bb4de1e584041ac98c9ce71b490606d074285
Reviewed-on: https://chromium-review.googlesource.com/985535
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546757}

Blink scheduler code is transitioning to a new directory structure.
This patch moves a few files related to FrameScheduler, and rewrites
include paths in the affected files.

This patch introduces new directories: platform/scheduler/public and
platform/scheduler/main_thread. DEPS file is added to main_thread/
for moved tests.

Bug: 826203
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5894ccb0635922957aed6ada2a6e4e2e536d02e7
Reviewed-on: https://chromium-review.googlesource.com/983084
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546756}

No behavioral differences: a new struct (TrackedSession) is introduced
to represent what the tracker knows about a session, which is an
extended version of SyncedSession.

The set |tab_node_ids| is moved away from SyncedSession to the new
struct, because there's nothing that depends on it except the tracker
itself.

Somewhat unrelated, minor changes are introduced in the API as have
been suggested in code reviews.

Bug: 681921
Change-Id: Ife4c215b65dfbeb97d5c70fd1f984986b9938a8f
Reviewed-on: https://chromium-review.googlesource.com/983773
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546755}

Client (ClipboardInstance) of this version can handle a ClipData larger than 800K.

Android-side CL : ag/3763924
Doc : go/arc-image-cp

Bug: b:74877813
Test: cheets_ClipboardTest
Change-Id: I74dbd9e2e39cf5051b6f68cadef14ec5d769e897
Reviewed-on: https://chromium-review.googlesource.com/974669Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546754}

This CL implements recommendations from a Desktop PWA UI review.
 - Use "Install <app>..." instead of "Add <app> to shelf..." for PWAs.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331947&signed_aid=9D-HKXE7gYd0wUpreYCSAg==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331948&signed_aid=cDTnW4abw74CAZfks6FXkw==&inline=1
 - Use "Create shortcut" instead of "Add to <shortcut container>" for non-PWAs.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331943&signed_aid=Ok3VbYPcM5cA0kp1mufUcQ==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331944&signed_aid=Jn3zF1Bjunr7NY6U5HZs-Q==&inline=1

In addition to these changes the confirmation dialog for these actions
have been updated for consistency:
 - For PWAs:
   Use "Install app?" instead of "Add to shelf?" for the title.
   Use "Install" instead of "Add" for the button.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331949&signed_aid=NBRq_H4GTrT_Nlj4uJZUgg==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331957&signed_aid=yEqown9Qn32Do3_UyXfbGw==&inline=1
 - For non-PWAs:
   Use "Create shortcut?" instead of "Add to shelf" for the title.
   Use "Create" instead of "Add" for the button.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331945&signed_aid=vHvplIxwxZt1AbSCXNlRug==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331958&signed_aid=y82Q7ebdDf31vnnHy_vqcg==&inline=1

Bug: 789817, 822305
Change-Id: Ib2fbe35f43b575a985af6c50094235dc7693a149
Reviewed-on: https://chromium-review.googlesource.com/984916
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546753}

This patch moves block related functions
 - EndOfBlock()
 - IsEndOfBlock()
 - IsStartOfBlock()
 - StartOfBlock()
to "EditingCommandsUtilities.cpp" from "VisubleUnits.cpp" because these
functions are used only in files in "editing/commands/" for improving code
health.

Change-Id: Idbf3ebc0c29d44c955fe18d5e4a09b1d38aecfef
Reviewed-on: https://chromium-review.googlesource.com/985340Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546752}

Now that all the blocker issues(see bug below) are fixed, we can reenable this
feature.

Bug: 653200
Change-Id: I42c6bc582c4b7e4af770e093e46bbf12357c7753
Reviewed-on: https://chromium-review.googlesource.com/963642
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546751}

CompositorFrameMetadata can arrive on the UI thread out of order:
Metadata is sent from compositor to UI in response to synchronous or
asynchronous draws. The synchronous draw replies is processed
immediately, even if there are replies to asynchronous draws pending. So
when there is a mix of sync and async draws, it's possible for metadata
to arrive out of order.

This has been a theoretical problem for a long time, but only became
real problem when FrameSwapMessageQueue was expecting metadata to be
ordered. The only practical fix is to simply drop out of order metadata
instead, which FrameSwapMessageQueue is designed to handle already.

Bug: 821706
Change-Id: I493862ba6d0838097f26e824359f03017eaa2a35
Reviewed-on: https://chromium-review.googlesource.com/985096Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546750}

Use ToCharacterData(node)->length() instead of Node::MaxCharacterOffset()
to avoid to use indirection call.

Because has the default implementation of Node::MaxCharacterOffset() = NOTREACEHD()
and all call sites call it for CharacterData.
Hence, it is better to deprecate to use Node::MaxCharacterOffset().

Bug: 825077
Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com>
Change-Id: Ia7c44c0f92551295eb3e51cdd576ac172c2aaf25
Reviewed-on: https://chromium-review.googlesource.com/979894
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546749}

What CVC is doing with WebContentsObserver instance concerns
the action after navigation to a new contents. (whether it is
completed or render process is terminated). This CL handles
the task through a native, not Java WebContentsObserver.

There are 3 things involved for the task:
 - hidePopup / clear text selection (SelectionPopupController)
 - reset scroll (GestureListenerManager)
 - hide keyboard / (ImeAdapter)

Used GestureListenerManager to do all 3, just to avoid adding
numerous JNI calls. This is done by adding a new WebContentsObserver
so GLM can listen to the additional events in interest.

Bug: 598880
Change-Id: Ide527c0a594ed780e80522f733de6abd23ab3d6f
Reviewed-on: https://chromium-review.googlesource.com/972701
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546748}

This reference is not needed.
We can put the logic into DownloadManagerImpl.

BUG=803135

Change-Id: I7bdb0dfaa64d1860865566a67d8619fcd0f6bdaf
Reviewed-on: https://chromium-review.googlesource.com/985030Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546747}

MockObjectManager is currently not useful as the mocked methods are not
virtual.

BUG=chromium:812468
TEST=None

Change-Id: I3fa533299cda839b4f3602de88f6e76dbac5b24c
Reviewed-on: https://chromium-review.googlesource.com/982942Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546746}

This patch moves caret bounds related functions
 - AbsoluteCaretBoundsOf()
 -AbsoluteCaretRectOfPosition()
to "LocalCaretRect.cpp" from "VisubleUnits.cpp" to reduce size of
"VisubleUnits.cpp" for ease of maintenance.

Change-Id: Ie40d372bd78e7723feb7bf3e5ef73bcdb7d762df
Reviewed-on: https://chromium-review.googlesource.com/984758Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546745}

It's already used in a number of places in Blink. Blessing direct use of
the standard UMA histogram macros will also make it simpler to make
improvements to things like the macros for enumerations.

Bug: 742517
Change-Id: Ic7b83312e77918170c0dbabc92c1536fed673abc
Reviewed-on: https://chromium-review.googlesource.com/982946Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546744}

This CL fixes a null pointer crash when uninstalling an extension from
the app menu of a PWA window. The existing code expected the main UI
toolbar to be present.

Bug: 825554
Change-Id: I89353dd246168393747cca02f02444859b4457c6
Reviewed-on: https://chromium-review.googlesource.com/981839
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546743}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e367c2f4075..85a5ac7c6177

$ git log 4e367c2f4..85a5ac7c6 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 ihf cbuildbot: mark caroline/kevin-arcnext important.
2018-03-26 jkop chromite: Increase VM Test timeout to 90 minutes.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:826755,chromium:818859


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8c9699eac4f21cb7c857f820d12011111218406d
Reviewed-on: https://chromium-review.googlesource.com/985650Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546742}

This change fixes a crash when Native Filesystem Providers call the
Service::RequestMount() function via the providers_menu in the CrOS
Files App.

Bug: chromium:827023
Test: manually verified on eve
Change-Id: I25ba6fb33fe9c9ae1a360368c0d8bb45728fc7a1
Reviewed-on: https://chromium-review.googlesource.com/972421Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546741}

This patch moves the target |Unknown| because
there was a pushback in removal discussion:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/VllurNrBlL0/discussion

Until we can gather collect usage counter, postpone it.

Bug: 523952
Change-Id: I7844b37759b32120a2d542ce8ddb75e2c2230844
Reviewed-on: https://chromium-review.googlesource.com/983281Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546740}

For AppCache, almost all of the 'origin' have been converted to url::Origin
type. Convertion to GURL is still needed at quota api boundary.

Bug: 598424
Change-Id: I6d0ae63127b497d475c01a7a3affbbc8759ad700
Reviewed-on: https://chromium-review.googlesource.com/981962
Commit-Queue: Xunran Ding <xunran.ding@samsung.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546739}

Following interesting stuff happens during OnExtensionLoad:
  - ContentVerifier adds ContentVerifierIOData on IO thread through
    PostTask.
  - SharedUserScriptMaster loads user scripts that might end up
    creating ContentVerifyJobs (VerifyContent function) from
    UserScriptLoader::StartLoad.

There's no guarantee that VerifyContent will see the IO data added
by ContentVerifier. This CL ensures that user scripts will always
see IO data (if it was loaded) regardless of the timing: by hopping
to UI thread (essentially by yielding to
ContentVerifier::OnExtensionLoaded to PostTask IO data) and then
going to IO thread to call VerifyContent.

This CL also fixes and enables ContentVerifierTest.DotSlashPaths.
The test used to fail because it loaded content scripts that was
vulnerable to the bug. This CL also adds stricter expectations
to the test through TestContentVerifyJobObserver.

Bug: 826584, 825540
Change-Id: I95f3bfb934af6e82703113df973363543bfdbaea
Reviewed-on: https://chromium-review.googlesource.com/982938
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546738}

This updates an inefficient usage of flat_set in base::IDMap::Clear().
It used to insert all of its keys into a flat_set, which is O(n) time
for each and O(n^2) in total, and the new one inserts the keys in bulk,
which is O(n log n) time.

Change-Id: I8185823648682ecd7dcbc5427f1e39a43eeb3d37
Reviewed-on: https://chromium-review.googlesource.com/983275Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546737}

When overscroll-behavior-x for the root element of a page is set to
anything other than 'auto', gesture-nav should not start on the page.

Similarly, when overscroll-behavior-y for the root element of a page is
set to anything other than 'auto', pull-to-refresh should not start on
the page.

BUG=800074,742510
TEST=GestureNavSimpleTest.* in content_unittests

Change-Id: I86cf2f50c5ceb6613dc293c1fd32ca2cfff4daa2
Reviewed-on: https://chromium-review.googlesource.com/981127Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546736}

CrostiniInstallerView downloads the cros-termina component, then uses
CrostiniManager to start the concierge service and then a termina vm,
then a container.

If the above steps are successful, a new window running crosh connected
to the container is opened.

Bug: 813699
Change-Id: I459220b0481d46956b3f3ba5b5abdae063baa3bb
Reviewed-on: https://chromium-review.googlesource.com/967961
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546735}

This reverts commit 292706da.

Reason for revert: breaks RK3399, where we don't have ARGB+AFBC support yet:

  https://bugs.chromium.org/p/chromium/issues/detail?id=826973

once

  https://chrome-internal-review.googlesource.com/c/chromeos/vendor/mali-ddk/+/597023

lands we can reland.

Original change's description:
> Reland "ozone/drm: Render primary framebuffers as RGBA"
> 
> This is a reland of 48d1ecaf
> 
> With CL:967415 and CL:964984, we've fixed the issues where RGBA
> framebuffers slipped through to KMS on devices without RGBA support.
> 
> Original change's description:
> > ozone/drm: Render primary framebuffers as RGBA
> >
> > In preparation for hardware plane underlay support in ChromeOS, we
> > need to allow for RGBA primary framebuffers. When using an underlay,
> > we cut out a transparent rectangle in the primary framebuffer to allow
> > the underlay to show through, while still allowing for RGBA content on
> > top of the underlay (for example, video controls or annotations).
> > When not using an underlay, the primary framebuffer will be displayed
> > as RGBX (opaque) to avoid unnecessary blending in the display
> > controller.
> >
> > Bug: 789288
> > Change-Id: I2fc94e524e250ec9b7e11cd6801e1c8308046a10
> > Reviewed-on: https://chromium-review.googlesource.com/801974
> > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> > Reviewed-by: David Reveman <reveman@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#542877}
> 
> TBR: piman
> Bug: 789288
> Change-Id: Ie1032615d8970c6a74f354ad78c30679706e40ed
> Reviewed-on: https://chromium-review.googlesource.com/975782
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545503}

TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789288
Change-Id: I980fb2dda940cf0b9bdfbdb8b88c2c519f5e9f85
Reviewed-on: https://chromium-review.googlesource.com/985255Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546734}

Also call EnsureNSSInit in CertVerifyProcNSS, shouldn't just assume something has already done it.

Gets some NSS usage off of the IO thread.

Bug: 59847
Change-Id: I08b77c5f641d1bb67de26a8c057372f4fef7037f
Reviewed-on: https://chromium-review.googlesource.com/963616
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546733}

https://chromium.googlesource.com/catapult.git/+log/b1c9ad5aa1d0..191fda7cc6ae

$ git log b1c9ad5aa..191fda7cc --date=short --no-merges --format='%ad %ae %s'
2018-03-28 nednguyen Remove Page._collect_garbage_before_run param
2018-03-28 simonhatch Pinpoint - Add closing </p> tag to new-job-fab

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I46a644d72c955b71f08a692404ae9fc4d7f9064b
Reviewed-on: https://chromium-review.googlesource.com/985634Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546732}

This provides a way to more concisely do asynchronous work using
lambda syntax and also register asynchronous tasks as scopes
watching Observables. For example:

    AsyncTaskRunner runner = new AsyncTaskRunner();
    state.watch(value -> runner.doAsync(
            () -> { /* do work asynchronously */ },
            result -> { /* handle response on UI thread */ }));

The above code will run the asynchronous task whenever `state`
activates, and cancel the asynchronous task automatically if
`state` deactivates. No more null-checks and canceling existing
tasks when a creating a new task!

Refactored ExternalServiceDeviceLogcatProvider as an example.

Bug: None
Test: cast_shell_junit_tests
Change-Id: Iaa277ff75cd398fb1e50fd1c25e2d6afdb4c5b31
Reviewed-on: https://chromium-review.googlesource.com/980671Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546731}

Before this patch, SignedExchangeHeader fuzzer passed the entire input
to the parser. But the seed corpus (htxg files) have 3-byte encoded
length prefix and exchange body.

After this patch, the fuzzer extracts the encoded header length, and
create parser input based on it. This will increase the chance the
CBOR parser gets valid input, so the fuzzer exercises more code.

Bug: 803774
Change-Id: I7334017c4c3e56a95f5699d6c3750eed7e62bc81
Reviewed-on: https://chromium-review.googlesource.com/985336Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546730}

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546729}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ceb34538985..a16b4ccd5521

$ git log 6ceb34538..a16b4ccd5 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I416a441792df5279b78b6b12f2303099fff7d4d1
Reviewed-on: https://chromium-review.googlesource.com/985123Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546728}

https://chromium.googlesource.com/angle/angle.git/+log/8a02d3b57b30..a3b220f36f51

$ git log 8a02d3b57..a3b220f36 --date=short --no-merges --format='%ad %ae %s'
2018-03-06 tobine Vulkan: Adding null driver as device option

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I97ac9d33078565e83c4bb48c88fda7ce38ac1106
Reviewed-on: https://chromium-review.googlesource.com/985626Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546727}

https://webrtc.googlesource.com/src.git/+log/467057ec7fe7..7abc9a07d774

$ git log 467057ec7..7abc9a07d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:826720,chromium:826720,chromium:826655,chromium:None,chromium:b/77199993,chromium:none


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib24def67d5d129b206f2dc5b390e371701b028e3
Reviewed-on: https://chromium-review.googlesource.com/984728Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546726}

GpuVideoAcceleratorFactoriesImpl calls BindToCurrentThread() on media task
runner, so releasing the reference should also happen there to avoid race
conditions. crrev.com/c/959432 introduced the regression, since we took
care of initialization, but we didn't take care of destruction.

Bug: 826539, 580386
Change-Id: I2fff505b445bca7ff38343f6f1e5d3035a06714e
Reviewed-on: https://chromium-review.googlesource.com/984438Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546725}

Use the same function to retrieve favicon for web contents for MacViews
as on the other platforms, so the favicon can be displayed.

BUG=792605

Change-Id: Ide93ddb52747f86e04d09f7741af6e881d5374d6
Reviewed-on: https://chromium-review.googlesource.com/979258
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546724}

Most resize/synchronization related operations going from browser=>
renderer happen through ViewMsg_Resize except auto-resize. In auto-resize
mode three additional IPCs are used:

ViewMsg_EnableAutoResize
ViewMsg_DisableAutoResize
ViewMsg_SetLocalSurfaceIdForAutoResize

This introduces a lot of auto-resize specific complexity that should
not exist. In this CL, all three auto-resize IPCs are removed and their
operations are coalesced into ViewMsg_Resize.

In the future, we'd like to allocate LocalSurfaceIds in both the parent
and child. By de-special-casing auto-resize, this allows us to simplify
the surface synchronization protocol.

Change-Id: I6d0142353830e0740e67dc7b6075f5588a8e1230
Bug: 672962
Reviewed-on: https://chromium-review.googlesource.com/981394Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546723}

Change the open button when it's displayed as a combobox to open the
options list instead of opening the file when there are more options.

Open button is only displayed as a combobox when there are more than
one application for the selected file, otherwise it's displayed as
a regular button.

This change of behavior is to make the open button (as combobox)
accessible via keyboard and screen reader (Chromevox).

IMPORTANT: This is a change of behavior, but this seems more consistent
since the UI displays the button as a combo, it's expected that enter
key or click open the combo list, instead of triggering the "open"
button which is open with default app. Users already have option to
use enter key to open the file without the "open menu".

Test: browser_test
Bug: 793723
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8dab527805cb687103882e1b650b857fd5fb876c
Reviewed-on: https://chromium-review.googlesource.com/970048Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546722}

Also added a test to detect the case when cookie CRUD protocol methods
operate on different cookie storage with regards to the network layer.

Bug: 721408
Change-Id: If81d4b2c1e13d69289e6dc006aabf9879fa80b11
Reviewed-on: https://chromium-review.googlesource.com/985246
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546721}

All unchecked code will contain errors and apparently, due to quirks of
VC++ template compilation, emulated by clang-cl, the ThreadSpecific<T>
destructor was never *really* compiled. It referenced two functions and
one variable and only one of these three things actually existed. This
was reported by Microsoft who use chromium as a compiler torture test.

Bug: 825352
Change-Id: I5dd1868acda760ef33dde518d72e3d7694fad9a8
Reviewed-on: https://chromium-review.googlesource.com/978849
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546720}