- 05 Mar, 2019 40 commits
-
-
Nicolas authored
Also, migrate the BrowserSwitcherEnabled policy in the other direction, as "browser_switcher_enabled". This CL refactors ChromeExtensionPolicyMigrator to make it easier to transform values (e.g. convert types) as they are being migrated. Bug: 909880 Change-Id: I0d49bd9296a096da713a2d6cface9eab724b29d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500203 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637862}
-
Anthony Vallee-Dubois authored
This resets the backoff state in order to re-run the experiment in India Bug: 936028 Change-Id: Id55c80ce6ff3d4b4c824a4c1833a5f5d3c03d202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504129Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#637861}
-
siashah authored
Change the title from "Update expiration date" to "Enter expiration date" Demo: https://screenshot.googleplex.com/N5Lzem5GFFV Bug: 926316 Change-Id: I4ded120187dd31478e19e35f56807e0a97fb2f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504215Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#637860}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Also convert IOSPaymentInstrumentLauncher (and its unit tests) to use the new base::Value API instead of the deprecated one. Bug: 925165, 646113 Change-Id: I74ddfbb9a0752967ead0b73ebe2ce3f06a96d225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503373 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637859}
-
Sammie Quon authored
This is consistently failing. I will try finding a proper owners to diagnose why it is failing but in the meantime disabling to get the bots green. Test: none Bug: 938575 Change-Id: Ib3867bb01c67776ccd5b6aa0db082d485157c759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504252Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#637858}
-
rbpotter authored
Moving: SetLayout/SetMargins/SetPagesPerSheet/SetColor => *_settings_test:'select option' Moving: DisableMarginsByPagesPerSheet => margins_settings_test: 'disabled by pages per sheet' Adding some 'set setting' tests (all are almost identical) validating that setting the setting updates the UI. Also fixing some small issues found due to new individual section tests running on debug builds: - Missing includes - Margins settings -> use an (already existing) enum, not hardcoded values. Change-Id: Ia29beafdfcb66634a33279c2c98fe08f9cea9084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501793Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637857}
-
Jordan Taylor authored
web_tests/animations/animationworklet/scroll-timeline-overflow-hidden.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-overflow-hidden.https.html web_tests/animations/animationworklet/scroll-timeline-overflow-hidden-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-overflow-hidden-ref.html web_tests/animations/animationworklet/scroll-timeline-root-scroller.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-root-scroller.https.html web_tests/animations/animationworklet/scroll-timeline-root-scroller-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-root-scroller-ref.html Bug: 915352 Change-Id: Ia48d26bb3a61e773d6e85a637f53790b568343ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490216Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#637856}
-
Tomasz Wiszkowski authored
This change ensures that currency conversion answers are shortened to offer just final result, eg. instead of: 1,000 United State Dollar = 1,330.75 Canadian Dollar 1000 usd to cad this will show: 1,330.75 Canadian Dollar 1000 usd to cad Bug: 936730 Change-Id: I1222c5fba17e6cca07947e37bc2494f89abec98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500915Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#637855}
-
Tao Bai authored
This patch added metrics for ContentCapture in renderer and have the test for ContentCaptureTask related metrics. Bug: 924681 Change-Id: I00913a46b53a7c5bc76b0fbd80b3cf2e51d9bd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490762Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637854}
-
Tatiana Buldina authored
Bug: chromedriver:427 Change-Id: Ic17855832f7d865c42fb51f5d240de8e965d88ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497197Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#637853}
-
Joel Einbinder authored
The constructor name was not being passed correctly into the JSON, which was causing static methods to be incorrectly parsed as unique top level functions. Bug: 913363 Change-Id: If0a94184cceef0c16b8755fe375aad3e2e48de0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501495Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#637852}
-
chrome://flagsMarijn Kruisselbrink authored
Bug: 929490, 853326 Change-Id: Ie2149b7a753d95c02067fcd1ff13c6c03426953a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501574Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#637851}
-
Joel Einbinder authored
If the tab pane itself is selected, as opposed to one of the buttons we should move focus to the newly selected tab. Bug: 854505 Change-Id: I6f1b440d65500ccb8dd4d3c8ceab749b6fa39131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501949Reviewed-by:
-
Joel Einbinder authored
Previously we were bailing out of searches if the previous search returned no results. But things might have changed since the last search. So always perform a search if the user presses enter. Bug: 859881 Change-Id: Ibd6a576c69a2e508583c377d7a4d064bbefa403e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500629Reviewed-by:
-
Tarun Bansal authored
This is not being used in actual production. This CL - Removes the observer - Marks the corresponding histograms as obsolete. None of these are being recorded as per http://shortn/_87vkPT3VpS - Removes some of the browsertests Change-Id: I4c79538854076dfa2b990578ce1a3898a87365d0 Bug: 778222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496657Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#637848}
-
Xiaocheng Hu authored
The mojo API is a no-op other than on Android with |enabled| being false. This patch refactors it and renames it into |DisconnectSessionBridge| to make the behavior more explicit. Bug: 814225 Change-Id: I786411375edd594806fb2f7bcdc7b884be4352fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500016 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637847}
-
Nate Chapin authored
Currently, the FrameTreeNode destructor ensures that its navigation_request_ is cleared, but does not ensure that navigation has been cancelled for any of the other criteria it uses to determine that it is loading. Ensure that the current and speculative RenderFrameHostImpls are reset as well. Many tests tear down a WebContentsImpl without ensuring that it is done loading, and that is benign. However, it is possible to get a situation where a subframe FrameTreeNode is detached while still loading. If it is the last frame loading, this will cause the FrameTree to transition from loading to not loading without an associated DidStopLoading() callback. WebContentsObserverSanityChecker DCHECKs on the rare case where that happens. Bug: 916413, 795479 Change-Id: I5abed2648dba2eb99db66a222b4fb5a22d594612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1455110 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#637846}
-
Jenny Zhang authored
Bug: 938540 Change-Id: Ic4441c4bf5fbc2ca82b4a0393e96514ea4e99d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504051Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637845}
-
Jarryd authored
Change-Id: I3a09a2b8d2fabacbb625e7029e97121a83a03250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504217 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
Erik Chen authored
The perf trigger script requires that all shards are dispatched simultaneously. The go implementation of 'swarming.py trigger' requires one invocation for each shard. This CL adds a field to the perf trigger script dictionary so that the recipe engine can correctly handle the different dispatch requirements. Bug: 926987 Change-Id: I52b739afc707dd77acd012ca483f5ce27dd7bbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501950Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637843}
-
Anne Lim authored
Metric that logs when a strike is expired (per-project) and metrics to track how many LocalCardMigration strikes there are when migration was accepted. Bug: 884817 Change-Id: Ia904c08b708b4da716670a39fceab2a4e54bbca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497433Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Christopher Cameron authored
This modifies 3 parts of WebContentsViewMac and its friends. 1: Initiation of a drag from web contents This action follows the following path * WebContentsViewMac::StartDragging is called, which calls * -[WebContentsViewCocoa startDragWithDropData...], which * Creates a WebDragSource (to store state for the drag) and calls * -[WebDragSource startDrag], which calls * -[NSWindow dragImage...] This doesn't work across processes because the WebContentsViewMac now exists in the browser process and the WebContentsViewCocoa exists in the app shim process. Fix this by adding the mojo method WebContentsNSViewBridge::StartDrag, which is called by WebContentsViewMac::StartDragging in the browser process, and makes the -[WebContentsViewCocoa startDragWithDropData...] when it is received in the app shim process. 2: Completion of a drag via -[NSDraggingSource draggedImage...] This method takes the following path * -[WebContentsViewCocoa(NSDraggingSource) draggedImage...] is called by the system, which then calls * -[WebDragSource endDragAt:], which then calls * WebContentsImpl::SystemDragEnded and WebContentsImpl::DragSourceEndedAt This doesn't work across processes because the WebContentsViewCocoa is in the app shim process while the WebContentsImpl is in the browser process. Fix this by adding the mojo method WebContentsNSViewClient::EndDrag, which is called by WebDragSource in the app shim process, and makes the WebContentsImpl calls when it is received in the browser process. 3: -[NSDraggingInfo namesOfPromisedFilesDroppedAtDestination] is called This method takes the following path * -[WebContentsViewCocoa(NSDraggingInfo) namesOfPromised...] calls * -[WebDragSource dragPromisedFileTo...], which creates a * DragDownloadFile, which uses the WebContentsImpl Same as the above, the WebContentsViewCocoa cannot access the WebContentsImpl, so we add a mojo method to bridge between the two. Move tracking of state for the drag (e.g, the source RenderWidgetHost) from WebDragSource to WebContentsViewMac. This eliminates the last need for accessing the WebContentsViewMac in WebContentsViewCocoa and WebDragSource, to remove the related member variables. Because the use of base::ThreadRestrictions::ScopedAllowIO is moved by this patch, update it to be ScopedAllowBlocking and add WebContentsViewMac as a friend of ScopedAllowBlocking. Bug: 898608 Change-Id: I4e7f069e96902b7f0ef26e8579444be96b765a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497543Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#637841}
-
Simon Que authored
Bug: 915568 Change-Id: I1c35ab46ee53526efdfa356ffbe693935570990b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501776Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#637840}
-
Charlie Harrison authored
This is failing on Win7 Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29?limit=200 Failures are causing python errors because the "failures" element must be a list. The actual cause of the failure is not yet known. Bug: 938020 Change-Id: I53742dbf49f97a8828af5675a0360e431ed376c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503614Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#637839}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc019f471fc2..6ce450029683 git log fc019f471fc2..6ce450029683 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 cjmcdonald@chromium.org Added more configurations to VSCode Import Sorting 2019-03-05 evanhernandez@chromium.org branch_archive_stages: Support artifacts.json 2019-03-05 saklein@chromium.org cros_sdk_lib: Remove the memoized chroot updater. 2019-03-05 dgarrett@google.com cbuildbot_view_config: Add --builder. 2019-03-05 allenwebb@google.com usergroup_baseline: Remove /var/empty from nobody's homedir. Created with: gclient setdep -r src/third_party/chromite@6ce450029683 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I859e4db1722a48b283a9a941d4727b1a4ed3e812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503797Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637838}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59db7d4f1098..b56862dc292a Created with: gclient setdep -r src-internal@b56862dc292a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790399 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I2d6955ff7430c9e886b73ce960ba7b4b1a1d64c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504174Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637837}
-
Andrew Grieve authored
The test runner assumed resource filenames were unique, which recently changed. TBR=wnwen # Expediting small change to fix bots Bug: 935576, 938607 Change-Id: I3fb0105388c6d71427518a9f7b8831ed34388a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504228Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#637836}
-
Tanja Gornak authored
Currently fcm channel and subscription to topics use same enum in order to track their state. This Cl introduces separate enum for the Fcm channel state tracking. Bug: 801985, 878446 Change-Id: I4a462414852d9bc77c45da125c2a0598afffa8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502912 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#637835}
-
Peter Kasting authored
This aims to restructure the tests so the functional diff from the fixes is small enough to be reviewable. There are minor functional changes in this patch which aren't intended to meaningfully affect the tests. Primarily, this involves refactoring so tests which do common functionality use a common base class (so we can fix just one place); sequential steps are broken into better-named pieces; and those pieces are named in ways that will correspond to how they will be organized later (e.g. with widget observers instead of direct calls eventually driving things). Hopefully this CL is still clearer on its own than the previous code, but in some cases the exact organization of code may look a bit unmotivated. Bug: none Change-Id: I43560992eb83dff6c7d19c161dcb4ff8b6c52d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479421Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#637834}
-
Victor Vasiliev authored
Replace connection_id_length in QuicPacketHeader with connection_id_included Historically, QuicPacketHeader has included two fields: destination_connection_id_length and source_connection_id_length, because in older versions of gQUIC (that have since been deleted) there was a way to compress the connection ID by only sending a variable amount of bits. In all currently supported versions of QUIC, there are only two options in a given header: connection ID present and connection ID absent. Therefore this CL replaces these length fields with corresponding destination_connection_id_included and source_connection_id_included. This will allow us to support connection ID lengths that are not 8 in the future. Merge internal change: 236736901 https://chromium-review.googlesource.com/c/1504055/ Stop using AckBundling mode to send ack and replace ack_queued with scheduling ack_alarm to now. No functional change expected, protected by quic_reloadable_flag_quic_deprecate_ack_bundling_mode. With this change, ACKs will be sent in 3 cases: 1) Anytime there is data to send, bundle an ACK if ack_alarm is set. 2) If there is no data to send or packets get received after frames get queued, send an ACK only if ack_alarm expires now. 3) Send an ACK when ack_alarm goes off. Merge internal change: 236725546 https://chromium-review.googlesource.com/c/1504126/ Deprecate quic_keep_ack_decimation_reordering. Merge internal change: 236719336 https://chromium-review.googlesource.com/c/1504004/ Deprecate --quic_restart_flag_quic_check_blocked_writer_for_blockage Merge internal change: 236709014 https://chromium-review.googlesource.com/c/1504125/ Add tests for version negotiation to QuartcEndpointTest. Allows QuicVersionMangers to be injected into both client and server implementations of QuartcEndpoint, in order to control version support in tests. Adds two tests to QuartcEndpointTest for behaviors surrounding version negotiation: - One test actually performs version negotiation: the client picks a version that the server doesn't recognize and the server negotiates for an older one. - One test confirms that the server can accept connections on any supported version: the client picks an older version and starts that. Moves all the fakes from quartc_session_test into a shareable test-only library. Merge internal change: 236677680 https://chromium-review.googlesource.com/c/1504124/ In QUIC, fix connection close's encryption level. Protected by quic_reloadable_flag_quic_fix_termination_packets. Merge internal change: 236663907 https://chromium-review.googlesource.com/c/1504123/ Fix Quartc 0rtt test in chromium. More importantly, this fixes a lifetime issue that occurred in the simulator. Simulator assumes that once an actor is added, it is alive for the entire simulation. Destroying an actor (in this case the client endpoint) may cause runtime failures. (in this case, new object was allocated at the same address, which caused a DCHECK in simulator). Merge internal change: 236660882 https://chromium-review.googlesource.com/c/1504120/ Deprecate quic_reloadable_flag_quic_encryption_driven_header_type Merge internal change: 236650118 https://chromium-review.googlesource.com/c/1504118/ Deprecate gfe2_reloadable_flag_quic_always_reset_ietf_connections. Merge internal change: 236645139 https://chromium-review.googlesource.com/c/1504001/ R=rch@chromium.org Change-Id: I67c2e21e3f23108bb96c1fc1d861fbea5816dfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504233 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637833}
-
Xiaocheng Hu authored
This reverts commit 6d77a353. Reason for reland: Max recursion depth is reduced to avoid stack overflow. Original change's description: > Revert "Fix caret rendering when at the end of a block after an ineditable inline" > > This reverts commit e9aa20fd. > > Reason for revert: this change breaks tests on win dbg bot > > This is the first failure > https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/6437 > > Test InsertListCommandTest.CleanupNodeSameAsDestinationNode is definitely fails because of this patch (I've verified it locally on Windows). > The problem with this test that it's very deep recursion in function between functions > AdjustBlockFlowPositionToInline > ComputeInlineAdjustedPositionAlgorithm > > and as a result stack overflow. > > > Original change's description: > > Fix caret rendering when at the end of a block after an ineditable inline > > > > AdjustBlockFlowPositionToInline() has an early-reject branch that avoids > > infinite recursion, introduced in crrev.com/664b6437. > > > > However, the early reject condition is too aggressive that, it also > > rejects some positions that don't enter an infinite recursion, like > > the one used in the new unit test added in this CL. > > > > As now AdjustBlockFlowPositionToInline() has a hard limit on recursion > > depth, this CL safely removes the over-aggressive reject condition, so > > that caret can be correctly rendered for more positions. > > > > Note: Unit test InlineBoxPositionTest.ComputeInlineBoxPositionMixedEditable > > uses another position that doesn't enter the infinite loop but is falsely > > rejected by the condition. This patch allows caret rendering also for that > > position, and therefore changes its test expectation. > > > > Bug: 936988 > > Change-Id: Idef91ffaa412e67cddd5fcf0dd61f54055de7189 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497466 > > Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637311} > > TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org > > Change-Id: I6fcff118f27d633e627d5942671b04554fef283b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 936988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503579 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637676} TBR=yosin@chromium.org,yoichio@chromium.org,dvadym@chromium.org,xiaochengh@chromium.org Change-Id: Ic959d3d57558995a315269bb938b75307efb6ea8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504226 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637832}
-
Matt Menke authored
Previously, socket pools could stack on top of each otherwise, with each socket in one pool owning a socket in the lower pool. When a lower layer pool had no available socket slots and a pending request, it would call into the next layer up and ask it to close a socket. Now that socket pools are no longer layered on top of each other, socket pools no longer have to have the logic to act as the higher layered pool. This leaves the code in place for socket pools to act as a lower layer pool, however. H2 connections can still sit on top of socket pools, and each session is treated as a higher layer "pool" when a socket pool is stalled at its global socket limit. Bug: 472729 Change-Id: I3bbec857166a46a86b07d9ecb96cc77022a7f5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496490Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637831}
-
Xianzhu Wang authored
- Avoid two comparisons when updating an animatable paint property node - Avoid checking animation status in both PaintPropertyTreeBuilder and XXXPaintPropertyNode. This also makes the checking consistent. Previously we checked style.IsRunningXXXAnimationInCompositor() in PaintPropertyTreeBuilder and CompositingReason::kActiveXXXAnimation in XXXPaintPropertyNode which was incorrect because the latter also includes animations that are updated in the main thread (while we composite the layer to accelerate rendering changes). - BTW, don't ignore transform origin changes during composited animation. Change-Id: I889b0d5155d0744ba3fa9b44621e83402e113900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498030Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637830}
-
Stefan Zager authored
Previously, the dirty flags to IntersectionObservation::Compute were computed by doing a walk up the ancestor tree. This is silly, since the IntersectionObserver algorithm runs in a top-down tree walk. This CL propagates ancestor frame flags down to child frames to avoid the tree walk. R=chrishtr@chromium.org Change-Id: I09f95696ce4d22c15ee76bc0a0ecc4e12778284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501492 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#637829}
-
Tommy Martino authored
This CL adds an enum describing the type of data contained in a sheet. Bug: 902425 Change-Id: I36a9b06465af839d324ad1d56dc629915d3e597e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484811 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#637828}
-
Takumi Fujimoto authored
Instead of having a stop button contained in the sink button, make the entire sink button clickable when the sink state is CONNECTED, The stop button worked by activating the entire button, so no extra logic is necessary to make the sink button send the stop request. Focusing on the sink button (tab or mouse hover) changes the status text to "Stop casting". Bug: 900012 Change-Id: I6abce70735bf7920e314063a3326268b54d27b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497632Reviewed-by:
-
Matt Menke authored
The class is going to be merged into HttpProxyConnectJob, which it used to be part of, and can be part of once more, now that proxy auth is handled entirely while a single ConnectJob is in a socket pool. There are only two tests for QUIC proxies in the file: 1) HttpProxyClientSocketWrapperTest.QuicProxy is redundant, given QuicNetworkTransactionTest.QuicProxy passes. 2) HttpProxyClientSocketWrapperTest.QuicProxySocketTag is much like QuicStreamFactoryTest.Tag, except it also checks the HttpProxyClientSocketWrapperTest passes the the SocketTag to the QuicStreamFactoryTest.Tag. Given the significant setup needed to test QUIC, and the fact that there are no other QUIC tests at this layer, I'm not sure the test is worth the cost of creating a new test fixture just for it. Bug: 938569 Change-Id: I8f2dd83ba2348abfb0a4426c7da9394c6e14013d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504003Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Change-Id: Ieea938de39081ef958fc82d0c971ededd8214b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504117Reviewed-by:
Tommy Martino <tmartino@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#637825}
-
Yuchen Liu authored
For some web pages, we'd like to use DefaultRendererFactory, so that we can render video on graphics plane. This is mainly used to support playing short video on top of another Cast web page. Bug: internal b/125912333 Test: Playing video on top of YT doesn't break any pages. Merge-With: eureka-internal/247900 Change-Id: Ibbcd3ee13e6642aa4d9ab1548a8f64ce95329fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496008 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#637824}
-
Istiaque Ahmed authored
Bug: None Test: file_manager logs will show spelling correction. Change-Id: I5688ef6b973147adbc55c16a5f2fe49866bb405c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504114Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#637823}
-
