- 28 Oct, 2020 40 commits
-
-
Tanya Gupta authored
They will not be created on demand. This simplifies the logic to decide which options are relevant given the current state of the Chrome app. Change-Id: I9b3ebf3030cfaa48088d7c1d0082d659b47f28cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485838 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821914}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a73a21f. With Chromium commits locally applied on WPT: 2b985496 "Add webgl2 tests for WebXR" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I6db4d725f347328fdb10dc30f37e92c5c44e8ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505606Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821913}
-
DimanNe authored
Return std::unique_ptr<WebAssociatedURLLoader> instead of raw pointer from WebLocalFrame::CreateAssociatedURLLoader() R=kmoon@chromium.org Bug: 1127146 Change-Id: Iac86abe5d0e41468a9d1fb2dd610f2c5278da9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500843Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821912}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3542c2cb..81a2c08d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0956d3ee944a29440373b5291be5d87eec525e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505461Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821911}
-
Oriol Brufau authored
IndefiniteSizeStrategy::FindUsedFlexFraction needs to iterate all grid items that cross a flexible track. To do so it, takes the indices of the flex tracks, and for each one it uses GridIterator to iterate the items in that track. Then, to avoid processing the same item multiple times, it used to check that the item started in the current flex track, not in a previous one. However, this was insufficient: it wasn't taking into account that an item can be in a single flex track, but span multiple tracks in the other axis. Therefore, this patch changes it to use the same approach as in GridTrackSizingAlgorithm::ResolveIntrinsicTrackSizes, i.e. creates a HashSet outside of the loop, and inserts each given grid item to it, checking whether it's a new entry or not. Bug: 1026275 Change-Id: Ia0327e0459f2398de84b27851be53867f9be5f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506210Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#821910}
-
Rodney Ding authored
- currently when CSS.supports is called it does not pass in the ExecutionContext to the css parser context, hence it does not support Origin Trial enabled properties/values. - This changeset added plumbing to pass in the top level document to CSSParserContext which we extracted from ExecutionContext. - Repurposed one of the ParseValue overload and change all its callsite to pass in ExecutionContext, they were previously passing in ExecutionContext->GetSecureContext() - CSSParserContext used in support parsing are constructed using the document if the execution context belongs to one. We then override the parser mode to kHTMLStandardMode as quirks mode values must not be supported in CSS.supports method according to https://quirks.spec.whatwg.org/#css This is also in line with current behaviours before document is added to the context. - Added virtual test that checks for CSS.supports(condition) and CSS.supports(property, value) Bug: 1134237 Change-Id: I4c1b3cd2707f3ce5495ee298a909e3f42946fc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477014Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#821909}
-
Aaron Leventhal authored
Fix cases where AnyDescendantWasReparented() fails to notice a reparenting occurrence, because it stops recursing when there is an unignored node. This is correct; however, sometimes it thinks something is unignored when it's really ignored, because there are two places to look for this info -- currently it only looks to see if the node was ignored at the end of the previous serialization, but it also needs to check if the node has recently become ignored. In release builds, these illegal reparenting crashes cause a Reset(), which is a fail safe, but also indicates there's an inconsistency, leads to performance problems and causes virtual buffer resets. Cleaning up these types of issues over time will improve stability, performance and predictability. Bug: 1141720,1141916 Change-Id: I4e1d065df08c2bf642561618b435fc7a987eafc1 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504194 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821908}
-
Dana Fried authored
This expands the scope of what can be put in this folder to include more than just the IPH bubble and controller. For example, code allowing the "New" badge to be displayed on some Chrome elements to denote a new feature. Change-Id: I4c7570dbb2333069f5bcf4f3ea80aca8f95ca84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496343 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#821907}
-
David Black authored
Previously the code which determined the index at which to insert a view for a finalized item assumed that newer finalized items would have already been added as views before older finalized items. This assumption is not true when showing UI with a model already containing finalized items. Bug: 1143371 Change-Id: I836d8169b8ded78e418abd70bd95a146ababef53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505960 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821906}
-
manukh authored
Removes 2 features that were enabled by default in crrev.com/c/2314268 which rolled out with m86: - OmniboxHistoryQuickProviderAllowButDoNotScoreMidwordTerms - OmniboxHistoryQuickProviderAllowMidwordContinuations Bug: 591981 Change-Id: I3f0137dd432af8895d48e52695912c312bb57fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506389Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821905}
-
Reilly Grant authored
This flag is shipping on Windows enabled-by-default in M-87 so I would like to keep it available in M-88 for debugging purposes. On macOS this flag is still disabled-by-default so I am extending the expiration through M-90 to give us time to complete the work necessary to enable it everywhere. Bug: 637404, 1096743 Change-Id: I50f82a79e65ea5b14c1549e0969d726d76990d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506349 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#821904}
-
David Jacobo authored
Currently ArcCustomTabs is enabled by default with no easy way (ie no longer listed in chrome://flags) for the user to disable, this shouldn't be an issue but due to stability concerns it would be better to assume a safer approach, this CL does that by marking such feature as DISABLED_BY_DEFAULT. Bug: 1065124 Test: Build. Change-Id: I0682b05629bc5892ad04871f244f3e3b7119dcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506151 Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#821903}
-
Matt Menke authored
Also remove MockPersistentNelStore::GetDebugString(). It's only used in a single LOG statement in a single test. Bug: 993805 Change-Id: I03e52c5a327d6ec1c9e7c6913e3869a106664202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505939 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#821902}
-
Daniel Cheng authored
This also converts FontDisplay to be a scoped enum, which allows: - clang to enforce kMaxValue correctness - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION. Bug: 742517, 1047547 Change-Id: Iabb56121750acac4147e20bffe132bde190d9f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505676 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821901}
-
Henrique Nakashima authored
Limit results to 20 and bubble up the ones whose class name starts with the search term. This favors ".c.b.tabmodel.TabModelImpl" instead of ".c.b.tabmodel.Foo" for the search string "TabModel". The main reason is performance, it takes a couple of seconds for the browser to react when the search term is changed at the moment in the class graph. Bug: 1142610 Change-Id: I6e73a603114360bda561ca5c3e78f64f372f257d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500463 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821900}
-
Alexander Timin authored
- Merge back_forward_cache into navigation folder. - Move scheduling-related histograms from other to scheduler/. - Add myself as owner for scheduler/ and navigation/. R=sweilun@chromium.org,isherman@chromium.org Change-Id: I6b4d296be8316d65fd6e7da1371f986fcf2fe706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503730Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821899}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/47e66f22759a..77defeb04693 2020-10-28 jmadill@chromium.org Add the ability to re-trace existing traces. 2020-10-28 jmadill@chromium.org Fix unintialized data in VertexAttributeTest. 2020-10-28 cnorthrop@google.com FrameCapture: Handle glReadPixels with pack buffer 2020-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 03f6ffd1dc46 to 87b0951f8dba (12 revisions) 2020-10-28 jmadill@chromium.org Capture/Replay: Always base replays on frame "1". If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: Capture PUBG Mobile Change-Id: Ifb7b08a49489585c5a5ad3c6a60b2df13dcbd2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821898}
-
Alice Gong authored
Bug: 1093321 Change-Id: Id513ffc0b7f2bdae8560817e5a69ecc8f52d26a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499082Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Alice Gong <alicego@google.com> Cr-Commit-Position: refs/heads/master@{#821897}
-
Kyle Horimoto authored
We're still interested in looking at these histograms over the next year to monitor success metrics for settings/search. Fixed: 1140016, 1140017 Change-Id: I7f4625ea00c9a62f993074dd5caf0a7d19388f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506235 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/541601602ee9..e25c30034a63 2020-10-28 herb@google.com use SkArenaAlloc for combineIfPossible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I1ab2ee6f5ad19f820028ccfd6c7e3d9d4e624e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506256Reviewed-by:
-
Chris Hamilton authored
This creates a helper that allows NodeAttachedData on abstract ExecutionContext node wrappers. BUG=1080672 Change-Id: I8587841824bcf65a91eff85ab259f4b7321e0016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506231 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#821894}
-
Evan Stade authored
Bug: 1132894 Change-Id: Ibb942cbb4ceaa97bb973ffdac8e483502e96fae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503569Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#821893}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I7f9213e3770c9d999c889545a8d92c704788359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506119Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821892}
-
Carlos Knippschild authored
And adds basic explanation on the differences between the different history services it houses. Change-Id: Ic93603c9b2d9312315886a0fe10a4940c8b44829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495907 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Feature has not launched yet, so pushing flag expiration back a few milestones. Change-Id: I982ad888d985c5ae798d2039defdea8fe68840a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505796 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#821890}
-
Morten Stenshorne authored
Copying a HitTestLocation object has a cost in the (micro)benchmark perf_tests/events/hit-test-lots-of-layers.html , so only do this when it's necessary. This still doesn't bring performance back to what it used to be prior to CL:2490111, but the second half of the regression is due to the fact that HitTestContentsForFragments() no longer gets inlined automatically, presumably because the code size now exceeds some magical limit. Had to update a DCHECK in LayoutInline::NodeAtPoint(), since we now only set a target fragment if there is more than one of them. Bug: 1142801b Change-Id: I7845aac259a187610e8cf929d5859875af436d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503555Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#821889}
-
Wenbin Zhang authored
Removing the variables which will confuse gtests. Bug: chromium:1138988,1142435 Change-Id: Ied118e9350db38ba960ac6ac2cac75f5db601bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504637 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821888}
-
Josh Karlin authored
This CL swaps 'blacklist' with 'blocklist' or 'block' throughout the directory. A followup CL will migrate the backend database. Bug: 1097286 Change-Id: I6f62ad1dfbcbdbc1c1ce22d3c550ebb129454bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495607Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821887}
-
chrome://net-exportEric Roman authored
Chrome on iOS does not use //net for issuing network requests for web content, making the data captured by chrome://net-export/ more limited. Bug: 1140996 Change-Id: I46f9d0d986672a9a10b7e8bd2f5b82145525002c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490270Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821886}
-
Jesse Schettler authored
Until PDF is supported, set PNG as the default file type. Bug: 1059779 Change-Id: I6675e6526de668d8cafb1152baeb94ed37e7f13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506111 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821885}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603884477-6bc4961628956c25c92dc091d1c24520abfa529f.profdata to chrome-linux-master-1603907949-21fa2a082049efb8a42fb5e981f107656277e3ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2327961e0e15fbe4541970c8e3175dc157d05695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506260Reviewed-by:
-
Martin Kreichgauer authored
Make AuthTokenRequester not invoke its Delegate's PromptInternalUVRetry() method the first time it calls GetUvToken() and awaits a user interaction. Fixed: 1142969 Change-Id: I38ce9ebd35a968c7346ce0cecd6a3109a0b6fb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504598 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821883}
-
Anders Hartvoll Ruud authored
I want to try and remove the dynamic specificity calculation altogether. After this, it's only used by :host and :host-context. Also, we currently return kClassLikeSpecificity for pseudo-elements (for some reason), so use this for ::slotted as well. Even though it's not observable for authors, it makes things somewhat consistent internally at least. Test: external/wpt/css/css-scoping/slotted-specificity.html Change-Id: Ie64144dfca7439cb02ee839d33c53a409e3cc523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505751Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b28ec889c239..a4e218211286 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC takumif@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141619,chromium:912681 Tbr: takumif@google.com,nicolaso@google.com Change-Id: Ie44b1cca8ba9ab062561df6f5d5f1d826311a8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506252Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821881}
-
dpapad authored
In order to optimize the initial load time of the NTP, move non-essential UI elements to a "lazy" loaded module. This significantly reduces the amount of code that needs to load before the initial paint. Specifically: Before: 312K new_tab_page.rollup.js After: 97K new_tab_page.rollup.js 97K shared.rollup.js 122K lazy_load.rollup.js which means that there is a ~38% reduction (312 -> 97 + 97 = 194K), in the size of the code that is loaded on startup. Bug: None Change-Id: I8f9d0e41047538015f3c41cac0ac3ba5fb1fffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425330 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821880}
-
Mei Liang authored
Change-Id: Id164d3564d3fec41d3c1014d9282e5989b33f8b3 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491444 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821879}
-
Avi Drissman authored
-[AppControllerMac lastProfile] can return null; check for that. Bug: 1143001 Change-Id: I89abfd6171c12d6fceab982fb2d895137a6a0bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505605 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821878}
-
Stephen McGruer authored
Bug: None Change-Id: I35d4c865e69968d53ceb73d248ca1bbdf952a288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506112 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#821877}
-
Peter Kotwicz authored
This CL changes the current working directory to the chromium src root prior to running 'gn format'. This CL also changes the exception thrown by NormalizeAndroidDepsDir() to reference --android-deps-dir (instead of the non-existent --android-deps-path) BUG=1064277 Change-Id: Ia70b3c13d032027254a753e1297044055c1d61f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506079 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#821876}
-
Alexei Svitkine authored
Updates expand_owners_unittest.py to work even if the checkout does not begin with a 'chromium' dir. Note: This does not fix the issue that makes this test fail on bots yet and so doesn't re-add it to the list of tests ran by metrics_python_tests.py. This is a slightly different issue, where on bots, there isn't even a 'src' directory, which trips up other assumptions in the test. Bug: 1126653 Change-Id: I0f345f3efa3a54b4f7ba08106fd6d08ffbc5345b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505573 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#821875}
-
