- 26 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic1042d470ff8e03447657b0c329238c7f8fc3682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791607}
-
Kalvin Lee authored
This change finalizes the implementation of ResolveManufacturers() and updates the corresponding unit tests to pass. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdProviderTest.Manufacturer*' Change-Id: I27b4cf1f9f675eb1462c2e30818f0dd6c33301e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304312 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#791606}
-
David Tseng authored
The row Header output rule (which has a 'speak' clause) was added prior to the 'inherits' attribute being added to the rowHeader's role info. The change to inherit cell omitted removing the rowHeader rule itself. R=dmazzoni@chromium.org Fixed: 1108570 AX-Relnotes: ChromeVox correctly reads cell index in GOogle Sheets with braille mode on. Change-Id: I015c35235a896f318f5d0a73fd0d6f5d2df1888a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315426Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791605}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8a56f0f79ebaeaba1ba0c59f7641564e1f65238b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319150Reviewed-by:
-
Yi Gu authored
Previously phone number collection was bundled with other fields. e.g. address, email etc. A standalone metric can help with better measuring the impact of WebOTP on phone number collection. See the design doc for details: https://docs.google.com/document/d/1OPqPNY9l76kvaBPBCS5wbBQv2HNhmNlsDAcUvmYgyNI/edit#heading=h.cdqwwzem8y9w Bug: 1107590 Change-Id: I3e1bc1188910cda81b4751ce37162ac739673acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316789Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791603}
-
Richard Knoll authored
We need to check if an origin has at least one visible notification after handling a push message to prevent silent pushes. Currently this is done by loading all notifications from the database and checking the size of the returned vector. This is quite resource intensive as all we actually need is the count itself without loading all data into memory. Especially on Android where we can't synchronize displayed notifications with the OS. This CL adds two new methods to the PlatformNotificationContext API to help with this: - CountVisibleNotificationsForServiceWorkerRegistration - DeleteAllNotificationDataWithTag By handling this directly in the PlatformNotificationContextImpl we can use the ForEach* APIs of the NotificationDatabase to only ever have one NotificationDatabaseData object in memory. Bug: 1105787 Change-Id: I4781ab5eecf448cca6ae1459dbaa4b141d0c2011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302907Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791602}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5cdec88a..e873f801 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia45f08a6026f5503ecaf460e38d486eeb33311d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315304Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791601}
-
Gang Wu authored
This required by https://critique-ng.corp.google.com/cl/322733863 Bug:1109501 Change-Id: I905c97c178ae66803ff3e0d7cc72cd4482affad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315803 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791600}
-
Sangwoo Ko authored
We shouldn't count on GetVisualState() as it is. When an image model for a state is empty, The image for NORMAL_STATE will be used instead. Thus, we should check the given |for_state| with the state for image properly. Bug: 1048901, 1109105, 1108990, 1109138 Change-Id: I9c9f494b014af7e96a751400b11f6b4dbf6169cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315902 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791599}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I2eb498b0dabfaba1fffc45755863344adc2d864c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319366Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791598}
-
phillis authored
This moves the uninstallation logic of various OS hooks from WebAppInstallTask to OsIntegrationManager. Bug: 1098027 Change-Id: Ifaf60920c748eff47c9855c4c126c51925a1fc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294332 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#791597}
-
Peter Boström authored
This gives us a better chance to not extend outside monitor space for ones around ~768px vertical. Ideally something like this would be dynamic and enforced by all dialogs but this is more expedient. To me it looks reasonable at larger resolutions as well. Bug: 1096630 Change-Id: I104f2726051d9531f7d6028b5ed357581d45c535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317831 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791596}
-
Aya ElAttar authored
As new fields were added to ClipboardData class and it got moved to a separate file, adding unittests would be helpful especially that now it's not only used in ClipboardNonBacked. Bug: 1096571 Change-Id: Id4f5fdb327ec3875ccfd49da060f5302ea03bfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315863Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#791595}
-
Avi Drissman authored
This reverts commit bc6c3a19. Reason for revert: Suspicions of causing failure of paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html which are consistently failing on https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests Original change's description: > Remove InvalidatePaintIncludingNonCompositingDescendants in compositing > > The callsites are not needed, and just need to either > call PaintInvalidationOnCompositingChange directly or be removed, > because PaintInvalidationOnCompositingChange was going to be called > later because the PaintLayer was going to be added to > layers_needing_paint_invalidation anyway. > > When PrePaint is moved before compositing, we should be able to get > rid of the remaining two callsites to > InvalidatePaintIncludingNonCompositingDescendants. > > Change-Id: I012a1319f1ad0afbbcbf4024b35f1c2b7a222c74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316949 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791440} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: I4e0e792703f849ef42cd54d46abbd74cb6b2c6f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318729Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791594}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3ace17663e00c8dacb1993920ad77835a4134708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318567Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791593}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia8d0c9367d29e79d243dd9299013ccaeb914b272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318809Reviewed-by:
-
Richard Knoll authored
This calls the DiscoveryManager interface from JS and listens for discovered and lost devices to update the device list. The selected device is then passed through to the confirmation-page. Bug: 1103190 Change-Id: I9296e5449533eb869fd9f20fe442d4ac1bc05a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315862 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791591}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/43b951c8d8e2..bef908ee7878 2020-07-25 timvp@google.com Enable KHR GLES31 tests blocked on Issue 4146 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSOTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdateTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPI Change-Id: Ib945a7af4b3535217702c38c33518b7a0f7338fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318978Reviewed-by:
-
Noah Rose Ledesma authored
Bug: 1096245 Change-Id: Ib551cc1cfe04421fe1b65d5d6d4686e00c87a9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294571Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#791589}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bcad714ddf45..84ab9b3dd3ae 2020-07-24 lalitm@google.com ui: add missing cast for idle counters 2020-07-24 lalitm@google.com Merge "tp: allow value_at_max_ts to also take doubles as value inputs" 2020-07-24 treehugger-gerrit@google.com Merge "TraceProcessor RPC: ensure Query returns whole raws" 2020-07-24 lalitm@google.com Merge "trace_processor: Fix UpdateThreadName for threads that share tid" 2020-07-24 treehugger-gerrit@google.com Merge "processor: Parse ChromeProcessDescriptor's host_app_package_name" 2020-07-24 primiano@google.com Merge "traced_probes: relax string filtering for atrace events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie9172ce38fa4ebfa99e13172303cc10ed9da017e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318973Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6a8a74986c35..4eaf6d79edfa 2020-07-24 amaiorano@google.com Delete third_party/llvm-7.0 2020-07-23 sugoi@google.com Add basic support for VK_EXT_debug_utils 2020-07-23 srisser@google.com Add support for depthBiasClamp 2020-07-23 spang@chromium.org Silence warnings on dedicated external memory allocations 2020-07-23 capn@google.com Regres: Roll dEQP to 1.2.3 2020-07-23 amaiorano@google.com Fix CMake failure on MacOS when PowerVR submodule is checked out 2020-07-23 capn@google.com Don't update CMake for Windows Kokoro builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ica01dc4ba35011763b81f45b008db7627fb76691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318868Reviewed-by:
-
Mark Brand authored
Bug: 1105964 Bug: 1106603 Change-Id: I75ee1079018a2d7566a917dff15c67dba75af0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317945 Auto-Submit: Mark Brand <markbrand@google.com> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#791586}
-
Xinghui Lu authored
Add five bullet points in the enhanced protection preference page. Also add a ic_data_viz_grey drawable in browser_ui/styles. It is used by the fifth bullet point in the enhanced protection preferences. before: http://screen/QvKbx401JAE after: http://screen/sWF7npkAeb4 Bug: 1097310 Change-Id: I53c685c3a2d8e74ef4deae47c2d324dbb12dc7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309146 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791585}
-
Peter Kasting authored
Instead, use the affected labels themselves to do metric calculations, or, where FontLists are necessary, to obtain the FontLists. This makes a couple of behavioral changes: (1) The "opening" string no longer assumes that the string length with the filename = the string length without the filename + the filename length. This isn't a valid assumption in general (due to e.g. kerning). Instead it just subs in the normally-elided filename. This isn't ideal; really we'd like to do filename eliding on the full string at the point where the filename subs in, but no APIs exist for that today. (2) The filename is no longer abbreviated when showing the "prompt for scanning" dialog, since that's not inside the shelf and eliding is unnecessary (and maybe harmful). This will also make it possible to style the filename inside |file_name_label_| as is already done for other labels, but that change isn't in this CL. In theory, this would also behave better if the warning/deep scanning/ filename labels used different font sizes (but in practice they don't). Bug: none Change-Id: I5b6a0607a86b090204f65ff05151340b94d3a53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315438 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791584}
-
Hans Wennborg authored
The token limits are set after the default version (used on the CQ) and may not be appropriate for the headers in other versions. Bug: 1049569 Change-Id: I6230efe9d7e56459fbae0355751bf81e6e5c5dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315691Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#791583}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d66d3f9d4ce..15292955fea1 2020-07-25 reed@google.com test for valid mips before setting on image 2020-07-25 fmalita@chromium.org [skottie] Add support for inline/data-uri fonts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ia5378744a7890a51dc7ddef607348a54b1750563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319134Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595483644-344e9c0c00099fa9f04b516964f94e743df86469.profdata to chrome-win64-master-1595548091-fbf1089422fe94cc098aa428bb435f8d7f2c1e43.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5d29cd902920d2a17881f1f55bbc7d03c4455437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316252Reviewed-by:
-
Josh Nohle authored
Implements NearbyShareLocalDeviceDataManager, persisting device data in prefs. All RPC-related calls are guarded by a timeout, so callbacks are guaranteed to be invoked. In addition to supporting on-demand device-data downloads, this implementation schedules periodic downloads of device data--full name and icon URL--from the server. We leverage the Nearby Share scheduler classes to ensure network connectivity, persist pending requests across reboots, retry failures, etc. Note: Device name uploads will most likely soon be deprecated. We include the functionality here. If necessary we will strip it out of all relevant classes in a follow-up CL. Bug: b/154865027 Change-Id: I0ccf21a394beaae5957d3b26c9a788ab7790e06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274740Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791580}
-
Avi Drissman authored
This reverts commit a0f7bda2. Reason for revert: Consistently failing on a bunch of Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests [18135:775:0725/170339.208790:ERROR:web_ui_browser_test.cc(537)] CONDITION FAILURE: encountered javascript console error(s): [18135:775:0725/170339.208835:ERROR:web_ui_browser_test.cc(539)] JS ERROR: '[18135:775:0725/170337.110306:ERROR:CONSOLE(49)] "Mocha test failed: cr_lottie_test TestRenderFrame AssertionError: expected 'data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDABALDA4MChAODQ4SERATGCgaGBYWGDEjJR0oOjM9PDkzODdASFxOQERXRTc4UG1RV19iZ2hnPk1xeXBkeFxlZ2P/2wBDARESEhgVGC8aGi9jQjhCY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2P/wAARCADIASwDASIAAhEBAxEB/8QAGAABAQEBAQAAAAAAAAAAAAAAAAMGBwX/xAAdEAEAAAYDAAAAAAAAAAAAAAAAAQIDBDRzBrHB/8QAGAEBAAMBAAAAAAAAAAAAAAAAAAIEBgX/xAAbEQEAAgIDAAAAAAAAAAAAAAAAAQIyMwQFgf/aAAwDAQACEQMRAD8A5+ADotlhW+uXpZGywrfXL0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL82hr9i1jJ8vzaGv2K5wt0L3Xb49eAA7jSAAOi2WFb65elkbLCt9cvSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vzaGv2LWMny/Noa/YrnC3Qvddvj14ADuNIAA6LZYVvrl6WRssK31y9LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny/Noa/YtYyfL82hr9iucLdC912+PXgAO40gADotlhW+uXpZGywrfXL0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL82hr9i1jJ8vzaGv2K5wt0L3Xb49eAA7jSAAOi2WFb65elkbLCt9cvSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vzaGv2LWMny/Noa/YrnC3Qvddvj14ADuNIAA6LZYVvrl6WRssK31y9LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny/Noa/YtYyfL82hr9iucLdC912+PXgAO40gADotlhW+uXpZGywrfXL0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL82hr9i1jJ8vzaGv2K5wt0L3Xb49eAA7jSAAOi2WFb65elkbLCt9cvSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vzaGv2LWMny/Noa/YrnC3Qvddvj14ADuNIAA6LZYVvrl6WRssK31y9LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny/Noa/YtYyfL82hr9iucLdC912+PXgAO40gADotlhW+uXpZGywrfXL0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL82hr9i1jJ8vzaGv2K5wt0L3Xb49eAA7jSAAOi2WFb65elkbLCt9cvSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vzaGv2LWMny/Noa/YrnC3Qvddvj14ADuNIAA6LZYVvrl6WRssK31y9LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny/Noa/YtYyfL82hr9iucLdC912+PXgAO40gADotlhW+uXpYGZtlLH3ykARRAAAAAAAAAAAAAAAAAAAAAAAAAAAAGT5fm0NfsQXOFuhe67fHrwAHcaR//Z' to equal 'data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDABALDA4MChAODQ4SERATGCgaGBYWGDEjJR0oOjM9PDkzODdASFxOQERXRTc4UG1RV19iZ2hnPk1xeXBkeFxlZ2P/2wBDARESEhgVGC8aGi9jQjhCY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2P/wAARCADIASwDASIAAhEBAxEB/8QAGAABAQEBAQAAAAAAAAAAAAAAAAMGBwX/xAAdEAEAAQMFAAAAAAAAAAAAAAAAAwE0cwIEBrHB/8QAGAEBAAMBAAAAAAAAAAAAAAAAAAIEBgX/xAAbEQEAAgIDAAAAAAAAAAAAAAAAAQIyMwQFgf/aAAwDAQACEQMRAD8A5+ADouysoMenpZHZWUGPT0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL72DH7VrGT5fewY/arnC3Qvddvj14ADuNIAA6LsrKDHp6WR2VlBj09LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny+9gx+1axk+X3sGP2q5wt0L3Xb49eAA7jSAAOi7Kygx6elkdlZQY9PSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vvYMftWsZPl97Bj9qucLdC912+PXgAO40gADouysoMenpZHZWUGPT0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL72DH7VrGT5fewY/arnC3Qvddvj14ADuNIAA6LsrKDHp6WR2VlBj09LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny+9gx+1axk+X3sGP2q5wt0L3Xb49eAA7jSAAOi7Kygx6elkdlZQY9PSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vvYMftWsZPl97Bj9qucLdC912+PXgAO40gADouysoMenpZHZWUGPT0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL72DH7VrGT5fewY/arnC3Qvddvj14ADuNIAA6LsrKDHp6WR2VlBj09LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny+9gx+1axk+X3sGP2q5wt0L3Xb49eAA7jSAAOi7Kygx6elkdlZQY9PSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vvYMftWsZPl97Bj9qucLdC912+PXgAO40gADouysoMenpZHZWUGPT0szNspY++UgCKIAAAAAAAAAAAAAAAAAAAAAAAAAAAAyfL72DH7VrGT5fewY/arnC3Qvddvj14ADuNIAA6LsrKDHp6WR2VlBj09LMzbKWPvlIAiiAAAAAAAAAAAAAAAAAAAAAAAAAAAAMny+9gx+1axk+X3sGP2q5wt0L3Xb49eAA7jSAAOi7Kygx6elkdlZQY9PSzM2ylj75SAIogAAAAAAAAAAAAAAAAAAAAAAAAAAADJ8vvYMftWsZPl97Bj9qucLdC912+PXgAO40gADouysoMenpYGZtlLH3ykARRAAAAAAAAAAAAAAAAAAAAAAAAAAAAGT5fewY/agucLdC912+PXgAO40j//Z' at Function.assert.strictEqual (file:///opt/s/w/ir/third_party/chaijs/chai.js:2329:32) at assertEquals (file:///opt/s/w/ir/chrome/test/data/webui/test_api.js:726:15) at Context.<anonymous> (file:///opt/s/w/ir/chrome/test/data/webui/cr_elements/cr_lottie_tests.js:240:5) ", source: file:///opt/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) ' Original change's description: > [webui] Re-Enable cr-lottie tests > > It's not clear if these tests will still be flaky on the CI or not. We > made some changes that may have deflaked them. > > Bug: 1103865, 1021474b > Change-Id: Icfe7ed6637868fc29e30c0d182f985a6b38aa000 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311144 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Auto-Submit: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791463} TBR=dpapad@chromium.org,nsatragno@chromium.org Change-Id: Idd9cfd301804197c09552f3cbc9ee75fb4c44e27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103865 Bug: 1021474b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319306Reviewed-by:
-
David Tseng authored
Blink can be unstable when setting selections over non-text units (see bug). R=dmazzoni@chromium.org Fixed: 1104423 AX-Relnotes: fixes a crash when navigating in the Clear Browser Data settings page Change-Id: I0eec2db11b958964dae92762f20707c3e6e18bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315250 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 1106699 Change-Id: I83fde75b4fca219cfb9312fcf89d8fac21d77dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316206 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#791577}
-
Peng Huang authored
http://crrev.com/c/2316399 fixes a VkSemaphore release before signal problem which causes device lost, if we reuse some VkSemaphores. So with that CL, we can reuse all VkSemaphores. Bug: 1107558 Change-Id: I5b91cd899a32220ba73669cef36478c989c85289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318787 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#791576}
-
Keren Zhu authored
Replace some raw new objects with unique_ptr. This CL is part of the change that applies documented best practices to examples. Note that Widget and WidgetDelegate handle their lifetime with raw pointers. They are not touched in this CL. Bug: 897377 Change-Id: I1f819d56c21c97d58bdca0cd21ad66865200e346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315221Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791575}
-
chrome://omniboxmanuk authored
- Also use lower case and 14px to fit both chars. - Also rename the 2nd 'S' to 'bk'. This CL makes it easier to identify the 4x 'D', 2x 'S', 'T', and 'P' columns. Bug 891303 Change-Id: I17d0ad51cb7d117b40ea09421edadbd30d9eb7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317718Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791574}
-
Jose Dapena Paz authored
wayland_unittests source set asserts if use_wayland_gbm is false. This should not happen as GN will consider that rule valid. Solution is allowing unit tests both with and without wayland GBM. To do that we only add the GBM dependent unit tests if use_wayland_gbm is true. Bug: 1109134 Change-Id: Ifccce611e374b320f778e7c0a0147ba4f6b5c3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317385 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791573}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/views/bookmarks. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1106699 Change-Id: Ib9fee66ed2f55101cdf9ce03b96197e2f7f0a61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316577 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791572}
-
Xida Chen authored
After we landed: https://chromium-review.googlesource.com/c/chromium/src/+/2300402 There were much less crash reports than it used to be. But we are still seeing reports. The problem is still use-after-free. As we can see, in the destructor of LayerTreeHostImpl, we call frame_trackers_.SetUkmManager(nullptr); This sets FrameSequenceTrackerCollection::throughput_ukm_reporter_| to nullptr. Note that FrameSequenceMetrics has a raw pointer |throughput_ukm_reporter_| that points to the above, but that pointer doesn't know that it is nullptr now. So in the ~FrameSequenceMetrics() which calls ReportMetrics, it tries to use the raw pointer, which causes the problem. Bug: 1105854, 1100868 Change-Id: I5c2045afd361a527baebce574377fbd43fd32879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309094 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791571}
-
Omer Katz authored
Following CLs 2247020 and 2248622, the USING_GARBAGE_COLLECTED_MIXIN macro is no longer needed. Mixins don't use a virtual method anymore to get a TraceDescriptor, which left the macro empty from content. Since the clang plugin update, there are no longer checks that the macro is used, which allows us to remove the macro now. This will simplify usages of garbage collected mixins. Bug: 1101271 Change-Id: I834aaf67a8686b00117f64096dc633bf86f98a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247794 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791570}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cebfb4e614a8..a58287b8ee08 2020-07-24 ehmaldonado@google.com presubmit: Also validate metadata in OWNERS files. 2020-07-23 ddoman@chromium.org [resultdb] Bump up the cipd pin of rdb in depot_tools 2020-07-23 sokcevic@google.com Make presubmit_canned_checks inclusive 2020-07-23 ehmaldonado@google.com gclient: Apply on patch of remote's branch-heads instead of local. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098560,chromium:1102997,chromium:1108638 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2fa0b5630ed0a7efac60c24742e133749b686dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318867Reviewed-by:
-
Chris Harrelson authored
This adds onto the other CL (*) that modifies fragmentation + compositing, and removes another dependency on pre-paint of compositing. (*) https://chromium-review.googlesource.com/c/chromium/src/+/2280583 Bug: 1100711 Change-Id: I9b66bc39f4af65746ecc05d834f0e4abf65c04eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318688 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791568}
-
