- 07 Oct, 2020 40 commits
-
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ifea18890a5bc6144ae6a5581525d1495ff037a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453926Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814718}
-
Weilun Shi authored
Add /tools/metrics/histograms/histograms_xml/*.before.pretty-print.xml to gitignore to ignore generated before.pretty-print files for split histograms as well as histograms_xml/obsolete_histograms.xml and histograms_xml/histogram_suffixes_list.xml Change-Id: I308bdfe8ff205def461418aca7a527c4ca3998a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437729 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814717}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7e22b1c44fb0..2ee68783068c 2020-10-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 488d7a9346ff to c9110b93cb8a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I7ad75828c853dd33fd15bd0eb55db1de4ae4a87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456188Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814716}
-
Fabio Tirelo authored
This fixes an issue of UEMs sending empty string for unset policies on Android (issue happening on both GEM and AirWatch). Until all UEMs fix this issue on their side, we should fail gracefully. The proposed approach is simply consider that special case as policy not-set for policies with type list or dictionary. I inspected all list and dict policies, and the only ones for which I expect changes in side-effects are: - DefaultSearchProviderAlternateURLs - DefaultSearchProviderEncodings - ProxySettings The DSP policies are fine, as discussed before. They will in fact prevent other policies from not being set when values are pushed via managed configurations, especially the most basic DefaultSearchProvider ones. The ProxySettings policy should also be OK. When it's unset, values from ProxyMode, ProxyServerMode, ProxyServer, ProxyPacUrl, and ProxyBypassList will be used instead. BUG: 1134739 Change-Id: Ib194b432df0b1f6caba7340bb82496a44ff2c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443669 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#814715}
-
Anne Lim authored
Adds a footer at the bottom of the InfoBar which spans the InfoBar's whole width. Screenshot where a footer is added to SavePasswordInfoBar: https://screenshot.googleplex.com/AVqcryn4jnEcoT9 Bug: 1135847 Change-Id: I8c3cd9968ced6ee4280b3929671e5e61043d4fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454694Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#814714}
-
Michael Hansen authored
This updates the account row on the Nearby settings subpage to display the user's full name instead of the device name. Screenshot: https://screenshot.googleplex.com/C3uXbjhA2QaDrNQ.png Bug: b:166779043 Change-Id: Icc1eeddc3100bcb78c4ac7c9699972d67eec9f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454094Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#814713}
-
Dylan Cutler authored
identifiability study. This API leaks information about users' machines' GL implementation which could be used to identify users across different origins. The instrumentation reports digests of the value returned by this method when the study settings are enabled. For a similar CL that instruments WebGLRenderingContext.getShaderPrecisionFormat() see: https://chromium-review.googlesource.com/c/chromium/src/+/2431782 Bug: 973801 Change-Id: Ib7dea35f5a3d87591fea9f83a9c8cc0a11570797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441021 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814712}
-
Jeffrey Young authored
Construct ambient widget when two images are in memory to prevent burn in. BUG=b:167332126 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I520ada00429125d35bda9ef66089ca9a9c8d4440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440306 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#814711}
-
Elly Fong-Jones authored
This change makes it clearer that the window title can never change once this dialog is shown, and removes a bunch of now-unneeded overrides of WidgetDelegate methods. Bug: 1075649 Change-Id: I3f720f92e9e4ca4a6cdd1cade48bd53c861d2252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453189Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#814710}
-
Maks Orlovich authored
It may not be available, making the test flake. Bug: 1135894 Change-Id: I5b4a2db692c7bc25c39d8eea0776e6fdb447982f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456290Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#814709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/10d329d9803b..a51c2a0b4243 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 63cc22d645ba to fc8264854c53 (1 revision) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 14289452a832 to 1abaced34b84 (1 revision) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from afe6ca45b6da to 635de036d766 (3 revisions) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c7d7610581df to e171d8431cfa (1 revision) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 3610ce9fa2d8 to a638f3acae94 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ie0d91b7164ffb324d2e77072cdeda41a8d5e436e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814708}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We rewrite below tests fast/scroll-behavior/main-frame-interrupted-scroll.html, fast/scroll-behavior/overflow-interrupted-scroll.html and fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests because we cannot guarantee that the scroll arrives before the animation completes. TBR=bokan@chromium.org Bug: 1047176 Change-Id: I46a6cb0697b8a74ff260aafbc2fc60a7d65ae1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446534Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#814707}
-
Simeon Anfinrud authored
Chromecast internal code was making use of this. Added an exhaustive list of internal chromecast's android dependencies that should be checked by gn gen to prevent similar situations from arising in the future. Bug: Internal b/169779668 Test: build internal chromecast apk with this patch and chromium-review.googlesource.com/2425010 cherry-picked. Change-Id: I9c32af013a718e44f1f79e7465f4d6c2c185c671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453433Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814706}
-
Wei Lee authored
This CL fixes a bug that will cause camera failed to play the preview. Bug: b/166850715 Test: Launch Chrome Camera app and preview is shown Change-Id: If61d74dc9478bc6138389b9fa6c0dded5a6e8359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454592 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814705}
-
Matthias Körber authored
This CL adds concurrent experiments for stable and beta to the field trial configuration. Change-Id: I83a0afef311d3df2f8881ce2684cf86847660372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452474 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#814704}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4af799c5156f..e66f55b48608 2020-10-07 mulherje@gmail.com Switched to empty string for live expression preview during creation 2020-10-07 szuend@chromium.org [ts] Type-check network/RequestInitiatorView.js with TypeScript 2020-10-07 szuend@chromium.org [ts] Type-check network/NetworkTimeCalculator.js with TypeScript 2020-10-07 szuend@chromium.org [ts] Type-check network/SignedExchangeInfoView.js with TypeScript 2020-10-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-07 sigurds@chromium.org Revert "Disable new resource loading mechanism to debug flaky test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1069378,chromium:1126033 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib445bb08aaec91ad29d6ec543056aee45b32930c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814703}
-
Peter Kasting authored
This also reorders the definitions in one file to match the declarations. Bug: 772945 Change-Id: I74f04421cdab8acd02e380a317155bd1bdcc2a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454789 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#814702}
-
Yi Gu authored
There are UMA metrics to measure the duration from when the API is called to when the SMS is received / a user clicks "Allow" to complete the flow. We want to add corresponding UKMs to help with the feature adoption. Note that the UKM that records the duration from when the API is called to when a user clicks "Deny" to abort the flow will be added in a follow up patch after crrev.com/c/2428825. UKM collection review: https://docs.google.com/document/d/15orQiLx06QSuZr4ShBaozY0dvPzXiTWwJZ9Xk5cgzAA/edit?usp=sharing Bug: 1127402 Change-Id: I204bd469ca203182eba6a37f3522d7a492cc937d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429236Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814701}
-
Nicolás Peña Moreno authored
UKM privacy review: https://docs.google.com/document/d/1M1nsLapTIoNgaD8SXtrqEirVQajYKmfmQKHbtI7J6-w/edit#heading=h.k5jx6iluw4yt Bug: 1045640 Change-Id: I09e2e779f28d42e3760ed1acaf08c7614e3f9194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450909Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814700}
-
Dominic Mazzoni authored
Fixes a regression caused by http://crrev.com/c/2424854 ("Refactor chrome.automation.EventType") See http://crrev.com/c/2450663 for more context. Bug: 1110367, 1135248 Change-Id: I64de7e85f47ec1920c37e2730fbebdca4efaca3b AX-Relnotes: none because this just fixes a regression Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454420Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814699}
-
Owen Min authored
The chrome.enterprise.reporting_private.getPersistentSecret return -25300(errSecItemNotFound). It's likely caused by keychain item recreation. Disable the feature for now to relieve the issue on Stable. Bug: 1136089 Change-Id: Icbd96ce81a448e1069c3adee08bfca19a66b4bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456509Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814698}
-
Robert Liao authored
BUG=1130078 Change-Id: I41b8a046ed0a392d8df41a747286e346d57cb385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454095 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#814697}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //google_apis. R=bsazonov@chromium.org Bug: 1113033 Change-Id: I3201f9dc1878451491c10a2b0ac750fa6f917e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454497 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#814696}
-
Bill Budge authored
- UMA shows this interface has no usage. This is a Dev API at 0.1. Change-Id: I98aef1dcaf38c9203030526bbdf4e4e51b0e9497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574487Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#814695}
-
Mason Freed authored
With the removal of Web Components v0 in [1], these tests are no longer needed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2195005 Bug: 1135672 Change-Id: I92a26fe39edd6dd1536d0cbe27b288104414845b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454093 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814694}
-
behdad authored
Marked ie_chalkboard story as experimental on MacOS because of recent flakiness of test. Bug: 1133599 Change-Id: If93c0594ad79259042b6e574d6ac59ce034f2049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456306 Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#814693}
-
Sebastien Lalancette authored
Loading the URL before the data allows us to remove the spin loop (and potentially flakiness). Bug: 1132210 Change-Id: Ib696ff63a7b353871dff5984850ad0490a2d3ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453905Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#814692}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I153a88e26cdd9c208d6effa738b16b9416751c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814691}
-
Tanmoy Mollik authored
MOBILE_IDENTITY_CONSISTENCY allows users to be signed in without syncing. Renaming this method in SyncTestRule to properly reflect what it does. Bug: 1135669 Change-Id: I0260636efc98c46a8250d25324ea8763e069e5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454049 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#814690}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/223fd5da..e1e716fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbabc6ea6b8b6931a9343177e01128737d1c2417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456026Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814689}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/025eeee82946..f6c1b2bf9beb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC eirage@google.com,vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: eirage@google.com,vasilii@google.com Change-Id: Ib7895796c07d84bde77ad1dd0d1125a2a2278312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456009Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814688}
-
nuwanda authored
To validate TBMv3 metric a CSV file should be provided: see example below. The metric validation will be done on the provided traces. Fixed the way of getting links to proto traces, when finding the proto trace requires looking into traceEvents/ directory Example of CSV file content: test,measurement,trace_link ChromiumPerf/mac-10_12_laptop_low_end-perf/v8.browsing_desktop/blink:gc:main_thread:cycle:full:incremental:mark:step_max/browse_social/browse_social_tumblr_infinite_scroll_2018,v8.browsing_desktop/blink:gc:main_thread:cycle:full:incremental:mark:step_max/browse_social/browse_social_tumblr_infinite_scroll_2018,https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/20200928T183503_42028/v8.browsing_desktop/browse_social_tumblr_infinite_scroll_2018/retry_0/trace.html ChromiumPerf/mac-10_12_laptop_low_end-perf/v8.browsing_desktop/memory:chrome:renderer_processes:reported_by_chrome:partition_alloc:allocated_objects_size_std/browse_social/browse_social_tumblr_infinite_scroll_2018,v8.browsing_desktop/memory:chrome:renderer_processes:reported_by_chrome:partition_alloc:allocated_objects_size_std/browse_social/browse_social_tumblr_infinite_scroll_2018,https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/20200928T183503_42028/v8.browsing_desktop/browse_social_tumblr_infinite_scroll_2018/retry_0/trace.html Follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2413492 Bug: 1128919 Change-Id: I9c44e63802c3993416879aa43d9889418b9c18c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449350Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#814687}
-
Minggang Wang authored
Currently, resource_load_stats.h/cc defines a collection of methods collecting histograms related to resource load and notifying with loading stats. Along with the OnionSoup for loaders, we need these functions could be available inside Blink. This patch leverages the mojom interface ResourceLoadInfoNotifier to notify the loading stats, which is visible in Blink, thus we could invoke it by sort of blink::URLLoaderClientImpl in the future. The original functionalities offered by resource_load_stats.h are splitted into ResourceLoadInfoNotifierWrapper and RenderFrameImpl. The ResourceLoadInfoNotifierWrapper class is responsible to collect the histograms and hold a ResourceLoadInfoPtr struct used by the ResourceLoadInfoNotifier. After this patch, only NotifyUpdateUserGestureCarryoverInfo() is left in resource_load_stats.h. Change-Id: Ib5fd5d774544f771753707c4fffcf0034cd12a01 Bug: 1110032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402321Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#814686}
-
David Schinazi authored
These tests have been failing for months, and the code behind them was deleted via <https://crrev.com/c/2446019>. This CL finishes that cleanup by deleting these tests, and removes RTCQuicStream and RTCQuicTransport from event_target_modules_names.json5. Bug: 1070747 Change-Id: If958024eca5f7d9a7dc3a2e8678dab724065181d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454382 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814685}
-
Mike Jackson authored
Removes the parameterization for all tests in the web_app_policy_manager_unittest.cc file, now that kDesktopPWAsWithoutExtensions flag is always true. Bug: 1065748 Change-Id: I255416df8e5e3da2cdb79d195e8779871bc7e26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453353 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814684}
-
Chris Sharp authored
Change-Id: I9d6768028bc2b749394cd4f6794403b0121fba9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456027Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814683}
-
Mugdha Lakhani authored
So that it can be componentized. Chrome specific logic has been moved to BackgroundSyncDelegateImpl. Bug: 1087486, 1091211 Change-Id: Ie4e220c563d48072e719524aad39bed50f9b101b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454071 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#814682}
-
Xianzhu Wang authored
This is to avoid too low scale when animating scale above the scrollbar layer. This is not ideal. In the future we should move rasterization of scrollbar layers to impl-side to better handle scales (crbug.com/1009291). Bug: 1133997 Change-Id: I3364754f530914816fe8526c627e6cf12e7942ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453436Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814681}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //mojo. R=rockot@google.com Bug: 1113033 Change-Id: I6e12b602687b803c0270c86a0df3771b74c2e081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454408 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#814680}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ifd07737813cd58f7c86f0bed2bc1e61f5fb4dea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456146Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#814679}
-