GitLab

This is a precursor to moving input handling into blink. Expose the
switches and features that will be read in blink from blink.

BUG=1073560

Change-Id: I492dabe30b307fc3288160e17952dc3c1a0b14f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232804Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776074}

In this CL, we introduce an additional state in InflationObserver:
onInflationComplete. This event happens between onPreInflationStartup
and onPostInflationStartup, thus provides a way to split the
implementation of onPostInflationStartup into two methods.

In RootUiCoordinatior, the ToolbarManger is created in
onInflationComplete, and ChromeTabbedActivity calls showOverview()
after RootUiCoordinatior#onInflationComplete but before initializing
other components in onPostInflationStartup. Thus, ToolbarManager setups
an OverviewModeObserver and won't lose any early events that an
overview is shown or overview mode is changed.

Bug: 1077022
Change-Id: I6bc8b96906a9519a928c6490bec0ca158b3d6241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181667Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776073}

The logic it added (adding a Cancel button) was moved to
ActionSheetCoordinator. Moving that logic also allows cleaning-up
duplicate logic for adding a cancel button.

Added unit tests to cover the new logic in ActionSheetCoordinator.

Change-Id: I2e0871d1be885e09f472729a5f342659eaa6e192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220069
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776072}

This CL migrates these two legacy IPC messages out of frame_messages.h
and view_messages.h to LocalFrameHost and {Local,Remote}MainFrameHost
mojo interfaces from Blink. Normally, we would have migrated the two
messages in separate CLs, but I'm doing it in one CL to simplify the
process since that way we can remove RenderViewImpl::DidFocus() in one
go, which I think makes the patch clearer and cleaner.

An important part of this CL is the introduction of a mojo interface
named RemoteMainFrameHost, needed because in some cases the renderer
will make sure that the Focus() request gets initiated from the topmost
frame (e.g. see DOMWindow::focus()), and such frame would be a remote
frame in the case of OOPIFs. So, the ViewHostMsg_Focus IPC method has
been migrated both into the pre-existing LocalMainFrameHost interface
and into the newly added RemoteMainFrameHost interface, and Blink will
make sure to route the message through the correct channel depending
on whether the renderer's main frame is a LocalFrame or a RemoteFrame.

Another subtlety of this CL is that we need to still keep the call to
web_view_->Client()->DidFocus() from ChromeClientImpl being always run
whenever Frame::FocusPage() is called for testing purposes, so that the
override of WebViewClient::DidFocus() in ViewCreatingWebViewClient will
still work after this migration.

Last, this CL also renames RenderFrameHostDelegate::DidCallFocus()
into DidCallFocusOnPage() to make it clearer that what that method
reports is that a given frame has called focus() over a page, and
not that such frame got focused.

Bug: 1047461, 1083393
Change-Id: Ie6bf56fbcf9c689c88597e3f83098c5b7d2f2513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224858Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776071}

SetAlwaysHidePlayPauseButton() was confusing, because it's actually used
to set visibility rather than invisibility.

Also, SetShowPlayPauseButton() doesn't need to be a part of the
PictureInPictureWindowController interface.

Change-Id: I2dd32b64b44d3318a6cc1906070b439190e162b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231068Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#776070}

These tests consistently take 5-6x longer to run when DCHECK is enabled
versus when it is now. This takes a 0.5-1s test into flaky timeout
category, and we have seem many, many flakes with idlharness tests on
the CQ bots (which are DCHECK-enabled, versus the waterfall bots that
aren't).

Investigations into this slowdown were inconclusive. It appears that the
heavy use of JavaScript in idlharness tests means they get a much worse
slowdown than most web_tests (which are rarely JavaScript-bound), but
even with the v8 team's help we were unable to identify any particular
DCHECKs that could be modified or disabled to improve the situation. As
such, our final option is to just hack them into always being considered
slow tests.

Note that since we can't detect whether or not DCHECK is on, we consider
them slow for all setups.

Bug: 1047818
Change-Id: I33b27017f6c9641dbe9881a78a33563fb8b2df67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232698Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776069}

Bug: 1090331
Change-Id: Ic0489afae9948ead9817ae41b44b796c1201168f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230462Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#776068}

Delete some TilePriority-related dead debug code.

BUG=none

Change-Id: Ia1a9fa25c6bf2fa9546084a56291c9c3574a20f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231508
Commit-Queue: vmpstr <vmpstr@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776067}

https://webrtc.googlesource.com/src.git/+log/10ef84728937..593e6a423883

2020-06-08 tommi@webrtc.org Fork RtpSenderEgress.
2020-06-08 jonaso@webrtc.org Add forget_learned_state to IceControllerInterface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I7ebfa048888bc0535c68ca75d27fc8e04e4e3161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235109Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776066}

Add this new method to RemoteFrame along with the required plumbing
in RemoteFrameClient[Impl] and WebRemoteFrameClient so that we can
access the AssociatedInterfaceProvider managed by RenderFrameProxy
from Blink, required to migrate the legacy IPC ViewHostMsg_Focus to
mojo (see crrev.com/c/2224858).

Bug: 1047461, 1083393
Change-Id: Iea78bd9347362a02d4a3a8b4c29eefb3c6ed5f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233062Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776065}

Bug cause:
The UI didn't listen to the activity destroy event. When it happens,
the UI didn't notify the PaymentAppProvider (via
ServiceWorkerPaymentProviderBridge). As a result, the
PaymentAppProvider was still alive after the UI has closed. In this
situation, if the merchant page try to show() the UI, it would hit the
error "Already called show() once"[1] (because accept_resolver_ != null)

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/payments/payment_request.cc;l=763

Fix:
Let the UI listens to the activity's destroy event. When that happens,
notify PaymentAppProvider that the UI has closed.

Change:
* the fix
* centralized the calls of ServiceWorkerPaymentAppBridge and call it
just before the WebContents is destroyed. This is to ensure that only
one "onClosingPaymentAppWindow*" would be invoked.
* added scrimCoordinator null check. The null is triggered when a dying
activity triggers the UI to close (e.g. theme change as in
crbug.com/1092309).


Bug: 1091137, 1087410, 1092309

Change-Id: I78bfafadd98278765170540ae369d3d497dcbf0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231978
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776064}

This reverts commit b6b99e74.

Reason for revert:
Causing build failure:
https://ci.chromium.org/p/chromium/builders/ci/GPU%20Linux%20Builder/208156

Original change's description:
> Define protobuf for enterprise connectors.
> 
> This CL also adds a new enterprise component under //components.
> 
> Bug: 1069026
> Change-Id: I7d696cf39beff070e242b1221ba4b13419ef6eb7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219009
> Commit-Queue: Roger Tawa <rogerta@chromium.org>
> Reviewed-by: Cait Phillips <caitkp@chromium.org>
> Reviewed-by: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776059}

TBR=rogerta@chromium.org,mad@chromium.org,caitkp@chromium.org,drubery@chromium.org,domfc@chromium.org,sukwanlee@chromium.org

Change-Id: I5ff6e47a8a0196b24204a8a1a9a6209f6b36499e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1069026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235978Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776063}

R=cbruni@chromium.org

Change-Id: I0bf20def702be0c6b7617de3993c0c65d2ac267a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231110Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776062}

The script to roll material_components_ios needs to keep the list
of file up-to-date. This is done by updating the values assigned
to the three variables _mdc_public_headers, _mdc_include_dirs and
_mdc_sources.

Recent change removed _mdc_sources (and inlined the value) which
broke the script. Re-introduce the _mdc_sources and add a comment
explaining why the value is not directly assigned to sources.

Bug: none
Change-Id: If2d097c80f4b9692963d42169dc8cb90aff2ad72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235514
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776061}

According to crbug.com/1090687 NotifyHandlersChanged() is getting called when GetPage() returns null (i.e. after Frame is detached)

To avoid the crashes this adds a check for GetPage().

Bug: 1090687
Change-Id: I154a121c96a0ac39db6a5066c8bb3940eb006838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234325Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776060}

This CL also adds a new enterprise component under //components.

Bug: 1069026
Change-Id: I7d696cf39beff070e242b1221ba4b13419ef6eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219009
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776059}

Bug: 1047818, 1092029
Change-Id: I401e1ad6a88c4a4fc3a04da3ce385075778c8184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235712Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776058}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/926f4bf2..9912e35d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I99609d507859cc76405b77f7437f81d2065ac679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235456Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776057}

The word "relying" was mistyped as "reying".

This CL fixes the typo.

Change-Id: I899e5d543bf3330fa6bbc1c13bc8216290c0b5c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233147
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776056}

Bug: internal b/156555613
Test: None
Change-Id: I10e7cec42d0046b7392b75772d23aa69d535f62d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233494
Auto-Submit: Junbo Ke <juke@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776055}

This makes the model.Paths run os.path.abspath on its arguments. This is a
large mechanical change because tests did not use absolute paths before;
most of the CL was generated by:
  gsed -i -E -e 's@\$(W|I|O)@/$\1@g' chrome/installer/mac/signing/*_test.py

Bug: 964608
Change-Id: Iac8d1213e47fd8f08daf4962a756e47dab26d64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231440
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776054}

After a portal activation, the previous page is no longer fullscreeen in
the tab, so we should exit picture-in-picture mode.

Bug: 1078814
Change-Id: I3a8f2ffdb1f265d0bde967c5d85d3c75b33d3f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231587
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776053}

The startupInformation is still needed, even in warm start.

Bug: 1069748
Change-Id: I69cf8197914904fb21943602534e681b9df1292f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235616Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776052}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/78f57416d0e1..4fa4342740a8

2020-06-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-06-08 alexrudenko@chromium.org Set min width for DataGrid columns

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I469768086f47980beba418fab69cee0d1e457465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235636Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776051}

https://android.googlesource.com/platform/external/perfetto.git/+log/3ea2467b7947..7fa78b7965fb

2020-06-08 rslawik@google.com Merge "Detect main threads"
2020-06-08 lalitm@google.com Merge "metrics: fix registration on Windows"
2020-06-08 eseckler@google.com Merge "processor: Check for TrackEvent metadata events without name"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I2dd1437d59c096993d791cc54111835e3d541926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776050}

In AXPosition in Blink, when we are unable to convert in a straight forward manner from a DOM to an AX position or
vice versa, we do the next best thing by moving to the next or previous valid position in the
corresponding tree.
However, the method that finds the next unignored / valid position in the AX tree skips over
nodes that are included in the AX tree but are accessibility ignored, i.e. they don't appear
in the browser's platform tree.
Similarly, the method that computes the next unignored node in the accessibility tree given
a DOM node, only looks at the next / previous unignored sibling of the ignored node
without looking at the node's descendants. However, there are cases when an ignored DOM node
could easily be represented by one of its children. For example:
<span>hello</span>
Even though the span node is ignored in the accessibility tree, its text child is not.

AX-Relnotes: Screen readers more reliably read the currently selected text.

R=dmazzoni@chromium.org

Change-Id: I687785cdc00ec739b61c943bfc9a3db030c5ae28
Bug: 1082814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220035Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776049}

Change-Id: I42ef120236cd94eeb869c6e19cd4033ed60878b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233011Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776048}

This CL converts WidgetHostMsg_DidFirstVisuallyNonEmptyPaint
IPC message to FrameWidgetHost interface.

In RenderWidgetHostTest, this CL replaces the message with
WidgetHostMsg_Close because WidgetHostMsg_DidFirstVisuallyNonEmptyPaint
is just used for testing.

Bug: 1071596
Change-Id: I07c9b16f9da37c3e9947cbcab3ca5ff2dd6014a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215143Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776047}

Two tests were marked as flaky because they were missing the updated
expectations.

This CL removes them from the TestExpectations and add rebases the
missing expectation files.

Bug: 990918
Change-Id: I3e33204fca1d5e93a73c4c2167a016fb41a694ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180879Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776046}

Bug: 973726, 1092121
Change-Id: I38a66a3584845bc982e2a993fc8197c6fcfdeb45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235672Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776045}

The function is used in a very few cases and is equivalent of ==.

Bug: 1033903
Change-Id: I8339ac5a43005759c19616684eb04829afe6f551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218089Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776044}

This CL migrates to vector icon for the show password icon
and adds proper support for dark mode.

Icons are slightly different, but, this is a change in the right
direction.
Pixel test output
pre-Butter:
https://chrome-gold.skia.org/detail?test=BrowserUiDialog_All_PasswordBubbleBrowserTest_InvokeUi_PendingPasswordBubble_0__windows&digest=48c9f80c9c4a11172a598cd9d392add4&issue=2235512
After-Butter:
https://chrome-gold.skia.org/detail?test=BrowserUiDialog_All_PasswordBubbleBrowserTest_InvokeUi_PendingPasswordBubble_1__windows&digest=48c9f80c9c4a11172a598cd9d392add4&issue=2235512


Screenshots:
Light Mode Hidden: https://screenshot.googleplex.com/vZyG8WZWPVX
Light Mode Shown: https://screenshot.googleplex.com/34Y11w12Qrg
Dark Mode Hidden: https://screenshot.googleplex.com/x4Z5yf68kaY
Dark Mode Shown: https://screenshot.googleplex.com/Q6wXbUPpEjS

Bug: 1091842,1044038
Change-Id: Id123d79d5f8c927219413abd33dab44e5ee531b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235512Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776043}

Handle focusing cr-input in oobe-dialog, and add utility method to
add default action when 'Enter' is pressed when user enters data.

Bug: 981472
Change-Id: I24af81d0aced7394ecd1a579068833fe8fe7cf7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235693
Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776042}

This CL adds sign-in/sign-out methods to AccountManagerTestRule and
replaces SigninTestUtils usage in ChromeBrowserTestRule with
AccountManagerTestRule.

Bug: 1085034
Change-Id: I482061fd46728e50330f9d0afb2597d9411fd676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231041Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776041}

When computing the MaxContentForChild size for the tracks by the
IndefiniteStrategy we were not considering the baseline shim, since we
assumed it was enough to do it for the MinContentSize.

However, there are possible definitions of the grid track that cause
the MinContentForChild function to not be called, leading to an
incorrect intrinsic size for the grid.

Bug: 1091944
Change-Id: I91a35852dd044ded0fc14f03e97d3e140d80ba12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233239Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776040}

MetricsWebContentsObservers should be created through the
|CreateForWebContents| factory function. Hiding the constructor ensures
callers can't accidentally skip initialization handled by the factory
function.

Change-Id: I332aa234c7a307d80d8793ed4ebb4d2efb987448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233411Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776039}

https://skia.googlesource.com/skia.git/+log/f9ffdd6942f9..6e659e960945

2020-06-08 nifong@google.com Add a gm for ManagedAnimation.setColor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bungeman@google.com
Change-Id: Idf3fe02a606f4d44bf530e69f52d400da8a5f213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776038}

The UI is implemented in a separate delegate class, to make testing
easier.

Bug: 1076880
Change-Id: Iff148c5b5b4b88b3c4fa926af07548b2fca50856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231045
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776037}

-UIViewController.modalPresentationStyle needs to be set before
accessing UIViewController.presentationController.
Bug introduced with crrev.com/i/2199465 when the presentation controller
delegate has been set.

Before:
https://drive.google.com/file/d/1rjwVvABB6VlrhvOhBfisLhIsgLj-_QET/view?usp=sharing
After:
https://drive.google.com/file/d/1U0-ww3gydS1bccVqwQHaoImj1lJPqpCH/view?usp=sharing

Fixed: 1084968
Change-Id: Ibeaaca60105f677bc192eb4be5833bf28abc04f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235812
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776036}

This CL adds a Signin.Extensions.GetAuthTokenResult histogram that
records the result of chrome.identity.getAuthToken() call.

I modified the error handling in IdenityGetAuthTokenFunction class to
report an IdentityGetAuthError object instead of a string. This object
is then converted to an enum for the histogram recording and to a string
for returning to the the extension.

Some error strings got mapped to several error codes so we can uniquely
identity a code path that returned an error.

Bug: 1091423
Change-Id: I4ab1116305a0aa3777d829b002165b4c4c1a2cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234752
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776035}