- 15 Jun, 2018 40 commits
-
-
Dominic Farolino authored
This CL takes most of the logic in RequestInit::SetUpBody, intended to implement "extract a body", modulo the ReadableStream conversion (https://fetch.spec.whatwg.org/#concept-bodyinit-extract), and moves it to a static function in request.cc. This is some preparation work before adding request_init.idl and generating the RequestInit implementation with the IDL compiler, which is itself some preparation work to getting the BodyInit typedef to work properly in every place it is used (right now only in Request::CreateRequestWithRequestOrString and Response::Create). R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 836873 Change-Id: I229c97c761800e0d2615f9f19fd822564978db6e Reviewed-on: https://chromium-review.googlesource.com/1098676Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#567553}
-
Alexandre Courbot authored
Although V4L2ImageProcessor takes VideoFrames as input, the output that is passed to the completion callback was just an output buffer index. It was the reponsibility of the client to obtain the backing memory of this buffer by dedicated means. So far the only way to do this was to call the GetDmabufsForOutputBuffer() method, which is DMA-BUF specific and non-portable. This patch makes the completion callback take a VideoFrame representing the output buffer as as argument. That way, the image processor can construct a VideoFrame with its backing memory of choice, and clients are no more limited to DMA-BUF. This allows us to get rid of the non-portable GetDmabufsForOutputBuffer(), and to extract a common, non-V4L2 specific ImageProcessor interface in a future patch. BUG=850375 BUG=b:73752373 TEST=Tested VDA unittest and video playback on Hana (decoder + IP), and VEA unittest and resulting video playback on pit (IP + encoder). Change-Id: I97eed0c1e831a8b2bee7dae763e1de7e280b7c40 Reviewed-on: https://chromium-review.googlesource.com/1090417 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#567552}
-
Koji Ishii authored
Following bot results are included. 6829 6831 6836 6842 6844 6849 6857 6864 6870 7 lines were removed and 3 lines were deflaked by consecutive results since 6806. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9c98c2611a06e882fdf19760bee5feac788b3c0c Reviewed-on: https://chromium-review.googlesource.com/1100371 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567551}
-
Stuart Langley authored
Upon startup we get a callback with: - The total list of team drives a user has. - A list of drives that have been added since last restart. - A list of drives that have been removed since last restart. We were only creating loaders for drives that had been added, however we really need loaders for the entire list of team drives, not just the new ones since the last load. Bug: 715355 Change-Id: I1126d94b6e12b285f132423b4b756dd14e585184 Reviewed-on: https://chromium-review.googlesource.com/1098735Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#567550}
-
Zhongyi Shi authored
Bug: 846079 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I384116a58acb044453a42dbedc1c9f7d23290640 Reviewed-on: https://chromium-review.googlesource.com/1093311Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567549}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2572baac764..cdae28ee591a git log c2572baac764..cdae28ee591a --date=short --no-merges --format='%ad %ae %s' 2018-06-15 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader a5ac650d2031..a62cf68ca10c (1 commits) 2018-06-15 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 49aacad566aa..9491e5ebed98 (3 commits) Created with: gclient setdep -r src/third_party/skia@cdae28ee591a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I0b7cbf263ba9cd1d1650be27423829092f2b2bc5 Reviewed-on: https://chromium-review.googlesource.com/1101726Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567548}
-
Kent Tamura authored
This CL reduces estimated expanded size of local_frame_view.h from 8.0MB to 3.0MB. FYI: local_frame_view.h is used in 2,400+ compilation units. - To avoid including chrome_client.h, GetChromeClient() returns PlatformChromeClient. It overrides ScrollableArea::GetChromeClient(), which returns PlatformChromeClient. Introduce ToChromeClient(PlatformChromeClient*) - To avoid including first_meaningful_paint_detector.h, split LayoutObjectCounter out from first_meaningful_paint_detector.h. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I14ad29eb359ed8e1b0506f91674e85e8704f8b8e Reviewed-on: https://chromium-review.googlesource.com/1100726 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567547}
-
Ryan Hansberry authored
ChromeProximityAuthClient now uses either CryptAuthService or DeviceSyncClient to get remote device info or perform Cryptauth calls, depending on whether the chromeos::features::kMultiDeviceApi is enabled. Once the migration to DeviceSyncClient has been completed across all of Smart Lock, code that references CryptAuthService will be removed. This is one of many future CLs which are migrating Smart Lock to use DeviceSync Mojo API instead of directly using the CryptAuth API. TBR=jhawkins@chromium.org Bug: 824568, 752273, 848956 Change-Id: If78959aa2a0ef6dc9433bca29649ab2d837114a1 Reviewed-on: https://chromium-review.googlesource.com/1102161 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567546}
-
Findit authored
This reverts commit daccddc2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 567420 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RhY2NkZGMyMjQwMTRkYzA1MTE5NzcxODU0MzgzYTg3ODEzNmQxZmUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27924 Sample Failed Step: unit_tests Original change's description: > Start Fast App Reinstall flow. > > If the user clicks the Install button after ARC++ is provisioned, we should > start the flow right away. If not, we delay the flow until Play Store is ready. > > ARC++ changes: ag/4174872 > > Bug: 835029 > Change-Id: I36037df522addd9aec3f525157e2e5478c9d4836 > Reviewed-on: https://chromium-review.googlesource.com/1080012 > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Yue Cen <rsgingerrs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567420} Change-Id: I9f2f20d8a1ea1a57c88c1d166e17a3a364e2c167 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835029 Reviewed-on: https://chromium-review.googlesource.com/1102197 Cr-Commit-Position: refs/heads/master@{#567545}
-
cr://s-bVarun Khaneja authored
Screenshot: http://screen/cj3PraiFqWn Bug: 750327 Change-Id: I1e7e24837af130e2596405b67d654c1ce8cbea1e Reviewed-on: https://chromium-review.googlesource.com/1101961Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#567544}
-
Lu Chen authored
When the user clicks an anchor link, the following metrics will be reported to UMA: - clickable area; - distance to root top; - distance to visible top; - inside iframe or not; Bug: 850624. Change-Id: Ic99ce8a67b05b5d284535fa2d521c659578681d0 Reviewed-on: https://chromium-review.googlesource.com/1089375 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#567543}
-
Ryan Landay authored
In the Android horizontal tab switcher, if you quickly discard a normal tab and then tap the incognito toggle while not having any incognito tabs open, we currently have a bug causing us to stay in normal mode instead of switching to incognito mode. This is because the tab closure happens after the model has already switched, and closing a tab resets the current model to that of the tab that was just closed, so it brings us back to normal mode. The fix is to call StackLayout#commitOutstandingModelState() in the incognito toggle button tab handler before changing the active model (which triggers the animation). We already do this the handler for the button that shows/hides the tab switcher. Bug: 853071,831359 Change-Id: Ia7a199f8c357f5258625aec38bde1e6fbbe9a6da Reviewed-on: https://chromium-review.googlesource.com/1102150Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#567542}
-
Sergei Datsenko authored
Use paths rooted to mount point when communicating with drivefs. BUG=chromium:848126 Change-Id: I3756fe7ebd9ec5aaef8237c4a91209e7db8cdef2 Reviewed-on: https://chromium-review.googlesource.com/1100729 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567541}
-
Ned Nguyen authored
Change-Id: I27304a169825489fd0b3af42c10c7581c0602c12 Reviewed-on: https://chromium-review.googlesource.com/1101922 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Nicholas Verne authored
The old version of this test could cause a browser crash by shutting down too early. Now we wait until the flow has finished and the installer view is closed before shutting down. Bug: 851253 Change-Id: I9f00f23587d2e3b52c8b1355f682e5397a460de1 Reviewed-on: https://chromium-review.googlesource.com/1101599Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567539}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/82ff2ae08f20..030b88a205c9 git log 82ff2ae08f20..030b88a205c9 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 tandrii@chromium.org cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload. Created with: gclient setdep -r src/native_client@030b88a205c9 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:796383 TBR=mseaborn@chromium.org Change-Id: I417019b2a46259d6a2ce50aeec5fcc25d102d3f4 Reviewed-on: https://chromium-review.googlesource.com/1101724Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567538}
-
Kunihiko Sakamoto authored
To clarify that it is for single Signed Exchange. Bug: 803774 Change-Id: If8503589f33749862f82c07569046abe64ec1e37 Reviewed-on: https://chromium-review.googlesource.com/1100728 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#567537}
-
Yuichiro Hanada authored
Test: keyboard_unittests. Change-Id: Ia69ef5a33cdec9a82ffac84d54205321f592b82e Reviewed-on: https://chromium-review.googlesource.com/1101607 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567536}
-
Kunihiko Sakamoto authored
To clarify that it is for single Signed Exchange. Bug: 803774 Change-Id: I9a7acc5b3c7b1074828c0560fba819ae351d6ff7 Reviewed-on: https://chromium-review.googlesource.com/1100658Reviewed-by:
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..a5ac650 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic6c36ddf3c2f3d1e58bc3f592aa93515f3f295f9 Reviewed-on: https://chromium-review.googlesource.com/1101401 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567534}
-
Gyuyoung Kim authored
FirstMeaningfulPaintDetector has been using a hardcoded timeout value (0.5 seconds) to limit the time of checking the first meaningful paint. However, there are various devices and network bandwidths that Chromium should work. In such cases, we need to change the FMP timeout value depending on the environment. To support it, this CL introduces a new command line switch in order to set a custom timeout value for the FMP detection. Bug: 850403 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id308a72acfc3563384076bbbe19c441d506757ee Reviewed-on: https://chromium-review.googlesource.com/1090512Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#567533}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28f5dd8a4c8a..c2572baac764 git log 28f5dd8a4c8a..c2572baac764 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 fmalita@chromium.org [skottie] Switch to SkJSON 2018-06-14 halcanary@google.com SkTHashTable no longer uses SkNoncopy 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 caryclark@skia.org do not mistake locals for methods 2018-06-14 halcanary@google.com SkTemplates no longer uses Sknoncopyable 2018-06-14 fmalita@chromium.org Reland [skjson] Size-constrained input API 2018-06-14 halcanary@google.com SkCanvas, SkImageGenerator, SkStream: remove SkNoncopyable 2018-06-14 halcanary@google.com SkRefCnt no longer a SkNoncopyable 2018-06-14 jvanverth@google.com Implement tilted concave ambient shadow 2018-06-14 fmalita@chromium.org Revert "[skjson] Size-constrained input API" Created with: gclient setdep -r src/third_party/skia@c2572baac764 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I8c7d779617a376a3b78b23d117ec30b803560caa Reviewed-on: https://chromium-review.googlesource.com/1101722Reviewed-by:
-
Shu Chen authored
Bug: 786434 Change-Id: I7f18cf55c99c61ad398015430818626aedd4da1e Reviewed-on: https://chromium-review.googlesource.com/1098739Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567531}
-
Weidong Guo authored
Changes: 1. Add enumeration for different types of app moving. 2. Add histogram for total page number and number of pages that have empty slots. (Both numbers' increase indicates the success of the feature.) Bug: 850269 Change-Id: I8e99e4b11e86dd003a3f6425b42084834b145fc1 Reviewed-on: https://chromium-review.googlesource.com/1096117Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567530}
-
chrome://media-internalschcunningham authored
MediaLog URL strings can be arbitrarily long and originate at untrusted renderer. Truncate to 1000 chars including an ellipsis. BUG=851048 Change-Id: I5b8d72a8f907707792c508eda5c7a2b75886ad34 Reviewed-on: https://chromium-review.googlesource.com/1098015 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567529}
-
Ian Clelland authored
Three header files were renamed recently, but the corresponding lines in the relevant BUILD.gn file were missed. Change-Id: Id22ef514e25b7d16f07459771327a404393fcd86 Reviewed-on: https://chromium-review.googlesource.com/1101509Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567528}
-
Ryan Hansberry authored
The special-case request to disable Smart Lock for all devices requires, on the server-side, that the public key not be set at all. Failing to do so results in an errback from the server. Bug: 824568, 752273 Change-Id: I867d4a897b39b3927170488900a23b2d6450d467 Reviewed-on: https://chromium-review.googlesource.com/1102106 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Wez authored
This is a reland of e17dbaf1 Original change's description: > Make base::ScopedZxHandle a zx::handle. > > - Add the ScopedZxHandle APIs to the base zx::handle. > - Add missing includes. > > This allows ScopedZxHandle to be removed incrementally from call-sites. > > Bug: 852541 > Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97 > Reviewed-on: https://chromium-review.googlesource.com/1100132 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567382} TBR: gab, rockot, kmarshall Bug: 852541, 852958 Change-Id: I66df191da2449007a154595255efc01ac732d110 Reviewed-on: https://chromium-review.googlesource.com/1101742 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#567526}
-
Mohamed Heikal authored
Fix cause for test flake WebApkIntegrationTest#testWebApkLaunchesByLauncherActivity and remove the flakey label. Bug: 852648 Change-Id: Iafbfd37297d8b589aa11455f2d6f129a74f2af43 Reviewed-on: https://chromium-review.googlesource.com/1101465Reviewed-by:
-
Ke He authored
This is one step of "moving //device/geolocation into //services". BUG=800659 Change-Id: I40f3c1f1b534027132e9eeb17ac5671cad398731 Reviewed-on: https://chromium-review.googlesource.com/1100680Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#567524}
-
Ke He authored
Before moving //device/geolocation into //services, we have to make sure all the clients can only depends on //device/geolocation/public. Clients shouldn't visit internal parts of the geolocation. After this, we can move geolocation into //service in a clean way in next step. BUG=800659 Change-Id: I1886e88bece4e20308e3e59a247d51b71a33ebac Reviewed-on: https://chromium-review.googlesource.com/1100550Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#567523}
-
Dirk Pranke authored
As part of the LUCI migration, we want to shut down chromium.webkit and just run the layout tests on the appropriate builders on the android/linux/mac/memory/win waterfalls instead. This CL moves the webkit_layout_test suites from WebKit Linux Trusty (dbg) to Linux Tests (dbg)(1), and from WebKit Mac 10.11 (dbg) to Mac Tests 10.13 (dbg). R=hinoka@chromium.org BUG=790293 NOTRY=true Change-Id: Iaec56746312a2aca700c77ad73314779e034f5fb Reviewed-on: https://chromium-review.googlesource.com/1101918 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#567522}
-
Rohit Rao authored
Adds a new image and view spacing when the UIRefresh experiment is enabled. Adds Dynamic Type support as well. Legacy: https://drive.google.com/file/d/1UIIDcwMcpcG-N7-AKox94UtQErhiy1ip/view Refresh: https://drive.google.com/file/d/1hrP-Cgrm1jdaK0K6BM-P-ytMMxBplwlX/view BUG=805166 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9b4ba4aac10b0b91ff38b127bf978db4ee93639d Reviewed-on: https://chromium-review.googlesource.com/1099415Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567521}
-
Yoichi Osato authored
This patch rebases image expectations for - fast/writing-mode/japanese-lr-selection.html since they are styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I015c144effcba7ef57f24d475607f372c3a46a70 Reviewed-on: https://chromium-review.googlesource.com/1100374 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567520}
-
Stuart Langley authored
UMAs already existed for full and directory fetch, so just added a new histogram for TeamDrives. Added UMA for delta fetch for both the default corpus and a TeamDrive. Added expiry dates for the three UMAs. I couldn't find an example of how to test that the correct UMAs are being written in a C++ test, hence there's no tests. Bug: 843446 Change-Id: Ifd000cabc02f1b0e4cd7cf599fe83d9bfa74b8f5 Reviewed-on: https://chromium-review.googlesource.com/1092959 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Jun Choi authored
Implement Cable handshake protocol client logic that dispatches control message to the authenticator and validates incoming control messages from connected authenticator. Handshake message sent to and received from the authenticator should together be used to construct a session key with which the FidoCableDevice use to encrypt/decrypt incoming and outgoing messages. Bug: 849307 Change-Id: I818792c7234e039e43de8425ee8f7a30610073a0 Reviewed-on: https://chromium-review.googlesource.com/1089327 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567518}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91211414086..fce7bc9e0825 git log c91211414086..fce7bc9e0825 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 tandrii@chromium.org Add infradata/config repo to gclient. 2018-06-14 tandrii@chromium.org Revert "gclient_scm: Use cherry-picking instead of rebasing." Created with: gclient setdep -r src/third_party/depot_tools@fce7bc9e0825 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:613739,chromium:850812,chromium:853032 TBR=agable@chromium.org Change-Id: I24e9ff53d5457de436e88160a1e1637cb2b63a1d Reviewed-on: https://chromium-review.googlesource.com/1101723Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567517}
-
Chris Hamilton authored
This is in preparation for surfacing the data in the chrome://discards UX. Change-Id: I64d0f43e6f313cfd96291c3c81adc15a8d78b5a3 Reviewed-on: https://chromium-review.googlesource.com/1099596 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567516}
-
Blake O'Hare authored
When the launcher pops up, the search field has focus. If you do this quickly after the virtual keyboard has been hidden, the transient blur heuristic will cause the keyboard to be re-shown. Backstory: Some text boxes are actively focused (user presses a text field) and some are passively focused (a window has a search box that is auto- focused). The latter cases should not cause the keyboard to show up. However, if the keyboard was recently dismissed, the "transient blur" heuristic will cause any passively focused text field to invoke the keyboard. The primary purpose of this is login flows that require you to type your name on one screen and then your password on the next screen (like the Gaia login flow) where the password field is passively focused. By explicitly dismissing the keyboard, it will clear out the counter for this heuristic and prevent the focused search field in the launcher from causing the keyboard to open if it was previously open in the past few seconds. The most common form this bug manifests is if someone clicks away from the keyboard to dismiss it with the intention of showing the shelf to immediately access the launcher. Bug: 848664 Change-Id: Ibdcb7a64906498be052c0071a611fdb639fc32f5 Reviewed-on: https://chromium-review.googlesource.com/1088450 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Nigel Tao authored
Type checking should already be covered by the existing js_type_check("closure_compile") BUILD.gn target. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3086629f3439237722f8f7b36a41031a7551901 Reviewed-on: https://chromium-review.googlesource.com/1100661Reviewed-by:calamity <calamity@chromium.org> Reviewed-by:
-
