- 06 Mar, 2018 16 commits
-
-
Tetsui Ohkubo authored
It fixes asan failure on shutdown when SystemTrayUnified flag is enabled. WebNotificationTray explicitly set |system_tray_| as the next focusable view. However, the focusable view linked list was broken when UnifiedSystemTray is enabled, as UnifiedSystemTray is inserted between these views. UnifiedSystemTray is invisible, and these viewss are adjacent, so we don't have to set the focusable view explicitly. It also renames |system_tray_unified_| in Shell to |unified_system_tray_|. TEST=out/asan/ash_unittests --gtest_filter=UnifiedStatusAreaWidgetTest.Basics BUG=none Change-Id: Ifac7ae910771802cc1515e4e05318264c6f82a52 Reviewed-on: https://chromium-review.googlesource.com/940707Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#541008}
-
Chris Harrelson authored
This was the case until https://chromium.googlesource.com/chromium/src/+/8e4234fdc272ddda5ec9c156a2397c64d7a69f60, which removed scroll offset. Bug:818519 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id79668c0ea9ca62ff8c181de2b4f1a0be6594e82 Reviewed-on: https://chromium-review.googlesource.com/949969Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541007}
-
John Abd-El-Malek authored
This reverts commit 31fd846e. This causes debug Windows component builds to not run on Windows, giving the error below. Bruce & Rob tracked it to the change in util/BUILD.gn which adds mincore.lib --------------------------- chrome.exe - System Error --------------------------- The program can't start because api-ms-win-power-base-l1-1-0.dll is missing from your computer. Try reinstalling the program to fix this problem." Original change's description: > Update Crashpad to 4375233ad2dad48f2332ecc20221df10f98b668a > > This includes a reland of 58866fc9, which was reverted at > 68255cbf. The cause for the revert was addressed by upstream > 82777cff5848. > > 14dbd3531d98 gn win: Get main test binaries building > 6cf4f928eb08 gn win: Add auxiliary test binaries used by > end_to_end_test.py > 36679d572ba0 win: Don't assume offsets the same when > kDoesNotObserveDaylightSavingTime > 9ab4fbf1e1a7 win: Improve child crash location test > 798f6540435f gn win: Use new toolchain names to support both x86 and x64 > 83a83c5b0050 Roll mini_chromium to e7e8237 > a483e2c599b8 Fix names of Windows trybots after server-side rename > 38b20ca57efc Relocate CaptureContext to misc and implement on Linux > a8ad3bdbdfb1 linux: fix incorrect fallthrough > 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build > b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too > f878f155172b fuchsia: Add flock() stub to get test binaries linking > again > e5bbdaff87a9 Pass FilePath to Settings in Initialize() > c45ba7920e01 Make NewReport objects own their associated database > resources > 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM > c406797ce620 Add UploadReport to manage database resources during > upload > 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic > symtab > 8d0d999d9245 Add a cross-platform database implementation > b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader > implementations > 6667fa25595a fuchsia: Fixes to TestPaths > 90cde8e30f7d Disable upload on Android > 4094c2628d33 Address review comments for 8d0d999 > a4d7fb4cc390 Use .long for pointers on 32-bit platforms > 5e5b927b38ca Build crashpad_client_linux.cc on Android > eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch > 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests > f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests" > 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests > 0429216f59b1 linux: Add CrashReportExceptionHandler > f38af628c9dc fuchsia: Don't fail rename if source == dest > 040360239343 Fix > CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt > ions > 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non- > functional > 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to > Settings > 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE > 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad > source root > 4a9d422652a1 Turn fuchsia trybots on by default > ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed > from SDK > 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac > d2a866978b89 Makes 'all' build on Linux > d8d03172c278 arm: Capture context around pc and registers > ebad8bd925c3 Don't spawn an upload thread if url is empty > 0520fdff1edc linux: Move ScopedPrSetPtracer to util/ > 38540eaf71cb Add handler options for Linux/Android > 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH() > 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work > cab259330f2e fuchsia: Pass more data out of module snapshot > 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into > ModuleSnapshotElf > 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of > ProcessSnapshotFuchsia > 2290a826af1e Pull (most) platform-specific MemorySnapshots out > 3030ae54171a fuchsia: Fix ninja auto-regen after run > 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a > test > c69ba3d52783 non-win: Add > Multiprocess::SetExpectedChildTerminationBuiltinTrap() > f130822b9f4b linux: Add CrashpadClient tests > 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions > fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler() > cd3afe616e63 Linux: Pull and use clang toolchain in third_party > 8e80a575d15f Linux: Pull a sysroot if pulling a local clang > fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot > a869ae18d256 Workaround for death test failure when in threadsafe mode > on Mac > 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation > 9affa2a0e72d Optionally stub out the libcurl-based implementation of > HTTPTransport > dec23bef5769 win gn: reintroduce flags to disable warnings > 746ce1a63703 Roll mini_chromium to 987bde8 > 493e29bc3df0 win: Use correct format specifier > a45e88602b90 Skip ELF notes with a p_vaddr of zero > 71d90608828d Add Linux trybots to CQ > 449506d59c6a Roll mini_chromium to ef0df11 > 82777cff5848 win: fix warnings when building with clang > 23b2156fb694 Don’t read beyond a StringPiece’s bounds in > StringToNumber() > 4375233ad2da win: fix 64-bit build > > Also: > Add new metrics enums values. > Use new CrashReportDatabase interface. > > Bug: crashpad:30, chromium:817982, chromium:818376 > Change-Id: Ib4fcc423f68a4c80907968498264413f3f229c5c > Reviewed-on: https://chromium-review.googlesource.com/947745 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540894} TBR=palmer@chromium.org,jperaza@chromium.org,mark@chromium.org,siggi@chromium.org Change-Id: I2fbdde093d12fc1f93bd10478f6022effa0d8d2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crashpad:30, chromium:817982, chromium:818376 Reviewed-on: https://chromium-review.googlesource.com/950343Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#541006}
-
Devlin Cronin authored
Use URLPattern::MatchesEffectiveTld() in parsing ExternallyConnectableInfo. Now that we canonicalize the URL for the URLPattern, the behavior of these is the same and we can remove the duplicate logic. Bug: None Change-Id: I3a84c0aca81284ecca4ce60f1beb0bdeff05a961 Reviewed-on: https://chromium-review.googlesource.com/935453Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541005}
-
Jinsuk Kim authored
The 2 remaining callsites can use the corresponding content view directly to get the physical width/height. This CL does that, and removes the interfaces from ContentViewCore. Bug: 598000 Change-Id: I29a15a85eae58ded74dcbd6b00b8ba35f49c94fa Reviewed-on: https://chromium-review.googlesource.com/945185Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#541004}
-
Patrick Monette authored
Bug: 717696 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0999ac10df31c4d90e33cd139667c1c816722d27 Reviewed-on: https://chromium-review.googlesource.com/949309 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#541003}
-
MinChen authored
Bug: 799524 Change-Id: Ie6f09fb95debdfc1fed37eaae2c2bdc672c8b585 Reviewed-on: https://chromium-review.googlesource.com/944361Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#541002}
-
Xiaoqian Dai authored
Cros splitscreen: Use current screen orientation instead of cached screen orientation when calculating snapped window bounds. It's possible that there is a dismatch between the current screen orientation and the cached screen orientation in SplitViewController. Bug: 799609 Change-Id: I484324e4716b51239c40a9d482f9b7f85ced0627 Reviewed-on: https://chromium-review.googlesource.com/947665 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#541001}
-
gogerald authored
Test video: https://drive.google.com/file/d/1XJjWyN1hMDKoZsAkLF66Yp-Rn3pyDXv3/view?usp=sharing Bug: 782270 Change-Id: Ief93be66fb740feb439f92d2a55c41e6c9ed4f44 Reviewed-on: https://chromium-review.googlesource.com/943676Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#541000}
-
Fergal Daly authored
Add/update docs on various keys classes in the process. Bug: 795634 Change-Id: Ia9a996b7f087a3e301c348eba711e3ce86128b1b Reviewed-on: https://chromium-review.googlesource.com/934108 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540999}
-
Dmitry Gozman authored
We are accessing null RenderWidgetHostView. Also added a test which exposed an issue with emulation commands not being processed when crashed. Bug: 818573 Change-Id: Ife852d5323b56d2d08382ef865ac9bf51c5476ff Reviewed-on: https://chromium-review.googlesource.com/949725Reviewed-by:
-
Shubhie Panicker authored
This is needed for Lifecycle API, see: https://github.com/WICG/web-lifecycle WasDiscarded is set on RequestNavigationParams on browser side and passed into to WebURLRequest on renderer side. And later set on the Document in DocumentLoader::CommitNavigation. For detailed discussion, see (internal) thread: https://groups.google.com/a/google.com/d/msg/chrome-lifecycle-apis/e0vsRLUISBE/t_BKYGcwAQAJ Change-Id: I160628db6ba0a01f7b5281c78d7c2df40a28611f BUG: chromium:816454 Change-Id: I160628db6ba0a01f7b5281c78d7c2df40a28611f Reviewed-on: https://chromium-review.googlesource.com/912488 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540997}
-
Thomas Tangl authored
This CL replaces the current sync asset in the user menu. Screenshot: https://drive.google.com/file/d/1T7Ot720-gUi9xRIn5EwW1sX3YF734PAz/view?usp=sharing Bug: 818092 Change-Id: I1ea4f41b09003574670742930a9e74603d203f4f Reviewed-on: https://chromium-review.googlesource.com/945912Reviewed-by:
-
Jinho Bang authored
As discussed in crrev.com/934741, we no longer want to show the permission prompt. Bug: 665949, 816980 Change-Id: I80f5bdae056df841d8edea797d8578aacfaf6015 Reviewed-on: https://chromium-review.googlesource.com/939882Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Brett Wilson authored
The README file is two years out of date. This removes the transition status and references to GYP, and just retains the links to related documentation. Fixes a help typo. Change-Id: Ie783f32e90eb24643ba06698ddc0b3206116c724 Reviewed-on: https://chromium-review.googlesource.com/949769Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#540994}
-
sczs authored
- Creates TableViewHeaderFooterItem and TableViewTextHeaderFooterItem. - Adds viewForHeaderInSection and viewForFooterInSection in ChromeTableVC. Table Catalog Screenshot: https://drive.google.com/open?id=1xKjc3vGVxtkfcz39OdSZY_ENFDO1OnHv Bug: 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f3923db7909e6fbf732b0bc8d069d2cfbc6603a Reviewed-on: https://chromium-review.googlesource.com/942605 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540993}
-
- 05 Mar, 2018 24 commits
-
-
Reilly Grant authored
As requested by Yubico this change adds the rest of their Yubikey devices to the WebUSB blocklist. Bug: 818807 Change-Id: I4755ca0a2558e7efb2449e6b439c2abcc2440611 Reviewed-on: https://chromium-review.googlesource.com/949389Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540992}
-
Xianzhu Wang authored
Truncation caused inadequate logical width when padding is like 1.7px. Bug: 817342 Change-Id: Ibdb76cc528cc7e04801fe65409bb8f60e5ac69a5 Reviewed-on: https://chromium-review.googlesource.com/943827 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#540991}
-
https://pdfium.googlesource.com/pdfium.git/+log/31e08d1d6db1..f3be555096b0 $ git log 31e08d1d6..f3be55509 --date=short --no-merges --format='%ad %ae %s' 2018-03-05 dsinclair [formcalc] Simplify function signature parsing 2018-03-05 dsinclair [formcalc] Cleanup m_error handling Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I02471dc99f214abbe77990da67aa13b77f2b080b Reviewed-on: https://chromium-review.googlesource.com/949780Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540990}
-
Joy Ming authored
Since unswipeable notification issues are ephemeral and hard to to reproduce, adding logs with the 'DownloadFg' tag that will be visible in logcat if a bugreport is taken. Bug: 752675, b/73846764 Change-Id: I8272b690906ae16165a232c1679fce124e70410d Reviewed-on: https://chromium-review.googlesource.com/943929 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540989}
-
Tommy C. Li authored
This makes Home go to the beginning of the full unelided URL. It also makes Shift+Home select the elided part (scheme and subdomain) portion of the URL only. Bug: 797354 Change-Id: I47d9a7ad25e8dcb10f2e53f638cded6649ffa564 Reviewed-on: https://chromium-review.googlesource.com/944508 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#540988}
-
Kevin Bailey authored
If we close a tab, the tab index order can change, so, in Navigate(), use the index before closing the other tab. Bug: 780835 Change-Id: Ie88ab8e50528ec41e1048b3b5d12137f235202e3 Reviewed-on: https://chromium-review.googlesource.com/948822 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
-
Jose Dapena Paz authored
GCC 7.2/7.3 complains for redefining String as a method, in IDB code, because the string accessor is named String(). So rename the accessor to be GetString. It seems basic.scope.hiding should imply the original code is valid, so reported as a bug to GCC: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 Change-Id: Ide66104bd0953f5bb03a1bc62d7f238833ea62e7 Reviewed-on: https://chromium-review.googlesource.com/944406 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#540986}
-
John Rummell authored
Update the CDM interface to provide information on the encryption scheme and pattern necessary to decode the encrypted media. Currently only 'cenc' decryption is supported. Detection (and support) of other schemes will be done later. Note that only CDMs that implement the ContentDecryptionModule_10 interface will be able to use this information. CDMs that implement a previous version of the interface will not get this information, so only 'cenc' encrypted (or unencrypted) data will be passed to those CDMs. BUG=658026 TEST=existing EME browser_tests pass Change-Id: I14d7d1a44f0d7ff721dab7d6046a29a65055b3a4 Reviewed-on: https://chromium-review.googlesource.com/933730 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540985}
-
Chris Nardi authored
Change-Id: I071484497d2126171928191c66985e2e055e3f8b Reviewed-on: https://chromium-review.googlesource.com/945147Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#540984}
-
Lukasz Anforowicz authored
Bug: 477150 Change-Id: Ia72179e9ea9e953d8d12963c1b1cddc481679f08 Reviewed-on: https://chromium-review.googlesource.com/944423 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Chris Palmer authored
It would return true even if you were actually at the end of the input. Bug: 818844 Change-Id: I0ba5be52b568e39a087efc1e8114138ac4c18799 Reviewed-on: https://chromium-review.googlesource.com/949963Reviewed-by:
-
Jinsuk Kim authored
This CL is moving the 2 other gesture events (scroll/doubletap) flow to EventForwarder, and removes the related logic from ContentViewCore. Bug: 598880 Change-Id: Ie52de9f5074e7921184d394154c82e20284e057d Reviewed-on: https://chromium-review.googlesource.com/935601Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
I saw a flake on trybots. TBR=rockot@chromium.org NOTRY=true Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I42b7af3f1c4c0bfcaac80f12712f43aab2758f80 Reviewed-on: https://chromium-review.googlesource.com/950123 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/1a8d762a18d6..9d28974d16d1 $ git log 1a8d762a1..9d28974d1 --date=short --no-merges --format='%ad %ae %s' 2018-03-05 bsalomon Reenable write pixels tests 2018-03-05 bungeman Remove BitmaskEnum from SkTypeface. 2018-03-05 fmalita [skottie] Inverted matte support 2018-03-05 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 52ea039af..76a0bf463 (2 commits) 2018-03-05 egdaniel Don't use GENERAL layout during mipmap generation in Vulkan 2018-02-28 herb SkGlyphCache - update core routines. 2018-03-03 bsalomon Remove GrSurfaceOrigin from GrSurfaceDesc. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Iea5a08135ac8d1b56591bffbbf5165a38ecd0e70 Reviewed-on: https://chromium-review.googlesource.com/949766Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540979}
-
Karan Bhatia authored
Currently ExtensionWebContentsObserver(EWCO) does not get RenderFrameCreated notification for the Devtools main frame. This happens because the frame is created before the EWCO construction. Also, at the time of ExtensionWebContentsObserver construction, this frame happens to be the speculative RenderFrameHost of the root FrameTreeNode and hence is not enumerated via WebContents::ForEachFrame. To fix this, also track the new hosts seen through the WebContentsObserver::RenderFrameHostChanged method. Add a browser test for the same. Also, rename ExtensionAPIFrameIdMap::OnRenderFrameCreated to InitializeRenderFrameHost to clarify the new usage. BUG=817075 Change-Id: I81213f0441162a483fda9191991763a3fee65905 Reviewed-on: https://chromium-review.googlesource.com/942684 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540978}
-
Marcin authored
Notification.PRIORITY_* was deprecated in O since priority became determined by notification channel importance instead. This change makes it explicit that setting priority on a notification will only have an effect pre-O, and uses NotificationCompat.PRIORITY_* constants wherever possible. This is another try of resolving it after rollback for https://chromium-review.googlesource.com/c/chromium/src/+/793831 TBR=mlamouri, dimich Change-Id: I079e6a4e24ba989500aa9e0815889b136082200b Reviewed-on: https://chromium-review.googlesource.com/888748 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#540977}
-
flim authored
https://github.com/xiph/opus/pull/73 Bug: webrtc:8088 Change-Id: Ie3838e5c8600259af46bdf09680e58dcf55f78a2 Reviewed-on: https://chromium-review.googlesource.com/942317Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#540976}
-
Jay Civelli authored
Adds a new API to the unzipper service that lets clients select which files should be extracted. Also adding unit-tests for the unzipper client code. Bug: 799220 Tbr: sky@chromium.org, blundell@chromium.org Change-Id: I0408baccf8a2b0e5b904e76e25d840ead469660b Reviewed-on: https://chromium-review.googlesource.com/943828 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#540975}
-
Shimi Zhang authored
Split ClassRegister out from http://crrev/c/923021. Introduces ClassRegsiter to upstream, but don't make any use of it until the corresponding downstream part is added. Bug: 805531 Change-Id: I42db76afd1a78e70208876f8a8a9120b34cf2d44 Reviewed-on: https://chromium-review.googlesource.com/949611Reviewed-by:
-
Joel Einbinder authored
The PopoverHelper holds a reference to an external element. The helper needs to be disposed if the element outlives should outlive the helper. Change-Id: I58fb02a929a601cadf3472db886517c553a87575 Reviewed-on: https://chromium-review.googlesource.com/949668Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#540973}
-
Qiang Xu authored
changes: Using IsActiveUserSessionStarted instead of IsUserSessionBlocked as IsUserSessionBlocked could contain not ACTIVE state during logging in, which could cause BuildWindowList crash. Bug: 805046 Test: tested on device Change-Id: I13fac4df6a0dd7e531dc30fbc91d6dd80152ee30 Reviewed-on: https://chromium-review.googlesource.com/949666Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#540972}
-
Christopher Cameron authored
If a LayerTreeHost's LocalSurfaceId has been committed to a LayerTreImpl, then never allow that LocalSurfaceId to be used with incompatible size or scale factor. This CHECK should eventually be enabled on all platforms, but for now only passes tests on non-Aura. Ideally, this CHECK should not depend on has_pushed_local_surface_id, but scale factor adjusting layout tests use transiently-invalid settings. Bug: 814690 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia610cbbb0859260e620cc79639daed9b39ba7a1b Reviewed-on: https://chromium-review.googlesource.com/947713Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#540971}
-
Saman Sami authored
The call into ClearCompositorSurface... is not necessary because the destructor of RWHVGuest will implicitly evict the surface by invalidating its frame sink id. Remove that method and its unit test and also unify RenderWidgetHostViewGuest::SubmitCompositorFrame and RenderWidgetHostViewChildFrame::SubmitCompositorFrame because there doesn't seem to be any differences between them that actually matters. Change-Id: I2cae5d3d8f5099cd224b849c3bffe71645596328 Reviewed-on: https://chromium-review.googlesource.com/949563Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#540970}
-
Hwanseung Lee authored
According to the spec[1], Element.computedStyleMap() should return the same object each time. [1]https://drafts.css-houdini.org/css-typed-om-1/#dom-element-computedstylemap Bug: 816761 Change-Id: Ice74cca345ba5b4f7136f44695a4b3f6ab605f9a Reviewed-on: https://chromium-review.googlesource.com/939123Reviewed-by:
-
