- 13 Jan, 2021 40 commits
-
-
Thomas Guilbert authored
|VideoFrame::metadata_| is now a value type, and guaranteed to never be null. This CL updates the return value of VideoFrame::metadata() to use a const VideoFrameMetadata&. This should save an indirection every time metadata() is used. Bug: 1096727 Change-Id: I1ba6fb2a9df4605ab0c015d1e92c6a3838276d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604398 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#842899}
-
Yuki Shiino authored
This reverts commit 8a443cd6. Reason for revert: Suspicious about breaking chrome_all_tast_tests. https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-eve-chrome/12106/overview Original change's description: > Reland "Move crostini section under Advanced in settings." > > This is a reland of 3ece5c0f > > Original change's description: > > Move crostini section under Advanced in settings. > > > > Bug: 1163003 > > Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840920} > > Bug: 1163003 > Change-Id: If8e1b56cda55269d67df5e9aad21464dc9245f5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623571 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842785} TBR=khorimoto@chromium.org,nverne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ia2686a1edb8bcc773503329b6a30b34ed891a36e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626698Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842898}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d7f91cf..1e60bce4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0023d7943ed0ab0a8d39651fe80e9bbc722ac50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625802Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842897}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - fake_file_selection_handler.js - file_selection.js - file_transfer_controller.js - file_transfer_controller_unittest.m.js - holding_space_util.js - path_component.js Bug: 1133186 Change-Id: I410a81add17eeb9a3f4e8d85258bf202f15e42f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622132 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842896}
-
Yuta Hijikata authored
The change replaces deprecated variable names is_lacros and IS_LACROS with is_chromeos_lacros and IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: I9d4664ed4f9ef0b95a43e51183f92a29fd0a5040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623611Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842895}
-
Yuta Hijikata authored
The change replaces deprecated variable names is_ash, is_lacros, IS_ASH, IS_LACROS with is_chromeos_ash, is_chromeos_lacros, IS_CHROMEOS_ASH and IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: Id8e24910248b5537ba7e558b02be10c2ee7c2a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621793Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842894}
-
David Black authored
Holding space is enabled for guest sessions but previously redirected to use original profile instead of OTR profile. This caused: - Thumbnails to fail to render - Opening Files app via util to fail These failures are due to expectations further downstream that guest sessions use OTR profiles. To address this: - Redirect to primary OTR profile in holding space for guest sessions - Allow OTR profiles in FileChangeService for guest sessions Note that FileChangeService was previously *not* created for OTR profiles but they will now be allowed if the profile is a guest session. This CL also modified FileChangeService to *not* create the service w/ the browser since the service does not need to exist until interacted with. Bug: 1165733, 1164329 Change-Id: I032aea25171594bdb0666c87564a80f7c0cfe203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625799 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#842893}
-
Asami Doi authored
This CL fixes origin comparison on IsSameOriginClientContainerHost() for blob url workers. This fixes WPTs for clients.claim() when PlzDedicatedWorker is enabled. Before this CL, IsSameOriginClientContainerHost() took an origin from ServiceWorkerContainerHost::url() that returns GURL. However, this didn't work when the function returns a blob url (e.g., when the container host is for a blob url worker) because GURL::GetOrigin() cannot retrieve an origin from blob URLs (see https://crbug.com/1144717). After this CL, the function takes the origin from ServiceWorkerContainerHost::GetUrlForScopeMatch(). Even for blob url workers, this returns a non-blob URL inherited from their parent. It should be valid to take the origin from the alternative URL because it's guaranteed that they are in the same origin. This might not align with the spec based on the discussion in the issues, but we implement this to keep compatibilities: - https://github.com/w3c/ServiceWorker/issues/1265 - https://github.com/w3c/ServiceWorker/issues/1554 Bug: 1017034 Change-Id: Ia167c1acaa665ac08e433d37f78d4c5b22383ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600420 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#842892}
-
Sammie Quon authored
This patch tries to different between users who want to use the trackpad to quickly switch desks and users who use the trackpad to look at the contents of adjacent desks. For the former, we introduce a threshold of 500ms. If the user ends their swipe within 500ms, we will move them to the next desk if the next desk is more than 10% visible. For the latter, we keep the old logic of moving them to the desk which is most visible when the swipe ends. Also lowers the threshold when starting a swipe. We had some feedback that this was too high. Bug: 1158065, 1158067 Test: manual, added tests Change-Id: I9feb8f8a8f591227f883d58bfe9c38b1653f7fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617044 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842891}
-
Yoshifumi Inoue authored
This patch changes |Text:splitText()| to avoid having empty |LayoutText| as other text modifying functions, e.g. deleteData(), replaceData() to reduce changes that AX tree having AX objects with empty |LayoutText|. Note: The root cause of issue 1149171 is |Range#insertNodes()| calling |Text#splitText()| with offset 0. Bug: 1149171 Change-Id: Ibfecb14111ff16f3901fe23cdba6d3fcae1ddda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623371 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842890}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d79335daa04a..76d89fa22033 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968 Tbr: yukishiino@google.com Change-Id: Ia02af77d9c9551bfdb0d8ab2cc59dbcec1716b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625818Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842889}
-
Xiaohan Wang authored
Add this metrics to help track EME session type usage. Manually tested on Shaka Player Demo and saw the following in about://histograms: Histogram: Media.EME.Widevine.CreateSession.SessionType recorded 1 samples, mean = 1.0 (flags = 0x41) 0 O (0 = 0.0%) 1 ------------------------------------------------------------------------O (1 = 100.0%) {0.0%} 2 ... Tbr: foolip@chromium.org Bug: 1165438 Test: See above Change-Id: Ie6482f0f66b94d743866304ff56eef8d7cf0b2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622724Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842888}
-
Simon Jackson authored
The `MediaRecorder` spec was recently updated to allow either constant bitrate (CBR) or variable bitrate (VBR) encoding to be specified with `MediaRecorderOptions`, previously VBR was assumed when using anything other than uncompressed PCM. This change adds support for the updated specification and for enabling the hard CBR mode of the Opus encoder when CBR mode is configured for the `MediaRecorder`. Intent-to-ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/ewJTgBMTxGg/m/w2qGgVCeAQAJ Bug: 980559 Change-Id: I2e4d6305e951dedfbbcd2447b69fc4f81209a3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731907Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#842887}
-
Regan Hsu authored
* Disconnect button is now a single chromevox stop. * Feature title and labels are no longer chromevox stops. "Learn more" link is still a tab stop though, because it's actionable. * Tooltip icon now announces tooltip content. Fixed: 1163773 Bug: 1106937 Change-Id: I7e97743d53ccf55128e18f5210ac35350ac3b0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618521 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#842886}
-
Kuo Jen Wei authored
Bug: b/176266123 Test: Manually test grid line transition animatation when toggling and change grid type in grid setting. Change-Id: I91653609c0eea082de8091bc1b45a8a1f301d6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626695 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#842885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c13ea848e6b5..fdd89469d681 2021-01-13 jzern@google.com update stale codereview.chromium.org links If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I41183926532ee2506b8072dbafddbfad4c7119c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842884}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/22eff1eb8c2f..7faa362ea9c2 2021-01-12 shrekshao@google.com Fix SamplerFilterAnisotropicTests mipmap 2021-01-12 dsinclair@chromium.org Convert WGSL comments to // If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic56b7d7ab7199e9e4e54348746cda08252c63eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626456Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610485069-629e2dfa0196177c8ad81665d7b0a927aebce730.profdata to chrome-win32-master-1610495996-5598384ad8a00037e18a56fd00981ea765e31cd1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If883530a91fd7799828ae6824d69cff7ad53a900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626371Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d38b9f86ff8c..2ed9671a0ddd 2021-01-12 cnorthrop@google.com State: Provide reference to image unit binding vector 2021-01-12 jmadill@chromium.org Vulkan: Add YUV G8_B8_R8_3PLANE_420_UNORM format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Aztec Ruins MEC Change-Id: I4fe0c1c2a41b7105947fa8098cc12e9630118392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626093Reviewed-by:
-
Yuta Hijikata authored
This change renames deprecated macro IS_LACROS to IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: I55fe9e33983a75f340d953b12c8c72d69b7eee6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623733Reviewed-by:
-
Theo Johnson-kanu authored
Screenshot: https://screenshot.googleplex.com/7sot2pkVRoKn5ci.png - Adds a new system tray icon - Adds icon as a button to system tray - No test where added because network_section_header.cc does not currently have a test. Test will be added in a subsequent CL Bug: 1163556 Change-Id: Ia965ec395b83f72b20350851a730f76a392f4669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622658Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#842879}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/002c03c4b6ed..2881d6b22d1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia1f472898714aae6b32bb322bf9cf2163ff4f537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626359Reviewed-by:
-
Luciano Pacheco authored
Add JS modules for files in //ui/file_manager/file_manager/js/ui/ : - progress_center_panel.js - commandbutton.js - default_task_dialog.js - combobutton.js Bug: 1133186 Change-Id: I08267440b93e2c181a966824937f21db134be59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626669 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842877}
-
Jasmine Chen authored
Add entry to record the client type during OpenDevice(). This allows to determine the number of Chrome, Android camera users respectively. The client side CL is at crrev.com/c/2619449 2. emerge and deploy cros-camera 3. Verify that the metric is logged in chrome://histograms Bug: b/176787333 Test: 1. Build and deploy simple chrome. Change-Id: I8159eae088b83a99dba5657e04ac63e965d01f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621452Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#842876}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610474333-dd150f7e1f8853577c8d1e97bbf4737322a5d0b4.profdata to chrome-win64-master-1610495996-7189a1d14c9908600535ebce9352fe55a59722e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66965d7737f25a7fa9edc7a2bb59edb67d1980bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626455Reviewed-by:
-
Nancy Wang authored
AppService creates standard circle icons for all apps. However, there are a few cases that icons on shelf are not app icons, e.g.: 1. Task manager 2. A few extensions show icons when open a new window, e.g. google hangouts. This CL create standard circle icons for them when they are shown on shelf. Modify TaskManagerView to create standard icon when running in Chrome OS. Modify ChromeLauncherController::OnAppImageUpdated. If the icon is not loaded by AppServiceAppIconLoader (which loads the standard circle icons), create standard icons. BUG=1162514 BUG=1142373 Change-Id: Ibfe40c33944a1120ca9c991c4953d0da906ee2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624273 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Peter Kasting authored
If we pass a View* through a void*, we need to cast to View* on the other side before any casting to a View subclass, or the pointer will not be fixed up correctly. In this case, we can just pass as a View* directly, avoiding the void*, and the cast-to-derived Just Works. Found this while trying to add metadata to OmniboxViewViews, which inherits from views::Textfield but does not have that as the first base class. Bug: none Change-Id: I5abc3efc3abbbe470ab23b3579984767f9e51b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625752 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#842873}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Icfc56e5ea80edf8434748822d93c5f6c91922d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626768Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842872}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.86. R=rmhasan@google.com Bug: 1041619 Change-Id: I0120a8122986353bf85cf29319b623ad05fe9a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626372 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#842871}
-
Mike Jackson authored
This change extends support for running a PWA at OS login to MacOS. iOS is not supported with this change. The change adds MacOS to the support about:flags page, allowing users to control at both installation time, and from chrome://apps page if an application can run at login. Tested: Manually on MacOS 11.0 - Install extension from chrome/test/data/extensions/background_app/ - Chromium should be set to run at login for user - Remove extension - chromium should no longer be set to run at login Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: I28a96de60479b6bf1627d6b0e39ef603f52d5658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521233 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
With this CL, most of Cros API starts to support multiple receivers. AshChromeService and LacrosChromeService are exceptions. Bug: 1148448 Test: Build and run Lacros on a DUT. Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#842869}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8149a9615c1b..c13ea848e6b5 2021-01-13 mandy.chen@microsoft.com Change to slash separator to fix a bug on Windows in owners.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I6ee75e49be9f11f97db6e84649b2dd3ab97ede65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626629Reviewed-by:
-
Rayan Kanso authored
Bug: 1125665 Change-Id: I0f3b9de05eb1b5f78912637d22836501a61d0057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624652 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Carlos IL authored
Bug: 1105210 Change-Id: If66e6ade4aefe2f147352093afe5ecc0eee074fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626110 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#842866}
-
Dominick Ng authored
Apps that are hidden in the launcher, but still able to be launched should be able to be shown in the shelf. One example of this is the four Android apps explicitly hidden from the launcher: Android Settings, Android Files, Android Contacts, and Android Clock. If the user manages to launch one of these (e.g. through Chrome OS settings or via Play Store), they should be pinnable on the Shelf. Currently, this doesn't work as the ARC publisher prevents apps which are hidden from the launcher from being shown in the shelf. Practically, this manifests as an inability to persist the pin state for these four apps. That is, the apps can be pinned, but logging out and logging back in loses the pin state. This CL addresses the bug by always allowing ARC apps to be shown in the shelf, independent of whether they are present in the launcher. This should only affect the four apps listed as they were the only four Android apps where the show_in_shelf value was false. A test is added to verify the behaviour - the test fails before this CL. BUG=1124865 Change-Id: Ie4ac89a929396e7ee4a40efd9386d4af00b532db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623610 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842865}
-
Callistus authored
Bug: b/170162419 Change-Id: I862f02fa7949d3c1e06b83c2389ddc63273f2188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617406 Commit-Queue: Callistus Tan <callistus@google.com> Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
-
Hayato Ito authored
It would be better to clarify an expected behavior how CORS behaves for WebBundle subresource loading in the current implementation. Note that - The expected behavior is a tentative decision, which might change in the future. The spec side issue is https://github.com/WICG/webpackage/issues/609. - A |crossorigin| attribute is not supported yet. BUG=1149816 Change-Id: Ic104ec039a07f864b6a60452ff42f2ec09a03c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617167Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842863}
-
Joel Riley authored
Based on feedback from UI review. Bug: 1165820 Change-Id: Ia8c40899676038a15a2a462696ea30be9167013b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625393 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
-
Bartek Nowierski authored
If GigaCage isn't enabled, this DCHECK will get triggered: {FreeNoHooksImmediate,PartitionAllocFreeForRefCounting}-> ->PartitionRefCountPointer->DCheckGetSlotOffsetIsZero-> ->PartitionAllocGetSlotOffset-> ->DCheckIfManagedByPartitionAllocNormalBuckets GigaCage isn't needed to set up PartitionRefCount. It's only needed to easily detect from BackupRefPtr code if PartitionRefCount is available, but this won't be an issue because BackupRefPtr is disabled when GigaCage isn't needed. Bug: 1073933 Change-Id: I78faea9427ca06643033d0025cdef6472131c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621855 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842861}
-
Yuki Shiino authored
This reverts commit 854d530c. Reason for revert: Suspicious about causing a test failure of SimpleURLLoaderTest.OnUploadProgressCallback specific to Fuchsia. https://ci.chromium.org/ui/p/chromium/builders/ci/Fuchsia%20ARM64/113096/overview Original change's description: > Roll Fuchsia SDK from 0.20210111.3.1 to 0.20210112.3.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast > Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com > Change-Id: I7d83d8a9d4fdfc9015e1b371fc4635b709fca37b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625688 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#842792} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I8c106070941443e3f25aeecb2b1acad73b4c80b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626694Reviewed-by:
-
