- 15 Jul, 2017 40 commits
-
-
Bruce Dawson authored
Doing another VS2017 test over the week end now with the newly packaged VS 2017 Update 3 Preview 4 (was Preview 2 last time). This CL is currently purely for testing purposes and will be reverted by the end of the weekend. R=dpranke@chromium.org BUG=683729 Change-Id: Ie5c2e92b789b1dcbd51d4e0028230b5b72ce9eb9 Reviewed-on: https://chromium-review.googlesource.com/572500Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486999}
-
Justin Schuh authored
Perform template check with UnderlyingType and clamp shift value for SaturateFastAsmOp<>; TBR=servolk@chromium.org Change-Id: I8828b06a211515ee06d65c7dd1989b7cd84a841c Reviewed-on: https://chromium-review.googlesource.com/572870 Commit-Queue: Justin Schuh <jschuh@chromium.org> Reviewed-by:
Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486998}
-
Dmitry Torokhov authored
We are changing the layout of top function row key, removing the "Browser Forward" button, moving several keys one position left, and inserting the Play/Pause button. Because Chrome needs to be able to map from Fnn keys to the proper action keys and back, we need to know the layout of keyboard we are dealing with. ChromeOS will use UDEV to mark the keyboards with new top row layout with CROS_KEYBOARD_TOP_ROW_LAYOUT=2 property, and we will be looking for this property in the event rewriter code and select appropriate layout. BUG=b:63576567 Change-Id: Id2be04ef85809b6bd7627d3b55ac6d3082f7b8c5 Reviewed-on: https://chromium-review.googlesource.com/571652Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#486997}
-
Varun Khaneja authored
This list used to be sync'd for both Chromium and Chrome previously but that was changed due to https://crbug.com/728757 because the PVer4 server did not support that list for non-Chrome clients. The server has now been updated to return this list to non-Chrome clients so changing the sync condition from kSyncOnlyOnChromeBuilds back to kSyncAlways. Bug: 728757,543161 Change-Id: I0dec4aa8556a9ba6b667f168d95711eaf48a5b61 Reviewed-on: https://chromium-review.googlesource.com/570378Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486996}
-
Quinten Yearsley authored
Bug: 736177 Change-Id: I7c4d54a4a3a7b33ac3be88ac07ee0e0d3a4353fb Reviewed-on: https://chromium-review.googlesource.com/570774 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486995}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3184e075. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/320 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Iea65fd4163ebd4fb0948b6dcb3ac82df05d6ed08 Reviewed-on: https://chromium-review.googlesource.com/572942 Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486994}
-
Geoff Lang authored
TBR=kbr@chromium.org NOTRY=true BUG=angleproject:2103 Change-Id: If69f5782e45218e5df364fb756d7676c5248c5be Reviewed-on: https://chromium-review.googlesource.com/572850Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#486993}
-
Mounir Lamouri authored
The work to abstract the media controls from the HTMLMediaElement allows us to do this without risks. However, when the Cast overlay has to be used, the controls need to be created even if they are not used. The code implementing this logic is part of the native controls so we can't lazy initialise the controls the same way. Bug: 731143 Change-Id: I2eb912ab6124c24000860007c1d6e6aa3300c440 Reviewed-on: https://chromium-review.googlesource.com/528176 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486992}
-
Amirhossein Simjour authored
screen_share.icon is moved back to ash/resources/vector_icons. As a result VrShell is no longer using the 1x version of this icon. BUG=736350 Change-Id: Iaa9934fa99345e58acd60d7e3250b58b80ba170f Reviewed-on: https://chromium-review.googlesource.com/565546Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#486991}
-
Hidehiko Abe authored
This CL migrates ArcEnterpriseReportingService. BUG=672829 TEST=Ran try. Change-Id: Ib86168f0cf52096025366c4a52ec0030a1c09f55 Reviewed-on: https://chromium-review.googlesource.com/571116 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486990}
-
Tom Anderson authored
BUG=661774 TBR=erg@chromium.org Change-Id: I16aa7ff8acd6c389173f970485fcb9659900a45d Reviewed-on: https://chromium-review.googlesource.com/572871Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486989}
-
Jinho Bang authored
The spec[1] was changed. FYI, this feature is still behind runtime flag. [1] https://github.com/w3c/payment-handler/pull/187 Bug: 661608 Change-Id: I134c668110fcdc79d237dfd349e3dbf4203fb090 Reviewed-on: https://chromium-review.googlesource.com/564097Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#486988}
-
Hidehiko Abe authored
This CL migrates ArcCrashCollectorBridge. BUG=672829 TEST=Ran try. Change-Id: Idc873df7e2519c79e1ee2b0ed45b0100d8ee543c Reviewed-on: https://chromium-review.googlesource.com/571566 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486987}
-
Hiroshige Hayashizaki authored
ImageResourceContent::content_status_ is suspected to be reset to kNotStarted (i.e. 0) during ImageResourceContent::UpdateImage(), but therer is no code that sets content_status_ to kNotStarted explicitly. This CL adds CHECKs() to - Check whether |this| is garbage collected unexpectedly during UpdateImage(), and - Investigate where |content_status_| becomes kNotStarted precisely. This is to be reverted before going to beta. Bug: 737392 Change-Id: I2879bc54771a295a2dd77fed6808c1c08668e262 Reviewed-on: https://chromium-review.googlesource.com/572036 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486986}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86730555..248b789e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I8751ec8fd592db1cf6086ca46b7b3d13e7e378ea Reviewed-on: https://chromium-review.googlesource.com/572534Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486985}
-
tzik authored
This CL removes all dependency from SyncFileSystem to SequencedWorkerPool. SyncFileSystem did not use the task runner from SequencedWorkerPool even before this CL, and the remaining dependencies were shutdown detection and task queue flushing. Change-Id: I9feefbebee6b153472bbc04ac7d6cbb621162e4e Reviewed-on: https://chromium-review.googlesource.com/569530Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#486984}
-
Takeshi Yoshino authored
FindCharsetInMediaType() looks for a substring that is likely to be indicating the charset parameter loosely without performing ABNF validation. New code should use the strict version in HttpUtil. Bug: 674329, 743311 Change-Id: I9faa60dcb63e983a62aff74601ac16257da28e80 Reviewed-on: https://chromium-review.googlesource.com/564749 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486983}
-
Takeshi Yoshino authored
Bug: 699873 Change-Id: I9663d6728e770a4860f4f05beffc68722fa981b8 Reviewed-on: https://chromium-review.googlesource.com/571202Reviewed-by:
Sigbjørn Finne <sigbjornf@opera.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486982}
-
Hidehiko Abe authored
This CL migrates ArcClipboardBridge. BUG=672829 TEST=Ran try. Change-Id: I34642868629e673015bcf298869d1ced2d0a0ad5 Reviewed-on: https://chromium-review.googlesource.com/571528 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486981}
-
Aleks Totic authored
They symptom was really slow pipes between content_shell and test runner. I did not know what XDG_RUNTIME_DIR was, so I looked it up. Seems relevant to the symptom. Curious about what the root cause was. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html XDG_RUNTIME_DIR defines the base directory relative to which user-specific non-essential runtime files and other file objects (such as sockets, named pipes, ...) should be stored. The directory MUST be owned by the user, and he MUST be the only one having read and write access to it. Its Unix access mode MUST be 0700. The lifetime of the directory MUST be bound to the user being logged in. It MUST be created when the user first logs in and if the user fully logs out the directory MUST be removed. If the user logs in more than once he should get pointed to the same directory, and it is mandatory that the directory continues to exist from his first login to his last logout on the system, and not removed in between. Files in the directory MUST not survive reboot or a full logout/login cycle. The directory MUST be on a local file system and not shared with any other system. The directory MUST by fully-featured by the standards of the operating system. More specifically, on Unix-like operating systems AF_UNIX sockets, symbolic links, hard links, proper permissions, file locking, sparse files, memory mapping, file change notifications, a reliable hard link count must be supported, and no restrictions on the file name character set should be imposed. Files in this directory MAY be subjected to periodic clean-up. To ensure that your files are not removed, they should have their access time timestamp modified at least once every 6 hours of monotonic time or the 'sticky' bit should be set on the file. If $XDG_RUNTIME_DIR is not set applications should fall back to a replacement directory with similar capabilities and print a warning message. Applications should use this directory for communication and synchronization purposes and should not place larger files in it, since it might reside in runtime memory and cannot necessarily be swapped out to disk. Bug: 725229 Change-Id: Ia34c349c94dd44357c135b98deab1a119fa557a6 Reviewed-on: https://chromium-review.googlesource.com/572640Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#486980}
-
Brett Wilson authored
These are on both Windows and Linux. Use the new ScopedPlatformFile typedef. Change-Id: I3905a70c68c306c418ac1d24913d624bdd997c8b Reviewed-on: https://chromium-review.googlesource.com/572521 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#486979}
-
Hidehiko Abe authored
This CL migrates ArcBootErrorNotification. BUG=672829 TEST=Ran try. Change-Id: I8ea1f03507a4a654e035f5b9ba34819770d4b6fe Reviewed-on: https://chromium-review.googlesource.com/571527 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486978}
-
Fady Samuel authored
This CL moves SurfaceResourceHolder{Client} to components/viz/service/frame_sinks, removes an invalid include from cc::Surface to SurfaceResourceHolderClient, deletes an unused FakeSurfaceResourceHolderClient and updates all includes, forward declarations and namespaces appropriately. Bug: 722935 Change-Id: Ib0194d17a16555bbf70899ff67b8c7bca7ec9e04 Reviewed-on: https://chromium-review.googlesource.com/571267 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486977}
-
Hidehiko Abe authored
This CL migrates ArcBluetoothBridge. BUG=672829 TEST=Ran try. Change-Id: I731078ffc94bd45fa2a97daf6c9d57fbd26e251f Reviewed-on: https://chromium-review.googlesource.com/571526 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486976}
-
Toni Barzic authored
The CL adds a entry point for launching note taking app on lock screen to lock screen UI. The entry point is located in top right corner of the lock screen UI, and expands to the full screen when clicked. When the animation is done - i.e. app launch button covers the whole screen, note taking app launch is requested (and unlock button shown in the login header bar). Note that the new entry point position can conflict with the current position of version info - when note taking entry point is present, the version info string is translated to the left - this is done by introducing a top-header-bar shown at the top of the screen (in md UI only) that contains version string and new-note-action button. Also, introduce two more LOCK_SCREEN_APPS states in login UI - AVAILABLE - state set when new note action is available on lock screen (and new-note-action button should be displayed) LAUNCH_REQUESTED - transient state for requesting new note action launch Bug: 737067 Change-Id: Ie13b6bbc6920269d3721f6680eceb641f3d5c4b9 Reviewed-on: https://chromium-review.googlesource.com/568393Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#486975}
-
Erik Chen authored
The 10.12 SDK adds new availability annotations for many existing methods. Existing code must be updated with availability annotations to prevent "-Wunguarded-availability" warnings from triggering when compiling against the 10.12 SDK. For more details, see https://clang.llvm.org/docs/LanguageExtensions.html#objective-c-available TBR=avi@chromium.org, davidben@chromium.org, reillyg@chromium.org Bug: 669240,735328 Change-Id: Ifebb4a6f5b7f2171f0d0ba732c92d8ac79bc435f Reviewed-on: https://chromium-review.googlesource.com/571316 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486974}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: If4cce04e63a15b6d71dfc5e849bed6f145eb97d2 Reviewed-on: https://chromium-review.googlesource.com/572527Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#486973}
-
Hidehiko Abe authored
This CL migrates ArcAudioBridge. BUG=672829 TEST=Ran try. Change-Id: I2d48c86e0ba20bc98d28b09e25a309b888304610 Reviewed-on: https://chromium-review.googlesource.com/571344Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486972}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/52586f952ecb624f823eb9ee5ef2eb41e644e7f5..14308731e5446a73ac2258688a9688b524483cb6 This picks up, among other things, the fix to some ServerHello parsing. Bug: 743218 Change-Id: I45316af58f675f59ae141f9f1379690010bf04c7 Reviewed-on: https://chromium-review.googlesource.com/572621Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#486971}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f2c901474c24..1a325d25b941 $ git log f2c901474..1a325d25b --date=short --no-merges --format='%ad %ae %s' 2017-07-14 csmartdalton Coverage counting path renderer 2017-07-14 scroggo Report error on failure to create SkCodec 2017-07-14 ethannicholas converted GrBlurredEdgeFragmentProcessor to sksl 2017-07-14 csmartdalton Fix SkClassifyCubic for near-quadratics 2017-07-14 brianosman Revert "remove dead code for legacy image encode api" 2017-07-14 bsalomon Make GrAtlasTextOp a non-legacy GrMeshDrawOp 2017-07-14 ethannicholas converted EllipseEffect to sksl Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Iee5257b138cec85ae8f0e71a5285028771b6ddad Reviewed-on: https://chromium-review.googlesource.com/572563Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486970}
-
Jinho Bang authored
The spec[1] was changed. [1] https://github.com/w3c/payment-handler/pull/167 Bug: 661608 Change-Id: I38e7ff1d6e6da4ffb99e83fdb37f4cda94eab91d Reviewed-on: https://chromium-review.googlesource.com/565078Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#486969}
-
Tom Anderson authored
BUG=730889 R=sadrul@chromium.org Change-Id: I4b28a1e0a70236e2410eed9d442481db5fb0c898 Reviewed-on: https://chromium-review.googlesource.com/572054Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486968}
-
Bruce Dawson authored
This change switches the VS 2017 package to use the 10.0.15063.468 SDK and the fourth preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 4, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.468 SDK installer was used to install the Debuggers package. The latest version of vswhere.exe doesn't show pre-release versions of VS by default so win_toolchain/package_from_installed.py was locally patched to add the -prerelease flag to the vswhere.exe invocation. Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default so this makes no immediate difference. R=dpranke@chromium.org BUG=683729 Change-Id: Ic9515f6f315931c72a762411ea6713e86351ce37 Reviewed-on: https://chromium-review.googlesource.com/572480 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486967}
-
Ilya Sherman authored
Prior to launching Safe Mode, we want to verify that there won't be a significant number of false positives, which might otherwise cause more harm than good. This CL adds metrics to measure how often Safe Mode would trigger, without actually enabling safe mode even when the heuristics say it should trigger. R=asvitkine@chromium.org Bug: 727984 Change-Id: I83b909bf81ec8c6416f47151c17fe4e53725ee3c Reviewed-on: https://chromium-review.googlesource.com/570731 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486966}
-
Devlin Cronin authored
Make two changes to how we initialize features for contexts in extension native bindings: - Treat runtime specially. This is necessary because certain runtime methods should be exposed only if there exists an extension that can connect to the given context (e.g., an extension that cooperates with a given website). Simply checking the fature availability is insufficient. Update unittests to match. - Treat web contexts specially. Web contexts only ever have a handful (3) APIs that are potentially available to them, and are by far the most commonly created context. As such, add a fast path for them by only checking those possible features. (This matches logic in the JS bindings system). Bug: 653596 Change-Id: I57f50b6f762f578679771c5e07a1b3ce31da3e0c Reviewed-on: https://chromium-review.googlesource.com/571962Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486965}
-
Alex Vallée authored
Added --disable-all-origin-trial-controlled-features which will turn off all RuntimeEnabledFeatures that can be enabled by OT. These features can then only be enabled with a valid trial token. Bug: 685788 Change-Id: Ic5e3976fe51482794107ca82c32412f2b47aee8c Reviewed-on: https://chromium-review.googlesource.com/568807 Commit-Queue: Alex Vallee <avallee@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#486964}
-
perryuwang authored
When running GPU thread inside browser process, GpuPreferences is not updated from GPU command line switches and blacklists. So we need update those preferences in GpuDataManagerImplPrivate::UpdateGpuPreferences when in_process_ is true. Change-Id: Ic60e778e0c436b8f44365eec70c2855935629a54 Reviewed-on: https://chromium-review.googlesource.com/569324Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#486963}
-
Bruce Dawson authored
If we always build clang with symbols on Windows then it makes debugging and profiling easier. The build time costs shouldn't be too bad, and the generated code will be identical. This would have saved a bit of time in the investigation of crbug.com/727447. BUG=727447 Change-Id: Ib065be626db5d6b0b9c27792a0141c5fb696e208 Reviewed-on: https://chromium-review.googlesource.com/572660Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486962}
-
Quinten Yearsley authored
This reverts commit 4f552ac6. Reason for revert: Caused unit test failures, see https://crbug.com/743211 Original change's description: > shelf: Add a back button to the shelf. > > This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. > This approach of adding a back button expands the current app list button to be modal and have two functionalities > depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what > is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The > exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the > meantime. > > Screenshots: > https://screenshot.googleplex.com/ZVNP0aq0cc3 > https://screenshot.googleplex.com/fDcGTuoyZg5 > https://screenshot.googleplex.com/ZFBzk72LLVt > > Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*" > Bug: 721940 > Change-Id: I699c6d971aea89ba201536ca8534a14b4d44b0e2 > Reviewed-on: https://chromium-review.googlesource.com/555836 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486830} TBR=msw@chromium.org,oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org,msw@google.com Change-Id: Id4eb870a99514a7f2b64cbe35d993047d0cc43e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721940 Reviewed-on: https://chromium-review.googlesource.com/572682Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486961}
-
Dave Schuyler authored
This CL moves the policy indicator on the homepage url from under the input to the same line as the input. Bug: 736149 Change-Id: I3896b3e77284a82742ae51ea1d6fe86753087488 Reviewed-on: https://chromium-review.googlesource.com/570821Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#486960}
-