GitLab

TBR=vsevik@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/196423025

git-svn-id: svn://svn.chromium.org/blink/trunk@169553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch keeps highlightPosition method on SourceFrame for backwards compatibility with corresponding virtual methods on View.

R=lushnikov@chromium.org, lushnikov, pfeldman

Review URL: https://codereview.chromium.org/204323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce InspectorStyleSheetBase, inherit InspectorStyleSheet and InspectorStyleSheetForInlineStyle from it.

BUG=341506

Review URL: https://codereview.chromium.org/202103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r169450 has resulted in multiple failures of existing code where functions
annotated with @this are passed as arguments along with their receivers.

The cases include:
- Array.prototype.forEach and other iteration-with-callback methods.
- RemoteObject.prototype.callFunction[JSON], whose functionDeclaration
  can be evaluated on any Object (but expect a certain type thereof).
- WebInspector.Object.prototype.{add,remove}EventListener, which accepts
  the callback receiver as its third argument.

This patch introduces receiver specification detection in these cases,
or resorts to IGNORE in ambiguous situations.

R=aandrey, sergeyv, vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/203443010

git-svn-id: svn://svn.chromium.org/blink/trunk@169549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

overridden for explicit destructor dispatching.

The |finalize| name is too short and makes sense in other places
in the code. We rarely need to override finalizeGarbageCollectedObject
so it is fine that the method name is long.

Concretely, fileapi Stream has a finalize method that currently
gets called instead of the destructor. That leads to crashes because
the Stream destructor is not called and therefore the Stream is
no unregistered as a ContextLifecycleObserver and a call is made
on the already dead stream when the Document dies.

R=erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, zerny@chromium.org
BUG=352755

Review URL: https://codereview.chromium.org/199273005

git-svn-id: svn://svn.chromium.org/blink/trunk@169548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spaces are are neither in the Ps, Pe, Pi, Pf and Po sections of UNICODE, so they should not be
considered when determining the length of the first-letter pseudo-element. This change will make
Blink inconsistent with WebKit (which consider spaces, without it being specified by the CSS spec.
It will make Blink consistent with other engines such Trident (IE11) and Opera.

R=eae@chromium.org, tkent@chromium.org
BUG=340688
TEST=Update existing test to treat spaces according to this change, and move it to use reftests.

Review URL: https://codereview.chromium.org/198013006

git-svn-id: svn://svn.chromium.org/blink/trunk@169547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also moved the simple ViewportStyleResolver onto the heap. Next will change ImmutableStylePropertySet to transition types.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/204373003

git-svn-id: svn://svn.chromium.org/blink/trunk@169546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutUnit misuse, often from improper conversion to other types,is a 
constant source of bugs in Blink. This is the second patch with the goal 
of making such error-prone conversions explicit in the hopes of forcing 
developers to think through these conversions while writing their patches.
These conversion sites were discovered by toggling the float conversions
to explicit and finding the compiler errors.

BUG=350474

Review URL: https://codereview.chromium.org/200023002

git-svn-id: svn://svn.chromium.org/blink/trunk@169545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move BitmapImageTest.cpp, GIFImageDecoderTest.cpp and JPEGImageDecoderTest.cpp.

BUG=353585

Review URL: https://codereview.chromium.org/203543002

git-svn-id: svn://svn.chromium.org/blink/trunk@169544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minor refactor, that removes an unused private member function valueChanged.

Review URL: https://codereview.chromium.org/204333002

git-svn-id: svn://svn.chromium.org/blink/trunk@169543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, pfeldman, vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/202763006

git-svn-id: svn://svn.chromium.org/blink/trunk@169542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to determine if it could be made readonly. The getter is
measured to learn the relative usage, and is most likely above any
threshold for removal.

BUG=none

Review URL: https://codereview.chromium.org/203193010

git-svn-id: svn://svn.chromium.org/blink/trunk@169541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/201083004

git-svn-id: svn://svn.chromium.org/blink/trunk@169540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Web Animations API: Load resources referenced in element.animate() (https://codereview.chromium.org/196573030/)

Reason for revert:
Causing assertion failure in ChromeOS browser_tests.
https://code.google.com/p/chromium/issues/detail?id=353962

Original issue's description:
> Web Animations API: Load resources referenced in element.animate()
> 
> This patch fixes a bug where resources in element.animate() calls were
> not being fetched. This resulted in StylePendingImages leaking out of
> the style resolving stage and into rendering which causes a crash.
> 
> This patch fixes the bug by ensuring StylePendingImages introduced in
> applyAnimatedProperties() will be resolved as non-pending StyleImages
> through an additional call to loadPendingResources().
> This patch also modifies AnimatableImage to be a wrapper of CSSValues
> instead of StyleImages in order to follow the same resource caching
> logic as typical CSS image values.
> This patch also updates EffectInput::convert() to pass the document's
> StyleSheetContents to MutableStylePropertySet::setProperty() so that
> relative URLs are correctly resolved to absolute URLs.
> 
> BUG=353385
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169424

TBR=dstockwell@chromium.org,esprehn@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353385

Review URL: https://codereview.chromium.org/203413008

git-svn-id: svn://svn.chromium.org/blink/trunk@169539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also add missing transition type handling for [PutForwards] over
garbage collected interface types.

R=haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/196133029

git-svn-id: svn://svn.chromium.org/blink/trunk@169538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptExcution thread can set source location info such as postioin, orientation and velocity.
These locations also are read from audio thread.

Distance model also need to quarantee a thread safety.

FIXME :consider thread safety about m_position in audio thread.
FIXME :consider thread safety about m_orientation in audio thread.
FIXME :consider thread safety about m_velocity in audio thread.

BUG=350583

Review URL: https://codereview.chromium.org/196993002

git-svn-id: svn://svn.chromium.org/blink/trunk@169537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/200053006

git-svn-id: svn://svn.chromium.org/blink/trunk@169536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Prepare to move AbstractSQLTransactionBackend, SQLTransactionBackend, and SQLTransactionCoordinator::CoordinationInfo to Oilpan heap.

This CL changes the mapped type of m_coordinationInfoMap from copyable
object to OwnPtr<> or Member<>. So we need to update some code
in SQLTransactionCoordinator.

BUG=347902
R=ager@chromium.org, haraken@chromium.org

Review URL: https://codereview.chromium.org/198213005

git-svn-id: svn://svn.chromium.org/blink/trunk@169535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Missed a case for remote tracks.

BUG=352154

Review URL: https://codereview.chromium.org/201353002

git-svn-id: svn://svn.chromium.org/blink/trunk@169534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=abarth
BUG=None

Review URL: https://codereview.chromium.org/203593010

git-svn-id: svn://svn.chromium.org/blink/trunk@169533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also have DOMWindow keep a persistent reference to its Performance object.

R=
BUG=340522

Review URL: https://codereview.chromium.org/197283036

git-svn-id: svn://svn.chromium.org/blink/trunk@169532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/203363003

git-svn-id: svn://svn.chromium.org/blink/trunk@169531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov@chromium.org, lushnikov, pfeldman

Review URL: https://codereview.chromium.org/202043002

git-svn-id: svn://svn.chromium.org/blink/trunk@169530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/204063002

git-svn-id: svn://svn.chromium.org/blink/trunk@169529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353934
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/197873036

git-svn-id: svn://svn.chromium.org/blink/trunk@169528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347902
NOTRY=true

Review URL: https://codereview.chromium.org/203303009

git-svn-id: svn://svn.chromium.org/blink/trunk@169527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a node is removed and then re-added to the document,
the back-end node id remains the same and the front-end id
is new. This means that if we keep resolved front-end nodes,
we should check if these still exist and re-resolve the ids
to new nodes if these are detached and re-attached to the document.

BUG=
R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/195813010

git-svn-id: svn://svn.chromium.org/blink/trunk@169526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=127940

Review URL: https://codereview.chromium.org/179973004

git-svn-id: svn://svn.chromium.org/blink/trunk@169525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Constructors view is updated whenever allocation or summary perspective is selected.

BUG=277984
R=alph@chromium.org

Review URL: https://codereview.chromium.org/198833008

git-svn-id: svn://svn.chromium.org/blink/trunk@169524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169508

BUG=345027
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/204283004

git-svn-id: svn://svn.chromium.org/blink/trunk@169523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169505

BUG=352050
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/196343029

git-svn-id: svn://svn.chromium.org/blink/trunk@169522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL also fixes the -expected file with the correct expectations (PASS),
though this test rarely passes.

As noted in the bug, the test has been confirmed correct, and we need to fix
our behavior. At that time, we can remove the TestExpectations entry.

BUG=306249

Review URL: https://codereview.chromium.org/204003004

git-svn-id: svn://svn.chromium.org/blink/trunk@169521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/204183002

git-svn-id: svn://svn.chromium.org/blink/trunk@169519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

messageHandlerInMainThread can be invoked while we're initializing a window (See stack traces in the bugs). In that half-baked situation, we don't have a valid context nor a valid world, so we should return immediately.

BUG=345014,352179
NOTRY=true

Review URL: https://codereview.chromium.org/203123006

git-svn-id: svn://svn.chromium.org/blink/trunk@169518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

core/ and v8/ only use |impl|, while bindings/ uses half |imp|
and half |impl|.
This regularizes bindings to |impl|.

BUG=345503
R=haraken

Review URL: https://codereview.chromium.org/202203009

git-svn-id: svn://svn.chromium.org/blink/trunk@169517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add the implementation for V8 Promises in ScriptPromise and ScriptPromiseResolver so that:
 - They can handle V8 Promises correctly.
 - ScriptPromise creates a V8 Promise if ScriptPromiseOnV8Promise turns on.

Add ScriptPromiseOnV8Promise runtime enabled flag which is always off.
Add Layout tests for ScriptPromise.

BUG=352552

Review URL: https://codereview.chromium.org/197213007

git-svn-id: svn://svn.chromium.org/blink/trunk@169516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169478

BUG=345027
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/204273002

git-svn-id: svn://svn.chromium.org/blink/trunk@169515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit r169269. This is a speculative fix for the performance
tests timing out on the Win8 bot.

BUG=353275

Review URL: https://codereview.chromium.org/203463008

git-svn-id: svn://svn.chromium.org/blink/trunk@169514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169472

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/204263002

git-svn-id: svn://svn.chromium.org/blink/trunk@169513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is a followup to [1] to cleanup the dependencies on
the old text autosizer. The largest change in this patch is to
remove the "container" concept and rely only on clusters and
blocks in the FastTextAutosizer.

The big changes in this patch include:
* formInputTags vector -> isFormInput(const Element*)
    Passing around a static vector was unnecessarily confusing. This
    patch refactors the formInput statics into a single function:
    isFormInput.
* isAutosizingContainer -> !isExemptFromAutosizer
    The logic of isAutosizingContainer has been switched in
    isExemptFromAutosizer and I think the new name better reflects
    what this function does.
* containerIsRowOfLinks -> blockContainsRowOfLinks
* contentHeightIsConstrained -> blockHeightConstrained
* containerContainsOneOfTags -> blockContainsFormInput
* containerShouldBeAutosized -> !blockPreventedFromAutosizing
    The logic of containerShouldBeAutosized has been switched in
    blockPreventedFromAutosizing. I think this better reflects what
    this function does.
* blockMightBecomeAutosizingCluster has been added.
* isFingerprintingCandidate has been removed in favor of
    blockMightBecomeAutosizingCluster

[1] https://codereview.chromium.org/200603002

BUG=302005

Review URL: https://codereview.chromium.org/197883013

git-svn-id: svn://svn.chromium.org/blink/trunk@169511 bbb929c8-8fbe-4397-9dbb-9b2b20218538