- 17 Aug, 2016 40 commits
-
-
jshin authored
Fix libfuzz builds on Mac. There's only one change in this roll. https://chromium.googlesource.com/chromium/deps/icu/+/2341038b BUG=636127 TEST=Libfuzzer Upload Mac ASan builds TBR=mmoroz@chromium.org Review-Url: https://codereview.chromium.org/2254543005 Cr-Commit-Position: refs/heads/master@{#412598}
-
flandy authored
The bezier icon should use an image asset like our other icons. Review-Url: https://codereview.chromium.org/2237663002 Cr-Commit-Position: refs/heads/master@{#412597}
-
pasko authored
This prevents exposing the server outside of the local machine (given a sane firewall). BUG=none Review-Url: https://codereview.chromium.org/2257523002 Cr-Commit-Position: refs/heads/master@{#412596}
-
vabr authored
This helps when printing FormDigest objects to logs during debugging. autofill::PasswordForm has a similar operator but implemented through JSON stringification for better flexibility. FormDigest does not need this, because it only has 3 members and is unlikely to grow. R=dvadym@chromium.org BUG=621355 Review-Url: https://codereview.chromium.org/2252053002 Cr-Commit-Position: refs/heads/master@{#412595}
-
oysteine authored
This adds functionality to insert filtering predicates in-between calls to add trace events, and the actual trace buffer. These predicates can be used to implement custom logic for whether or not events should actually be added or not, in addition to the normal category checks. Events can also be modified, if need be. The initial added usecase for this is to be able to add an additional level of filtering to reduce sizes of traces to the bare minimum, for use with perf waterfall TBMv2 metrics, and Slow Reports. Review-Url: https://codereview.chromium.org/1923533004 Cr-Commit-Position: refs/heads/master@{#412594}
-
eugenebut authored
NSObject.description is not nullable and may return nil. In which case gesture recognizer should not be matched. BUG=None Review-Url: https://codereview.chromium.org/2252833003 Cr-Commit-Position: refs/heads/master@{#412593}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/8d3f92a92be7..e4f246111380 $ git log 8d3f92a92..e4f246111 --date=short --no-merges --format='%ad %ae %s' 2016-08-17 bsalomon Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper() 2016-08-17 mtklein SkLiteDL: inline empty() 2016-08-17 jvanverth Add alternative spot shadow to Android shadow sample 2016-08-17 csmartdalton Implement difference clip rects with window rectangles CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=robertphillips@google.com Review-Url: https://codereview.chromium.org/2254903002 Cr-Commit-Position: refs/heads/master@{#412592}
-
estevenson authored
Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change. BUG=638252 Review-Url: https://codereview.chromium.org/2256553002 Cr-Commit-Position: refs/heads/master@{#412591}
-
tommycli authored
BUG=635861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2249933002 Cr-Commit-Position: refs/heads/master@{#412590}
-
qyearsley authored
Currently, w3c-test-autoroller: 1. Uploads a CL. 2. Triggers try jobs on Blink try bots. 3. Waits for try job results (which are failing). 4. Modifies TestExpectations and commits. 5. Uploads another patch. 6. Calls `git cl land -f --auth-refresh-token-json ...`. I think that when landing CLs, w3c-test-autoroller commits should go through the CQ, and if the CQ fails even after updating TestExpectations etc., then the CL should be closed. BUG=629275 Review-Url: https://codereview.chromium.org/2248913003 Cr-Commit-Position: refs/heads/master@{#412589}
-
qyearsley authored
The main advantage of this is that it makes the main method shorter and more abstract, and provides a convenient place to put a comment about why we're copying over files from outside the imported repo into the new imported directory before committing. Review-Url: https://codereview.chromium.org/2247923002 Cr-Commit-Position: refs/heads/master@{#412588}
-
guidou authored
TBR=foolip@chromium.org BUG=638621 Review-Url: https://codereview.chromium.org/2253953002 Cr-Commit-Position: refs/heads/master@{#412587}
-
pkotwicz authored
This CL makes WebApkInstaller take the Murmur2 hash of the bitmap at the icon URL prior to any transformations being applied to the bitmap (such as encoding/decoding the bitmap). The icon hash is used to determine whether the icon that the user sees matches the icon of a WebAPK that the server generated for another user. The icon could be dynamically generated and: - use the same icon URL for all users - be visually different for each user If the hashes match the server can vend the WebAPK that it previously generated to other users. Vending previously generated WebAPKs is faster than creating a new WebAPK for each "create WebAPK" request. BUG=624059 TEST=WebApkIconHasherTest Review-Url: https://codereview.chromium.org/2231843003 Cr-Commit-Position: refs/heads/master@{#412586}
-
cmumford authored
Indexed DB was passing net::URLRequestContext as it was needed for Blob writing in WriteBlobToFileOnIOThread. This switches to passing the *Getter which facilitates the move to Mojo where initialization is done on the Indexed DB thread. BUG=627484 Review-Url: https://codereview.chromium.org/2172863002 Cr-Commit-Position: refs/heads/master@{#412585}
-
mattreynolds authored
Removes an assert that was triggered when scanner_ was nil, which is expected whenever the scanner is in the "stopped" state. Instead, we explicitly check if scanner_ is nil and return an empty metadata list. BUG=630769 Review-Url: https://codereview.chromium.org/2248983003 Cr-Commit-Position: refs/heads/master@{#412584}
-
schenney authored
The test result looks worse than it used to, but not bad enough to fix. It's a super marginally situation, so not too important. There may still be failures on Mac Debug after this. The test previously showed Release/Debug differences. The expectation may need to be re-added with narrowed conditions. R=fmalita@chromium.org BUG=390488,636475 Review-Url: https://codereview.chromium.org/2254833002 Cr-Commit-Position: refs/heads/master@{#412583}
-
reillyg authored
This wrapping was added in r355704 because at the time mojo::Callbacks did not like being freed on arbitrary threads, which would happen if they were passed to //device/usb APIs. This is no longer an issue so the wrapping can be removed. BUG=None Review-Url: https://codereview.chromium.org/2236683002 Cr-Commit-Position: refs/heads/master@{#412582}
-
sadrul authored
BUG=637923 TBR=sky@ for trivial services/ui/gpu update. Review-Url: https://codereview.chromium.org/2248973005 Cr-Commit-Position: refs/heads/master@{#412581}
-
erikchen authored
Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2249923003/ ) Reason for revert: Has correctness issues on 10.10: https://bugs.chromium.org/p/chromium/issues/detail?id=638526 Original issue's description: > Reland of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2238113002/ ) > > Reason for revert: > Landing again, since main performance regressions have been dealt with. > > https://bugs.chromium.org/p/chromium/issues/detail?id=636884 > > Original issue's description: > > Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2234513002/ ) > > > > Reason for revert: > > Causes performance regressions when there are a lot of filters. Probably needs better IOSurface caching. > > > > https://bugs.chromium.org/p/chromium/issues/detail?id=636884 > > > > Original issue's description: > > > Enable promotion of RenderPassDrawQuads to CALayers. > > > > > > BUG=581526 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > > > Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c > > > Cr-Commit-Position: refs/heads/master@{#411055} > > > > TBR=ccameron@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=581526 > > > > Committed: https://crrev.com/314269eae868551bb560428fce916863e4d60cb4 > > Cr-Commit-Position: refs/heads/master@{#411505} > > TBR=ccameron@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=581526 > > Committed: https://crrev.com/777aa9fb4a33a0ae71ed5363225d52ed807a5ff0 > Cr-Commit-Position: refs/heads/master@{#412144} TBR=ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581526 Review-Url: https://codereview.chromium.org/2255833002 Cr-Commit-Position: refs/heads/master@{#412580}
-
chongz authored
|content::| to "ui/events/blink" This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to "ui/events/blink", so they can be accessed by |InputHandlerProxy|. Adds dependency: 1. content/common : ui/events/blink 2. content/renderer/mus : ui/events/blink Concerns: 1. Moving |WebInputEventTraits| seems redundant since we only need |WebInputEventTraits::Delete/Clone|. 2. "ui/events/blink" seems to be static linked, so it will cause each file to grow. After discussion with dtapuska@ and tdresser@ it doesn't really matter whether we move it entirely or only part of it. So the easier solution is to move it entirely for now, and handle it later if it's actually causing problems. BUG=637393 Review-Url: https://codereview.chromium.org/2240983003 Cr-Commit-Position: refs/heads/master@{#412579}
-
khmel authored
Hides ToS when Arc is managed, disable checkbox for Location Service and B&R in case they are managed. Apply managed settings on each Arc start. TEST=Manually on device. BUG=b/30469058 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2235293002 Cr-Commit-Position: refs/heads/master@{#412578}
-
oysteine authored
Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs R=simonhatch@chromium.org BUG=637129 Review-Url: https://codereview.chromium.org/2247033005 Cr-Commit-Position: refs/heads/master@{#412577}
-
svaldez authored
https://boringssl.googlesource.com/boringssl/+log/96e1a25943ba98e644d71d23dd30815704da77a7..405da489002ca1fe5ee3f1c390b207d468f4a8e7 BUG=none Review-Url: https://codereview.chromium.org/2253103002 Cr-Commit-Position: refs/heads/master@{#412576}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/d24ee1419f17..8d3f92a92be7 $ git log d24ee1419..8d3f92a92 --date=short --no-merges --format='%ad %ae %s' 2016-08-17 csmartdalton Make GrReducedClip's gen ID only apply to the element list 2016-08-17 robertphillips Kick the can down the road a bit w.r.t. fuzzer complaint 2016-08-17 bsalomon Fix tile bitmap code in SkGpuDevice to compute correct local coords. 2016-08-17 bsalomon Minor cleanup of GP classes in GrOvalRenderer 2016-08-17 msarett Modify SkPngCodec to recognize 565 images from the sBIT chunk BUG=635787 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=robertphillips@google.com Review-Url: https://codereview.chromium.org/2251113002 Cr-Commit-Position: refs/heads/master@{#412575}
-
zqzhang authored
There's a crash in AutoplayUmaHelper::onVisibilityChangedForVideoMutedPlayMethod(). It might be possible that the callback is called after the observer is released. This CL adds additional nullcheck to avoid the crash. This CL also fixes a possible memory leak by changing wrapPersistent to wrapWeakPersistent. BUG=638595 Review-Url: https://codereview.chromium.org/2249223003 Cr-Commit-Position: refs/heads/master@{#412574}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c31b348..a33f1674 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2255803002 Cr-Commit-Position: refs/heads/master@{#412573}
-
blundell authored
//components/test_runner signals that a test is finished if it receives a notificationDone signal from Javascript at a time when (a) it is waiting for such a signal, (b) it does not think it is in the midst of a load, and (c) it has no work in its queue. However, the definition of (b) is flawed for browser-side navigation. The current definition for being in the midst of a load is the time between WebFrameClient::didStartProvisionalLoad() being called and WebFrameClient::didStopLoading() being called. However, for browser-side navigations there is a period of time when navigation is ongoing but the renderer has not yet received the didStartProvisionalLoad() callback. If //components/test_runner gets a notificationDone signal during this period, it can erroneously think that the test is finished. This CL fixes the problem by having WebFrameTestProxy implement WebFrameClient::didStartLoading(), teaching //components/test_runner to be aware of the time period where a navigation is occurring, and using that as input to decide whether a test is finished when it receives a notificationDone signal. Review-Url: https://codereview.chromium.org/2147633003 Cr-Commit-Position: refs/heads/master@{#412572}
-
xidachen authored
Currently this layout test canvas/philip/tests/2d.text.draw.text.metrics.html gets different results on linux platform comparing to all the other platforms. But when I open the test file directly on chrome, the result is exactly the same as the results on the other platform. The reason is that the content shell test runner has some flags enabled. This CL rewrite the test in a more reasonable way. BUG=277215 Review-Url: https://codereview.chromium.org/2232243002 Cr-Commit-Position: refs/heads/master@{#412571}
-
jmadill authored
An ANGLE revert requires this test to be expected to fail. BUG=638313 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2249823004 Cr-Commit-Position: refs/heads/master@{#412570}
-
rnk authored
Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ ) Reason for revert: Invalid cast breaks CFI build, which is shipping on Linux soon Original issue's description: > cc: Move data to LayerTree from LayerTreeHost. > > Move bulk of the tree state from LayerTreeHost to LayerTree. The > LayerTree mirrors LayerTreeImpl in terms of what it stores and is used > to push the corresponding properties to LayerTreeImpl during commit. > > BUG=628683 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b > Cr-Commit-Position: refs/heads/master@{#412413} TBR=enne@chromium.org,loyso@chromium.org,vollick@chromium.org,piman@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628683 Review-Url: https://codereview.chromium.org/2253143002 Cr-Commit-Position: refs/heads/master@{#412569}
-
asvitkine authored
This was there so that crash client id could be cleared. However, this was being called out of MetricsService::Stop(), so it needed a special provision to not clear it when shutting down, for example. This change instead removes all of that plumbing and makes the id clearing happen in the same place we clear the UMA client id, when the user actually opts-out (as opposed to just metrics service stopping). Unifies the prefs manipulation that happens when the user changes the setting into a helper function. As a follow up change after this lands, we should also make that function be called on iOS. BUG=635669 TBR=sgurun@chromium.org,nyquist@chromium.org,noyau@chromium.org Review-Url: https://codereview.chromium.org/2248793002 Cr-Commit-Position: refs/heads/master@{#412568}
-
Guido Urdaneta authored
TBR=lushnikov@chromium.org BUG=638618 Review URL: https://codereview.chromium.org/2253133002 . Cr-Commit-Position: refs/heads/master@{#412567}
-
oshima authored
Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG=635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Review-Url: https://codereview.chromium.org/2249953002 Cr-Commit-Position: refs/heads/master@{#412566}
-
boliu authored
Revert of Android: Make the spare renderer accessible to all Chrome tabs. (patchset #7 id:120001 of https://codereview.chromium.org/2199393002/ ) Reason for revert: New test WarmupManagerTest#testCreateAndTakeSpareRenderer failing on 3 different bots: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35784 https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester/builds/5165 https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5527 Original issue's description: > Android: Make the spare renderer accessible to all Chrome tabs. > > In Custom Tabs, an external application can "warm up" Chrome. This > creates and initializes a spare renderer, and has been found to be a > significant optimization for loading performance. > > This patch moves the spare renderer logic out of Custom Tabs, and makes > it accessible and useful for regular navigations in Chrome. Note that > this patch doesn't add new call sites for the spare renderer creation. > > BUG=633964 > > Committed: https://crrev.com/f7ce563033df1df90b314e4f727596c93c2b3d6d > Cr-Commit-Position: refs/heads/master@{#412510} TBR=yusufo@chromium.org,mariakhomenko@chromium.org,lizeb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633964 Review-Url: https://codereview.chromium.org/2254863002 Cr-Commit-Position: refs/heads/master@{#412565}
-
mikecase authored
BUG=522043 Review-Url: https://codereview.chromium.org/2243353002 Cr-Commit-Position: refs/heads/master@{#412564}
-
ddorwin authored
BUG=249976 Review-Url: https://codereview.chromium.org/1920433003 Cr-Commit-Position: refs/heads/master@{#412563}
-
rouslan authored
Currencies such as JPY do not have fractions by default. If the website is using web payments with an amount like "500", then UI should show only "500", without any decimals. BUG=638480 Review-Url: https://codereview.chromium.org/2246923006 Cr-Commit-Position: refs/heads/master@{#412562}
-
schenney authored
Remove expectations for compositing/overflow/reflected-overlay-scrollbars-should-appear-without-compositing.html The test seems to be passing consistently. TBR=vollick@chromium.org BUG=396775,636475 Review-Url: https://codereview.chromium.org/2253893002 Cr-Commit-Position: refs/heads/master@{#412561}
-
xhwang authored
This reverts commit 7ce3db95 and relands 22f8a43c without changes. I believe the failure would be fixed after the bots are clobbered. Original Description: This class handles output protection query and request in the browser process on all platforms. On ChromeOS, it delegates the operations on the hardware displays to OutputProtectionDelegate. On other platforms, it does not check hardware displays. On all platforms, it checks whether there is any network link and adds it to the existing link mask. This class will also be used to implement mojo OutputProtection service on all platforms. This CL also updated PPAPI cdm adapter and PPAPI code to enable output protection calls on all platforms. A unit test is added via external clear key tests. TBR=ddorwin@chromium.org, jrummell@chromium.org, oshima@chromium.org, bbudge@chromium.org BUG=592122, 589618, 623214 TEST=Added new tests. Review-Url: https://codereview.chromium.org/2094903005 Cr-Commit-Position: refs/heads/master@{#412560}
-
khmel authored
Add policy declaration for using of Location Service BUG= b/30469058 TEST=policy and browser tests extended. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation patch from issue 2225933002 at patchset 20001 (http://crrev.com/2225933002#ps20001) Review-Url: https://codereview.chromium.org/2243513002 Cr-Commit-Position: refs/heads/master@{#412559}
-