- 04 Sep, 2018 34 commits
-
-
Gemene Narcis authored
This CL renames class with name BlacklistedDuplicatesCleaner to RedundantCredentialsCleaner. This is to reflect expanding this class to handle also non-blacklisted credentials, which will be done in coming CLs Bug: 862930 Change-Id: Ifba11a521775cbcd33c183aa685ae84a591d8457 Reviewed-on: https://chromium-review.googlesource.com/1202664 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588473}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 27a0ea6a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24051 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-cascade ericwilligers@chromium.org: external/wpt/css/motion kojii@chromium.org: external/wpt/css/css-writing-modes mkwst@chromium.org: external/wpt/cookies rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I68aa6d963b923126c0c892a7de059fc7afda43a9 Reviewed-on: https://chromium-review.googlesource.com/1203318 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588472}
-
Chih-Yu Huang authored
Originally when we check the keyframe behavior, we track the number difference by variable |num_keyframes_requested_|. The variable is incremented when we ask encoder to encode a keyframe, and decremented when we got the encoded keyframe buffer. However, these two flows are not synchronized. That is, when checking the behavior at the middle of the stream, we only receive half of frames but already encode more than half of frames. The mismatch causes the test failed. In this CL, we check each requested keyframe is received during the loop, and refactor the implementation for readability. BUG=835716 TEST=Run VEA unittest on nyan_big and eve device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52f53523b741df12fbac9fd00a02bbbd68547267 Reviewed-on: https://chromium-review.googlesource.com/1168950 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588471}
-
Guido Urdaneta authored
This method reports if a frame currently has active capture sessions. This is intended to support Autoplay. Bug: 880075 Change-Id: I3d5e0669d38cf145e34879e969bf983251192bea Reviewed-on: https://chromium-review.googlesource.com/1202208Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#588470}
-
Adam Rice authored
The websockets/cookies/006.html?wss test didn't work on any modern browser because you can't set a secure cookie from JavaScript on an insecure page. See https://wpt.fyi/results/websockets/cookies/006.html%3Fwss. Change the expectations to never see the cookie set. Add a new test, 006.https.html, which runs over https so that the cookie can be set. Unfortunately, due to mixed content checks, this can't test the insecure "ws:" scheme, so it still doesn't cover all the cases the original test intended to. BUG=803200 Change-Id: I7e280ebc781c693529588a68cd5eef5332b730fa Reviewed-on: https://chromium-review.googlesource.com/1203495Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#588469}
-
Christopher Cameron authored
To make sure that we don't confuse the mojo interface views_bridge_mac::mojom::BridgeNativeWidget and the concrete implementation, views::BridgeNativeWidget (to eventually be moved to views_bridge_mac::BridgedNativeWidget), rename views::BridgeNativeWidget to views::BridgeNativeWidgetImpl. In NativeWidgetMac, make it clear when we are talking to the mojo interface (which works across processes) versus the local interface (which doesn't) by separating out NativeWidgetMac::bridge into NativeWidgetMac::bridge (for mojo) and NativeWidgetMac::bridge_impl (for local). Change-Id: I5cc54f76c1d35a50c97b311809833f729a69493d Reviewed-on: https://chromium-review.googlesource.com/1203312 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#588468}
-
David Jean authored
Also Added some missing eg tests. Bug: 879569 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99084b2fc3d32797bcb4e12135b1d950d9befa1d Reviewed-on: https://chromium-review.googlesource.com/1199363 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588467}
-
Maja Kabus authored
added Definition of a union type that can replace any of Trusted Types added. New functions GetString() and GetStringWithoutCheck() added in a util file to accept the generic Trusted Type as an argument. The change is required in situations where multiple Trusted Types could be matched as an argument of a function e.g. in change 1146563. Bug: 739170 Change-Id: Iea619108633dc80c8807b90da0df6f84a08585c8 Reviewed-on: https://chromium-review.googlesource.com/1196517 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#588466}
-
Benoit Lize authored
Bug: 877044 Change-Id: I193aec9eaf8e0f59413b4b0c58489aeac48b5ad2 Reviewed-on: https://chromium-review.googlesource.com/1202143 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#588465}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d0fb4a5..9680338c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie266df1cbdcb54802d751c059ed0b9ba29a3e0d6 Reviewed-on: https://chromium-review.googlesource.com/1203317Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588464}
-
Takashi Sakamoto authored
This reverts commit 1e471d39. Reason for revert: ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension is failling on Linux Chromium OS Asan Lsan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28834 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28835 [ RUN ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:273: Failure Expected equality of these values: "application/msword" Which is: 0x2de8e960 FindArcMimeTypeFromExtension("doc") Which is: 0x2eaa2520 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:276: Failure Expected equality of these values: "video/3gpp" Which is: 0x2de8e520 FindArcMimeTypeFromExtension("3gp") Which is: 0x2eaa3aa0 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:279: Failure Expected equality of these values: "audio/mpeg" Which is: 0x2de8eb60 FindArcMimeTypeFromExtension("mpga") Which is: 0x2eaa2d60 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) [ FAILED ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension (1 ms) [ RUN ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:273: Failure Expected equality of these values: "application/msword" Which is: 0x2de8e960 FindArcMimeTypeFromExtension("doc") Which is: 0x2eaa2520 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:276: Failure Expected equality of these values: "video/3gpp" Which is: 0x2de8e520 FindArcMimeTypeFromExtension("3gp") Which is: 0x2eaa3aa0 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:279: Failure Expected equality of these values: "audio/mpeg" Which is: 0x2de8eb60 FindArcMimeTypeFromExtension("mpga") Which is: 0x2eaa2d60 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) [ FAILED ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension (2 ms) [ RUN ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:273: Failure Expected equality of these values: "application/msword" Which is: 0x2de8e960 FindArcMimeTypeFromExtension("doc") Which is: 0x2eaa2520 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:276: Failure Expected equality of these values: "video/3gpp" Which is: 0x2de8e520 FindArcMimeTypeFromExtension("3gp") Which is: 0x2eaa3aa0 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:279: Failure Expected equality of these values: "audio/mpeg" Which is: 0x2de8eb60 FindArcMimeTypeFromExtension("mpga") Which is: 0x2eaa2d60 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) [ FAILED ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension (1 ms) [ RUN ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:273: Failure Expected equality of these values: "application/msword" Which is: 0x2de8e960 FindArcMimeTypeFromExtension("doc") Which is: 0x2eaa2520 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:276: Failure Expected equality of these values: "video/3gpp" Which is: 0x2de8e520 FindArcMimeTypeFromExtension("3gp") Which is: 0x2eaa3aa0 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) ../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc:279: Failure Expected equality of these values: "audio/mpeg" Which is: 0x2de8eb60 FindArcMimeTypeFromExtension("mpga") Which is: 0x2eaa2d60 Stack trace: #0 0x000008bf16ff (/b/s/w/ir/out/Release/unit_tests+0x8bf16fe) #1 0x000008c17af0 (/b/s/w/ir/out/Release/unit_tests+0x8c17aef) #2 0x000008c166ca (/b/s/w/ir/out/Release/unit_tests+0x8c166c9) [ FAILED ] ArcDocumentsProviderUtilTest.FindArcMimeTypeFromExtension (2 ms) Original change's description: > Check file mime type provided by ARC before appending a file extension. > > Some files are returned with an unexpected mime type (eg. 3gp and video/mp4) causing an extra > extension to be appended when it is not in the list of allowed extensions returned by > net::GetExtensionsForMimeType. In those cases, do an extra lookup in the Android mapping by > extension, and don't append the extension if a valid MIME type is returned and the MIME > category type (ie. MIME type without the subtype) matches. > > Bug: 844252 > Test: Tested on kevin. > Change-Id: I9899d74d6046d6c392adc4f828af09296c73f1c6 > Reviewed-on: https://chromium-review.googlesource.com/1189690 > Commit-Queue: Alex Lau <alexlau@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Shuhei Takahashi <nya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588444} TBR=hidehiko@chromium.org,nya@chromium.org,alexlau@chromium.org Change-Id: I6b77806153d942e9f996624a2d782448371c04bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844252 Reviewed-on: https://chromium-review.googlesource.com/1203353Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#588463}
-
Alexander Yashkin authored
This was kept around to ensure the old and the new conversions produced the same output. The fuzzer hasn't found anything, so it should be safe to remove the old code at this point. Change-Id: I4fcf5161922fce3a160fefffed9186530eb70691 Reviewed-on: https://chromium-review.googlesource.com/1198962 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588462}
-
Jan Krcal authored
This CL cleans up BUILD.gn for android to make clear no-one here is using the nano protobuf. The only remaining user is //third_party/cacheinvalidation/BUILD.gn (to be removed soon). Bug: 782237 Change-Id: Ic6e09a8eeb192971249666f1b34cd3fc0d7ee0d1 Reviewed-on: https://chromium-review.googlesource.com/1202182Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#588461}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a2428c5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24050 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Idb811aa1837483a4bb4d840264544980bef42391 Reviewed-on: https://chromium-review.googlesource.com/1203314 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Joel Hockey authored
Crostini should still work for incognito to do things such as save files from browser into Linux files. By default any keyed service such as CrostiniRestarterService will not be created for an incognito profile. Bug: 878230 Change-Id: I066f2d810351eb682e9637e104daac2ddb8fe23c Reviewed-on: https://chromium-review.googlesource.com/1201649 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#588459}
-
Giovanni Ortuño Urquidi authored
Bluetooth System is the High level interface targeted towards UI level components like Ash and chrome://settings that: _ Show the BT Radio state and allow users to change it. - Show a list of nearby, connected and paired BT Devices. - Start and stop BT scans. - Connect to and pair with BT devices. Bug: 870192 Change-Id: Ifb6afaffc2d05e0718dcda70c0a0a23cffb68c1e Reviewed-on: https://chromium-review.googlesource.com/1161716 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
Originally, we need to add "--disable_flush" argument when running the VEA unittest if the encoder does not support flush. This CL added a method IsFlushSupported() to check if the encoder support flush. BUG=820313 TEST=Run vea unittest at eve and nyan_big without "--disable_flush" argument Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id6a59546b0a13df15ca4ff2825eb70c848eaf704 Reviewed-on: https://chromium-review.googlesource.com/1170671Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2331bcfd..7d0fb4a5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I04f78d04fc0ecc82cbb9172ec4d193e48ce38f5e Reviewed-on: https://chromium-review.googlesource.com/1203315Reviewed-by:
-
Philipp Hancke authored
BUG=879021 Change-Id: Ie500c1e60fd30f637e28dc1616cca10a1ee93d1f Reviewed-on: https://chromium-review.googlesource.com/1203210 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24e58341fbcd..cff3fd834ca8 git log 24e58341fbcd..cff3fd834ca8 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 fda46aa50ecb..3e29cf318258 (4 commits) Created with: gclient setdep -r src/third_party/skia@cff3fd834ca8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I3e5387472858bf4461762c73c55100bfac18b2f9 Reviewed-on: https://chromium-review.googlesource.com/1203313Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588454}
-
Leo Zhang authored
Expose kImeServiceConnectable to IME private clients, which is used for checking whether it should load IME Mojo Service bundles. Bug: 837156 Change-Id: Id2889577616823cef99e3a3cfea16b5e33a9147c Reviewed-on: https://chromium-review.googlesource.com/1203515Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#588453}
-
Dominick Ng authored
This CL stops TabSpecificContentSettings::OnContentSettingChanged from posting a message to the renderer unless the changed content settings type is actually consumed by the renderer. This should dramatically cut down on the number of messages posted - e.g. the site engagement content setting is updated many times over the lifetime of a page, whilst the renderer-relevant content settings are often not updated at all. This CL also ensures updated content settings rules are posted to the renderer at navigation time. This ensures that settings for origin A that are changed while a tab is currently at origin B are sent to the renderer when it navigates to origin A. Some tests inadvertently relied on navigation posting a site/media engagement content setting update to pick up a change to the JAVASCRIPT content type; without this fix, these tests would have broken in the future if site engagement or media engagement stopped updating on navigation. BUG=875937 Change-Id: I0ab2279a1296d18b51276ecfa52c35503745a1e9 Reviewed-on: https://chromium-review.googlesource.com/1194555Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#588452}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8dd4fde..2331bcfd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If3eb828bb78cead23fb1a19ad083c6230db8eee6 Reviewed-on: https://chromium-review.googlesource.com/1203415Reviewed-by:
-
Trent Apted authored
Currently `js_unit_tests("foo")` declares a single target with both closure type-checking and unittest html generation as dependencies. This CL has it generate two targets instead. One for html generation (foo), and another for typechecking (foo_type_check). Bug: 879066 Change-Id: Ic8b411d89d2dd6ec91c40e102d42288c66fc8157 Reviewed-on: https://chromium-review.googlesource.com/1198665Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#588450}
-
Kunihiko Sakamoto authored
Before this patch, StructuredHeaderParser was used to extract the v= parameter of application/signed-exchange content type. However, the content-type header field has slightly different syntax [1]. For example, parameter names are not restricted to lower case but are case-insensitive. This patch replaces SignedExchangeSignatureHeaderField::GetVersionParamFromContentType() with signed_exchange_utils::GetSignedExchangeVersion() function, which follows the "Identifying signed exchanges" algorithm [2] and uses HttpUtil::NameValuePairsIterator to parse parameters. [1] https://tools.ietf.org/html/rfc7231#section-3.1.1.1 [2] https://wicg.github.io/webpackage/loading.html#signed-exchange-version Bug: 803774 Change-Id: Ibc00d20837ed2e1f503b3734cbf015468f4bf756 Reviewed-on: https://chromium-review.googlesource.com/1201635 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#588449}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ic892c7b9d9bf99a5330cfbb9a13d45cffce87992 Reviewed-on: https://chromium-review.googlesource.com/1203434Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588448}
-
Noel Gordon authored
Make a local helper to open FilesApp on Drive. Document the test steps to explain the intent of the test. Test: browser_tests --gtest_filter="*addRemoveFolderShortcuts" Bug: 880127 Change-Id: I4c31539bf518e59376602308208ba0bb7a854c70 Reviewed-on: https://chromium-review.googlesource.com/1201654Reviewed-by:
-
Noel Gordon authored
Move directory tree expansion / icon constants into their helpers (the only place they are used). Minor comment clean-ups. Test: browser_tests --gtest_filter="FolderShortcuts/FilesApp*" Bug: 880127 Change-Id: I466ab7f59042801c170192b2ae5a5b132d3e26bf Reviewed-on: https://chromium-review.googlesource.com/1201655Reviewed-by:
-
Noel Gordon authored
Use SetupAndWaitUntilReady(). Add comments describing each test step. Test: browser_tests --gtest_filter="*traverseFolderShortcuts" Bug: 880127 Change-Id: Icd425052e9acc9f2086a6c0b97ebca6b643ef473 Reviewed-on: https://chromium-review.googlesource.com/1201653Reviewed-by:
-
Alex Lau authored
Some files are returned with an unexpected mime type (eg. 3gp and video/mp4) causing an extra extension to be appended when it is not in the list of allowed extensions returned by net::GetExtensionsForMimeType. In those cases, do an extra lookup in the Android mapping by extension, and don't append the extension if a valid MIME type is returned and the MIME category type (ie. MIME type without the subtype) matches. Bug: 844252 Test: Tested on kevin. Change-Id: I9899d74d6046d6c392adc4f828af09296c73f1c6 Reviewed-on: https://chromium-review.googlesource.com/1189690 Commit-Queue: Alex Lau <alexlau@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#588444}
-
Adam Rice authored
Add support for streaming encoding and decoding via the TextEncoderStream and TextDecoderStream. See design doc https://docs.google.com/document/d/17goe4jacAYjHHtprfVPSrqDvF_J58u2qirz0HQ58sQ4/edit Modify transform_stream.cc so it doesn't claim every exception happened during construction Remove failing wpt expectations. Add a new test for TextDecoderStream constructor and property behaviour. BUG=845427 Change-Id: I538022680ef8e90f5eb2b11fd1775e902e7f25fd Reviewed-on: https://chromium-review.googlesource.com/1174073Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Chris Hall authored
Bug: 879943 Change-Id: Ib1d66fc21936ae508cd3ea210be21a6793f30125 Reviewed-on: https://chromium-review.googlesource.com/1203491Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588442}
-
Daniel Bratell authored
In certain jumbo configurations, the two constants names kForcedInvocationDeadline could end up in the same translation unit and then clash. This patch changes the names to kTextFinderTestTimeout and kIdleSpellcheckTestTimeout. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I76e030b98bead46fa0aff7f3e0ce1f264d754ef9 Reviewed-on: https://chromium-review.googlesource.com/1202064 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit e6df6345. Reason for revert: Suspect WebKit Linux Trusty MSAN failures: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9778 crash log for content_shell (pid 19555): STDOUT: <empty> STDERR: [1:16:0903/135605.516164:ERROR:adm_helpers.cc(73)] Failed to query stereo recording. STDERR: CONSOLE WARNING: line 371: The Web Audio autoplay policy will be re-enabled in Chrome 70 (October 2018). Please check that your website is compatible with it. https://goo.gl/7K7WLu STDERR: ==19555==WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x119c0a99 in network::P2PSocketUdp::HandleReadResult(int) ./../../services/network/p2p/socket_udp.cc:231:9 STDERR: #1 0x119bf30b in network::P2PSocketUdp::OnRecv(int) ./../../services/network/p2p/socket_udp.cc:202:3 STDERR: #2 0xc8cd202 in Run ./../../base/callback.h:99:12 STDERR: #3 0xc8cd202 in DoReadCallback ./../../net/socket/udp_socket_posix.cc:690:0 STDERR: #4 0xc8cd202 in net::UDPSocketPosix::DidCompleteRead() ./../../net/socket/udp_socket_posix.cc:711:0 STDERR: #5 0xc8cc98d in net::UDPSocketPosix::ReadWatcher::OnFileCanReadWithoutBlocking(int) ./../../net/socket/udp_socket_posix.cc:676:14 STDERR: #6 0xb3aa2ec4 in base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) ./../../base/message_loop/message_pump_libevent.cc:0:13 STDERR: #7 0xb3c2bd6 in event_process_active ./../../base/third_party/libevent/event.c:381:4 STDERR: #8 0xb3c2bd6 in event_base_loop ./../../base/third_party/libevent/event.c:521:0 STDERR: #9 0xb3aaf3e in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:214:5 STDERR: #10 0xb12a9ff in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 STDERR: #11 0x8655f3e in content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) ./../../content/browser/browser_process_sub_thread.cc:175:11 STDERR: #12 0xb26ea58 in base::Thread::ThreadMain() ./../../base/threading/thread.cc:357:3 STDERR: #13 0xb39a887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:76:13 STDERR: #14 0x7ffa170eb183 in start_thread /build/eglibc-ripdx6/eglibc-2.19/nptl/pthread_create.c:312:0 STDERR: #15 0x7ffa0fa3703c in clone /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 STDERR: STDERR: Uninitialized value was created by a heap allocation STDERR: #0 0x1ab9a79 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:46:35 STDERR: #1 0x119a51de in network::P2PSocket::Create(network::P2PSocket::Delegate*, mojo::InterfacePtr<network::mojom::P2PSocketClient>, mojo::InterfaceRequest<network::mojom::P2PSocket>, network::P2PSocketType, net::NetLog*, network::ProxyResolvingClientSocketFactory*, network::P2PMessageThrottler*) ./../../services/network/p2p/socket.cc:173:14 STDERR: #2 0x1198d68c in network::P2PSocketManager::CreateSocket(network::P2PSocketType, net::IPEndPoint const&, network::P2PPortRange const&, network::P2PHostAndIPEndPoint const&, mojo::InterfacePtr<network::mojom::P2PSocketClient>, mojo::InterfaceRequest<network::mojom::P2PSocket>) ./../../services/network/p2p/socket_manager.cc:294:7 STDERR: #3 0x1e6127b in network::mojom::P2PSocketManagerStubDispatch::Accept(network::mojom::P2PSocketManager*, mojo::Message*) ./gen/services/network/public/mojom/p2p.mojom.cc:1105:13 STDERR: #4 0x11991146 in network::mojom::P2PSocketManagerStub<mojo::RawPtrImplRefTraits<network::mojom::P2PSocketManager> >::Accept(mojo::Message*) ./gen/services/network/public/mojom/p2p.mojom.h:446:12 STDERR: #5 0xb407929 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32 STDERR: #6 0xb4056da in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 STDERR: #7 0xb421df5 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:869:42 STDERR: #8 0xb41f60d in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:590:38 STDERR: #9 0xb4056da in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 STDERR: #10 0xb3fdbc2 in mojo::Connector::ReadSingleMessage(unsigned int*) ./../../mojo/public/cpp/bindings/lib/connector.cc:457:51 STDERR: #11 0xb400300 in mojo::Connector::ReadAllAvailableMessages() ./../../mojo/public/cpp/bindings/lib/connector.cc:486:10 STDERR: #12 0xb3e106b in Run ./../../base/callback.h:129:12 STDERR: #13 0xb3e106b in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ./../../mojo/public/cpp/system/simple_watcher.cc:273:0 STDERR: #14 0xb3e1a6c in mojo::SimpleWatcher::Context::Notify(unsigned int, MojoHandleSignalsState, unsigned int) ./../../mojo/public/cpp/system/simple_watcher.cc:105:22 STDERR: #15 0xb3de578 in mojo::SimpleWatcher::Context::CallNotify(MojoTrapEvent const*) ./../../mojo/public/cpp/system/simple_watcher.cc:55:14 STDERR: #16 0x46bbfd7 in mojo::core::WatcherDispatcher::InvokeWatchCallback(unsigned long, unsigned int, mojo::core::HandleSignalsState const&, unsigned int) ./../../mojo/core/watcher_dispatcher.cc:90:3 STDERR: #17 0x46b9935 in mojo::core::Watch::InvokeCallback(unsigned int, mojo::core::HandleSignalsState const&, unsigned int) ./../../mojo/core/watch.cc:78:13 STDERR: #18 0x46a4715 in mojo::core::RequestContext::~RequestContext() ./../../mojo/core/request_context.cc:72:20 STDERR: #19 0x466c618 in mojo::core::NodeChannel::OnChannelMessage(void const*, unsigned long, std::__1::vector<mojo::PlatformHandle, std::__1::allocator<mojo::PlatformHandle> >) ./../../mojo/core/node_channel.cc:695:1 STDERR: #20 0x461c6a4 in mojo::core::Channel::OnReadComplete(unsigned long, unsigned long*) ./../../mojo/core/channel.cc:714:18 STDERR: STDERR: SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/content_shell+0x119c0a99) STDERR: Exiting STDERR: [19588:19588:0903/135606.482234:WARNING:x11_util.cc(1391)] X error received: serial 170, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown) Original change's description: > Cleanup lifetime handling in P2P sockets. > > Several fixes for P2P sockets: > 1. P2PSocketTcpBase no longer posts tasks with base::Unretained(). > 2. Previously P2P sockets were destroyed only in response to Mojo > interfaces errors. They were not destroyed on other error. Fixed > it now. > 3. Simplified TCP server socket protocol. Now the accepted socket is > passed directly in IncomingTcpConnection. > 4. Updated unittests to verify that P2P sockets are destroyed in > response to errors. > 5. Other minor cleanups, particularly moved packet dump logic to > SocketManager and removed some unittests that are not relevant > after migration to mojo. > > Bug: 877515, 877514 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc > Reviewed-on: https://chromium-review.googlesource.com/1189083 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588430} TBR=nasko@chromium.org,jam@chromium.org,mmenke@chromium.org,sergeyu@chromium.org Change-Id: I33bfb1c8127a945df37fd8bf9efda681a739095e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877515, 877514 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1203492Reviewed-by:
-
- 03 Sep, 2018 6 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e0a58f83..f8dd4fde Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I66c0b9f31fd5e356f5574310b85b638798e90c8d Reviewed-on: https://chromium-review.googlesource.com/1203310Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a792193e17c4..3e29cf318258 git log a792193e17c4..3e29cf318258 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 jmadill@chromium.org Vulkan: Fix redefining TexStorage after TexImage. Created with: gclient setdep -r src/third_party/angle@3e29cf318258 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I2481572a106a308c11f572da034e5d1b0b9f924e Reviewed-on: https://chromium-review.googlesource.com/1203391Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588438}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2c55d8f5eeb0..24e58341fbcd git log 2c55d8f5eeb0..24e58341fbcd --date=short --no-merges --format='%ad %ae %s' 2018-09-03 reed@google.com check if stream failed Created with: gclient setdep -r src/third_party/skia@24e58341fbcd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I0bcb6272306c9ba2f2e2e4a270a4a298083c382c Reviewed-on: https://chromium-review.googlesource.com/1203390Reviewed-by:
-
Victor Costan authored
This CL only handles the files in //components. The files in //net were tackled in https://crrev.com/c/1188959. Parallel CLs will tackle other directories. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: If70c6373def9a2b46561af5c5ff7de55027d44fa Reviewed-on: https://chromium-review.googlesource.com/1200415Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588436}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0a598ade. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24020 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: tdresser@chromium.org: external/wpt/hr-time NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Iedc66e95b50ef2b475dd412e3c9dd225b4fd6c7a Reviewed-on: https://chromium-review.googlesource.com/1203311 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf67741140fd..2c55d8f5eeb0 git log bf67741140fd..2c55d8f5eeb0 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 9808d38c032a..fda46aa50ecb (7 commits) Created with: gclient setdep -r src/third_party/skia@2c55d8f5eeb0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I070f0d19e03082715971d2f236644e50655effb2 Reviewed-on: https://chromium-review.googlesource.com/1203190Reviewed-by:
-
