- 26 Dec, 2019 40 commits
-
-
Dana Fried authored
Fixes a rare use-after-free crash that could occur when an animating layout manager was already fading out a view and then that view was removed from its parent. Also adds a DCHECK and two regression tests to prevent the problem from occurring again (the DCHECK covers ALL LayoutManagerBase-derived layouts, not just AnimatingLayoutManager). Bug: 1037625 Change-Id: I87f4611a081bad7bb4fcffa30ab60a81502aeb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981338Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#727489}
-
Renato Silva authored
Changes the contrast of the separator under the password field on the login/lock screen. When the password field receives focus, the separator will be highlighted. When it loses focus, the highlight is removed. TBR=xiyuan@chromium.org Fixed: 908967 Change-Id: I8e953497586b96e8836745a8e086d3adb36edeca Bug: 908967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969340 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#727488}
-
Matthew Mourgos authored
ShelfWidgetTest::ShelfEdgeOverlappingWindowHitTestMouse is broken when enabling the hotseat. It is caused by the CL (https://crrev.com/c/1966428) which fails to set window insets for hotseat widget. To accelerate the process of enabling the hotseat flag, only run this test with hotseat disabled. TBR=xiyuan@chromium.org Bug: 1032702 Change-Id: I0a6ee824f23ea8ae948f4b6db2f0f9b27d828fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981113Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727487}
-
Matthew Mourgos authored
With this change, the padding between the edge of the screen and the status area widget no longer has anything to do with the hotseat state. This edge padding will now only ever have two possible values, one value in tablet mode and another value in clamshell mode. Bug: 1035716 Change-Id: I70f8ffe99ddf8e44482a3c9772f72dcf7adb9885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977025Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727486}
-
Takumi Fujimoto authored
Whenever a Cast session is started from the Cast dialog, we record how the dialog was opened, and the cast mode of the session. Bug: 1033591 Change-Id: I7c5122b706b71e66ab37aef4ae7066fb6d537b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965442 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727485}
-
Caleb Rouleau authored
https://chromium-review.googlesource.com/c/catapult/+/1961011 makes it so that if you do no specify a --webview-embedder-apk flag then we will use WebLayerShellSystemWebView.apk for a weblayer browser. It is also nicer not to explicit specify a flag for the reasons described in https://chromium.googlesource.com/chromium/src.git/+/c1324fa4ee0802370abbd624df217ef7b479180c R=johnchen@chromium.org Bug: 1028125 Change-Id: I01ac075f8ef92928ca9e15dbb665ea9ce8c95f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981068Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727484}
-
Dominic Mazzoni authored
For exporting tagged PDFs, we need the ability to take a snapshot of the accessibility tree for a RenderFrame, and to have the accessibility context stay alive long enough that IDs in the snapshot, and IDs sent to the printing system, are consistent. We already had code to do AX tree snapshotting, so this patch is just some refactoring to make it a class instead, and to have it return a public type rather than a content-specific type. This will be used in the follow-up change that implements support for tagged PDFs: http://crrev.com/c/1970742 Bug: 607777 Change-Id: I5163561c2cabcb2dd3579ce9d7a2de8ac96106d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970579 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727483}
-
Alice Wang authored
This CL removes the unused method isMobileIdentityConsistencyEnabled. Bug: 1035950 Change-Id: I39ce79e68a5e03ff281358673451a9bf4d8507c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980740Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727482}
-
Chris Harrelson authored
This reverts commit f3d96d04. The original commit was reverted because it caused flakiness in some browser tests (in particular, HostZoomMapBrowserTest.PageScaleIsOneChanged) The flakiness was caused by a real bug in the CL, which is fixed in the latest patchset. The bug was that the base::Optional pending_view_state_ was not being rest after being applied. See https://chromium-review.googlesource.com/c/chromium/src/+/1981806/1..3 for what has changed from the original CL. Bug: 1018632 Change-Id: I0f93094569c52deee02e6bf6296b2c181fb226bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981806Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727481}
-
Maggie Chen authored
DX12/Vulkan info collection is not needed for headless mode. Don't launch the unsandboxed GPU process, which is only for info collection. Bug: 1008904 Change-Id: Ibd0a58ab02675752e86282ef91e2b0b87935e256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981130Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727480}
-
Kevin Qin authored
Current OpenXR runtime only supports microsoft motion controller and Khronos simple controller. Add suggest interaction profile for Oculus touch controller. Fixed: 1033708 Change-Id: I6904a2335c50291b3b4338b2004d262fdb2772e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966354 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#727479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07d744fb8a53..1e5672715a8f git log 07d744fb8a53..1e5672715a8f --date=short --first-parent --format='%ad %ae %s' 2019-12-26 brianosman@google.com Roll ICU and Harfbuzz 2019-12-26 rmistry@google.com Add bots to push apps from skia/skia-wasm docker images Created with: gclient setdep -r src/third_party/skia@1e5672715a8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I060e24e5cff3417cb4812da37dc9ee2efa0913ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727478}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bd97b6f9f213..5de15a256eb0 git log bd97b6f9f213..5de15a256eb0 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 cepheus@frii.com HLSL: Fix #2037: Integer dot used incorrect input for adds. Created with: gclient setdep -r src/third_party/glslang/src@5de15a256eb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Ie4150648153c95016603f79192369006787684c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982662Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fe10b5cac14e..a46fc1dcdc3d git log fe10b5cac14e..a46fc1dcdc3d --date=short --first-parent --format='%ad %ae %s' 2019-12-26 crouleau@chromium.org [Pinpoint] Telemetry: pick support apk from next to the release APK. Created with: gclient setdep -r src/third_party/catapult@a46fc1dcdc3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028125 Tbr: zhanliang@google.com Change-Id: I16746b5ddfc6213a8b1bf5fdb1fff29dbebf0330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982663Reviewed-by:
-
Stepan Khapugin authored
Reverts changes that maintain the downstream tests compileable. This should land after CL 2277302 in ios_internal which updates the call site to use MainController instead of SceneController. Bug: none Change-Id: I028c096279fbd9dd5b9dbfd8e7720c9818a1580b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958121 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727475}
-
Avery Musbach authored
Before the present CL, SplitViewDivider::OnWindowDragStarted checks if the dragged window and the divider window have the same parent, and if so, stacks the divider window below the dragged window. For when the parents are different, there is no provision, and that is a problem as shown in the video linked on https://crbug.com/1035984. Fixed: 1035984 Change-Id: Ib5a5e628b59a87b55fc5369150b784d3004d86fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979102Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#727474}
-
Devlin Cronin authored
Callers of ResultCatcher::GetNextResult() should always, always check the result. Typically, a return value of `false` means that something went wrong (because it is returned when a test fails), so it should be explicitly checked. (Note that we don't just assert in the ResultCatcher itself, because some tests do expect to fail). Update the one call site that didn't already check the result. Bug: None Change-Id: I690b794b0c1ac07cb0a30b5d3078ffdb258195a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980752Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727473}
-
Devlin Cronin authored
Remove: - ExtensionBrowserTest::installed_ - ExtensionBrowserTest::loaded_ - ExtensionBrowserTest::LaunchBrowserForAppInTab() - ExtensionBrowserTest::InstallExtensionWithUI() - ExtensionBrowserTest::WaitForExtensionLoadError() - browser_test_util::LaunchBrowserForAppInTab() None of these had active usage. No functional changes; pure deletion. Bug: None Change-Id: I815af35198ebeb0b75139086060eedb48a0d8209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981067Reviewed-by:
-
John Chen authored
Disabling perf test v8.browsing_mobile/browse:media:imgur:2019 on Android Nexus6 WebView Perf. TBR=crouleau@chromium.org NOTRY=True Bug: 1037905 Change-Id: I69f2cab841c944e00e4aa11c336f7422b877c417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982592Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2f4e0cb1acb..533cb856c0c9 Created with: gclient setdep -r src-internal@533cb856c0c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iacbf2d48f7a2b915a3e1c97d20bea4d25ee52ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727470}
-
Siye Liu authored
We should reset the flag |new_text_inserted_| after each |RequestLock| call because the flag is used to indicate whether current session has new text inserted/replaced. We should clear the flag at the end of current session to prepare the state for next edit session. Bug: 1013472 Change-Id: I6efd9600d84550857ba4f55a42966753d2a7bdab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972752Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727469}
-
Nazerke authored
This CL adds helper methods to signin_earlgrey_utils_app_interface.* and converts the following tests: -testSyncUploadBookmarkOnFirstSync -testSyncUploadBookmark -testSyncDownloadBookmark -testSyncCheckSameCacheGuid_SyncRestarted -testSyncCheckDifferentCacheGuid_SignOutAndSignIn -testSyncCheckSameCacheGuid_SyncRestartedAfterSignOutAndSignIn -testSyncDownloadAutofillProfile -testSyncUpdateAutofillProfile -testSyncDeleteAutofillProfile -testSyncUploadOpenTabs -testSyncTypedURLUpload -testSyncTypedUrlDownload -testSyncTypedURLDeleteFromClient -testSyncTypedURLDeleteFromServer. Bug: 987646 Change-Id: I559a90182f78996399bfc1ae9ac98a184c36d914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955555 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#727468}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dadde9348d46..63b6be2bbc99 git log dadde9348d46..63b6be2bbc99 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@63b6be2bbc99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I26f4d3f290fa7c13c467157589bf928a94c42516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981805Reviewed-by:
-
David Bertoni authored
The ExtensionBrowserTest and ExtensionApiTest classes have a set of enums for flags that have identical names and, in some cases, conflicting values. This is a problem when a function expecting one set of values is called with the other set of values. This CL removes the overlap between these sets of names and breaks their use into separate function parameters.. Bug: 1031605 Change-Id: Ie8aef41b0cfa0029ebbbb330b80bc4491c5ac5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954715Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#727466}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib5e7685bc295b472ade8638bfcf3af0a329ac4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981802Reviewed-by:
-
Justin Miron authored
This change calculates main frame document intersections by adding new intersection observer state for parent main frame intersections, propagated down the frame tree in ViewportIntersectionState. It adds new behavior to bypass clipping to the main frame's viewport when calculating a frame's intersection with the main frame, enabled by a new visual rect flag kDontApplyMainFrameOverflowClip. This is a precursor to two changes: 1. Propagating main frame intersections from render frame observers through page load metrics to the browser process. 2. Measurement of ad density within the main frame with each ad frames main frame intersection. BUG=993453 Change-Id: I7cdc790c6c2ee1047abb397fa3dc55a4c72b8c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968388Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#727464}
-
dalyk authored
The detailed host resolution error information in ResolveErrorInfo will be obtained via NavigationHandle in a future cl to trigger captive portal probes when navigations finish with secure DNS errors. The top-level error code that currently exists in NavigationHandle does not contain sufficient information to know whether certain errors (e.g. CERT_COMMON_NAME_INVALID) occurred during a DNS-over-HTTPS lookup or when establishing a connection to the desired endpoint. Bug: 1016325 Change-Id: I3c28a2582aaf9a884f43924aa6c65867ac771453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954849 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#727463}
-
Devlin Cronin authored
Update content/browser/web_package/web_bundle_browsertest.cc to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. - This allows us to avoid overriding the existing WebContentsDelegate, if any (which can mask behavior unintentional changes). - Avoids the need for a filter of "*" Bonus cleanups: Extract common functionality for awaiting a failed navigation and extracting the console message; cuts down ~50 lines of duplicate code. Bug: 1034150 Change-Id: I6b78a46ee8bb02f529ea44980f2aa97efa80d0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980896Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727462}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dd2c743d22b..d2f4e0cb1acb Created with: gclient setdep -r src-internal@d2f4e0cb1acb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I95ad19443136527b6bb331426f5bf5429131ee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981801Reviewed-by:
-
Alice Wang authored
This CL moves the static method startSigninActivityIfAllowed from SigninPromoUtil to SigninUtils. Bug: 1033425 Change-Id: Ia88eae874cc198fe3291f05e3259b4f125e67b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968983Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a23873d6497d..6dd2c743d22b Created with: gclient setdep -r src-internal@6dd2c743d22b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie1e11be9c56d8a318f5b661b43a37d8968d731f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981800Reviewed-by:
-
Stepan Khapugin authored
Makes waitForMainTabCount: print the actual tab count when it fails. Bug: none Change-Id: I63e3b26b33c0cede5c8bec72b4f35b738314fa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942341 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#727458}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4718c8bf88ee..a23873d6497d Created with: gclient setdep -r src-internal@a23873d6497d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I765e9ede92a11b68036bd31d80dfaa24ff14ada1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981799Reviewed-by:
-
Martin Kreichgauer authored
Change the SealCredentialId(), EncodeRpId(), EncodeRpIdAndUserId() and SealLegacyV0CredentialIdForTestingOnly() methods to not return base::Optional in order to make them less clunky. No functional changes intended. Change-Id: Ic7088e3e016c09b1df5e4bcdc665d72c5ea3286b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963861Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#727456}
-
Javier Ernesto Flores Robles authored
Previously whenever a new tab was open programmatically the snapshot wasn't updated, causing inconsistencies in the tab switcher. This CL amends that by asking for a new snapshot in main controller, before the action of opening a new tab takes place. Bug: 1029482 Change-Id: I49c327b3891d91cc6bdf60de28c80770e23e893a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981717 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: I059935e0d348ccc038f525a62a889439f1a11ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982335 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#727454}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: I718ce2f7ac43ef6778091170b00ffb6367f4a9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982339 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib28015c3f231e83131e1546185671f7eeb86cbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981796Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8df6d30b0fbc..4718c8bf88ee Created with: gclient setdep -r src-internal@4718c8bf88ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3b3245d523a58c98f4cfed168d8265297d97ec59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981797Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: I0d7d71cd0c314c31fe38116a40e1a74b381ca796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982334 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
