GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b1908cf0075b..8cd8f2f71e22


git log b1908cf0075b..8cd8f2f71e22 --date=short --no-merges --format='%ad %ae %s'
2019-02-01 pprabhu@chromium.org config: Migrate asuka-release to use Skylab


Created with:
  gclient setdep -r src/third_party/chromite@8cd8f2f71e22

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I1db8a4d214337d576443ce84b826d3b860228b82
Reviewed-on: https://chromium-review.googlesource.com/c/1450631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628487}

This test double will be used in my upcoming network-aware scheduler
class. Additionally, I wanted to reuse the logic of the FakeDelegate
class defined in DeviceSyncPersistentEnrollmentSchedulerTest, so I moved
that to a shared location where it will be able to be used from my
upcoming CL.

Note: I also needed to add a copy constructor for
CryptAuthEnrollmentResult since it is copied in this test double.

Bug: 899080
Change-Id: If78f716e9f5fa0f39e9d027dccfe6b1cb92ffcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1450463Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628486}

Convert client of the deprecated of PrefValueMap::SetValue taking
a std::unique_ptr<base::Value> to the recommended override taking
a base::Value directly.

The conversion is done using the following rules:

- If the value is built inline using std::make_unique<base::Value>
  then change to just construct a base::Value directly,

- If the value is built use base::Value::CreateDeepCopy(), then
  change to use base::Clone() which returns a base::Value instead
  of a std::unique_ptr<base::Value>,

- If the std::unique_ptr<base::Value> is just forwarded by the
  caller, dcheck it is not null (the check was present in the old
  method implementation) and use base::Value::FromUniquePtrValue
  to convert the std::unique_ptr<base::Value> to a base::Value.

This CL fixes uses in src/components/policy.

This CL was uploaded by git cl split.

Bug: 646113
Change-Id: Ief82c150539f913edd8f44f36caf566baaf39819
Reviewed-on: https://chromium-review.googlesource.com/c/1446360Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628485}

This fixes the issue where background color is not updated when dark
mode is toggled. The because background_color was not updated, only the
using_dark_mode param.

Bug: 926601
Change-Id: I464bb7c926849eba95884bf641262e44e66b4eed
Reviewed-on: https://chromium-review.googlesource.com/c/1450217Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628484}

This was initially a prereq for logic @
https://chromium-review.googlesource.com/c/chromium/src/+/1232518/23/base/task/sequence_manager/thread_controller_with_message_pump_impl.cc.
While that CL adopted a different approach, this still feels worthwhile.

A similar attempt was made for TimeBase in https://crrev.com/c/1155264
but was reverted for various concerns. It's also somewhat orthogonal
to this CL because it specifically ignored the TimeTicks +/- TimeDelta
issue whereas it's all this CL does (that one was about preserving
infinity once reached whereas this one is just about obtaining it
when adding/subtracting it).

One of the concerns in https://crrev.com/c/1155264 was that it should
use clamped_math.h instead of rolling its own. This CL doesn't do this
specifically because both values are int64_t but we want max int64_t
to be "infinity" and thus result in infinity even if added to a negative
(non-infinity) TimeTicks. It still makes sense to use clamped math for
TimeBase to TimeBase saturated math.

R=dcheng@chromium.org

Bug: 885371, 869387
Change-Id: I10cb0831d1fbdc489fbeaa5f4a87492831e0d083
Reviewed-on: https://chromium-review.googlesource.com/c/1449323Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628483}

This fixes a subtle bug in GetDecodedImageForDrawMipUsageChange where
the test image was created with a dimension larger than
|max_texture_size_| and never went through the GPU upload path.

R=ericrk@chromium.org

Change-Id: I4c9bbdfa6f8c25bbc75deb34cd37d427fd869a9c
Reviewed-on: https://chromium-review.googlesource.com/c/1450231
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628482}

Bug: 643554
Change-Id: I30b9e73aa3b5f6424b81614c5a9ae8e3466f37f8
Reviewed-on: https://chromium-review.googlesource.com/c/1440701
Auto-Submit: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628481}

Since crbug.com/922198 is fixed, we can reenable them.

Bug: 921003
Change-Id: I5208c773b8a47ae38858c2f7a2f620fe8f965d97
Reviewed-on: https://chromium-review.googlesource.com/c/1450419Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628480}

Remove the SSLClientSocketPool - use TransportConnectJobs instead.

This CL allows TransportClientSocketPools to stack on top of other
TransportClientSocketPools, when being used for SSLClientSockets.

It also leaves ssl_client_socket_pool_unittests in place, those just
use TransportClientSocketPools now, and will be moved in future CLs.

This is part of an effort to flatten the socket pools.
https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit

Bug: 472729
Change-Id: I473f28136347ce6e2bd17c5da0bcf4d7ac648072
Reviewed-on: https://chromium-review.googlesource.com/c/1446244Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628479}

This is a reland of 6a235ad7

This reland includes a fix for a use-before-initialization
error in HidReportDescriptor that caused devices that do not
use report IDs to sometimes report that they did.

Original change's description:
> Parse HID report descriptor for report info
>
> The previous HID report descriptor parser was designed to only
> extract the maximum size of each type of report and did not preserve
> information about the individual fields within a report. This CL
> adds a new parser that builds a hierarchical representation of the
> reports supported by the HID device.
>
> BUG=890096
>
> Change-Id: I4ac3bf883a843bec00576bfad78958d42f53abc7
> Reviewed-on: https://chromium-review.googlesource.com/c/1257897
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626816}

BUG=890096

Change-Id: I8991162f0bb8c442d4e7cdce5940dd801ab5bfa0
Reviewed-on: https://chromium-review.googlesource.com/c/1446661Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628478}

When a SBER user triggers an On Focus ping, extract visual features from
the login pages and attach them to the PhishGuard ping.

Bug: 922226
Change-Id: I4139270f98e717bb977914e5399ba9dec702f878
Reviewed-on: https://chromium-review.googlesource.com/c/1448809
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628477}

Bug: 927435
Change-Id: Ic1f17615bc5f4f6f2f2c02d8c3557c9ade7d1bc0
Reviewed-on: https://chromium-review.googlesource.com/c/1450200
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628476}

This CL makes AndroidSmsPairingStateTracker observers checked. This will
prevent us from notifying destroyed observers.

Bug: 926429
Change-Id: I6bffbf3a6fd7eb3e1bd59a640a851a733057e229
Reviewed-on: https://chromium-review.googlesource.com/c/1449170
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628475}

This reverts commit 27008de3.

Reason for revert: This resulted in all dropdown menus in Print
Preview being cut off, see https://crbug.com/927649.

This also caused a regression in the settings credit card dialog,
may be others that have not been identified yet.

Original change's description:
> Fix Assistant settings label padding
> 
> - Wrap the sub-label of settings entry.
> - md-select items automatically shrink, adding a min-width to it.
>   (not sure if this is intended?)
> 
> Bug: b/123363474
> Test: Manual Test
> Change-Id: Idd47e14a3b9d00dafe792f421660665d636e58b5
> Reviewed-on: https://chromium-review.googlesource.com/c/1439460
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: Yue Li <updowndota@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#627996}

TBR=stevenjb@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/123363474
Change-Id: I56b0551c822152498f5b8387c954a785c1af94f5
Reviewed-on: https://chromium-review.googlesource.com/c/1450017Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628474}

ui/base/user_activity causes ui/base to have a dependency on ui/events.
To remove another instance of this dependency, put user_activity into
its own component.


Bug: 921723
Change-Id: I8c82bcb82b876386c63fa263937280c48ceb43fb
Reviewed-on: https://chromium-review.googlesource.com/c/1448735Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#628473}

This reverts commit a7b9fce3.

Reason for revert: Sorry, need to take more time with this.

Original change's description:
> Reland "Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts"
> 
> This reverts commit 925d0880.
> 
> Reason for revert: Mis-interpreted local results and incorrectly reverted. Undoing.
> 
> Original change's description:
> > Revert "Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts"
> > 
> > This reverts commit a00335ea.
> > 
> > Reason for revert: Not a bug, but after cleaning up the CL, it doesn't fully address the original issue. Will re-assess.
> > 
> > Original change's description:
> > > Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts
> > > 
> > > During teardown of GPU channels, several GLContextVirtuals may be made
> > > current and released in a row. This change makes two tweaks to avoid
> > > excessive calls to Release/MakeCurrent which were leading to hangs on
> > > ARM:
> > > 
> > > - When we call ReleaseCurrent on GLContextVirtual, only release the
> > >   real GL context if:
> > >   a) We are releasing a real surface (need to release to clean
> > >      up surface).
> > >   b) We are the last virtual owner of the GL context (we need to
> > >      release before final destruction of real context).
> > > 
> > > - When we call SetCurrent(nullptr) on GLContext, only clear the
> > >   surface / GL API if we are the real context. During normal
> > >   operation GLContextVirtual always calls through the real context in
> > >   ReleaseCurrent. During destruction, both will be called.
> > > 
> > > Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1437704
> > > Reviewed-by: Antoine Labour <piman@chromium.org>
> > > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#628386}
> > 
> > TBR=piman@chromium.org,ericrk@chromium.org
> > 
> > Change-Id: Iaa25787bf8bb133094b6a4c2ab7a1d4438649707
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/1450223
> > Reviewed-by: Eric Karl <ericrk@chromium.org>
> > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#628464}
> 
> TBR=piman@chromium.org,ericrk@chromium.org
> 
> Change-Id: I5caaa51a0b4d7461558dca91cbc3344685dd556e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1450426
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#628470}

TBR=piman@chromium.org,ericrk@chromium.org

Change-Id: I3a999d335ed70d2e3e402e89012d11f820c78555
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1450226Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628472}

This change prepares //net for the upcoming switch of base::string16 to
std::u16string.

Bug: 911896
Change-Id: I4e752515a92f81a43154c0f7df856289d2bed2c5
Reviewed-on: https://chromium-review.googlesource.com/c/1450195
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628471}

This reverts commit 925d0880.

Reason for revert: Mis-interpreted local results and incorrectly reverted. Undoing.

Original change's description:
> Revert "Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts"
> 
> This reverts commit a00335ea.
> 
> Reason for revert: Not a bug, but after cleaning up the CL, it doesn't fully address the original issue. Will re-assess.
> 
> Original change's description:
> > Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts
> > 
> > During teardown of GPU channels, several GLContextVirtuals may be made
> > current and released in a row. This change makes two tweaks to avoid
> > excessive calls to Release/MakeCurrent which were leading to hangs on
> > ARM:
> > 
> > - When we call ReleaseCurrent on GLContextVirtual, only release the
> >   real GL context if:
> >   a) We are releasing a real surface (need to release to clean
> >      up surface).
> >   b) We are the last virtual owner of the GL context (we need to
> >      release before final destruction of real context).
> > 
> > - When we call SetCurrent(nullptr) on GLContext, only clear the
> >   surface / GL API if we are the real context. During normal
> >   operation GLContextVirtual always calls through the real context in
> >   ReleaseCurrent. During destruction, both will be called.
> > 
> > Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded
> > Reviewed-on: https://chromium-review.googlesource.com/c/1437704
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#628386}
> 
> TBR=piman@chromium.org,ericrk@chromium.org
> 
> Change-Id: Iaa25787bf8bb133094b6a4c2ab7a1d4438649707
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1450223
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#628464}

TBR=piman@chromium.org,ericrk@chromium.org

Change-Id: I5caaa51a0b4d7461558dca91cbc3344685dd556e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1450426Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628470}

This patch fixes one of the reasons for the transparent chrome window
bug.
We clone the window layer tree after we create a mirror window for
overview mode. This does not work well with transferable resource and
when to release them. This was resulting in empty resource texture
being displayed in cloned + mirrored windows at times. The resource
was being released as soon as the original layer was destroyed after
cloning.


The reason cloning was performed on the mirror window was to purge the
texture memory being used by the now minimized window. Recreating the
layer tree allowed the ui to delete the old layer tree and thus the old
textures.

This patch replaces the cloning that happens after a mirror window tree
is created while achieving the same goal of purging unneeded texture
memory by tricking the compositor into resetting its visibility.

           mode, solid color layer

Bug: 923595
Change-Id: I56c9a201922a4d0f2047b08979fa3f0589789c37
Component: ui layer, delegated frame host, stale content, overview
Reviewed-on: https://chromium-review.googlesource.com/c/1448119
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628469}

This change fixes a crash caused by an OOB access from the
|chooser_observer_| when removing the observer upon the destruction of
SiteSettingsHandler. The crash occurs when the following conditions are
met.

1. An off the record profile is created.
2. A chooser permission is granted in the off the record profile.
3. The chrome://settings/content page is opened in the main profile
   window.
4. The off the record window is closed.
5. The chrome://settings/content page is closed.

The SiteSettingsHandler will attempt to remove itself from the off the
record ChooserContextBase upon destruction, but the off the record
ChooserContextBase was already destroyed previously, therefore accessing
memory that has already been freed.

This change removes the logic that adds the SiteSettingsHandler to the
off the record ChooserContextBase, since the UI does not actually
display off the record chooser permissions anyways. I created
https://crbug.com/927372 for adding this feature.

Bug: 926501
Change-Id: I87359a3d67020a80b9fb698d5252c320436317de
Reviewed-on: https://chromium-review.googlesource.com/c/1447312Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628468}

There are three states of visibility: VISIBLE, HIDDEN, and OCCLUDED.
Currently on Mac, events are sent when the window is occluded, and this
changes the state to visible, which is incorrect and can lead to accounting
problems in handling future visibility events.

Bug: 921703
Change-Id: Ife41983602f838a0475182f376c31f9bf5de4d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1450299Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628467}

https://pdfium.googlesource.com/pdfium.git/+log/7da523216533..e13cf694d42b


git log 7da523216533..e13cf694d42b --date=short --no-merges --format='%ad %ae %s'
2019-02-01 thestig@chromium.org Add some helper functions in CFX_Font.


Created with:
  gclient setdep -r src/third_party/pdfium@e13cf694d42b

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I36cba74e1902e5539657f7d63c1b9a39efca511a
Reviewed-on: https://chromium-review.googlesource.com/c/1450462Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628466}

This reverts commit 96b864cc.

Reason for revert: This sometimes results in mangled .app bundles, needs a cleaner solution.

Original change's description:
> MacPWAs: Reparent tabs when installing PWAs
> 
> This works now. When re-parenting the window, the initial attempt to
> re-parent the window fails, because the PWA's bundle has not yet
> been created. The second attempt then re-creates the bundle and
> succeeds. This is a bit kludgey in that it is possible that the bundle
> will be recreated twice.
> 
> A cleaner solution would be to delay reparenting the contents and
> revealing the app in Finder until the app has been created, but that
> solution may not be suitable for merge.
> 
> Bug: 859152
> Change-Id: Ifaf507525729a9a168e821f722aee03e9f6dd8f4
> Reviewed-on: https://chromium-review.googlesource.com/c/1438037
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#627151}

TBR=benwells@chromium.org,ccameron@chromium.org,dominickn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 859152
Change-Id: I6460da08a6dfb8f3e68218ecc19216773062458a
Reviewed-on: https://chromium-review.googlesource.com/c/1450216Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628465}

This reverts commit a00335ea.

Reason for revert: Not a bug, but after cleaning up the CL, it doesn't fully address the original issue. Will re-assess.

Original change's description:
> Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts
> 
> During teardown of GPU channels, several GLContextVirtuals may be made
> current and released in a row. This change makes two tweaks to avoid
> excessive calls to Release/MakeCurrent which were leading to hangs on
> ARM:
> 
> - When we call ReleaseCurrent on GLContextVirtual, only release the
>   real GL context if:
>   a) We are releasing a real surface (need to release to clean
>      up surface).
>   b) We are the last virtual owner of the GL context (we need to
>      release before final destruction of real context).
> 
> - When we call SetCurrent(nullptr) on GLContext, only clear the
>   surface / GL API if we are the real context. During normal
>   operation GLContextVirtual always calls through the real context in
>   ReleaseCurrent. During destruction, both will be called.
> 
> Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded
> Reviewed-on: https://chromium-review.googlesource.com/c/1437704
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#628386}

TBR=piman@chromium.org,ericrk@chromium.org

Change-Id: Iaa25787bf8bb133094b6a4c2ab7a1d4438649707
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1450223Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628464}

Mac now runs with Views. I couldn't think of a good reason to keep the
ChromeOS comment either, so I nuked it.

Change-Id: Ia49b6e5cce021996c495f121fc093cfd756ed56c
Reviewed-on: https://chromium-review.googlesource.com/c/1450018
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628463}

https://codereview.chromium.org/2873593002 added an optimization to not
damage targets on property changes only.

This is only correct when the layer and the render target share the same
property tree node.  In that case, the layer isn't affected by the
property tree change and the damage is applied to the render target's
target instead.  If the property tree nodes are not shared, then
the target needs to be damaged.  (Thus, this bug.)

This patch may include some false positives (damage when we could have
avoided it), but will fix the linked issue where there is missing damage
when there should have had damage.  An approach to optimize away these
false positives would be to track effect and transform node property
changes on LayerImpl separately.

Bug: 923794
Change-Id: I34bc7f4ce03841f7b04eed885c1f37fa6bb9e8ad
Reviewed-on: https://chromium-review.googlesource.com/c/1450310Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628462}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3e7bf99febab..b1908cf0075b


git log 3e7bf99febab..b1908cf0075b --date=short --no-merges --format='%ad %ae %s'
2019-02-01 dhanyaganesh@chromium.org BuildStore: Redirect GetBuildStatus through BuildStore (part 2)
2019-02-01 dgarrett@google.com chromeos_config: Add tryjobs for other postsubmit configs.


Created with:
  gclient setdep -r src/third_party/chromite@b1908cf0075b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia883e018398b6a76b000a0e15965e398bad31562
Reviewed-on: https://chromium-review.googlesource.com/c/1450458Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628461}

[Animation Worklet] Clean up animator registration logic for wpt test worklet-animation-with-fill-mode.https.html

Similar to [1], we should register the animator only once in the setup.

[1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html

Bug: 923881
Change-Id: I0f6761b7753aacdf3ebe6d8ed63fe4e0ea183e25
Reviewed-on: https://chromium-review.googlesource.com/c/1448519Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628460}

It appears that this test is crashing, and thereby causing
webkit_layout_tests to leak content_shell.exe processes on
Swarming, which in turn causes the entire swarming shard to
fail. Disabling to hopefully stop the leakage and green up the
Win10 bot.

R=wjmaclean

Bug: 926016,927862
Change-Id: Ia655db8ad1918fb3fb567a850bb07a1b9427aa6d
Reviewed-on: https://chromium-review.googlesource.com/c/1450407Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628459}

Intent to deprecate and remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/e0bzxOfL-2I

Bug: 880863
Change-Id: I9dc88d7521444c0a965f8e4d6e4bb23ce3f27905
Reviewed-on: https://chromium-review.googlesource.com/c/1449009Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628458}

This was causing a weird discontinuity in retina.

Bug: 924484
Change-Id: Idaefc7933a69fbb46cfbe8180e1df02161067d0b
Reviewed-on: https://chromium-review.googlesource.com/c/1450213Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628457}

When using ScopedTaskEnvironment::NowSource::MAIN_THREAD_MOCK_TIME, both
base::Time::Now() and base::TimeTicks::Now() are affected. However, this
isn't clear in the comment and there's no unit test covering it.

This CL updates the comment and added tests to cover both
base::Time::Now() and base::TimeTicks::Now().

Bug: 917527
Test: New tests added.
Change-Id: Ida9b5f334e12e0bceb9e952f97f0ee9ef01ffc45
Reviewed-on: https://chromium-review.googlesource.com/c/1450402
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628456}

Test fixtures include:
- AcceleratorInteractiveUITest (renamed to AcceleratorTest)
- AppListTest
- DragDropTest
- NativeCursorManagerAshTest interactive ui test is deleted
  (it was only ever enabled for x11)

Bug: none
Change-Id: Ifdae12d85eba18e589b9282ee39c2e903d27e560
Reviewed-on: https://chromium-review.googlesource.com/c/1449092
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628455}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b80b951e0bf..263746b68633


Created with:
  gclient setdep -r src-internal@263746b68633

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I3cf6b376117009b5259fc74a075f2d08dbc4daf8
Reviewed-on: https://chromium-review.googlesource.com/c/1449789Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628454}

to HasGreaterFrecencyThan.
Some nits that I forgot to commit for
crrev.com/c/1446866.

Change-Id: I5117154f40a6b97f882fc90fe7c6b6f76e9528f7
Reviewed-on: https://chromium-review.googlesource.com/c/1450050Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#628453}

https://skia.googlesource.com/skia.git/+log/1a0126f61a98..3ed198faf93a


git log 1a0126f61a98..3ed198faf93a --date=short --no-merges --format='%ad %ae %s'
2019-02-01 reed@google.com remove docs for containsText
2019-02-01 robertphillips@google.com Rename GrContext::uniqueID to contextID and hide it
2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cf9383ed325c..a54104803d72 (1 commits)
2019-02-01 reed@google.com delete orphaned sample
2019-02-01 reed@google.com remove breakText, and all utf cache accessors


Created with:
  gclient setdep -r src/third_party/skia@3ed198faf93a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: I21ea2a74e7e8a04ac9d23d8ae37d7d68df892c26
Reviewed-on: https://chromium-review.googlesource.com/c/1450312Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628452}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b2d43541..1fe1ad2c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia71e97fe86c3f9cc4de21fa7fedc045b38f579f5
Reviewed-on: https://chromium-review.googlesource.com/c/1450309Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628451}

This is called in Debug builds when initializing the GPU process:

 0x5620120abcfc sandbox::Trap::SigSysAction()
 0x7b1559a70ab0 <unknown>
 0x7b155865ae80 __getrlimit
 0x56200dd02039 base::AssertMemoryIsReadOnly()
 0x56200dd00dd5 base::AutoWritableMemory::AutoWritableMemory()
 0x56200dd01a17 base::AutoWritableMemory::Create<>()
 0x5620105343bf gl::SetGLGetProcAddressProc()
 0x56200526dde4 ui::(anonymous namespace)::LoadEGLGLES2Bindings()
 0x56200526d9b4 ui::LoadDefaultEGLGLES2Bindings()
 0x5620051fa447 ui::(anonymous namespace)::GLOzoneEGLGbm::LoadGLES2Bindings()
 0x56200526e2dc ui::GLOzoneEGL::InitializeStaticGLBindings()
 0x562010d78287 gl::init::InitializeStaticGLBindings()
 0x562010d72e8f gl::init::InitializeGLOneOffImplementation()
 0x562010d72c95 gl::init::(anonymous namespace)::InitializeGLOneOffHelper()
 0x562010d72df0 gl::init::InitializeGLNoExtensionsOneOff()
 0x562010fc594c gpu::GpuInit::InitializeAndStartSandbox()
 0x56201b3f43bb content::GpuMain()
 0x56200ca83652 content::RunOtherNamedProcessTypeMain()
 0x56200ca85619 content::ContentMainRunnerImpl::Run()
 0x56200ca7a88c content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
 0x56200ca9a0ba service_manager::Main()
 0x56200ca80d83 content::ContentMain()
 0x562002f9f298 ChromeMain
 0x562002f9f182 main

BUG=923570
TEST=Build and deploy debug build to grunt; get to login screen

Change-Id: I2c91e0bb3932dcb462b1e89123e0ea357abf93cb
Reviewed-on: https://chromium-review.googlesource.com/c/1448771Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628450}

If a Tab is leaked, it's possible for BVC's URLLoadingObserver callbacks
to be triggered after the Tab's corresponding WebState has been
destroyed.  This CL updates that implementation to prevent crashes if
this occurs.

Bug: 925757
Change-Id: Id47321d2555605e1c1634080c7601b4d0f0b969d
Reviewed-on: https://chromium-review.googlesource.com/c/1448686
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628449}

There was a missing space that was making logs confusing.

BUG=None
TEST=Compile, run, see better log line.

Change-Id: I1740323a60393686b0badbd2ab737096c6f8ac5d
Reviewed-on: https://chromium-review.googlesource.com/c/1450214
Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628448}