- 10 Nov, 2020 15 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0bec1380d03d..9b7f81867ddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I88419d08994b5406f8a4a798b6d354b95ad13ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825556}
-
Curt Clemens authored
When multiple files are shared, instead of showing the filename as a preview, we show the file count, i.e. "3 Files". Bug: b/163036847 Change-Id: I6aa28ca8f769538c7244268661bec9a4e23b73b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522909Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#825555}
-
sebsg authored
Change-Id: I399ec1b246536e906c56f6ae4e84659e1c4a032b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522975 Auto-Submit: sebsg <sebsg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#825554}
-
Ian Kilpatrick authored
As above. This change implements the behaviour described by: https://github.com/whatwg/html/pull/5936/files This introduces an internal pseudo class ":-internal-modal" which applies the additional style rules when the dialog goes modal. Intent-to-ship/change: https://groups.google.com/a/chromium.org/g/blink-dev/c/Ow63WaHuTgc Change-Id: I6d807fffd64b4f9c8ea57a2993ac755b23df8287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258897 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#825553}
-
Mike Jackson authored
This is a reland of b94143e8 The OSHookType when uninstalling mac app shim was incorrect, fixing to pass the correct parameter. Original change's description: > dpwas: Move delete shared mac shim to behind shortcuts > > While working on Run On OS Login for Mac, I noticed that the shared > app shims were being deleted when toggling Run On OS Login. This happens > because the app shims unconditionally delete the app shims. > > This change moves the code to delete the shared app shims behind > the shortcut check. On Mac you can have both per profile shims, > and shared shims, so the callbacks are chained together only on > that platform. > > Bug: 897302 > Change-Id: I318137ac0f34e4f2429a5119d47e3fe5c3c96892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519877 > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825165} Bug: 897302 Change-Id: Icc376223a9b5bccd19ac1c9c92bda9397487dc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525284Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#825552}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9217d49db032..489f2c838bb7 2020-11-09 jmadill@chromium.org Perf Tests: Trace multiple threads. 2020-11-09 jmadill@chromium.org Vulkan: Make feature names consistent. 2020-11-09 syoussefi@chromium.org Fix expectations file for prerotation dEQP executables 2020-11-09 m.maiya@samsung.com Vulkan: Rewrite interpolateAtOffset to account for Y-flip 2020-11-09 jmadill@chromium.org Fix trace writing in angle_perftests. 2020-11-09 m.maiya@samsung.com Vulkan: Support VK_KHR_image_format_list for AHB backed EGL image 2020-11-09 stha09@googlemail.com Vulkan: add explicit template specialization for barrierImpl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_end2end_tests.exe Change-Id: I2b6c9690735ccf482263faf781f7291b17a010dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527670Reviewed-by:
-
Clark DuVall authored
The fix in https://crrev.com/c/2522511 almost worked, but ended up crashing when inflating layouts. This change replaces the underlying ClassLoader from the ContextImpl for each Activity. Bug: 1146745 Change-Id: I23fc0b15fcd5ef80b78c82de2ab83245af1146d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526627Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#825550}
-
Mark Pearson authored
This reverts commit dde3defc. Reason for revert: browser_tests on linux-lacros-tester-rel consistently fail after this landed in https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4381 Failures are: MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys MediaKeysListenerManagerImplTest.PressPlayPauseKey MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController They all crash: [ RUN ] MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys DevTools listening on ws://127.0.0.1:37255/devtools/browser/5be580d5-fcf2-46b2-8f43-033ac20657af [22277:22277:1109/134807.593313:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55ec232b31d9 base::debug::CollectStackTrace() #1 0x55ec2322bc63 base::debug::StackTrace::StackTrace() #2 0x55ec22e77786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f5f63b034c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x55ec20957235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x55ec22e76577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x55ec22f20fde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x55ec226b9896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x55ec22b09c33 content::StartupTaskRunner::RunAllTasksNow() #9 0x55ec226b8877 content::BrowserMainLoop::CreateStartupTasks() #10 0x55ec226bb278 content::BrowserMainRunnerImpl::Initialize() #11 0x55ec226b6f68 content::BrowserMain() #12 0x55ec218feeb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x55ec218feaa6 content::ContentMainRunnerImpl::Run() #14 0x55ec218fbf54 content::RunContentProcess() #15 0x55ec218fc8dc content::ContentMain() #16 0x55ec22e75f8c content::BrowserTestBase::SetUp() #17 0x55ec21670678 testing::Test::Run() #18 0x55ec2167150f testing::TestInfo::Run() #19 0x55ec21671ef7 testing::TestSuite::Run() #20 0x55ec2167f677 testing::internal::UnitTestImpl::RunAllTests() #21 0x55ec2167efdf testing::UnitTest::Run() #22 0x55ec22ebf284 base::TestSuite::Run() #23 0x55ec22e48027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x55ec22e9a871 content::LaunchTests() #25 0x55ec22e47fe0 main #26 0x7f5f63aee840 __libc_start_main #27 0x55ec1fce43ea _start [ RUN ] MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController DevTools listening on ws://127.0.0.1:37481/devtools/browser/4cec391a-3d7f-4854-bdcf-7c8abf8b0cbe BrowserTestBase received signal: Segmentation fault. Backtrace: [25621:25621:1109/134831.864948:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. #0 0x5636f5a041d9 base::debug::CollectStackTrace() #1 0x5636f597cc63 base::debug::StackTrace::StackTrace() #2 0x5636f55c8786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fbfcb8e44c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5636f30a8235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x5636f55c7577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x5636f5671fde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x5636f4e0a896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x5636f525ac33 content::StartupTaskRunner::RunAllTasksNow() #9 0x5636f4e09877 content::BrowserMainLoop::CreateStartupTasks() #10 0x5636f4e0c278 content::BrowserMainRunnerImpl::Initialize() #11 0x5636f4e07f68 content::BrowserMain() #12 0x5636f404feb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x5636f404faa6 content::ContentMainRunnerImpl::Run() #14 0x5636f404cf54 content::RunContentProcess() #15 0x5636f404d8dc content::ContentMain() #16 0x5636f55c6f8c content::BrowserTestBase::SetUp() #17 0x5636f3dc1678 testing::Test::Run() #18 0x5636f3dc250f testing::TestInfo::Run() #19 0x5636f3dc2ef7 testing::TestSuite::Run() #20 0x5636f3dd0677 testing::internal::UnitTestImpl::RunAllTests() #21 0x5636f3dcffdf testing::UnitTest::Run() #22 0x5636f5610284 base::TestSuite::Run() #23 0x5636f5599027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x5636f55eb871 content::LaunchTests() #25 0x5636f5598fe0 main #26 0x7fbfcb8cf840 __libc_start_main #27 0x5636f24353ea _start [ RUN ] MediaKeysListenerManagerImplTest.PressPlayPauseKey DevTools listening on ws://127.0.0.1:36939/devtools/browser/4a443d13-30b6-430d-a4b3-503ecbbdc73e [4137:4137:1109/134809.976176:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x5647f92c11d9 base::debug::CollectStackTrace() #1 0x5647f9239c63 base::debug::StackTrace::StackTrace() #2 0x5647f8e85786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f6dac3524c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5647f6965235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x5647f8e84577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x5647f8f2efde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x5647f86c7896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x5647f8b17c33 content::StartupTaskRunner::RunAllTasksNow() #9 0x5647f86c6877 content::BrowserMainLoop::CreateStartupTasks() #10 0x5647f86c9278 content::BrowserMainRunnerImpl::Initialize() #11 0x5647f86c4f68 content::BrowserMain() #12 0x5647f790ceb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x5647f790caa6 content::ContentMainRunnerImpl::Run() #14 0x5647f7909f54 content::RunContentProcess() #15 0x5647f790a8dc content::ContentMain() #16 0x5647f8e83f8c content::BrowserTestBase::SetUp() #17 0x5647f767e678 testing::Test::Run() #18 0x5647f767f50f testing::TestInfo::Run() #19 0x5647f767fef7 testing::TestSuite::Run() #20 0x5647f768d677 testing::internal::UnitTestImpl::RunAllTests() #21 0x5647f768cfdf testing::UnitTest::Run() #22 0x5647f8ecd284 base::TestSuite::Run() #23 0x5647f8e56027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x5647f8ea8871 content::LaunchTests() #25 0x5647f8e55fe0 main #26 0x7f6dac33d840 __libc_start_main #27 0x5647f5cf23ea _start Original change's description: > Reland "[Media Session] Fix for Lacros" > > This is a reland of ddb531f7 > > There is a fix in media_session_service.cc to allow the tests to pass > when ash-chrome is not running. > > Original change's description: > > [Media Session] Fix for Lacros > > > > At the moment in Lacros there are two instances of the > > Media Session Service (MSS) one hosted in ash-chrome and > > the other in lacros-chrome. This means that sessions in > > either browser process cannot see sessions from the other. > > > > This changes it so when a client asks for lacros-chrome > > MSS instead of providing a locally hosted MSS it binds > > the MSS in ash-chrome. > > > > BUG=1140215 > > > > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825016} > > Bug: 1140215 > Change-Id: I64834d9be778998b42bf3447444a6955265215ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825439} TBR=avi@chromium.org,dcheng@chromium.org,erikchen@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I284aea77c32a39c8641df70d83baa5b2e09b8641 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528306Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825549}
-
Vincent Boisselle authored
We also re-baseline the goldens by incrementing the version number since the testRender_FocusFakeBox test had its baseline golden with the new feed header UI enabled which we don't want anymore since the features flags related to that UI change are now disabled. Bug: 1146197 Change-Id: I0bb2525102dea745a3e419d2b8252abf1525811b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525741Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#825548}
-
Yulun Wu authored
Bug: 1143063 Change-Id: Icd0ec2088508d633757ed20749790b80a1dc09d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508558Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825547}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604685414-0763f88efc3380eb5f7b102366bfe07c0bfcf724.profdata to chrome-win32-master-1604931688-79a6ca0d5aca76d3d27163162f00dd49eb38f0e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0fa1c97fdd9f6fe204bc9ac9c5b3582165ff26b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526609Reviewed-by:
-
Frank Liberato authored
Also adds StatusOr::code() as a convenience. Change-Id: Id54fc2f2657b0589bad5b910b78022ac8cfef502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523541 Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#825545}
-
Andrew Grieve authored
Having "PATH=/foo/depot_tools/" is valid, but the script didn't accept it because os.path.basename('/foo/depot_tools/') == '' Bug: None Change-Id: I3e0b16f022ac0d99559a16d5866376523749681a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519608Reviewed-by:Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#825544}
-
Peter Boström authored
This has been true on all platforms for a long time now. Its presence is more confusing (suggests platforms where this is not true). Bug: 924232 Change-Id: Ib73c8d3f785e96912739a83e6d325db33c85a27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527365 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825543}
-
Yuri Wiitala authored
A recent change removed the use of this content public API. It provided legacy/duplicate functionality to that found in content/public/browser/audio_service.h. Bug: 1111026 Change-Id: Ie498c0b743f7c03cc65bb5613dd2765a3f2d2de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523744 Auto-Submit: Yuri Wiitala <miu@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#825542}
-
- 09 Nov, 2020 25 commits
-
-
John Williams authored
Bug: b/169327785 Change-Id: I70339ef33a19af6e2a9be3081429e0856ef145a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487560Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#825541}
-
Javier Ernesto Flores Robles authored
Bug: 3385043 Change-Id: I7b642702cf39da720f768cbed3631b3a2b59df6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521223Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#825540}
-
Etienne Bergeron authored
This CL is adding coverage of SetDisplayRect(...) to the RenderText API fuzzer. This is required to trigger the eliding code. Eliding occurs only when the text can't fit the display rect. The fuzzer should have caught that bug (crbug/1142020). We are expecting a new series of bugs from clusterfuzz after landing this change. These bugs are not recently added to chrome but should be fixed. Bug: 1142020 Change-Id: Id0fcfb025651286f4c474004ef8f93b48fb0e281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522605 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#825539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f692adcf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I78ac9c7e1655a7f118c60849c823946c5733c365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527962Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825538}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1030c88a4bb8..7b6396aaef5b 2020-11-09 miu@chromium.org Standalone Receiver: Integration with ApplicationAgent. 2020-11-09 jophba@chromium.org Add Control Protocol Schemas If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I750aa5a82820505d61ea33642b815212c8b9a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527766Reviewed-by:
-
Mohamed Adel authored
Change-Id: I435792f47b3d257a4f47fa3f11862dcedbef29cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526460 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825536}
-
Mark Mentovai authored
FruitCo advises that the oah names are deprecated in favor of the Rosetta ones. Bug: 1145672, 1145792, 1142017 Change-Id: I55892a5d9904c718068ecbd2485e7909b57e9a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527964Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#825535}
-
David Benjamin authored
Change-Id: Ic8481b3b139e2837683cf917929b7b89ac2c9fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527792 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#825534}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b7f81867ddd..1d532cbd0baa 2020-11-09 primiano@google.com base: set TCP_NODELAY to TCP sockets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibbe152b4bb16110f1ba552e2e91fbba0cc3e2a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525756Reviewed-by:
-
Jacob Kopczynski authored
They aren't in use in any console but are still checked for by the hooks BUG: chromium:1127088 Change-Id: Ibd13b00cfa23b56a3245035bf5b86533705112bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527942 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#825532}
-
Austin Eng authored
This reverts commit c3c7a75c. Reason for revert: FastCall crash on x86 was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2520902 Original change's description: > Disable webgl_conformance_fast_call_tests > > The test suite is failing on Win10 FYI x86 Release (NVIDIA) bot since it > landed. Add rule to stop it from running there. > > Bug: 1144751 > Change-Id: I69fac186a3eacb8dcd262ba88a0d3e29d927908f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512290 > Commit-Queue: kylechar <kylechar@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: kylechar <kylechar@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823265} TBR=ynovikov@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144751 Change-Id: Id055d1bc2eba4e8cbaa93f2677a8988a7744c92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527009Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#825531}
-
Dominique Fauteux-Chapleau authored
Bug: 1109242 Change-Id: I0dc66e30b9936ee9beabea5c61d586890751ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523690Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825530}
-
Ana Salazar authored
Add screen recordings video files type to holding space. Screen recordings are video captures of the contents of the user display. These files will be added in to the screen captures area of the holding space tray and will be treated in the same way as screenshots. Bug: 1144927 Change-Id: I0f47d1670b1bcd0e43d514325962ef3669a84901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518411Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825529}
-
behdad authored
This reverts commit 4d2c7974. Changes since revert: - Code cleanup: Multiple containers are replaced by a map from Frame_id to FrameState, which tracks the number of AddNewFrame/AddResults/Resets received regarding the frame. - Order of variable definition change in scheduler_test_common.h (for dropped_counter) which was causing destruction of FrameSorter prior to Acks being recorded and frames being flushed in some of the scheduler tests. - Added a new test for when reset happens in middle of two AddNewFrame calls with the same frame_id, which depending on the order of acks received afterwards could results into Dcheck failures (initial implementation would not cover such cases). [cc/metrics] Introduce FrameSorter. The begin-frames do not always terminate in the same order as they start. For example, a frame that does not have any updates can terminate earlier than a previous frame that had an update and is awaiting presentation. This can make it tricky to measure dropped-frames in a sliding window. To make this easier, introduce a FrameSorter, that makes sure the sliding-window can process the frames in order, regardless of when they are terminated. BUG=1138552, 1144480, 1145636 Change-Id: Icb8898b0185baa2fa1c8d0c4619f9576acc07fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518696Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#825528}
-
wutao authored
Bug: b/171071314 Test: Added new test helper and fixes tests. Change-Id: I22c9fe099025a51c999f2d8fbfa12d983f0aa5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505670 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825527}
-
David Maunder authored
PersistedTabDataStorage is an interface which enables different types of PersistedTabData to be backed by different types of storage. This CL implements the interface for a Level DB data store. The Level DB database is persisted_state_db in native. Bug: 1140773 Change-Id: Ie63dbd4e9fbeb08f1e55e1a2722a47d9566f5d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504215 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#825526}
-
Evan Stade authored
Bug: 1144109 Change-Id: Iba055d3a9876b80f0da828409e2f21b1c5940a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521156 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Collin Baker authored
On restore, a tab could be placed between tabs of another group. This fixes it by placing restored tab to the right of the group. Fixed: 1109368 Change-Id: Ifbc72e92f6539f15e0f92551b3ccfa4735935f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522114Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#825524}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0bec1380d03d..9b7f81867ddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I555b3751d6a5b8d2a39d637fcfeee8170dc04fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527544Reviewed-by:
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/33ece0a9f897..5fa7c4e22c1b $ git log 33ece0a9f..5fa7c4e22 --date=short --no-merges --format='%ad %ae %s' 2020-11-06 wtc Quiet the find_package(libyuv) call 2020-11-06 wtc Miscellaneous cleanup 2020-11-06 wtc Fix miscellaneous comment nits 2020-11-06 wtc Remove disableGridImages from avifDecoder 2020-11-06 sorairolake apps: Add version option 2020-11-06 wtc Move assignment of header->av1C.chromaSamplePosition 2020-11-06 wtc Add #error if AVIF_CODEC_AOM_DECODE/ENCODE undefined 2020-11-06 wtc Cosmetic: Move code to be with related code 2020-11-06 wtc Change avifDecoderReadItem to take avifIO as input 2020-11-06 jdrago Add BEST_QUALITY and FASTEST upsampling filters for easier high-level control over libyuv and filters (...) 2020-10-22 jdrago Fix accidental stomp of AVIF_PLATFORM_LIBRARIES CMake variable 2020-10-22 jdrago Fix various macOS/clang build issues 2020-10-22 jdrago Expose libyuv availability to API and cmdline tools 2020-10-22 jdrago Basic libyuv support, first pass 2020-10-22 wtc Fix a crash in avifJPEGRead() on fopen() failure 2020-10-19 wtc Link with {ZLIB_LIBRARY} after ${PNG_LIBRARY} 2020-10-16 wtc Remove unneeded libs and includes for svt and aom 2020-10-15 wtc Add size_t casts to fix MSVC x86 compiler warnings 2020-10-15 jdrago Various fixes to SVT-AV1 PR #369 2020-10-15 jon add SVT-AV1 encoder Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1136922 Change-Id: I5f6478281b769124d8f1b975b3d3dc27a70bc7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524292 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825522}
-
Antonio Gomes authored
Dependency/include graph: - frame_header.h is included by default_frame_header.h - browser_non_client_frame_view_ash.cc includes default_frame_header.h. So, in order to free browser_non_client_frame_view_ash.cc|h from including //ash/ headers the items above will migrate step by step to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org TBR=oshima@chromium.org Change-Id: I9a174c9daa9674380605805649496039d543a0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521706Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#825521}
-
Roman Arora authored
- Change search field font to inherited one - Move shortcut text to a side in a div Bug: 1145608 Change-Id: I6e6926c9d7a6a843072950e2fd0f31eaaf0df747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521097 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825520}
-
Mark Pearson authored
This reverts commit 96a972a1. Reason for revert: PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch is flaky on https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 It failed 4 out of the last 25 builds. https://screenshot.googleplex.com/8bGbnEgxTnyrXk9 When I say failed, I mean it failed on both the original run and the re-run (i.e. failed twice in a row), which turns the bot read. The failures look like [ RUN ] PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch [20276:19520:1109/002722.827:ERROR:device_event_log_impl.cc(211)] [00:27:22.827] Bluetooth: bluetooth_adapter_winrt.cc:1073 Getting Default Adapter failed. ../../chrome/browser/net/private_network_request_browsertest.cc(171): error: Value of: GetAddressSpaceFeatureBucketCounts(histogram_tester) Expected: has 1 element that has a first field that is equal to WebFeature::kAddressSpaceLocalEmbeddedInPublicSecureContext, and has a second field that is equal to 1 Actual: {} Stack trace: Backtrace: `anonymous namespace'::PrivateNetworkRequestBrowserTest_RecordsAddressSpaceFeatureForFetch_Test::RunTestOnMainThread [0x00007FF66FF0A4D5+1211] (o:\chrome\browser\net\private_network_request_browsertest.cc:168) content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF673CD884D+683] (o:\content\public\test\browser_test_base.cc:770) ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF673B2F126+4442] (o:\chrome\browser\chrome_browser_main.cc:1664) ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF673B2DF05+65] (o:\chrome\browser\chrome_browser_main.cc:1033) content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF672089943+73] (o:\content\browser\browser_main_loop.cc:991) content::StartupTaskRunner::RunAllTasksNow [0x00007FF67242BE1F+61] (o:\content\browser\startup_task_runner.cc:41) content::BrowserMainLoop::CreateStartupTasks [0x00007FF6720886AC+594] (o:\content\browser\browser_main_loop.cc:905) content::BrowserMainRunnerImpl::Initialize [0x00007FF67208B38A+126] (o:\content\browser\browser_main_runner_impl.cc:130) content::BrowserMain [0x00007FF672086E9D+161] (o:\content\browser\browser_main.cc:43) content::RunBrowserProcessMain [0x00007FF6729DADC5+89] (o:\content\app\content_main_runner_impl.cc:521) content::ContentMainRunnerImpl::RunServiceManager [0x00007FF6729DBA61+849] (o:\content\app\content_main_runner_impl.cc:1008) content::ContentMainRunnerImpl::Run [0x00007FF6729DB6E2+330] (o:\content\app\content_main_runner_impl.cc:886) content::RunContentProcess [0x00007FF6729DA561+805] (o:\content\app\content_main.cc:372) content::ContentMain [0x00007FF6729DA8DE+61] (o:\content\app\content_main.cc:398) content::BrowserTestBase::SetUp [0x00007FF673CD8452+1772] (o:\content\public\test\browser_test_base.cc:605) InProcessBrowserTest::SetUp [0x00007FF673A1EFA6+398] (o:\chrome\test\base\in_process_browser_test.cc:347) [20276:19520:1109/002727.767:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown. [ FAILED ] PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch, where TypeParam = and GetParam() = (5267 ms) Original change's description: > [CORS-RFC1918] Selectively re-enable broken test. > > This change enables the test except when a conflicting feature is > enabled. It improves on the status quo (test disabled everywhere) until > the underlying failure can be fixed, letting the test run on all CI bots > except for the offending Network Service bot. > > Bug: chromium:1142865 > Change-Id: I4bb870d04c6b35961c1c32d9d3549d03afeaa3f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519693 > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824400} TBR=mmenke@chromium.org,titouan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1142865 Change-Id: I65320686b457fcbe21211c0091abf9218a728b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528123Reviewed-by:
-
Daniel Cheng authored
This eliminates the need to cast the scoped enumeration to an integral type, and updates the enum to use the kMaxValue convention which allows: - clang to enforce kMaxValue correctness - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION() Bug: 742517, 1047547 Change-Id: I35c9d7cc03d15bcec530b599b459a94e4f975672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524932Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825518}
-
yjliu authored
Bug: 1147099 Change-Id: Ib8c822644ee3f12b75c585cfa07a255594974b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527842 Commit-Queue: Jun Liu <yjliu@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
-
