- 08 Apr, 2019 31 commits
-
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/navigatorcontentutils, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ib186b8359fc5f72ea26ebfa8587813177d5f13a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556862Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648584}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/netinfo, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ica09e05246b9a8e830498c4fb2c5be5d836d59b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556958Reviewed-by:
-
Christopher Lam authored
This CL adds a completion callback for SynchronizeInstallApps similar to Install/UninstallApps. This is in preparation for adding a OneShotEvent to the SystemWebAppManager which will allow clients to start tasks once all System Web Apps are installed. To test that the callback is run at the correct time, TestPendingAppManager now installs/uninstalls apps asynchronously (which more realistically simulates the production control flow). TBR=khorimoto@chromium.org Bug: 836128 Change-Id: I755a0a716554e27baa6e894a5b8b02635118c1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545370 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#648582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff7e80ae..e3b2feb3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia866135a0f9b0696f98f536090f92b69b2723f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557736Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648581}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4fe0db08d90..731eaa372a59 git log a4fe0db08d90..731eaa372a59 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fb201c5e208d..90b1865e2a8b (10 commits) 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3e2882be..afd96fdc (504 commits) Created with: gclient setdep -r src/third_party/skia@731eaa372a59 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I37717d46b9ac429c77e368755e5b5ed21e6f0edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648580}
-
Ken Rockot authored
This change allows message pipes to be "spliced" into other message pipes, unifying their message queues while retaining their logical independence for routing of written messages. This is supported by adding an array of per-handle options and flags to MojoAppendMessageDataOptions. If a handle is marked with MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, sending that message will effectively cause the handle and its peer to be spliced into the sending pipe. See bug for design doc link. Bug: 941809 Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648579}
-
Yu-Hsuan Hsu authored
The OutputDevice will try to connect to CRAS server when it is created. If we create the OutputDevice too early, CRAS server may not be ready yet so that the connection will fail. It causes this audio dispatcher turns to use fake device. To fix this problem, we can make the OutputDevice created when starting playing. Bug: 847212, 948806 Change-Id: Ib06f0d2db659f3081df28e2c5c40793a25e988b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556655Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Auto-Submit: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#648578}
-
Tina Wang authored
Add "Send Link to Your Devices" option to link context menu. - Add item before "Save Link As..." option. - Add separator to make it a separate section. - Add icon to the option works both in light mode and dark mode. The option will be enabled when the link url is valid (When it is http or https, not chrome native page). Add Histogram metrics. Screenshots: https://screenshot.googleplex.com/kNDVRRnFQpw https://screenshot.googleplex.com/6wChJm0ijkA https://screenshot.googleplex.com/0NpXU25vzY0 Bug: 939512, 945988, 948817 Change-Id: I31e3d2d1ffb579ceeee516300a7e367d7667dd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547938 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#648577}
-
Frank Liberato authored
This reverts commit 58ec016f. Reason for revert: crbug.com/950384 Original change's description: > MCVD: Remove shared image pool. > > Remove shared image pool which was used to manage shared image > destruction when video frame is destroyed/released or command buffer > stub is destroyed. This pool used to observe command buffer stub > destruction to clear the shared images. > > With this CL, shared image stub will now destroy the shared images on > video frame release callback. There is no need to observe command buffer > stub destruction or do anything on shared image stub destruction since > shared image stub destruction causes all shared images to be destroyed > in its destructor. > > Bug: 900963 > Change-Id: Ib03af245b6feb3d54d0f4e38a94a2700c600fd5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546360 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648432} TBR=liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950384 Change-Id: I1fa29a92435a649a11141b7cdf970b4152874cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557735 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#648576}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/951182bd19dc..a4fe0db08d90 git log 951182bd19dc..a4fe0db08d90 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0e3d328ac338..4ba1911b2d7f (14 commits) Created with: gclient setdep -r src/third_party/skia@a4fe0db08d90 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I75061c5d4689cf17a0ad2156debf8527efcd79bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556442Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/201a148bbf47..10e320433533 Created with: gclient setdep -r src-internal@10e320433533 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I3ebd12bd89734a45b3ee92592d1deb81eeee7094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648574}
-
Samuel Huang authored
This reverts commit 07619eb1. Reason for revert: Speculative revert for "Linux Chromium OS ASan LSan Tests (1)" failures in unit_tests related to extensions. Original change's description: > Clear inapplicable disable reasons for component extensions > > This change ensures that all component extensions are allowed to be activated despite having some inapplicable disable reasons set. > > In particular, this fixes any specific observed on-device instances where ChromeVox or tts had a disable reason of blocked by policy which prevented it from being activated. > > Bug: 946839,947305 > Test: manually. With a device enterprise enrolled, push down kiosk apps to the device from an admin console. Ensure that ChromeVox still works on all screens. > Change-Id: I2cedafeb16d4420702188f1516825ce1bad52802 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553017 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648464} TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946839, 947305 Change-Id: Icf19fe7e45c41ed559a732703844c0874c6cfdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557734Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648573}
-
Takashi Sakamoto authored
This reverts commit f8d4ff98. Reason for revert: This patch causes components_unittests failure on Linux MSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/16055 PaymentRequestSpecTest.ShippingOptionsSelection PaymentRequestSpecTest.ShippingOptionsSelection_NoOptionsAtAll PaymentRequestSpecTest.UpdateWithNoShippingOptions E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916905883293367392/+/steps/components_unittests/0/logs/Deterministic_failure:_PaymentRequestSpecTest.ShippingOptionsSelection__status_CRASH_/0 Original change's description: > Reland: [Payment Request] Add optional promise to show(). > > Originally landed in: https://crrev.com/c/1496920 > > Reverted in: https://crrev.com/c/1552254 > > Reason for revert: Browser test > PaymentRequestShowPromiseTest.CanShipAfterCheckingAddress sometimes > times out on Windows and Mac build bots. > > Justification for reland: Disabled the flaking test on the affected > platforms. > > Original patch description: > > > Spec change: > > https://github.com/w3c/payment-request/pull/672/files > > > > Intent to implement and ship: > > https://groups.google.com/a/chromium.org/d/msg/blink-dev/Lc2qCQgqqqk/NKOqwNweBQAJ > > TBR=danyao@chromium.org, yusufo@chromium.org, kenrb@chromium.org > > Change-Id: If4add36348ede9933c60b444a65a13a27ab7287e > Bug: 817073 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553170 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648493} TBR=kenrb@chromium.org,rouslan@chromium.org,yusufo@chromium.org,danyao@chromium.org,danyao@chormium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817073 Change-Id: Ic8698f290ec7aaf0ebead6aa598fffbc0f31bf3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556857Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#648572}
-
Joel Hockey authored
* Add share-with-plugin-vm and manage-plugin-vm-sharing commands These commands call through to the related FMP crostini commands and set vmName to PluginVm rather than termina. * Refactor crostini_share UI test to work for either crostini or Plugin VM Bug: 946273 Change-Id: I66a2610f0fffc33c08ccedf38ca8a7efd0e9a678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556815 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#648571}
-
Noel Gordon authored
Bug: 935285 No-try: true Change-Id: I4149d97f8bf845dc6c7e5d38e047340c4841de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556658Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#648570}
-
Takashi Sakamoto authored
E.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32600 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916783451242005184/+/steps/unit_tests/0/logs/Deterministic_failure:_ComponentLoaderTest.AddOrReplace__status_FAILURE_/0 TBR=jorgelo@chromium.org,leecy@chromium.org,stephenlin@chromium.org,abutzier@google.com Change-Id: Ib1011c9ef7b678795bf90a42c39441b419d50ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556817 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 37ca4422. Reason for revert: This patch causes content_browsertests failure on Linux MSan Tests bot: SitePerProcessBrowserTest.PageScaleFactorPropagatesToOOPIFs SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedScrollMainframe/0 TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedScrollMainframe/1 E.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/16056 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916784244150440112/+/steps/content_browsertests/0/logs/Deterministic_failure:_SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest__status_CRASH_/0 Original change's description: > Throttle Pinch-Zoom Re-Rastering in OOPIFs > > This CL implements pinch-zoom re-raster throttling for OOPIFs by making > OOPIF compositors aware of when the main-frame is active in a pinch > zoom gesture. > > It achieves this by receiving |is_pinch_gesture_active| via the > FrameVisualProperties sent to the FrameConnectorDelegate and appending > it to the VisualProperties synced from the browser process to subframes. > Then is is plumbed into the compositor along the same route as > |external_page_scale_factor|. > > An existing test for propagation of PageScaleFactor to subframes has > been enhanced to verify the value propagates from mainframe to > subframe, and from subframe to sub-subframe. Another test verifies > the flag makes it into the compositor when VisualProperties are synced > to the RenderWidget. > > Bug: 924336 > Change-Id: Ie6ed3be5e2a6c2e7fcfa2eb25a2ae40e2421fc99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483734 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648489} TBR=danakj@chromium.org,kenrb@chromium.org,alexmos@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 924336 Change-Id: Ie2b31a7b970b02f95e002778177442304274097d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557476Reviewed-by:
-
Kush Sinha authored
Please check the attached bug for context. Bug: 950258 Change-Id: Ib05f8e2c41ea07c95e639c240660af6a588af5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556833Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#648567}
-
David Staessens authored
Introduce media/gpu/test/OWNERS and media/gpu/linux/OWNERS to have more granular control over ownership. BUG=None Change-Id: I124e61e80361bd72a29b7a1daadc3b23aab4258a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553123Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#648566}
-
Noel Gordon authored
Bug: 935285 Change-Id: I567328d12eb84f721227eca4cadfc451baccd8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556956 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
The golden file contained null bytes, which made it look like a binary file. Strip null bytes from the result strings that caused that (maker and model). With that change, the command % file images.golden.hash reports ASCII text, rather than binary data. Remove images.golden.hash herein (will re-add it as text in a future change). Bug: 935285 Change-Id: Ifef49b40a8c00bc5d64f67b2a4e0728e1492f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557474Reviewed-by:
-
Katie D authored
Bug: 943703 Change-Id: I8e65b251aac54c7e70e503bb7eea4e6513b6b35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555008Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#648563}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a87523d622a..201a148bbf47 Created with: gclient setdep -r src-internal@201a148bbf47 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: Iada5fae72a5829f5945bc1a8f37efa9ef0d58355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556440Reviewed-by:
-
Anastasia Helfinstein authored
BUG=945794,949057 Change-Id: I8443144a47b987192e356a90798429ca2eaf9520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551932Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#648561}
-
Hirokazu Honda authored
This fixes a bug that I wrongly added nullptr when tested image format is RGB one. Bug: None Test: image_processor_test Change-Id: I80808a6526f9842e5a624026666d08fc028d21e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557654Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5dbcaa113103..2a87523d622a Created with: gclient setdep -r src-internal@2a87523d622a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I9cd6ab5f281e84fe58f32d20dfa5074428eae279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557539Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib1bcca396e093ab93a94c8eb31c9370b4352ff00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557538Reviewed-by:
-
chrome://drive-internalsSam McNally authored
Bug: 950375 Change-Id: I5104ef55135ece81e7adbb409c077a2e2c19250e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556814 Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#648557}
-
David Benjamin authored
C++14 extends std::set to fix the std::unique_ptr problem. No sense in paying an O(N) removal when we have a std::set. Bug: none Change-Id: If5319386b501cb9e4cd5863c82dfc3a2313c012c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534698Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#648556}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a6a2b2410e5..5dbcaa113103 Created with: gclient setdep -r src-internal@5dbcaa113103 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: Ife2a52664b3a44188c85df91231f8dbf286c9134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557537Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fd90040f0ae..0a6a2b2410e5 Created with: gclient setdep -r src-internal@0a6a2b2410e5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: Ib89cb10c5fd87d622f7731994f3b124df66d88ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556400Reviewed-by:
-
- 07 Apr, 2019 9 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a32ee20da458..7fd90040f0ae Created with: gclient setdep -r src-internal@7fd90040f0ae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I2f73ffd4484852a2fe748ec05d5cd5ee0788fa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557536Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a5d2e8a. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296 "Revise tests for datachannel ID handling" 80389713 "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c91944 "Change XRRigidTransform inverse method to attrib" 421cce6c "Fix a lot of RTCDataChannel parameter checks" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874c "[WPT] Fix JSON decoding errors in referrer-policy on Safari" fcd2c80d "Parse values in feature policy declarations." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I37b17e4de65cb9aef657ae51cf7af859fba1421d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556438Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648552}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6dbeba7c1d17..de64cb214d81 git log 6dbeba7c1d17..de64cb214d81 --date=short --no-merges --format='%ad %ae %s' 2019-04-07 manojgupta@google.com cros_setup_toolchains: Add llvm-libunwind to host pkgs. 2019-04-07 zhizhouy@google.com Follow-up fix for PGO builder tarball path Created with: gclient setdep -r src/third_party/chromite@de64cb214d81 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0c4d5fa93fc0df1bde44705668f4a6d63e8fa4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557535Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab02627e0b5d..a32ee20da458 Created with: gclient setdep -r src-internal@a32ee20da458 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I717803a6f222267203fba79288233b5b50a992fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557534Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51070715. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296 "Revise tests for datachannel ID handling" 80389713 "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c91944 "Change XRRigidTransform inverse method to attrib" 421cce6c "Fix a lot of RTCDataChannel parameter checks" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874c "[WPT] Fix JSON decoding errors in referrer-policy on Safari" fcd2c80d "Parse values in feature policy declarations." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a80586e04013c259e053c8416c1481ef7ecd000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556437Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3cf58439ae2..ab02627e0b5d Created with: gclient setdep -r src-internal@ab02627e0b5d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: Idc9243185d0b62f43d6e7b60b46d21f320b7a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556736Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I35b44fa0253639bb22a2ddd28503a4025c2decd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557533Reviewed-by:
-
Raul Tambre authored
Reland "Reland "AudioBus: Convert deprecated uses of FromInterleaved(Partial)/ToInterleaved, remove deprecated ToInterleavedPartial"" This is a reland of e06207dd Original change's description: > Reland "AudioBus: Convert deprecated uses of FromInterleaved(Partial)/ToInterleaved, remove deprecated ToInterleavedPartial" > > This is a reland of e8e3eced > > Original change's description: > > AudioBus: Convert deprecated uses of FromInterleaved(Partial)/ToInterleaved, remove deprecated ToInterleavedPartial > > > > There is no intended behaviour change. > > > > Bug: 619623 > > Change-Id: I38a3b3b11d81fcec1278855592cde0c355c6e69a > > Reviewed-on: https://chromium-review.googlesource.com/c/1461388 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > > Reviewed-by: Yuri Wiitala <miu@chromium.org> > > Reviewed-by: Bill Budge <bbudge@chromium.org> > > Reviewed-by: Kenneth MacKay <kmackay@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Reviewed-by: Max Morin <maxmorin@chromium.org> > > Commit-Queue: Raul Tambre <raul@tambre.ee> > > Cr-Commit-Position: refs/heads/master@{#631900} > > Bug: 619623 > Change-Id: I042f271c63f591d26f8aa887781dbc51b0849a16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472677 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Kenneth MacKay <kmackay@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Raul Tambre <raul@tambre.ee> > Cr-Commit-Position: refs/heads/master@{#646812} TBR=maxmorin@chromium.org,miu@chromium.org,bbudge@chromium.org,xiaohuic@chromium.org,kmackay@chromium.org CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome Bug: 619623 Change-Id: I0d1d1ff00fc4d7fa690980819a5918f5782a8980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549417 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#648546}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a3c1051c..ff7e80ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e236d9d57e5ab257375e849e2efd6a552544cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557009Reviewed-by:
-
