- 18 Apr, 2019 40 commits
-
-
John Chen authored
Python test ChromeDownloadDirTest.testFileDownloadWithClick is flaky on Windows, and also appears to cause a few other tests to fail. Disable it for now. Bug: 946704 Change-Id: I50c91c66725eb3b548d8dafc5e62224008dcc141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572966 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#652159}
-
Jared Saul authored
Also removes dlkumar@ by request. Bug: 940042 Change-Id: Ibff06d1ada36a86bb67e546f7a17ea8517075ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568767 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#652158}
-
Tsuyoshi Horo authored
Bug: 863305 Change-Id: Ib2656fe568543688d87193c5689eecfad640b5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573301Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652157}
-
Mike Wittman authored
Provides the V8 frame unwinder to the sampling profiler to enable unwinding stacks containing both native and V8 frames. Bug: 909957 Change-Id: I2183823e49ae75b3df10a5e94ba967cdf4d694fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565464 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#652156}
-
Stefan Zager authored
When an OOPIF is hidden, by scrolling it outside the parent document's viewport, or by setting display:none or visibility:hidden, then the iframe process stops running lifecycle updates, and IntersectionObserver notifications are not generated. That means that an IntersectionObserver running in the iframe process will not get a "not intersecting" notification until lifecycle updates resume. With this change, IntersectionObservers are forced to run when an OOPIF is hidden, so that the "not intersecting" notifications will be generated without waiting for a lifecycle update. Adding LocalFrame::WasShown and LocalFrame::WasHidden revealed another latent bug -- LocalFrameView::visibility_observer_ was not turned off in LocalFrameView::Dispose. As a result, it continued generating notifications and sending IPC's to the browser, even after the LocalFrameView was disposed. This is a problem with OOPIF's, because all iframe's are initially created as a LocalFrameView and later converted to a RemoteFrameView. The initial, temporary LFV would start up its visibility_observer_, which would continue pumping out notifications that were redundant -- and sometimes conflicting -- with IPC's sent from the RemoteFrameView. This bug only became apparent when writing the test included in this patch, which was flaky until LFV::visibility_observer_ was properly shut down in LFV::Dispose(). BUG=941231 R=dtapuska@chromium.org,kenrb@chromium.org,chrishtr@chromium.org Change-Id: I9c78742930c1829c49998b6f0212d58292fda57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568200Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#652155}
-
Eric Stevenson authored
This reverts commit 9ba66d45. Reason for revert: Might be breaking Chromium tree (crbug.com/954179) Original change's description: > Roll R8 and D8 1.4.14 -> 1.5.18 > > Bug: 952640 > Change-Id: I70eb96b3c7ba10df0ecc448316d87a5869a3e3cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567895 > Commit-Queue: Sam Maier <smaier@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650945} TBR=agrieve@chromium.org,smaier@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTREECHECKS=true No-Try: true Bug: 952640, 954179 Change-Id: Ib4143b32944fd6bdfa868abd89099d04040a7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573803 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652154}
-
François Doray authored
This reverts commit 19d0ffa5. Reason for revert: https://crbug.com/954186 Original change's description: > Add UMA for sync favicons in history WebUIs > > We add metrics to evaluate sync's usefulness in helping obtain favicons > for chrome://history and chrome://history/syncedTabs that would not be > available locally. > > Bug: 948109 > Change-Id: I38b527ffd3c0efb9c452d84e1c44c465b1234cec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561112 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652116} TBR=dbeam@chromium.org,treib@chromium.org,bcwhite@chromium.org,pkotwicz@chromium.org,victorvianna@google.com Change-Id: Iad91033532d7ad64026acc57b5148fe238b6746f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948109, 954186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573654Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#652153}
-
François Doray authored
This reverts commit 5432d3b6. Reason for revert: https://crbug.com/954186 Original change's description: > Add UMA for sync favicons in recently closed tabs menu > > We add metrics to evaluate sync's usefulness in helping obtain favicons > for the recently closed tabs menu. > > Bug: 948109 > Change-Id: I88958d41925dc9bab93d1714a0b4e56e88b10c17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564995 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652119} TBR=pkasting@chromium.org,dbeam@chromium.org,pkotwicz@chromium.org,alexilin@chromium.org,victorvianna@google.com Change-Id: I0733c533373c6694526a420d43d4e0ea27356af5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948109, 954186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573655Reviewed-by:
-
Owen Min authored
Remove the future flag for the policy. Update its description for more details. Bug: 749530 Change-Id: I8a99841f7f199c2d4107b7e9bfd044b0da508a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572582Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652151}
-
Sébastien Séguin-Gagnon authored
That way they can be re-used across platforms. Change-Id: I0084406679383c8a1e3e38dc040da3047e6a5d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573643Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652150}
-
Moe Ahmadi authored
TBR=marq@chromium.org Bug: 905816 Change-Id: Ie09aaf467a0025f0a9d74f091c12890d10b85b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566386 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#652149}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/html. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ie8619416d0d0b52aa9125556262749cf244f2c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571660Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#652148}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f10193dfe8a7..b61a710409a4 Created with: gclient setdep -r src-internal@b61a710409a4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I20c2bfc0c2457b460a8e5fedd305933d29752657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572687Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652147}
-
Jonathan Backer authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1572098 TBR=piman@chromium.org Bug: 935980 Change-Id: I63a24b963390209a60fda2fbf5c8d897473f1c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572657Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#652146}
-
Elly Fong-Jones authored
This file only lists pinkerton@ (on the iOS team for some years now) and spqchan@ (no longer on Chromium). This directory should just use the parent OWNERS list instead. Bug: None Change-Id: Idfd381759b8c7f7124a644b7a0ec81a31a8c4458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573645 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Alexander Timin authored
- Reset all features on document navigation. - Upload features once per task. - Use std::bitset. - Remove unneeded functionality from PageScheduler. R=haraken@chromium.org,kinuko@chromium.org BUG=933147 Change-Id: Ic5866181ece8963069741dda1a20ba707e265793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566331Reviewed-by:
-
Joshua Pawlicki authored
(...except for all these tests.) Bug: 740715 Change-Id: Ic2a480fe5ae8226f2ab1bb2a389e91850647626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557432Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Peter E Conn authored
This change is apart of a larger sequence of CLs for implementing notification delegation auto-enrolment. See https://crbug.com/945258. Specifically this change hooks up the plumbing put in place in https://chromium-review.googlesource.com/c/chromium/src/+/1554676 . Bug: 949146 Change-Id: Ib4be244acb751c28ab9dc7c1f46d9694b83b071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572127 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#652142}
-
Bo Liu authored
Add plumbing code in ChildProcessConnection to pass an extra instanceName parameter from constructor to bindService. Nothing uses it right now but it is allowed to be null. Bug: 953307 Change-Id: I74b5a879be4bff6e2742a1aecfa0c0871a948270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572544Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652141}
-
Olya Kalitova authored
Changes PluginVm setup flow strings according to the design deck. Bug: 931702 Change-Id: Ica783eb7de36fbf6640f8a103ac0be933012fc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566341Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#652140}
-
Elly Fong-Jones authored
This flag is used mainly by the ChromeOS UI and graphics teams to debug animation issues. This change assigns it to members of that team and marks it to never expire. Bug: None Change-Id: I18053c6ddccc959f27f9d03a339f3553e90664c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570489 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#652139}
-
Peter Wen authored
5a94b550008d [lss] add third_party/lss/lss to .gitignore 7411c8354baf [fuchsia] use source_set for C FIDL library 0c618f8317c4 [fuchsia] define zx and fidl_base in their own source_set 83f6f43d8105 [fuchsia] allow generation of C++ bindings for FIDL dependencies 77b2b2f1d008 [fuchsia] change attachments from filepaths to VMOs 5081a90207ec [fuchsia] delete old way of passing attachments ad49fcfad60d directory_reader_posix: more verbosity in PLOG e50676dcf243 Switch all string-number conversion to use fundamental types, and add long to the list 1c78fe23bd90 Update doc/developing.md with linux details c31a86a340f3 linux: Identify requesting threads a7859e9bc63e Add ExceptionSnapshotMinidump Bug: 894027 Change-Id: Ib67c6760cdc964414e3961d98d583ba09402da5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572655 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652138}
-
Olivier Robin authored
If the controller is closed before initialization is done, the controller will be detached and this can lead to a crash. Bug: 951580 Change-Id: I32042f43b25742a07b4593a04a9f98f971afedc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569018 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652137}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/546cc453efd0..2c5386eab92a $ git log 546cc453e..2c5386eab --date=short --no-merges --format='%ad %ae %s' 2019-04-16 dschinazi Prevent crash in EncryptInPlace when the encrypter is missing 2019-04-16 danzh Platform-ize epoll_export, epoll_ptr_util. Make code chromium compatible. gfe-relnote: (n/a) refactory, code clean up. 2019-04-16 quiche-dev Internal QUICHE change 2019-04-16 quiche-dev Add functions to enable/disable QuartcPeer and obtain the last sequence numbers sent by each of its sources. 2019-04-16 quiche-dev Create a test utility for sending and receiving data from QuartcDataSources. 2019-04-16 danzh gfe-relnote: n/a (quiche clean up) Switch to QUIC_LOG from LOG. Remove unused argument. 2019-04-16 bnc Fix "recevied" typo in //third_party/quic/core. 2019-04-16 dschinazi Print non-printable QUIC tags as hex. 2019-04-16 fkastenholz Remove OnApplicationClose upcalls, update OnConnectionClose as needed. 2019-04-16 fayang gfe-relnote: In QUIC, enforce packets be ACKed in the correct packet number space. Protected by enabling multiple packet number spaces. 2019-04-16 bnc Remove unused local variable. 2019-04-16 bnc Remove unnecessary QuicStreamPeer methods. 2019-04-16 bnc Add max_header_list_size argument to QpackDecodedHeadersAccumulator constructor. 2019-04-16 bnc Implement EXPECT_THAT(QuicHeaderList, ElementsAre()). 2019-04-16 bnc Remove unused QuicSpdyStream::unacked_frame_headers_offsets() method. 2019-04-15 bnc Add expect_final_byte_offset argument to CopyAndValidateTrailers(). 2019-04-15 danzh gfe-relnote: n/a(test only) Switch to use unordered_map instead of hash_map for platform compatibility. 2019-04-15 quiche-dev Project import generated by Copybara. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Manually update quic_flags_list.h to include new flags defined in above. R=rch@chromium.org Change-Id: I9ba383b8d75c94d997619b99bf107d903285ab9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571011 Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#652136}
-
Ulan Degenbaev authored
This feature is superseded by the new OOM intervention. Bug: 953649 Change-Id: I8aa6a6f409b12d1b302aea05c408d713a7c30146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570826Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652135}
-
Sam McNally authored
Bug: 950826 Change-Id: I968abc9bdfdddd5f6050aaacfcfe903714782733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567546 Auto-Submit: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652134}
-
Sigurdur Asgeirsson authored
Also add sequence checking to ProcessMemoryMetricsEmitter to avoid this sort of regression in the future. Bug: 953597 Change-Id: I6b6d9b7ec7759644a84752aeb6e215ec4e152c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571013Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652133}
-
Robbie Gibson authored
Before, these methods passed around url and virtualURL to show which page to load. However, I want to add some code that will conduct a search-by-image coming from app startup, which requires post data. As post data is stored in UrlLoadParams and that contains all of the data already being passed around, use that instead. Bug: 952939 Change-Id: Ided1a8a212d6294e910480f1505d3bb5ec7785d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569945Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#652132}
-
Jordan Demeulenaere authored
This is a reland of 1cecb81a Original change's description: > [Autofill Assistant] Introduce AssistantActionsCarouselCoordinator. > > This CL introduces a new carousels in which we display actions. > > Video: go/aa-carousel-v2 > > Change-Id: Ib8f61e13bda91f796c9c5741e217edcee0599a19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565002 > Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651911} Change-Id: Ia6b9ac466a9ce97e7c5aa45772ec925faf0e4f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573618 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#652131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a61595eaf3b1..f10193dfe8a7 Created with: gclient setdep -r src-internal@f10193dfe8a7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I54c781cab99053618549d8d641066a6582ffb2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573357Reviewed-by:
-
Mikel Astiz authored
Prior to this patch, random GUIDs were used for prepopulated search engines, which relied on a best-effort matching on the client side to avoid duplicates. This usually works well, except in rare cases like two clients enabling sync simultaneously, or slowness in the sync server. After this patch, the GUID for prepopulated search engines is generated deterministically based on the ID present in the JSON file. This means the more robust sync's built-in mechanisms for dedupping (namely the client tags) guarantee that prepopulated search engines do not get duplicated. The patch is believed to fix flakiness in sync integration tests, namely all tests in suite TwoClientSearchEngineSyncTest. Bug: 953711 Change-Id: I8d96d81a25a51f16d57fd70fee10ce2eae633876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572345 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652129}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/html. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I9bb9edba1d507315231d6a461b18124a609b323e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572130Reviewed-by:
-
François Doray authored
This reverts commit 2410dcb9. Reason for revert: Bug 954134 Original change's description: > [iOS][Alert] Add alert controller to Showcase > > Bug: 951301, 951300 > Change-Id: If0af93103f0038ad35770cee09b94b455aeca92b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561109 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652122} TBR=edchin@chromium.org,javierrobles@chromium.org Bug: 954134 Change-Id: I4f4d441cf3fa9ea5651a0b0bc01ef41e9bd0f277 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951301, 951300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573639Reviewed-by:
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/html. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I76fd023dc5f31f3bd90c488a850b4e55cf980617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571700Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59b57bd2. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" c1940432 "[WPT/common/security-features] Merge subresource path construction" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I0093bb2eb81b2b081fe8ca070b0b22341496f054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572654Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652125}
-
Leon Scroggins III authored
Bug: 953747 - remove patches/0000-plte.patch, which has been integrated into upstream - update README.chromium to remove references to the patch - reapply 0001-chunkerror.patch and 0002-fuzzeroom.patch - apply https://github.com/glennrp/libpng/pull/285 for ARM64 clang-cl build Change-Id: I0aa5e552b09309da4e65dbd0b9d6be5327b329e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570916 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652124}
-
François Doray authored
This reverts commit 012bea0a. Reason for revert: bug 954124 Original change's description: > [autofill assistant] Introduce small delay between key presses. > > Introduce a small delay between key presses while simulate_key_presses > is true. This hopefully will allow any JS from the website to have time > to process the events. > > Bug: b/124505757 > Change-Id: I3ab90bde3434043ae9988a9e0b7ff43fdf6e86fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567920 > Commit-Queue: Hui Wu <wuandy@chromium.org> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Cr-Commit-Position: refs/heads/master@{#652013} TBR=wuandy@chromium.org,arbesser@google.com Bug: 954124 Change-Id: I59b4f98d6e7e62aca98f09720d5835c36b07e7fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/124505757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573638Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 951301, 951300 Change-Id: If0af93103f0038ad35770cee09b94b455aeca92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561109 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
If wait_for_windows_closed is true, the task will be taken out of the queue until all windows for the placeholder app are closed. Once all windows for the app are closed, the task will be added to the beginning of the queue. Replaces stop_if_window_opened because that option is no longer needed. Bug: 844278 Change-Id: I76725d353a5d195ce00e2fed2167d14e1e0d13c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572760 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#652121}
-
Pavol Marko authored
Make GetFRERequirement easier to understand by explaining why the serial number is checked. The new comment is based on the original comment from https://chromium.googlesource.com/chromium/src/+blame/87b65e9b67790efd6aaa2201bbee4485f9015dca/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc#59 Bug: none Change-Id: I65202c838fd11f38aa7543954f7451cbf2bfdf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571698Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652120}
-
