- 08 Oct, 2020 40 commits
-
-
Yi Gu authored
This patch adds SmsFetcher::Subscriber::OnFailure(FailureType) to capture SMS parsing failures (this patch) and prompt timeout/cancelled failures (follow up). We also record the reason why an SMS is not parsed. The metrics can help us to quantify the level of unexpected SMSes. UKM collection review: https://docs.google.com/document/d/15orQiLx06QSuZr4ShBaozY0dvPzXiTWwJZ9Xk5cgzAA/edit?usp=sharing Bug: 1126266 Change-Id: I59214e2be64677dae1c9f0b47c2154eefeb1207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424542 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#815021}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f09b0b11305f..6f4898e52832 2020-10-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I303e56281f2fa77829184f34e2d1b5f1517f637e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815020}
-
Andrew Grieve authored
Change-Id: I6ee9728be16e04f62982258323f00cf91bb35589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460227 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#815019}
-
Daniel Ng authored
Will followup this CL with actual usage (launching the VM when installed) when CL:2435028 and CL:2454952 land. Tests: Wrote and ran tests. Tested on DUT. Bug: b:168763038 Change-Id: Ifdc10dc269515ba78c54950d455e34133624aa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454914Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#815018}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b603fae..c942e1b7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0efacbabd250ce3b52c017fff64069d79c9d31ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459088Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815017}
-
Takashi Sakamoto authored
For 64bit chrome, we are able to reserve a large virtual address space pools and to allocate/deallocate a part of address space from the pool. However for 32bit chrome, we are not able to reserve such a large virtual address space. It causes out of virtual address space (OOM). So we wrap AllocPages and FreePages inside PartitionAlloc by AddressPoolManager, and update bitmaps by using returned address space (by AllocPages) and freed address space (provided by FreePages' arguments). The bitmaps' sizes depend on the alignment and the number of pages when PartitionAlloc allocates. Regarding the alignment, kSuperPageSize. Regarding NomralBucket, for DirectMapped, multiples of PageAllocationGranularity(), and for NormalBuckets, kSuperPageSize. So bitmap sizes are 4GiB/kSuperPageSize bits and 4GiB/PageAllocatoinGranularity() bits (kSuperPageSize is multiples of PageAllocationGranularity()). Change-Id: I84778fb113df1af2b4ce2a181fc3ae08d9041d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418496 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815016}
-
Vladislav Kaznacheev authored
Set expiry for Accessibility.CrosShelfNavigationButtonsInTabletModeChanged.* at M91. Fixed: 1088526 Change-Id: Ide9b07ec83596a77d316538aa630e9188cb16d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449936Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#815015}
-
Eric Willigers authored
Desktop PWAs without Extensions (BMO) has shipped. The test no longer needs to be parameterized. Bug: 1065748 Change-Id: I410e0eaec8a18e0232155214b29bf22c79bdf07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459257 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#815014}
-
Klaus Weidner authored
Add some debug logs for WebXRPresentationState debugging in preparation for a refactor. Also log the expected frame number for GetFrameData to make event traces easier to follow. Change-Id: Ifc796b72c4173532fbd6f8fe3bde65a522a192a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458881 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#815013}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601358844-5f86e8497cfc6487ab81eec807b8b1aeda6b4d6d.profdata to chrome-win64-master-1602104345-4733e14208bb636a7ce6e80f22bf814b0d8103be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3a149d213f4b1ea785561c73f967475916e139cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459896Reviewed-by:
-
Mike Jackson authored
Removes the parameterization for AppNotificationsWebNotificationTest, now that kDesktopPWAsWithoutExtensions flag is always true. Bug: 1065748 Change-Id: I38497fb7460f2bc39b94fb7fdb22b6784ea44feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455246Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815011}
-
Risan authored
The unlimited map size is potentially causing OOM (and there are evidence that it might caused OOM). Here, the size of the map is limited to the max size of inotify event queue since it we are degrading our support for when we have too files more than the inotify events anyway. BUG=1134755 TEST=Decrease the limit and print the map size to see the capping work. Change-Id: Ifcaecde655afaf2d44ab48cef5701b9ee7fca8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456726Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815010}
-
Makoto Shimazu authored
This reverts commit 0d3b1f9c. Reason for revert: This seems to make ClipboardTest/TestClipboardTest.ReadAvailablePlatformSpecificFormatNamesTest fail. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/2950 Original change's description: > Reland "ozone: fix expectations in clipboard test" > > This is a reland of a60f7247 > > Original change's description: > > ozone: fix expectations in clipboard test > > > > In case of Ozone, we support more types. > > > > Bug: 1134495 > > Change-Id: I9712931545c8b70a1a0357d5b119b8c9a7c08c4e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443650 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#814303} > > Bug: 1134495 > Change-Id: I5849855e3fd037dc7eb34d0b94bbc08b6246b234 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454051 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#814742} TBR=sky@chromium.org,msisov@igalia.com Change-Id: Icd2d1a2e10e177bcbe85b66dd446fa2e8ed689ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460367Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815009}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/068617d6cfea..36ccb695bd6b 2020-10-07 geofflang@google.com Ensure a CGL context is current for WindowSurfaceCGL. 2020-10-07 timvp@google.com Skip GLES1ConformanceTest.SpotExpDir for Win+Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1136238 Tbr: timvp@google.com Test: Test: GLES1ConformanceTest.SpotExpDir/ES1_Vulkan Change-Id: I30681edc2aef64df7d578838150aae26551a4a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459894Reviewed-by:
-
Zach Trudo authored
CloudPolicyClient will be expanded to make use of a new server endpoint. This change prepares BrowserPolicyConnector for that eventuality. Bug: chromium:1135951 Change-Id: I30ffd427dbcb21399249fba80a394c3de9689c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453345Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#815007}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Icd7bd4002894051f697815bdd6207f19819f5ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459901Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: If4723b5f1ddeabeb9d379a292f382870550cec01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459902Reviewed-by:
-
Clark DuVall authored
This change converts GCM service classes, and adds new SplitCompat services for GcmTaskService and GcmListenerService. Review from Patchset 1 to get the right diffs on the changes in the Impl classes. Bug: 1126301 Change-Id: I2bdb1f8c1b8ccefd45bfb786a9190970db9d8f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459207Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815004}
-
jongdeok.kim authored
Due to flash removal in M88, remove |force_use_property_tree_builder_| and related logic. Bug: 925855 Change-Id: Ia9826e35ea3c3e70fb235fba916aeeeed7d95ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449840Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#815003}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1334f20f4cc..b9eab31a99bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134473 Tbr: shimazu@google.com Change-Id: Icad5e96dec84df8aca244be49b7879d36ebcc652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459895Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815002}
-
Clark DuVall authored
This service extends RemoteViewsService, so a new SplitCompat equivalent has been added. Review from Patchset 1 to get the right diffs on the changes in RemoteViewsServiceImpl (there are a few git cl format changes). Bug: 1126301 Change-Id: I6a800b7fa7191b238424b1f5476afb5d83e41717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458908Reviewed-by:
-
Gavin Williams authored
Change text color from Google Grey 500 to Google Grey 700 to adhere to a11y contrast ratio guidelines. Before: http://screen/4bELSswAmDVB8b7 After: http://screen/755GaSLQ5idytTS Fixed: 1111978 Change-Id: I33d9abb9b65d5bb400618219acb97804914d9fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458810Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#815000}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I31086c49dc7c159ca7a633b61f1cf6599b830a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459089Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602093472-3c443a4dbd74a5652b0b36774f0b190723e63d12.profdata to chrome-linux-master-1602115190-7131f9189957170a35177f66dc087c48158aec91.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibea4babdd0c6b67c53d39ce7f4693620fbf4574d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459900Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/3b5d31305f58..71f3a45238af 2020-10-08 rwkeane@google.com [Discovery] Avoid both positive + negative response in a message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iceeb6a17f7864cc470deb5ea09a71592b40e22be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459190Reviewed-by:
-
Prakhar authored
The experiment has been concluded and coverage would be enabled on mac-rel itself Bug: 1024915 Change-Id: I13b998b5261b9720437a42d387ce29fbc73b9e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440082 Commit-Queue: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#814996}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8baaabfc1b53684f233196dc83dc52fb41539c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459898Reviewed-by:
-
Mei Liang authored
This CL mainly focus on moving the onOverviewModeStateChanged() signal out of the OverviewModeObserver interface. That signal only matters when StartSurface is enabled, so the signal is merged to StartSurface.StateObserver.onStateChanged. With the above change, this CL allows features to attach the StartSurface.StateObserver to StartSurface via the ObservableSupplier pattern. In addition, this CL renames OverviewModeState to StartSurfaceState. Change-Id: Iebaa907fca4baf6a1fee819b31fbd57370126dbc Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315823 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#814994}
-
Makoto Shimazu authored
This reverts commit d22c8914. Reason for revert: This test continuously fails on linux-chromeos-dbg. Sample build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20743 Original change's description: > Switch Access: Add test for keyboard node. > > This change adds a test to ensure Switch Access state gets updated > when the virtual keyboard is opened and closed. > > Fixed: 1135248 > AX-Relnotes: N/A > Change-Id: I1b894bce635f1790cee1111f50992c9136d3ded7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453899 > Commit-Queue: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814745} TBR=dtseng@chromium.org,akihiroota@chromium.org Change-Id: Icafd07fedf3f65fb637e8383aaaf57457efc709e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459698Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. Tests like ShelfAppBrowserTest no longer need to be parameterized. Bug: 1065748 Change-Id: I42616fdd0d22d8f9b96bac88bd71269045737fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454777 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#814992}
-
Maggie Cai authored
This CL: - Update the installation of test arc app and PWA to allow actual app launch. - Add test callback in intent picker bubble view for bubble shown. - Update the tests to test show bubble on icon clicked. - Update the tests to test arc app and PWA launch. - Update the PWA only test case to work with kIntentPickerPWAPersistence flag. These changes also make the test for app preference and the test for desktop version intent picker bubble possible. There will be follow up CLs to add these tests. BUG=853604 Change-Id: I11a1b98d3005d5ac9c00408ac9c99d7fa968fc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439996 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814991}
-
Daniel Hosseinian authored
Resolution (aka DPI) support can already be read from PPDs and through IPP. Therefore, the options are already shown in Print Preview. However, the user's resolution option is not passed to the print job. Use PMPrinterSetOutputResolution() from the Core Printing API [1] to programmatically control the output resolution. While only supported resolutions will be passed to the job, the API also matches the passed in resolution to the closest resolution setting supported by the destination. [1] https://developer.apple.com/documentation/applicationservices/1459931-pmprintersetoutputresolution Bug: 123124 Change-Id: I836ff21a052c7a8a6cf27dbe4dd02de19f3c85ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459129 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#814990}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602093472-1d23f3e20a4e345891a53ac8f50b5338bb0c8ae6.profdata to chrome-mac-master-1602115190-6522495ca352d45be49e234f0c6bf7d20bdcb906.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7fc72acd65d6a7e9ab175e8db274fc2191afe4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460106Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae1f2502..7b603fae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3392663dd0124ea78c0fd4a360aaa48b40505c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459707Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 6860e109. Reason for revert: Speculative revert to fix fast/frames/iframe-scaling-with-scroll.html. https://crbug.com/1136335 Original change's description: > Limit minimum scale of PaintedScrollbarLayer to 1 > > This is to avoid too low scale when animating scale above the > scrollbar layer. > > This is not ideal. In the future we should move rasterization of > scrollbar layers to impl-side to better handle scales > (crbug.com/1009291). > > Bug: 1133997 > Change-Id: I3364754f530914816fe8526c627e6cf12e7942ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453436 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814681} TBR=wangxianzhu@chromium.org,bokan@chromium.org Change-Id: I4554c428bcc5a3d5fef9033e6772f53932d0e256 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133997, 1136335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459087Reviewed-by:
-
Samuel Huang authored
This reverts commit a4d34d8a. Reason for revert: This causes chromeos-amd64-generic-lacros-builder-perf to fail, likely due to missing eu-strip. Original change's description: > [Lacros] Size dashboard: Track stripped size of ELF files. > > This CL modifies lacros_resource_sizes.py to identify ELF files, and > also track their stripped sizes (using eu-strip) as well as compressed > stripped sizes. These news info are recorded for chrome and the Total. > > If eu-strip fails for a file then we simply ignore its stripping > results and print warning. Known-bad files include .nexe files and > libwidevinecdm.so. These are explicitly excluded to denoise the system. > > Bug: 1106626 > Change-Id: I9cb47bb41baa2b73996e6662db2fe4bc537338d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458869 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814972} TBR=huangs@chromium.org,erikchen@chromium.org Change-Id: I580c4ea4a125fef785cdb0c6de1c31846a7e8180 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459794Reviewed-by:
-
Xiaoqian Dai authored
In different capture mode type and source, we may show different icons/ messages in middle of the screen or in middle of the captured region and prompt the user to do the next step. And in video recording scenario, this message will transform into a 3-seconds countdown timer before starting video recording. This CL implements - showing different icon/text message in different scenarios - showing a 3-seconds countdown UI before video recording Animation is not implemented in this CL and will be addressed in a following CL. Bug: 1126669 Change-Id: Id07b4c1137eb77946695899603ae43aeda84c643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439778Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#814985}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7c1a3543d64eb534e89eb631f0ee64f897be8ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459892Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3419b3b485ba..9fb07662e436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifcd18a2ee715f3c144b2d38d3ce08e1602311e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459791Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e20d8219. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I6bf865b599ed9b7e6a6cd38c60bf8d57e4e75b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459171Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814982}
-
