- 22 Jul, 2019 40 commits
-
-
Cammie Smith Barnes authored
When there is no network service, we disable the PlzDedicatedWorker flavor of the following tests in *WebContentsSplitCacheBrowserTestEnabled* because network service is required in order to enable PlzDedicatedWorker. Bug: 983981 Change-Id: Ie2af5f7671855c2a7e4f2b7c336b07af44ee6a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710705 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#679548}
-
Yi Gu authored
The test has been flaky recently. Suspecting crrev.com/c/1686728. See bug for details. TBR=rsesek@chromium.org TBR=mark@chromium.org Bug: 986288 Change-Id: I6ddcf1b675871db30e786c0e152debe1a8fdd786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712048Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679547}
-
Robbie Gibson authored
On iOS 13, we can achieve this by using the overrideUserInterfaceStyle property to force the toolbars into dark styling. Then, all the UI elements can be the same UIColor in both modes (because that color is dynamic). This does not fix the problem for iOS 12, which will come in a later CL. Bug: 976643 Change-Id: I76eb50f6484f7ac9a846fb8cb50e5ffc46c0f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709322Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#679546}
-
Javier Ernesto Flores Robles authored
Bug: 976671 Change-Id: Ib7d0255bb5a21ca3ee3e1109d6a9bbf83dc9687d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700204Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#679545}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39483c66626c..6982f6091b5c git log 39483c66626c..6982f6091b5c --date=short --no-merges --format='%ad %ae %s' 2019-07-22 mbonadei@webrtc.org Remove empty OWNERS file. Created with: gclient setdep -r src/third_party/webrtc@6982f6091b5c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I29512036676dd1358feade7a82f1f50c42088c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679544}
-
David Benjamin authored
Also a MockSSLConfigService can be replaced with SSLConfigServiceDefaults. Trim some of the easy bits away from another humongous CL. TBR: alph@chromium.org Change-Id: Ib9e107b9f1709e9864ea32158a1ff3d3e0c595e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709169 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#679543}
-
Tanisha Mandre authored
The delete button now appears only while in edit mode. Bug: 984567, 984933 Change-Id: I8ce137f03ac43a4a5289d895863cbd122b1eb75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704104 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/257650935 to client. Change-Id: If2e6077cc9087724ce800089fc2f5db342e7c5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702412Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#679541}
-
Yi Gu authored
The three tests are slow on Win10 as well. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBmYXN0L2NhbnZhcy9jb2xvci1zcGFjZS9jYW52YXMtY3JlYXRlSW1hZ2VCaXRtYXAtZV9zcmdiLmh0bWwM TBR=juanmihd@chromium.org Bug:983642 Change-Id: I55feb35f13ed1af9237aa2d8fe712137d20582d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713028Reviewed-by:
-
Jessica Tallon authored
Currently AtkObject are often created before the ax::mojom::Role and other information is available or stable. This causes the AtkObjects to be repeatidly remade causing issues to screen readers on Linux. A number of things have been done to address the issue: 1. AtkObjects are now only created if the ax::mojom::Role information is known at Init, otherwise it's deferred until after the tree is stable. For non-UI changes this will come by AXPlatformNodeAuraLinux::DataChanged being called on each created/updated node once the update has finished. 2. We no longer call DataChanged (which checks if the AtkObject needs recreating) during a tree update which lead to objects being recreated several times during a single update (often erroneously). These changes will reduce spamming from chromium to ATK screen readers and prevent some of the dead event issues. Bug: 959650 Change-Id: I4e735e6ec62db60ebcca37a13d80951d47c5086b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670882Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#679539}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9f2236e58ed0..2bb2da919352 git log 9f2236e58ed0..2bb2da919352 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 cepheus@frii.com SPV: Update to latest SPIR-V header. 2019-07-22 johnkslang@users.noreply.github.com Merge pull request #1845 from greg-lunarg/kg105 Created with: gclient setdep -r src/third_party/glslang/src@2bb2da919352 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Change-Id: Ifb591547d656b5c67dfb0d06bc3dd04405bcd9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713026Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a36fb7e37cd7..459dcc9bf2b3 git log a36fb7e37cd7..459dcc9bf2b3 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 hjd@google.com Merge "trace_to_text: Handle unusual control characters" Created with: gclient setdep -r src/third_party/perfetto@459dcc9bf2b3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I699714d75616fd121e62cef0b0754641f326ebc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713029Reviewed-by:
-
Vadym Doroshenko authored
Bug: 986091 Change-Id: I3d1542d1dfc361f46a7870ec05410bc4660c2deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712672Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#679536}
-
Benoît Lizé authored
This is partially a revert of two commits: - 53a10113: "Delete unused file: base/android/linker/android_dlext.h" - fdb31883: "Use the LegacyLinker instead of the ModernLinker" ModernLinker has been reworked, especially the native side. Notable changes: - The library is only loaded once, not twice in the browser process - Relocations are always shared between the browser process and the other ones. This is enabled only on N+ for Chrome.apk, neither for Monochrome nor for TriChrome. on Q, further commit will trim it as well. Binary-Size: Increase due to bringing back ModernLinker. Required to save memory Bug: 979638 Change-Id: Ia76773b58a71854a36ea49ab82daef1af717b606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683245Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679535}
-
Yi Gu authored
The test is flaky due to some unexpected passes. See bug for details. TBR=yoavweiss@chromium.org NOTRY=true Bug: 986282 Change-Id: If8472002fb084d1e6d78d4e7f758077ac0e7aba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712046Reviewed-by:
-
Antonio Gomes authored
... prior to Onion souping some of the files on these directories. This is important so that we do not whitelist (via DEPS) needless header inclusions in Blink. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I43375af80f0997e1e0a2e03832c7cd445af7d5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713044 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#679533}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfa31022..5578fd9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibc64cfaa371fb0c9262b685068f952f58c309cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712944Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679532}
-
Yi Gu authored
[Sheriff] Mark test virtual/threaded/animations/web-animations/animation-state-changes-positive-playback-rate.html flaky The fast path test started to be flaky as well. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfAsSBUZsYWtlInFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBhbmltYXRpb25zL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1zdGF0ZS1jaGFuZ2VzLXBvc2l0aXZlLXBsYXliYWNrLXJhdGUuaHRtbAw TBR=flackr@chromium.org NOTRY=true Bug: 986019 Change-Id: I81933b76cb2d5f0255427cf8b01c19e2442074d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712514Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec3580361e62..39483c66626c git log ec3580361e62..39483c66626c --date=short --no-merges --format='%ad %ae %s' 2019-07-22 titovartem@webrtc.org Migrate some Vp8 simulcast and screen share tests on PC framework Created with: gclient setdep -r src/third_party/webrtc@39483c66626c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I112c92ee2ec291f10383af9b61cd6076c9355921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712904Reviewed-by:
-
Yi Gu authored
Test started to be flaky on Mac as well. TBR=majidvp@chromium.org NOTRY=true Bug: 986018 Change-Id: Ic896095e10af871eb7734f3730cfc58317475890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712513Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7f3490de0fdb1d5ca7cd7d3cff15a8252b7253ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712377Reviewed-by:
-
Edvard Thörnros authored
One argument passed wasn't used in the body of the function, it was thus removed. This change is only a refactor commit and shouldn't change any functionality. Bug: 981522 Change-Id: Ib8a8274c44d32bc1e50f0f6541c58b288dd77b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710651 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#679527}
-
Ramin Halavati authored
EnableAmbientAuthenticationInIncognito and EnableAmbientAuthenticationInGuestSession flags are added to enable authentication without user action in incognito or guest modes. This authentication is now enabled by default, but will be disabled in a few milestones. It has no UI to re-enable and is only manageable using Enterprise policies. Bug: 458508 Change-Id: If311a6cdd6b8a94a6339e268e10f83e2004d8294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707276 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#679526}
-
redatawfik authored
-Implement Method 'handleAddPayment' which response to 'Add Payment Method' button to open New View Controller for filling new Credit Card details. -Add new view controller 'AutofillAddCreditCardViewController' for filling new credit card details -Add the title and tow buttons 'cancel/add' to navigation bar. Bug: 984545 Change-Id: I0aad64c7be3b2ab35b2f08a880c04a21b2516d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699610 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
-
Guido Urdaneta authored
The device with VID/PID 13d3:5257 has been reported to fail with MediaFoundation. Bug: 984864 Change-Id: Iedc3128d959d251022b760c5e109bb15c9ddcdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712671Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#679524}
-
Abhijeet Kandalkar authored
This is a reland of original CL 40c91bea Reverted CL: 8e10f496 Goal of original CL: Original CL 40c91bea was intended to modify assistant_manager_service_impl.{h/cc} to 1. Uses mojo::Receiver<T> inplace of mojo::Binding<T> 2. Rename member variable media_controller_observer_binding_ to media_controller_observer_receiver_. Reason for compilation error on official build : Original CL missed to 1. Replace one occurrence of media_controller_observer_binding_ with media_controller_observer_receiver_ 2. Calling reset() instead of Close() on media_controller_observer_receiver_ assistant_manager_service_impl.{h/cc} files are only enabled for the official build. Hence, errors did not occur during CQ dry run. This CL fixed compilation error and performs other improvements as below: 1. Use new mojo function BindNewPipeAndPassRemote() instead of creating new remote and binding it. BindNewPipeAndPassRemote() holds receiver and pass remote to other endpoint. 2. Use 'Class Member Initialization' instead of the initializer list. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 955171 Change-Id: I56dca2b2c9f93df4e551874604a035f7818b2b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701128 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#679523}
-
Friedrich Horschig authored
This CL changes the footer string from "Payment methods" to "Manage payment methods" which is consistent with the "Manage <stuff>" footer commands in the other sheets. Bug: 985315 Change-Id: I3c69ad350ab9c36a90d6106f06221f91ec0b25a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708949 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Robbie Gibson authored
This mostly adds new colors and uses them. One other small change is related to highlighting the fake omnibox on the NTP. Before, it was colored with alpha, so the alpha could just be changed on highlight. Now, the color is opaque, so I added another view right over the fakebox itself that changes from alpha 0 -> highlighted. Bug: 976643 Change-Id: Ie681a109f6e69846036f932cfe7dba3820aaea51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705793Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30031ca3522b..03a695c8b3e5 Created with: gclient setdep -r src-internal@03a695c8b3e5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tinazwang@google.com,horo@google.com,yigu@google.com Change-Id: Ib096f963eab40a5035528e6bebeb1fad28c0ba4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712349Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679520}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/65c898e6e26a..a36fb7e37cd7 git log 65c898e6e26a..a36fb7e37cd7 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 eseckler@google.com Merge "processor: Import thread timestamps for use_async_tts async events" Created with: gclient setdep -r src/third_party/perfetto@a36fb7e37cd7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id8d28b4f1d232cbc6aec312ae8dd31a3776d3772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712347Reviewed-by:
-
Vasilii Sukhanov authored
The current behavior creates problem for the context menu. In Chrome two menus can't be open at the same time. Because the dropdown is almost all the time open the user can't access the context menu for the text field. Even if the dropdown is closed the following happens: - user makes a right click in the text field. - EditableCombobox::HandleMouseEvent is called. - it opens the dropdown. - the textfield's menu is cancelled. Bug: 972069 Change-Id: Ib77cae34355049f4b0dfe287422d58c62cd00a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702250Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/77a40eb1..cfa31022 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c27518f4e144bc92c5aa419b573a7a9ff4e7489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712705Reviewed-by:
-
Antonio Gomes authored
... due to precision loss: FAILED: android_clang_arm/obj/third_party/blink/renderer/platform/platform/media_stream_audio_processor.o ../../{path}/media_stream_audio_processor.cc:711:47: error: implicit conversion loses integer precision: 'long long' to 'const int' [-Werror,-Wshorten-64-to-32] const int total_delay_ms = capture_delay_ms + render_delay_ms; In the expression above, |capture_delay_ms| is int64_t, while |render_delay_ms| is 32bit sized. The result of the sum is stored in |total_delay_ms|, which is int. Given that |total_delay_ms| gets passed as parameter to webrtc::AudioProcessing::set_stream_delay_ms(int) ... in [1], CL caps |capture_delay_ms| to int too. [1] //third_party/webrtc/modules/audio_processing/include/audio_processing.h Issue was observed while Onion souping various files from content/renderer/media/stream in [2]. [2] https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/313772 [3] https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/313857 BUG=704136 R=haraken@chromium.org Change-Id: I3749ca263d60005e8541bf51dbd9a392225a879c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708660 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: -
Alex Chau authored
Bug: 985783 Change-Id: I0e071d42ef8f757572b2c3b0cc9adf3223cf00bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710645 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#679515}
-
Rayan Kanso authored
As per suggestions from UXW, make it clear that recording persists and continues in the background. Also make it clear when a metadata field is empty. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c34 Change-Id: Ief7b2dc23f00767fe4e87d37b652a4b0dbb1edd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708082 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#679514}
-
Julian Pastarmov authored
Make the policy_templates_en-US.json file be captured by the liux builds. This will be used to source updates for the new cloud policy documentation http://cloud.google.com/docs/chrome-enterprise/policies/ BUG=none Change-Id: Icded9c4e1a09201f7a4dd4adc3aae43fc9881efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709372Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#679513}
-
Stephane Zermatten authored
This change refactors the Controller to make it observable. This changes the relationship between the UIController and the Controller and avoids the need to return a dummy UIController in Controller:GetUiController(). Bug: b/130761227 Change-Id: I3c5dfb428109842a805808efee431fa0033abd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702269 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#679512}
-
Takuto Ikuta authored
Test from these builders consumes less than 1 machine hour in chrome pool per hour averagely. I took the stats from http://shortn/_EstLqOoMvH Bug: 954450 Change-Id: I2213739b73c22bb3d058b9555d95eb95bb5c38b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710243 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#679511}
-
A Olsen authored
For internal reviewer: Screenshot at https://screenshot.googleplex.com/rauyQUMJQ0E.png Bug: 930109 Change-Id: I802274c4355e10f5a7f78aa12882fc35dd0eeb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708933Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679510}
-
A Olsen authored
Change-Id: Icab49d1e24c0dac2579f0de5397e645aa5f4847c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712864Reviewed-by:
-
