GitLab

BUG=423257
TEST=out/Release/browser_tests --gtest_filter=FileManagerPrivateApiTest.OnFileChanged

Review URL: https://codereview.chromium.org/658013002

Cr-Commit-Position: refs/heads/master@{#301325}

This code is being developed in the mojo repository but it unused in
chromium.

R=aa@chromium.org

Review URL: https://codereview.chromium.org/646943006

Cr-Commit-Position: refs/heads/master@{#301324}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ff95c8e..193ad3d

TBR=

Review URL: https://codereview.chromium.org/675413002

Cr-Commit-Position: refs/heads/master@{#301323}

BUG=

Review URL: https://codereview.chromium.org/675633005

Cr-Commit-Position: refs/heads/master@{#301322}

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
HTML pre tag should be exposed as follow:
MSAA + IAccessible2
Role: IA2_ROLE_PARAGRAPH

AX
AXRole: AXGroup
AXSubrole: (nil)
AXRoleDescription: "group"

This CL depends on blink side CL https://codereview.chromium.org/671003002/ (Reverted)

Re-Land CL https://codereview.chromium.org/663233004/

BUG=426053
TBR=kalman

Review URL: https://codereview.chromium.org/671033002

Cr-Commit-Position: refs/heads/master@{#301321}

liblatency_info_nacl.a will be used by libppapi for nacl_helper_nonsfi.
This CL builds the library, but it is not used yet.
It is now for just making sure it is built properly.
It will be depended on by ppapi_proxy_nacl in a later CL.

BUG=358465
TEST=Ran trybot.

Review URL: https://codereview.chromium.org/671443005

Cr-Commit-Position: refs/heads/master@{#301320}

The responsibility of EntryWatcherService has been moved to WatcherManager
implementations.

Note, that the original code was unnecesarily complicated. After replacing
the observer interface with a simple callback, there is no need for an extra
service managing watchers anymore.

This was possible because with the new design entry watchers will no longer
survive reboots.

TEST=Compiles.
BUG=261491

Review URL: https://codereview.chromium.org/642343004

Cr-Commit-Position: refs/heads/master@{#301319}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e1901b..ff95c8e

TBR=

Review URL: https://codereview.chromium.org/652403004

Cr-Commit-Position: refs/heads/master@{#301318}

libtracing_nacl.a will be used by PPAPI library for nacl_helper_nonsfi.
This CL builds the library, but it is not used yet.
It is now for just making sure it is built properly.

BUG=358465
TEST=Ran trybot.

Review URL: https://codereview.chromium.org/650593003

Cr-Commit-Position: refs/heads/master@{#301317}

The test was removed a long time ago:
https://src.chromium.org/viewvc/chrome?revision=228580&view=revision

BUG=104950
TEST=none

Review URL: https://codereview.chromium.org/647763005

Cr-Commit-Position: refs/heads/master@{#301316}

This CL moves the NamedPage enum from ContentsView into AppListModel where
it will be used as a more generic value that represents the state of the
app list.

This is in preparation of notifying code across the chrome/ DEPS boundary
of changes to the app list's state.

BUG=425444

Review URL: https://codereview.chromium.org/675053002

Cr-Commit-Position: refs/heads/master@{#301315}

It looks fixed. The bot is no longer running the test, so ran valgrind
locally.

R=yhirano
NOTRY=true
BUG=417093

Review URL: https://codereview.chromium.org/672143002

Cr-Commit-Position: refs/heads/master@{#301314}

BUG=N/A
TEST=./tools/perf/run_benchmark --browser=android-chrome-shell page_cycler.top_10_mobile --pageset-repeat=1 --report-speed-index

Review URL: https://codereview.chromium.org/671913004

Cr-Commit-Position: refs/heads/master@{#301313}

The registrations of the ServiceWorker scope outside the script directory will be restricted, as per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468.
So this cl changes the scope which is used in PushMessaging tests.

After this patch will land, I will re-intoruce the scope restriction in Blink side by reverting this: https://codereview.chromium.org/672353003/

BUG=423983

Review URL: https://codereview.chromium.org/644763005

Cr-Commit-Position: refs/heads/master@{#301312}

Revert of Enable virtual viewport on all platforms (patchset #5 id:80001 of https://codereview.chromium.org/665963002/)

Reason for revert:
This appears to break the entire world as far as LayoutTests are concerned. Here's a small sample: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=css1%2Fbasic%2Fcontainment.html%2Ccss1%2Fbasic%2Fcomments.html%2Ccss1%2Fbasic%2Fgrouping.html%2Ccss1%2Fbasic%2Fclass_as_selector.html%2Ccss1%2Fbasic%2Finheritance.html%2Ccss1%2Fbasic%2Fcontextual_selectors.html%2Ccss1%2Fbasic%2Fid_as_selector.html

Original issue's description:
> Enable virtual viewport on all platforms except Android WebView.
>
> BUG=148816
>
> Committed: https://crrev.com/e52372c24d2e1e9785703f0563ffc3423f7161cc
> Cr-Commit-Position: refs/heads/master@{#301307}

TBR=aelias@chromium.org,mkosiba@chromium.org,cpu@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148816

Review URL: https://codereview.chromium.org/679973003

Cr-Commit-Position: refs/heads/master@{#301311}

This adds a ServiceRegistrationManager that acts as a global repository
of extensions API services to be added to RenderFrameHosts along with
the extensions API permissions that gate access to them.

BUG=389016

Review URL: https://codereview.chromium.org/652793002

Cr-Commit-Position: refs/heads/master@{#301310}

Worked for all other keys except for the media keys where CanAutoAssign would ALWAYS return true even if key was modified by user. Now no commands should be overwritten on update if they have been changed by a user.

BUG=421482
R=finnur@chromium.org

Review URL: https://codereview.chromium.org/667833004

Cr-Commit-Position: refs/heads/master@{#301309}

This CL moves the app list search box from AppListMainView into
AppListView. This sets up work for animating the start page
search box.

As a consequence, the ContentsView has been expanded to take up
the space previously consumed by the SearchBoxView's layout.

Some padding positions have changed in both app lists but the
overall app list dimensions remain unchanged.

BUG=425444

Review URL: https://codereview.chromium.org/657653002

Cr-Commit-Position: refs/heads/master@{#301308}

BUG=148816

Review URL: https://codereview.chromium.org/665963002

Cr-Commit-Position: refs/heads/master@{#301307}

BUG=248500,294196

Review URL: https://codereview.chromium.org/660823004

Cr-Commit-Position: refs/heads/master@{#301306}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/86217d8..30b83d4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/674343002

Cr-Commit-Position: refs/heads/master@{#301305}

Cr-Commit-Position: refs/heads/master@{#301304}

The related patch:
https://codereview.chromium.org/663783002/

BUG=323143

Review URL: https://codereview.chromium.org/663793002

Cr-Commit-Position: refs/heads/master@{#301303}

This change makes the Select button active by default. The Return key will
activate the Select button and the Esc key will activate the Cancel button.
This makes the dialog fully operable from the keyboard.

BUG=426737

Review URL: https://codereview.chromium.org/677853002

Cr-Commit-Position: refs/heads/master@{#301302}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/59b3815..86217d8

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/666433004

Cr-Commit-Position: refs/heads/master@{#301301}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cdc9cfa..3e1901b

TBR=

Review URL: https://codereview.chromium.org/677283002

Cr-Commit-Position: refs/heads/master@{#301300}

This is a revert of two cc patches:
1) cc: Always use invalidation on the pending tree when deciding to share
  https://crrev.com/82e46120237bc023559ac7ebddb29e21b6530170
2) cc: Always keep the PictureLayerImpl::twin_layer_ pointer valid
  https://crrev.com/11f13546fd3ee3d53921c23861bf970bd2bb6428

These are being reverted together because (1) depends on (2). Landing
through the CQ to prevent too much chaos muppet.

Reason for revert:
I suspect these patches are causing canary crashers (see http://crbug.com/427215)

TBR=enne@chromium.org,vmpstr@chromium.org,danakj@chromium.org
BUG=407418,387116,427215

Review URL: https://codereview.chromium.org/680793002

Cr-Commit-Position: refs/heads/master@{#301299}

This patch changes DropdownPopupWindow to check the type of the view in
each element of the popup list when measuring the width of its contents.
This ensures that popup list adapters that use multiple view types do
not have to check the type of the view in getView() method. One example
of adapter that uses multiple types of views is
PasswordGenerationAdapter.

BUG=412150

Review URL: https://codereview.chromium.org/662683005

Cr-Commit-Position: refs/heads/master@{#301298}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9735725..cdc9cfa

TBR=

Review URL: https://codereview.chromium.org/676163004

Cr-Commit-Position: refs/heads/master@{#301297}

This patch enables showing the saved passwords settings page on Android
by invoking this method:

  chrome::android::ChromiumApplication::ShowPasswordSettings()

This is similar to the existing method:

  chrome::android::ChromiumApplication::ShowAutofillSettings()

The new method is to be used in password management UI for Android.

BUG=412150

Review URL: https://codereview.chromium.org/656663004

Cr-Commit-Position: refs/heads/master@{#301296}

Include a URL what-you-typed option when the default search provider is not available and the input type is unknown.

Previously, when the default search provider was disabled via an enterprise policy, backspacing through the URL in the omnibar would get stuck as soon as the input got short enough to be classified as unknown. Normally, this is when the top autocomplete option would become a search for what you typed. But with search disabled, the top autocomplete option became the full previously visited URL. This change makes a URL what-you-typed autocomplete option to be provided instead under these circumstances.

BUG=363656

R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/672773003

Cr-Commit-Position: refs/heads/master@{#301295}

This pulls in the following Native Client changes:

r13975: (dschuff) Disable run_dynamic_load_test under nacl_clang x86-32
r13976: (nfullagar) More include path truncation for benchmark source relocation into SDK.
r13977: (bradnelson) Capture build_nexe verbose log messages to emit in the event of error.
r13978: (petarj) [MIPS] Disable seg_gap tests
r13985: (mseaborn) Non-SFI IRT: Remove workarounds for service_runtime/include/ headers
r13986: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13987: (nfullagar) Nacl-clang does not appear to follow the same portable SIMD vector alignment

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg
TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/675063007

Cr-Commit-Position: refs/heads/master@{#301294}

BUG=410400
TEST=-

Review URL: https://codereview.chromium.org/680743002

Cr-Commit-Position: refs/heads/master@{#301293}

Revert of Listen to Off The Record profiles in ContentSettingsHandler. (patchset #3 id:60001 of https://codereview.chromium.org/676083003/)

Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

is dying consistently in GuestModeOptionsBrowserTest.LoadOptionsByURL:

[16175:16175:1024/205028:FATAL:observer_list.h(159)] Check failed: false. Observers can only be added once!
#0 0x7fca41ce4b8e base::debug::StackTrace::StackTrace()

This looks like a very related CL.

Original issue's description:
> Listen to Off The Record profiles in ContentSettingsHandler.
>
> ContentSettingsHandler is now made aware of Off The Record profiles
> and will observe them as well, correcting bugs where changes from the
> settings webUI would function incorrectly.
>
> This is a rework of a previously landed fix [fix] which was reverted due to
> a crash bug [crash] when OTR profiles already existed before settings
> were opened.
>
> [fix] https://codereview.chromium.org/585953003
> [crash] https://code.google.com/p/chromium/issues/detail?id=417597
>
> BUG=425079, 418931
>
> Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c
> Cr-Commit-Position: refs/heads/master@{#301273}

TBR=thestig@chromium.org,scheib@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=425079, 418931

Review URL: https://codereview.chromium.org/652183006

Cr-Commit-Position: refs/heads/master@{#301292}

R=shuchen@chromium.org, yukishiino@chromium.org

Review URL: https://codereview.chromium.org/673163005

Cr-Commit-Position: refs/heads/master@{#301291}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5aa30ea8..9735725

TBR=

Review URL: https://codereview.chromium.org/661293003

Cr-Commit-Position: refs/heads/master@{#301290}

Revert of Enable a11y audit for chrome://settings (patchset #2 id:20001 of https://codereview.chromium.org/646853004/)

Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1)

started consistently failing OptionsWebUIExtendedTest.CloseOverlay in the build in which this CL landed. This touches WebUI, and is implicated in many of the stack traces.

Reverting to try to green the bot.

Original issue's description:
> Enable a11y audit for chrome://settings
>
> Enabled the tests and fixed failure. Failure was due to transition obscuring elements in the UI.
>
> BUG=311866
>
> Committed: https://crrev.com/34a84c6d1269332cc3ae2b8a50af489230c885de
> Cr-Commit-Position: refs/heads/master@{#301266}

TBR=dbeam@chromium.org,hcarmona@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=311866

Review URL: https://codereview.chromium.org/678883002

Cr-Commit-Position: refs/heads/master@{#301289}

This reverts commit af3c28a4.

TBR=scheib@chromium.org,cpu@chromium.org,jar@chromium.org,bshe@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=236640

Review URL: https://codereview.chromium.org/682463002

Cr-Commit-Position: refs/heads/master@{#301288}

Revert of Autofill: Fix recognition of Walmart ZIP code. (patchset #3 id:40001 of https://codereview.chromium.org/676983004/)

Reason for revert:
The tree exploded with zillions of bots across all platforms failing FormStructureBrowserTest.DataDrivenHeuristics21. FormStructureBrowserTest is autofill, and this is the only autofill change landed around the time everything died.

Original issue's description:
> Autofill: Fix recognition of Walmart ZIP code.
>
> BUG=426958
>
> Committed: https://crrev.com/dbec51e8134df4f722085ef98144ac0cd207eead
> Cr-Commit-Position: refs/heads/master@{#301252}

TBR=isherman@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=426958

Review URL: https://codereview.chromium.org/675303005

Cr-Commit-Position: refs/heads/master@{#301287}

These files are mutually dependent via includes (default provider
includes content_settings_util.h but content_settings_util.cc
includes host_content_settings_map.h, for example).

BUG=384869, 384876
R=bauerb@chromium.org, vabr@chromium.org
TBR=sky@chromium.org, rch@chromium.org
TEST=no functional changes, build succeeds

Review URL: https://codereview.chromium.org/670953006

Cr-Commit-Position: refs/heads/master@{#301286}