- 07 Dec, 2017 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3c7cb9c..79bacdd9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1683fcfd599045ef342b2c812bbc086ff1fa0802 Reviewed-on: https://chromium-review.googlesource.com/813994Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522419}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: none Change-Id: I4e256bef6d7cc6f3af24a5b1241d2279eaf82cad Reviewed-on: https://chromium-review.googlesource.com/813499 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522418}
-
Dave Tapuska authored
Reland https://chromium-review.googlesource.com/804357. This time ensure that we are using a MouseDown event instead of MouseMove event as MouseMove events can be sent from the UI synthetically and that causes the InputMsgWatcher to be in a different state sometimes. Devtools was not correctly handling input that is not generated by itself and invoking callbacks when the input wasn't actually processed. Add a modifier indicating content was injected using the debugger so that we can then query for that to determine if we should release the event. This is a stop gap solution until we can actually bind callbacks into the sending of events and devtools wouldn't need its own queues of callbacks. BUG=789869 TBR=pfeldman@chromium.org Change-Id: Id769fa9363debb196d787a73920f24e3a409c68f Reviewed-on: https://chromium-review.googlesource.com/811833 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522417}
-
David Roger authored
When the Dice token exchange fails: - if this is a Sync signin, the tab is navigated to the NTP, to match the behavior of the success case - if this is a Sync signin or if Dice is fully enabled for this profile, display the signin error dialog. Bug: 789130 Change-Id: I4a5309a18301c4e3112db50296edd625682f0fd3 Reviewed-on: https://chromium-review.googlesource.com/810805 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#522416}
-
Marti Wong authored
This CL makes Bookmarks ignore the cached path (and starts at root node) when cached path of Bookmarks is a permanent node (Mobile Bookmarks, Bookmarks Bar or Other Bookmarks) and is empty. Egtest is modified accordingly. Bug: 571878 Change-Id: I68773b63e3f12a1ce1e1cf0842c2888dae92d568 Reviewed-on: https://chromium-review.googlesource.com/810185 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#522415}
-
Martin Sramek authored
Testing under heavy load (on the order of thousands of resource loads writing into the cache and clearing it) did not produce crashes or other adverse effects. Therefore, we reenable the cache datatype for M65. With plenty of time to test on unstable channels of Chromium, and to perform additional heavy load tests, we should be able to re-ship with confidence in M65. Bug: 762417 Change-Id: I17bc1efb38fb9d3f5b7e91de2048420dbe75f6ac Reviewed-on: https://chromium-review.googlesource.com/809128Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#522414}
-
Yash Malik authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I57add5c261f28762a3cec1be364c6be8572703ca Reviewed-on: https://chromium-review.googlesource.com/809606 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#522413}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/40f0b37d3b9a..5dcbbfd1533b $ git log 40f0b37d3..5dcbbfd15 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I59f17611592a6f8de076bd4c7c7846911e3eed42 Reviewed-on: https://chromium-review.googlesource.com/813874Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522412}
-
Kush Sinha authored
Change-Id: Ie70563b27b64bc2c02b0a24ba79d1b35751c2177 Reviewed-on: https://chromium-review.googlesource.com/813918Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#522411}
-
Gauthier Ambard authored
When leaving the NTP, the progress bar of the toolbar was progressing backward before starting the loading. This CL fixes it. Bug: 792791 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49cbe4073b3d33d1e2fe45e44c588403c44dea7a Reviewed-on: https://chromium-review.googlesource.com/813734Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#522410}
-
Becca Hughes authored
Fix overflow icon padding on the new media controls if the overflow icons are enabled. BUG=787445 Change-Id: I2f2ec5a56839ccada45feebcd10b18fcbb82a749 Reviewed-on: https://chromium-review.googlesource.com/813915Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522409}
-
Morten Stenshorne authored
Let the flex/grid layout algorithm determine the size of tables that are flex/grid items. Don't let the intrinsic width of table columns affect the width of the item. Bug: 782948, 667785 Change-Id: Ifcea6af51ce5bf74377f93b5cd0437272a5c7ef0 Reviewed-on: https://chromium-review.googlesource.com/781859Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522408}
-
Jérôme Lebel authored
When the sign-in promo view is hidden (by collapsing the "Other Devices" section), Chrome crashes, if the sign-in promo view has to be reloaded (with a new identity added by another app for example). If the section is collapse the sign-in promo should not be updated. The view will be updated later when the user will uncollapse the section. Bug: 776939 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie68ba68e40580b510a782b54ec744865311ed2bb Reviewed-on: https://chromium-review.googlesource.com/811464 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#522407}
-
Shanmuga Pandi M authored
Bug: 769629 Change-Id: I996148aba74d03db821bb5f948d2d60dd321c808 Reviewed-on: https://chromium-review.googlesource.com/813440Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#522406}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership complex. After this CL, the clock instances are always un-owned by injectees. Instead, an injecter owned one is used on testing, and the shared instance is used on production path. Bug: 789079 Change-Id: I8af4709520e8c4484ecfe9c71aeb37fe629155d0 Reviewed-on: https://chromium-review.googlesource.com/792756Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#522405}
-
Marc Treib authored
This was broken recently by crrev.com/c/800931. Bug: 792401 Change-Id: Idd269b49bd282a7faa6ca13a259f60384b2b5a08 Reviewed-on: https://chromium-review.googlesource.com/810788 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#522404}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b463eed7..e3c7cb9c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I217c110111e2d2e09e83a65908ded53a49c531b9 Reviewed-on: https://chromium-review.googlesource.com/812550Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522403}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. I adopted kUnthrottled not to change the current behavior, and we need to replace a more appropriate task type in near future. Bug: 786332 Change-Id: I0b7f399007f6999cb276c35057ae5526aa5477fc Reviewed-on: https://chromium-review.googlesource.com/813655Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522402}
-
Daniel Bratell authored
There is both a ::testing and ::blink::testing namespace and if you refer to just "testing" inside the ::blink namespace you can get either one depending on what the compiler knows. This broke jumbo builds where the compiler knew about ::blink::testing and thought "testing" meant ::blink::testing instead of ::testing. The fix is to use the :: prefix. Change-Id: I15b2502a5b15ef585816faae843a97b3d2d73c93 Reviewed-on: https://chromium-review.googlesource.com/813775Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#522401}
-
Vaclav Brozek authored
If the settings do not show any saved passwords, the export button in the menu should still be present, but disabled. Note that the existence of "blacklisted" entries, i.e., entries where the user asked Chrome to never save a password, does not influence the state of the menu item, because those entries are not exported. Mocks: go chrome-pwd-export-mocks-android (currently slide 10, Google-internal only) General design: https://docs.google.com/a/chromium.org/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit?usp=sharing Bug: 788701 Change-Id: I1f5ad12eef9ef6ec1c9b0529c5b1ef16941c5298 Reviewed-on: https://chromium-review.googlesource.com/811186 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#522400}
-
Yuta Kitamura authored
Now WTF::Bind() returns base::OnceCallback, WTF::ConvertToBaseCallback() (for non-crossthread callbacks) is merely an identity function. This patch removes all the use sites of it in Blink. Note we still have WTF::ConvertToBaseCallback() for WTF::CrossThreadFunction, and it's not removed. Bug: 771087 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If7903bd6fcef538999b42d5b0b31b7f23a19c34a Reviewed-on: https://chromium-review.googlesource.com/813654Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#522399}
-
Yuta Kitamura authored
WTF::RepeatingFunction is already an alias of base::RepeatingCallback. This patch replaces all the existing references to WTF::RepeatingFunction, completing the migration of WTF::RepeatingFunction. Bug: 771087 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2d9f5264a0e5076bc6da8f2687188a5978bb18ca Reviewed-on: https://chromium-review.googlesource.com/813555Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#522398}
-
David Roger authored
Bug: 791948 Change-Id: Ie8f9c43ace98082e86d1bfbe01bc3ffe58a01fd6 Reviewed-on: https://chromium-review.googlesource.com/808979 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#522397}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/db654910e39e..16753e0633fc $ git log db654910e..16753e063 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 perezju [Telemetry] Cleanup do_nothing forwarder Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Idb110e1206f7af95233a446b18a814f41232c621 Reviewed-on: https://chromium-review.googlesource.com/813595 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522396}
-
Vaclav Brozek authored
This change adds a safeguard in PasswordReauthenticationFragment against repeated showing of the screen lock. If PasswordReauthenticationFragment gets killed during displaying the screen lock, this CL ensures that it won't attempt to display it again on re-creation. Bug: 791652 Change-Id: I7cc593906017bd059c6a4f3bd2b88d9b68488398 Reviewed-on: https://chromium-review.googlesource.com/806044 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#522395}
-
Dominik Röttsches authored
Previously a set if bechmark stories triggered the expensive glyph collection in GSUB and GPOS way too many times. This was found while investigating and hb_set performance issue 781794. browse:news:cnn triggered the call and GSUB/GPOS scanning method 1395 times, and was reduced to two. browse:news:hackernews 33 times reduced to 4, browse:social:twitter 58 times reduced to 4, browse:social:twitter_infinite_scroll 38 times reduced to 4 as well. We only need to do this work once per font face, independent of size - whereas previously it was once per Font object, which, depending on layout of the page, triggers much more frequently. Test: FontPlatformDataTest Bug: 791475 Change-Id: I15757abab2037677d5ea4c640ac26ab99da4649c Reviewed-on: https://chromium-review.googlesource.com/809106 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522394}
-
Peter Collingbourne authored
The signal handlers interfere with the breakpad and sandbox tests, so we need to disable them there. We will also want to use the same set of UBSan options during executable tests as we do during instrumentation tests, so move the $UBSAN_OPTIONS value into the test harness, and pass it into the instrumentation test runner using a string extra. Bug: 469376 Change-Id: I76ffdd4a8221a54a23e257ac4d2321b8f28d2f42 Reviewed-on: https://chromium-review.googlesource.com/812982Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522393}
-
Benoit Lize authored
Allows to collect profiling data from several page loads, and to scroll the screen while doing so. Bug: 758566 Change-Id: I4f0bb8fc167e69dea349dbd4b5ee733193996e41 Reviewed-on: https://chromium-review.googlesource.com/801016 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#522392}
-
rhalavati@google.com authored
A temporary network traffic annotation tag is added to be used during refactoring of the socket classes. Network Traffic Annotation Auditor is updated to add this tag to reserved words and ignore it in tests. Bug: 690323 Change-Id: I79f570ced37a8572b6f495de478d18d998dc4189 Reviewed-on: https://chromium-review.googlesource.com/813674Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#522391}
-
Boris Sazonov authored
This CL switches the default state of AndroidSigninPromos feature to FEATURE_ENABLED_BY_DEFAULT. Bug: 792430 Change-Id: I09e7c26db6b899c593f69b9d459bbe03171a115b Reviewed-on: https://chromium-review.googlesource.com/810744Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522390}
-
Hajime Hoshi authored
Bug: 765623 Change-Id: Ieaaa7a3f8fde471bb41a7af45ca0473d59f1a47b Reviewed-on: https://chromium-review.googlesource.com/672028Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522389}
-
Sylvain Defresne authored
Refactor Tab (and its unit test) and WebControllerSnapshotHelper to directly use SnapshotCache (accessed via the SnapshotCacheFactory). Move -generateSnapshotForView:withRect:overlays: method (and helper functions) to WebControllerSnapshotHelper. Bug: 661642, 620465 Change-Id: Ie8cde629b99ca39b30cd1bc3354dac441cd5e562 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/810768Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#522388}
-
Eugene But authored
This method is not called and is probaly a cruft from CRWWebDelegate. Bug: 681867 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6dd682c5889b540008b6807ffdc0bbd07ac83e4 Reviewed-on: https://chromium-review.googlesource.com/811291 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#522387}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: If89b985dc9be0a8b525a8d4dc1e807d3b0baeea1 Reviewed-on: https://chromium-review.googlesource.com/812548Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522386}
-
Eddy Mead authored
Bug: 752745 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I43c650c37c33cb92d500e5e82d437f24faf6287a Reviewed-on: https://chromium-review.googlesource.com/795515Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522385}
-
Makoto Shimazu authored
Currently ServiceWorkerVersion clears |pending_requests_| but not |request_timeouts_|, and it causes inconsistency after restart. This patch fixes it. Bug: 791451 Change-Id: I50778a81ab31d1094db5776a49137c0196c1fb5f Reviewed-on: https://chromium-review.googlesource.com/807835 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522384}
-
Katie Dektar authored
This fixes a bug where the first time you open the select-to-speak settings page the highlight color drop-down doesn't have a color selected. Bug: 792728 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic6f1653d8108e5d47fdc48c555eb55c0bbed51d8 Reviewed-on: https://chromium-review.googlesource.com/812426 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522383}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I71f58741822d6515d72210b93edba326c84f89b9 Reviewed-on: https://chromium-review.googlesource.com/807867Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522382}
-
Zhuoyu Qian authored
This patch makes ContentPosition and ContentDistributionType to be enum classes for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Id316e846b10d1aa5316fab78eb1189ce542a1404 Reviewed-on: https://chromium-review.googlesource.com/810406Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#522381}
-
Alexander Shalamov authored
This CL reverses axis signs for gyroscope, magnetometer and absolute orientation sensors. Before the change, wrong coordinate system was used based on the accelerometer's data. Integrating Motion and Orientation Sensors [1] document, explains what coordinate system must be used and why accelerometer's measurements differ from other platforms. [1] https://msdn.microsoft.com/en-us/library/windows/hardware/dn642102(v=vs.85).aspx Bug: 786252 Change-Id: I4afbc1a1d5fb03c3e2e0538a8ea7424c40020eca Reviewed-on: https://chromium-review.googlesource.com/804624Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#522380}
-