GitLab

Originally SetVersionInternal() was quite simple function, but that has been
puzzuled as the codebase has evolved.

This CL decomposes the function for readability and simplifies lifetime
management for a version to be set, that is, passes a refcounted version
as an argument instead of making temporary protect object.

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/1106723002

Cr-Commit-Position: refs/heads/master@{#326753}

MidiManagerAlsa needs udev for manufacturer extraction and robust device reconnection. Without udev, we cannot reliably get this information from the kernel.

This CL is the first step. It puts a hard requirement on udev for MidiManagerAlsa, but doesn't actually do anything useful with it yet.

Review URL: https://codereview.chromium.org/1079333002

Cr-Commit-Position: refs/heads/master@{#326752}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e2ee9248..18297c96

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1096743004

Cr-Commit-Position: refs/heads/master@{#326751}

Cr-Commit-Position: refs/heads/master@{#326750}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2de4669..5894a94

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1106733002

Cr-Commit-Position: refs/heads/master@{#326749}

In order to rename blink::EventTargetNames::LocalDOMWindow to
blink::EventTargetNames::DOMWindow, we have to temporarily disable
the test while the transition.  Once the renaming gets done, we'll
enable the test.

The following CLs should be landed.
http://crrev.com/1086663003
http://crrev.com/1088943008

NOPRESUBMIT=true
BUG=

Review URL: https://codereview.chromium.org/1064563005

Cr-Commit-Position: refs/heads/master@{#326748}

A WebMIDI port has properties such as .manufacturer, .name and .version
that remain empty in the current WebMIDI implementation on Android.
This CL fixes that by setting them to values got from USB descriptors.

BUG=473639

Review URL: https://codereview.chromium.org/1098913003

Cr-Commit-Position: refs/heads/master@{#326747}

These are designed to give us more information about production-only
crashes occurring in ChromeAppSorting. These checks should help narrow
down the times at which extension_scoped_prefs_ is null.

Added TODOs to remove most of the checks later (although I plan to leave
one in as a safeguard).

BUG=476648

Review URL: https://codereview.chromium.org/1055453007

Cr-Commit-Position: refs/heads/master@{#326746}

In the PasswordFormManager::OnRequestDone method, I found some usage of
raw pointers to elements of a ScopedVector with confusing ownership over
a lot of code. Rewrote the code to use scoped_ptrs so that the ownership
is always clear, and nothing needs to be manually deleted.

BUG=451018

Review URL: https://codereview.chromium.org/1094013002

Cr-Commit-Position: refs/heads/master@{#326745}

This is possible now that the data deps handling bug has been rolled.

BUG=477104

Review URL: https://codereview.chromium.org/1095873003

Cr-Commit-Position: refs/heads/master@{#326744}

These strings should only be included if enable_media_router is true.

Review URL: https://codereview.chromium.org/1105663003

Cr-Commit-Position: refs/heads/master@{#326743}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d641e95..2de4669

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1099963005

Cr-Commit-Position: refs/heads/master@{#326742}

In Async readback if the requested readback format is not supported.
Then fallback to RGBA_8888 format.

Removed RenderWidgetHostViewAndroid::PreferredReadbackFormat() API

Review URL: https://codereview.chromium.org/1095993002

Cr-Commit-Position: refs/heads/master@{#326741}

- Remove unused friendliness
- Remove DCHECK and if-statement combination forbidden by our coding standard
http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-
- Make some instance variables const

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/1100003005

Cr-Commit-Position: refs/heads/master@{#326740}

This makes it explicit why server_ip is blank when the connection was
proxied, so we can tell when it's blank because of a bug instead.

BUG=

Review URL: https://codereview.chromium.org/1088933007

Cr-Commit-Position: refs/heads/master@{#326739}

BUG=475699
TEST=None

Review URL: https://codereview.chromium.org/1085703002

Cr-Commit-Position: refs/heads/master@{#326738}

BUG=none
TEST=run closure compiler

Review URL: https://codereview.chromium.org/1104463004

Cr-Commit-Position: refs/heads/master@{#326737}

Fix bugs related to the latest GN roll.

1) the new GN binary will return an error if you pass it
a file it doesn't know anything about in 'gn refs'.

2) for some reason with the new GN binary we're triggering a
code path in gyp_flag_compare.py that wasn't running before,
and that code path was busted.

TBR=brettw@chromium.org
BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1109453002

Cr-Commit-Position: refs/heads/master@{#326736}

No behavioral change.

BUG=none

Review URL: https://codereview.chromium.org/1104543006

Cr-Commit-Position: refs/heads/master@{#326735}

BUG=466848

Review URL: https://codereview.chromium.org/1060033003

Cr-Commit-Position: refs/heads/master@{#326734}

BUG=466848

Review URL: https://codereview.chromium.org/1101593003

Cr-Commit-Position: refs/heads/master@{#326733}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bbf1039..d641e95

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1102853002

Cr-Commit-Position: refs/heads/master@{#326732}

BUG=480534

TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/1097153003

Cr-Commit-Position: refs/heads/master@{#326731}

Exclude MSE_ClearKey/EncryptedMediaTest.Playback_AudioClearVideo_WebM/0 under DrMemory for flakiness.

BUG=480750
TBR=prabhur@chromium.org

Review URL: https://codereview.chromium.org/1105793003

Cr-Commit-Position: refs/heads/master@{#326730}

BUG=480521

Review URL: https://codereview.chromium.org/1102793003

Cr-Commit-Position: refs/heads/master@{#326729}

BUG=478340
TEST=manually

Review URL: https://codereview.chromium.org/1101843003

Cr-Commit-Position: refs/heads/master@{#326728}

This converts the PrefSyncStatus enum which is passed at registration time of
a syncable pref into a more general "registration flags" mechansim for prefs.
PrefRegistrationFlags is an enum used in a bitmask to indicate different
options which can be passed when registering a pref.

Subclasses of PrefRegistry can use the first 8 bits of PrefRegistrationFlags
to specify their own flags. These are used by PrefRegistrySyncable to
specify whether or not the pref is syncable.

In a subsequent CL we plan to add a flag to indicate whether the pref is
"lossy" (see the bug linked).

BUG=476800

Review URL: https://codereview.chromium.org/1096833003

Cr-Commit-Position: refs/heads/master@{#326727}

BUG=474195
TEST=manually

Review URL: https://codereview.chromium.org/1071283003

Cr-Commit-Position: refs/heads/master@{#326726}

TBR=reveman@chromium.org
BUG=480741

Review URL: https://codereview.chromium.org/1093693007

Cr-Commit-Position: refs/heads/master@{#326725}

1. Initialize |next_keyframe_at_| to 0, so that the expected sequence will be i * |keyframe_period_|.
2. Update |next_keyframe_at_|, when a key frame is arrived at the requested window. Other key frames should be ignored.

BUG=470775
TEST=Run the binary on Samus and Peach-Pit

Review URL: https://codereview.chromium.org/1056133009

Cr-Commit-Position: refs/heads/master@{#326724}

An apk may provide instrumentation for itself or another apk. When
providing instrumentation for another apk, the target for that apk
should be added to the android_apk() target as apk_under_test. This
ensures that the instrumentation apk is built correctly.

TBR=yfriedman@chromium.org
BUG=359249

Review URL: https://codereview.chromium.org/1072193011

Cr-Commit-Position: refs/heads/master@{#326723}

R=phajdan.jr@chromium.org
BUG=479509

Review URL: https://codereview.chromium.org/1061983006

Cr-Commit-Position: refs/heads/master@{#326722}

BUG=480340
TEST=manually

Review URL: https://codereview.chromium.org/1101073002

Cr-Commit-Position: refs/heads/master@{#326721}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1109443002

Cr-Commit-Position: refs/heads/master@{#326720}

This prevents unit tests from finishing earlier than they are supposed to.

BUG=480657

Review URL: https://codereview.chromium.org/1079483006

Cr-Commit-Position: refs/heads/master@{#326719}

Make sure the expiration value of an SSL certificate is correctly
displayed in an interstitial.

BUG=476758

Review URL: https://codereview.chromium.org/1072913003

Cr-Commit-Position: refs/heads/master@{#326718}

ActionBarActivity was deprecated in AppCompat 22.1.0.
This CL renames all usages of ActionBarActivity in Chrome.

BUG=479858

Review URL: https://codereview.chromium.org/1095553005

Cr-Commit-Position: refs/heads/master@{#326717}

Revert of Roll GN (via buildtools) 321178:326666 (patchset #2 id:20001 of https://codereview.chromium.org/1082813004/)

Reason for revert:
Caused gyp_flag_compare failure on Linux GN bots.

BUG=480739

Original issue's description:
> Roll GN (via buildtools) 321178:326666
>
> This picks up the changes for 'gn help all' and
> the markdown docs, fixes a bug related to the
> transitive propagation of public_deps across
> shared objects, and includes a speculative fix
> for the WriteFile() failures we're seeing on
> Windows.
>
> TBR=brettw@chromium.org
>
> Committed: https://crrev.com/a21c4f2acc0b7b97a65c3c145361aed55c53f769
> Cr-Commit-Position: refs/heads/master@{#326704}

TBR=brettw@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1095553006

Cr-Commit-Position: refs/heads/master@{#326716}

This regressed after switching the PDF plugin to be a BrowserPlugin. It is safe
to open files that load in BrowserPlugin plugins because they are all sandboxed.

BUG=479049

Review URL: https://codereview.chromium.org/1095083003

Cr-Commit-Position: refs/heads/master@{#326715}

R=thestig@chromium.org
BUG=none
TEST=no unsafe way to use base::File

Review URL: https://codereview.chromium.org/1103733002

Cr-Commit-Position: refs/heads/master@{#326714}