- 07 Feb, 2019 40 commits
-
-
Koji Ishii authored
Following bot results are included. 14771 14772 14779 14790 14798 14801 14812 14817 2 lines were removed and 0 lines were deflaked by consecutive results since 14754. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I38d1d2800e92dcc6833a4206cb6d7f119c929800 Reviewed-on: https://chromium-review.googlesource.com/c/1456416Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629958}
-
Sergio Villar Senin authored
ChildAccountService was observing changes the list of gaia accounts in the cookie jar in order to notify its observers. We can achieve the same behaviour by observing IdentityManager instead. Apart from that the call to GaiaCookieManagerService::ListAccounts() was successfully replaced by IdentityManager::GetAccountsInCookieJar(). This allows us to completely remove the dependency on GaiaCookieManagerService. Bug: 921007 Change-Id: I7acc064c65ae2d61eb9d807e08183f2ee30e5183 Reviewed-on: https://chromium-review.googlesource.com/c/1409010 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629957}
-
Dominic Farolino authored
This reverts commit 66236c64. Reason for revert: Bad and unexpected performance regressions were introduced with this change. It is possible to incur an infinite loop of loading a <link> and firing the load event, if the onload function tampers with the `rel` attribute, as is sometimes done with preload links. This may prevent a window's load event from ever being fired. Mitigating problems like this needs to more looking into before this change can land apparently. Performance regression bugs: https://crbug.com/927427, https://crbug.com/928796, https://crbug.com/929153, https://crbug.com/929265. The original bug (https://crbug.com/922618) has been re-opened to track future work for this. Original change's description: > Link element events should be able to fire more than once > > As per spec https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet, > the <link> element can have its load and error events fire multiple times, > per resource it loads. > > Bug: 922618 > Change-Id: Ifc9ade076e119d5cf9f4eaf656c6ea7c1deb0ba9 > Reviewed-on: https://chromium-review.googlesource.com/c/1423601 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#628010} TBR=yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922618 Change-Id: I0affe5a242bf472743d11a4905a630da7895cfca Reviewed-on: https://chromium-review.googlesource.com/c/1457745Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#629956}
-
kylechar authored
Remove usage of deprecated base::Bind, base::Callback, base::Closure, base::CancelableCallback and base::CancelableClosure types from content/gpu/*, content/browser/gpu* and chrome/gpu/*. Where possible convert to the corresponding once type. Otherwise replace with the repeating type which is equivalent to the deprecated type. Bug: 714018 Change-Id: I8da148c51d9eb8b5d85a4a8f76b41f8a13ff295f Reviewed-on: https://chromium-review.googlesource.com/c/1456941Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629955}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ca375c8ca54..0041fe53dcfe git log 7ca375c8ca54..0041fe53dcfe --date=short --no-merges --format='%ad %ae %s' 2019-02-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1a597bc4..ee5dfb22 (629788:629907) 2019-02-07 oprypin@webrtc.org Roll chromium_revision c27b32b2..1a597bc4 (629510:629788) 2019-02-07 oprypin@webrtc.org Pause rolling buildtools 2019-02-06 steveanton@webrtc.org Reland: Remove dead code from stream_params.h 2019-02-06 solenberg@webrtc.org Remove HAVE_WEBRTC_VOICE. 2019-02-06 nisse@webrtc.org Move RtpSenderVideo tests to separate file. 2019-02-06 nisse@webrtc.org Delete MediaTransport method SetNetworkChangeCallback 2019-02-06 nisse@webrtc.org Allow more than one registered network change callback in MediaTransport 2019-02-06 oprypin@webrtc.org Roll chromium_revision 9d5d0c66..c27b32b2 (629245:629510) Created with: gclient setdep -r src/third_party/webrtc@0041fe53dcfe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:927867,chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a024246384477be0b56fa2bed7316f6983db105 Reviewed-on: https://chromium-review.googlesource.com/c/1457535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629954}
-
Erik Luo authored
Bug: 929561 Change-Id: I98ec6ea3cc6a6de1d82489a737cd5f51f9bc56f0 Reviewed-on: https://chromium-review.googlesource.com/c/1457919Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#629953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a54660850c3..36651e4e3873 Created with: gclient setdep -r src-internal@36651e4e3873 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5117525c0b39eeb83fefda75be9240ba6904a656 Reviewed-on: https://chromium-review.googlesource.com/c/1458277Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629952}
-
Hans Wennborg authored
TBR=thakis Bug: 929645 Change-Id: Ie38f68f99b82e8193afbf367a7894f70cb9e18ec Reviewed-on: https://chromium-review.googlesource.com/c/1458182Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629951}
-
Erik Luo authored
EagerEval's preview is breaking onto a new line. We should be making the entire preview 'nowrap'. Bug: 929535 Change-Id: Ib26f3bb26b06991e0a32320ec9f6744efa23e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/1455349Reviewed-by:
-
Michael Lippautz authored
In the case a dedicated worker is terminated before the backing thread has been created the message proxy would never be cleaned up. With unified heap this means that any wrappers may keep on to old window objects. Bug: 928781, 843903 Change-Id: Ic0f1968609d259a2eea9a4c90d47f95729b4ce79 Reviewed-on: https://chromium-review.googlesource.com/c/1458217Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629949}
-
jdoerrie authored
This change adds a base::as_u16cstr() utility function for platforms where wchar_t is UTF16. Furthermore, it also provides a as_writable_u16str() function, renames base::wdata() to base::as_wcstr() and base::as_writable_wcstr() respectively, and removes the no longer needed CastToStringPiece16 and CastToWStringPiece. Bug: 911896 Change-Id: I192da78b9d2d4ddca8a642242d0c65dc7fc361f4 Reviewed-on: https://chromium-review.googlesource.com/c/1452185Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#629948}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69a830d3..d6d7c729 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5455056689e8b5b3aeb0da03c2bd2edb254f9ec4 Reviewed-on: https://chromium-review.googlesource.com/c/1457926Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629947}
-
François Beaufort authored
This CL removes the SkipAd media switch feature as the Picture-in-Picture window will receive events only from blink/. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/l6sW0G4jzhE Bug: 910436 Change-Id: I4c41b476691f43d76a8811f8990873c222341e7c Reviewed-on: https://chromium-review.googlesource.com/c/1452186 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#629946}
-
Nicolas authored
This CL adds BrowserSwitcherServiceWin, which extends BrowserSwitcherService and contains the Windows-specific code. This avoids too many #ifdefs in that file. Change-Id: Icbf49f82e605710c273c8795805c4ad962b67ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1457221Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#629945}
-
Carlos Caballero authored
Add a new task trait to tell the future BrowserUIThreadScheduler which tasks are critical for startup and allow it to prioritize them accordingly. Design doc: https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit# Bug: 863341, 872372 Change-Id: Ifb082762726fbda951325802faf82f1dacf219cc Reviewed-on: https://chromium-review.googlesource.com/c/1454632 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629944}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/382b122e45dc..c19d81acc096 git log 382b122e45dc..c19d81acc096 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c27b32b2..635f1120 (414 commits) Created with: gclient setdep -r src/third_party/skia@c19d81acc096 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ide6b3951f697b7c6cfda248adff46d06564e11f6 Reviewed-on: https://chromium-review.googlesource.com/c/1458276Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/29ecb64560ae..3043fbd9fc27 git log 29ecb64560ae..3043fbd9fc27 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com trace_processor: fix MSAN failure due to off-by-one Created with: gclient setdep -r src/third_party/perfetto@3043fbd9fc27 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I61c047f0de6d35296dcd08b783cb3b8d7a664be4 Reviewed-on: https://chromium-review.googlesource.com/c/1457533Reviewed-by:
-
Yutaka Hirano authored
As part of WebDataConsumerHandle deprecation, this CL removes WebDataConsumerHandle references from core/. - Remove WebDataConsumerHandle parameter from - Resource::ResponseReceived - RawResourceClient::ResponseReceived - ThreadableLoaderClient::DidReceiveResponse. - Add RawResourceClient::ResponseBodyReceived. - Add ThreadableLoaderClient::DidReceiveResponseBody. - Remove BufferingDataPipeWriter and start using BufferingBytesConsumer instead. - Stop dispatching data chunks from WebURLLoaderImpl to ResourceLoader when |use_stream_on_response_| is set. Bug: 894819 Change-Id: Id85d8f377fd073378ac5bfde6e2571dc1ad9e4b5 Reviewed-on: https://chromium-review.googlesource.com/c/1447999Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#629941}
-
Kush Sinha authored
Bug: 816954 Change-Id: I4ee640075af0948cbb8b5bfcc127123348cad98b Reviewed-on: https://chromium-review.googlesource.com/c/1426779 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f0a00cd7f17b..93c01741f610 git log f0a00cd7f17b..93c01741f610 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 evanhernandez@chromium.org cros branch: Support custom repo root. 2019-02-07 zwisler@google.com portage_util: unit test for always_live GetSourceInfo() call 2019-02-07 ahassani@chromium.org cros_generate_update_payload: Use new paygen library 2019-02-07 saklein@chromium.org build_api: Implement ImageService/Test Created with: gclient setdep -r src/third_party/chromite@93c01741f610 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib85a3a46d1f4e977ca010f8e02f20abe9c8a9506 Reviewed-on: https://chromium-review.googlesource.com/c/1457534Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b68e715cb291..2a54660850c3 Created with: gclient setdep -r src-internal@2a54660850c3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2787fc634d12614c6d848d39dca3eb200480eb44 Reviewed-on: https://chromium-review.googlesource.com/c/1457530Reviewed-by:
-
Nikita Podguzov authored
Bug: 848942 Change-Id: I5e98582e5d1a949c8db25846068655ed2c551068 Reviewed-on: https://chromium-review.googlesource.com/c/1454897 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629937}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/859db6b5a03c..382b122e45dc git log 859db6b5a03c..382b122e45dc --date=short --no-merges --format='%ad %ae %s' 2019-02-07 csmartdalton@google.com Revert "Add a GpuGM class for GPU-only tests" Created with: gclient setdep -r src/third_party/skia@382b122e45dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I024bed8810e3f1f7a9149e673fb4770e68357be9 Reviewed-on: https://chromium-review.googlesource.com/c/1457531Reviewed-by:
-
Alan Cutter authored
This CL ensures we do not spam the user's Application directory on Mac when syncing down installed PWAs. This makes Mac behave the same as Windows and Linux. Bug: 929559 Change-Id: I31df57e7d8228b2a47cc362f258afeee2dc840ef Reviewed-on: https://chromium-review.googlesource.com/c/1457698 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#629935}
-
Kush Sinha authored
AccountManagerMigrator used |AccountReconcilor::Initialize| as a way of starting account reconciliation because |AccountReconcilor::Start| is a private method. Make |AccountReconcilor::EnableReconcile| call |AccountReconcilor::StartReconcile| in its implementation and call |EnableReconcile| from AccountManagerMigrator. Bug: 904128 Test: components_unittests --gtest_filter="*AccountReconcilorTest*" Change-Id: I7899fb261080c10bb62ebdefe31c45d3a9a4754c Reviewed-on: https://chromium-review.googlesource.com/c/1424299 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629934}
-
Kush Sinha authored
Th test assumed that Mirror account consistency will only be available if the logged in account is a child account. This assumption is no longer true. Bug: 915628 Test: browser_tests --gtest_filter="*ChromeOsMirrorAccountConsistencyTest*" Change-Id: I99a1f672949e76c22db159c0d69384f50727670d Reviewed-on: https://chromium-review.googlesource.com/c/1437285 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
The 'page_image_annotation' component uses V8 headers (transitively through blink) without importing the right build config for unittests, hence getting potentially wrong definitions due to missing #defines from the V8 build config. This CL adds blink_headers to public_deps of the renderer target, which fixes the problem for unit_tests and all future dependencies. Bug: v8:8788 Change-Id: I8ed60c8dc3f107c660235954a326e64a7b907e1d Reviewed-on: https://chromium-review.googlesource.com/c/1454491 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629932}
-
Olya Kalitova authored
After PluginVm image is successfully downloaded it needs to be unzipped to a specific location. This CL adds unzipping functionality to the PluginVmImageManager so unzipping of the downloaded image could be called using manager and observer could receive events regarding status of the unzipping. Bug: 904851 Test: unit_tests --gtest_filter="PluginVmImageManagerTest.*" Change-Id: I005929fccbeec191951a054e303bc816e853285a Reviewed-on: https://chromium-review.googlesource.com/c/1443171 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629931}
-
Hiroki Nakagawa authored
This CL introduces a new mojo method in DedicatedWorkerFactory interface that is the browser-side entry point of PlzDedicatedWorker, and wires it up with worker script loaders. The script loaders are shared with PlzSharedWorker. PlzDedicatedWorker depends on off-the-main-thread dedicated worker script fetch and NetworkService. IsPlzDedicatedWorkerEnabled() helper makes sure it. Follow-up CLs will implement the renderer-side, and add tests. See also the class diagram in the design doc: https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing Bug: 731604, 906991 Change-Id: I1a7392b68f33a68dec22e347d931a0bb757fb38a Reviewed-on: https://chromium-review.googlesource.com/c/1445037Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#629930}
-
Markus Heintz authored
This is the first part (cl) for adding a new record only sync data type for recording security events. This CL adds the Chrome Sync Specifics proto. In the next CL the Sync Data type will be wired. Bug: 919489 Change-Id: I542f5cae27568927e614f793edfaf374058ea70a Reviewed-on: https://chromium-review.googlesource.com/c/1455998 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
In crrev.com/c/1454618 FamilyInfoFetcher was migrated to use PrimaryAccountAccessTokenFetcher. However the code is still observing IdentityManager for the OnRefreshTokensLoaded() notification. It turns out that it is not very useful to listen to that as it's really unreliable. The reason is that at the time StartFetching gets called, OnRefreshTokensLoaded might or might not have happened already. If it has *not* already happened, then we'll report an error to the client. But if it *has* already happened, then we'll just end up waiting forever anyway. And there's not even a way for the client to know. Bug: 920965 Change-Id: I49b8741bfe438855bdf9c74c1a52528bba3baa79 Reviewed-on: https://chromium-review.googlesource.com/c/1454959 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2af003349292..29ecb64560ae git log 2af003349292..29ecb64560ae --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com Merge "trace_processor: make kernel lmk events lookup the upid for utid" 2019-02-07 taylori@google.com Merge "perfetto-ui: Add deselection" Created with: gclient setdep -r src/third_party/perfetto@29ecb64560ae The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaf99164c4e5c299bf98c440279b7c7ac26e4cdc9 Reviewed-on: https://chromium-review.googlesource.com/c/1457529Reviewed-by:
-
Benoît Lizé authored
The original size is the size without compression. This allows to see the savings in memory-infra memory dumps. Also add a trace event for the aging task. Bug: 924164 Change-Id: I5cb2f968f8ec51d330b66fa211fde048bb5e2323 Reviewed-on: https://chromium-review.googlesource.com/c/1456657 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Kush Sinha authored
A lot of tests fail with with Chrome OS Account Manager enabled. This patch fixes all of them in preparation of https://crrev.com/c/1426779. Failure details: https://crbug.com/915628#c8 Summary of (non-tests) changes: - Allow setting a fake URL loader factory in Account Manager - Initialize Account Manager for |TestingProfile| Bug: 915628 Test: interactive_ui_tests Test: sync_integration_tests Test: browser_tests Change-Id: I93aa1107fc1c48ed5e48bd38c0847e98ee15bcc6 Reviewed-on: https://chromium-review.googlesource.com/c/1437209 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I31902ed557d0dbc70df6dc3647d5de13ea641630 Reviewed-on: https://chromium-review.googlesource.com/c/1457528Reviewed-by:
-
David Roger authored
As this observer method has no production listeners, it is simply dead code. Bug: 922406 Change-Id: I9aa23327aed829111ca03ba3013840fdac5542d7 Reviewed-on: https://chromium-review.googlesource.com/c/1452443 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
AutofillDownloadManager calls variations::ShouldAppendVariationsHeader() to know if the specified URL is trusted by Google. But this call has a side effect to record histograms, and results in double counting for those uses. This patch factors out Google trusted URL checks into google_util, and change variations:: and AutofillDownloadManager to call google_util::IsGoogleRelevantUrl for each slightly different purpose. Bug: None Change-Id: I66dc666011e4cc57327e06889adaeb2828ac6232 Tbr: mahmadi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1451504 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629922}
-
Christian Dullweber authored
Add RemovalOptions.origins and RemovalOptions.exludeOrigins parameters to allow extensions to delete only a specific set of origins or exclude some origins from deletion. Bug: 78093, 113621, 924113 Change-Id: I42dbdf785ea5ef1cf9a3a95981a7551f2fadd2e2 Reviewed-on: https://chromium-review.googlesource.com/c/1405012 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#629921}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8200b1f0ea55..b68e715cb291 Created with: gclient setdep -r src-internal@b68e715cb291 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id1ad2dbc028b0cb1283f80248993c13cfa82540d Reviewed-on: https://chromium-review.googlesource.com/c/1457527Reviewed-by:
-
Marek Haranczyk authored
Bug: 854329 Change-Id: Ia163d503a4207859cd41c847c9d5f67e77580fbc Reviewed-on: https://chromium-review.googlesource.com/c/1456080Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Cr-Commit-Position: refs/heads/master@{#629919}
-
