- 26 Aug, 2020 40 commits
-
-
Russ Hamilton authored
Small change to measurement of sampled surfaces so that this type can be explicitly disabled as part of the Identifiabilty study settings. Bug: 1112787 Change-Id: I54fddb93276f152fe11dcd39326ad85bb142e1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375698Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#801796}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7023f47299aa..0fdfdcf61cd4 2020-08-26 lalitm@google.com tp: fix python test runner not returning errors on failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9088250a5c077579c1985b81540eb432cad74a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801795}
-
David Tseng authored
This change enables AccessibilityEventRewriter to only process key events from specific types of keyboard input devices. The new public method can be used by clients such as Switch Access to only consider key events from usb or bluetooth switches which show up as keyboard devices. Bug: none Test: ash_unittests --gtest_filter=Switch*.SetKeyboardInputTypes. Requires manual verification with switch devices. Change-Id: I7496b95cb380b9ddf301d7fa7bebb9748bdf40e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376035 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#801794}
-
Etienne Pierre-doray authored
It's necessary to temporarily implement both old and new versions of GetMaxConcurrency() until v8-platform makes the old version optional. Bug: 1114823 Change-Id: I284f97a36ffb8718c3b42c05a949cfc29f4f1678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375505Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#801793}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b77998026e82..fb9ee39c41d4 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/ContentProviderBasedProject.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/SoftDropDown.js with TypeScript 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/BreakpointManager.js with TypeScript 2020-08-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-26 petermueller@chromium.org Add feedback icon If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide41a83747fcc7b8ff48986d5de5909f190a0a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377357Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5da7327358e3..03cde5f9997d 2020-08-26 djsollen@google.com Revert "Reland "ICU: SkShaper (bidi iterator only)"" 2020-08-26 ethannicholas@google.com optimized SkSL inlining output If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ibe57ab2c55c73b133ab770cee708d43928e015a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378085Reviewed-by:
-
Monica Basta authored
This CL adds 'Done' button that on click will create a new profile. Once the profile is created, it is opened and the picker is closed. This CL also adjusts the layout of the page based on the latest mocks that takes into consideration different screen sizes. Screenshots: https://drive.google.com/file/d/1js21n3dxRaSkOqdBnn3v27e096UaiPE5/view?usp=sharing https://drive.google.com/file/d/11SIROfvDnIud8JkqZDsmlegnNkoDwmYD/view?usp=sharing https://drive.google.com/file/d/1x12IWRlhcQbLf4cmJ_1WoeQXzc9WDmn3/view?usp=sharing https://drive.google.com/file/d/17cfK6xuAkim9jvNxIgHIUVVljwOsUTu0/view?usp=sharing https://drive.google.com/file/d/1bkzZlNmae1ZIA_7b_13vf-THGcNZ8nD0/view?usp=sharing https://drive.google.com/file/d/1GnnSQ4qTRJxXEnsOPLyWoaNjnO_4zxDa/view?usp=sharing Bug: 1115056 Change-Id: I72c6f2ee07751b61f264443eab468583f7b2c95a Fixed: 1121662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375292 Auto-Submit: Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801790}
-
Peter Kasting authored
Bug: 1116289 Change-Id: If301c1bbac0ab64e06b9e23337a530033217e7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376506 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801789}
-
David Bertoni authored
This CL fixes one more instance of this issue by moving the code to the constructor. Bug: 1117287 Change-Id: I21c1749d1bc037c7952ef7130934c50d37f6b5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376044Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#801788}
-
Alice Wang authored
This CL simplifies identity manager tests' setup with AccountManagerTestRule. Bug: 1120301 Change-Id: I9ee0af5a144b582739a87b53dd8f8cd73c6eed44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369093Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801787}
-
henrika authored
Bug: 1109831 No-Presubmit: True Change-Id: Iab08af0a69f1e868d01031796c0d417644055333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377866Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#801786}
-
David Bienvenu authored
A few other minor cleanups, no functional changes. Bug: 1010217 Change-Id: I9b14492cbe21699f0d2c1d86f73a4937e599c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368414 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#801785}
-
Boris Sazonov authored
Renames IDS_SYNC_ANDROID_MASTER_SYNC_DISABLED to IDS_SYNC_ANDROID_SYSTEM_SYNC_DISABLED and adds a screenshot for this string. Bug: 1121973 Change-Id: Ifd49a44d3de5fc1397873e700d9325aa71b36d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377709 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#801784}
-
Vladimir Levin authored
This patch splits the RenderPass class (and RenderPassDrawQuad) into Aggregated version which is what the renderer and overlay systems deal with (post surface-aggregation), and a compositor version which is what each surface would submit for aggregation. Change-Id: I31b6aa73e1bbd93b46384b1dd6d98ba50541486d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321397 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#801783}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I574564174d10b5e35159819c6ee9b57f503e920f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377356Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c093d9ad623d..91c0477b4332 2020-08-26 lndmrk@webrtc.org Add AV1 support to IVF reader and writer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2c8bc2493d756f29f430e2d6266ec65debc10dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377858Reviewed-by:
-
Sean Gilhuly authored
SkiaRendererPixelTestWithOverdrawFeedback/2.TranslucentRectangles is now RendererPixelTestWithOverdrawFeedback.TranslucentRectangles/SkiaDawn after recent changes. The filter wasn't updated, but the test is now passing on the bots. Remove it from the filter file. Bug: 1061988 Change-Id: Icf043283ac95d0a32b68432a34a4793bafb6628a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377107Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#801780}
-
Henrik Boström authored
This reverts commit 864e565b. Reason for revert: Not the culprit of the bot failures Original change's description: > Revert "[Perfect Negotiation] Re-enable temporarily disabled WPTs." > > This reverts commit 154433da. > > Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 > > Original change's description: > > [Perfect Negotiation] Re-enable temporarily disabled WPTs. > > > > Now that https://webrtc-review.googlesource.com/c/src/+/180620 has > > rolled into chromium, we can re-enable the disabled tests and update > > the expectations that more tests are passing. > > > > Follow-up CLs will make us pass even more tests. > > > > Bug: chromium:1060083 > > Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707 > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801716} > > TBR=hta@chromium.org,hbos@chromium.org > > Change-Id: I3250545b0fff846a8c4c3a9352f5a342ae613599 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1060083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377872 > Reviewed-by: Amr Aboelkher <amraboelkher@google.com> > Commit-Queue: Amr Aboelkher <amraboelkher@google.com> > Cr-Commit-Position: refs/heads/master@{#801762} TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com # Skipping bots on reland because the revert was by mistake and there # are CL dependencies. NOTRY=True Bug: chromium:1060083 Change-Id: Ic542d9d2a6051de05073b59a21a2dee7ae81eafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376814Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801779}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc5e5f36. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 4e9cbb66 "Fixed test/reference mismatch for border." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I234b171fda432540cad21c18a24a0ee2f6b0faf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378005Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801778}
-
Bo Liu authored
Rename "virtual context lost" to just context lost and share the implementation for all GLContext subclasses: * MakeCurrent is no longer virtual and add virtual MakeCurrentImpl * MakeCurrent will mark context as lost if MakeCurrentImpl fails * Similar change for CheckStickyGraphicsResetStatus * Update all subclasses to override the impl methods. * Unit test mock needs to be updated to override the MakeCurrentImpl * Some unit tests directly call GLContextStub::MakeCurrent instead of the mock implementation, which now needs to be updated to MakeCurrentImpl Bug: 1115482 Change-Id: I50c6fa9364ca8fff7be589c9ac799c495c034f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363357Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801777}
-
Roman Sorokin authored
It's not actually registered before device is owned. Bug: none Change-Id: I124f4cecb7ea440e9b746827dc3b37fd0ccd48fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377805Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801776}
-
Rob Buis authored
Add a method to find the category for a given (String, form) pair as described in the spec [1] as well as unit tests. [1] https://mathml-refresh.github.io/mathml-core/#operator-dictionary Bug: 6606 Change-Id: I87aceb73720bf0e023d11767cde823ec4e04f185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375207Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#801775}
-
Benjamin Beaudry authored
This CL ensures that positioned nodes are inserted in the right fragmentainer and at the appropriate start offset. Bug: 1079031 Change-Id: I2ae47f4c210c64843d6e260b94165bdd25f79879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332300Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801774}
-
HyunJi Kim authored
Bug: 1010217 Change-Id: Icaffadcc037835b3c498a01b7a71d2ac77fc8dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375010 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801773}
-
Morten Stenshorne authored
On the layout object side, all children of a fieldset are wrapped inside an anonymous fieldset contents block. We'll detect during layout which of the legend children (if any) will become the rendered legend. Unlike all other in-flow children of a fieldset element, whose containing block is the wrapper, the containing block of the rendered legend is the fieldset layout object itself (not the wrapper child), so if we change / remove the rendered legend, the wrapper won't be marked for layout. Bug: 1119400 Change-Id: I5b898af8c7b7e3687def6a2333d43a8ba6af09b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374526Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#801772}
-
Erik Chen authored
The ChromeOS platform team still relies on these histograms. This CL extends the expiry and updates the owners of the histogram. Bug: 1084030 Change-Id: Id28dc41480e7106b30a5c77f6a18243272b4e062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368540 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801771}
-
dizg authored
Bug: 1115247 Change-Id: I0b4c90250ea532b6d8d427437073a785b54b8515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373082Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
-
Amr Aboelkher authored
This reverts commit dc5e5f36. Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 Original change's description: > Import wpt@a75c689d52f70baf607c8e6c1bb84c57f48badda > > Using wpt-import in Chromium c21b8329. > With Chromium commits locally applied on WPT: > 9f52c7e4 "COOP: add reporting to redirects" > d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" > > > Note to sheriffs: This CL imports external tests and adds > expectations for those tests; if this CL is large and causes > a few new failures, please fix the failures by adding new > lines to TestExpectations rather than reverting. See: > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md > > Directory owners for changes in this CL: > futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: > external/wpt/css/css-cascade > > NOAUTOREVERT=true > TBR=robertma@google.com > > No-Export: true > Change-Id: I1a13539eede33cfc0ecb838dd86dbcd04e84481d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377457 > Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#801734} TBR=robertma@google.com,wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Change-Id: I35b79183bad9975df7d6f87fb6bbe2f50cb9e2ed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377493Reviewed-by:
-
Yuki Shiino authored
Blink is implementing CSSStyleDeclaration's IDL attributes as named properties (pretending to be IDL attributes). Recently, the named property's implementation is improved[1] to better conform to Web IDL specification, and "deletion of named properties" now throws an exception when named deleter is not defined. So, accordingly CSSStyleDeclaration has to _better pretend_ to have IDL attributes, which are deletable, by defining a noop deleter. This patch introduces such a noop deleter. [1] https://crrev.com/c/2335713 Bug: 1121628 Change-Id: I338c064b9a2ea88fa97169a9e904da0a8613e0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377035Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#801768}
-
Benoit Lize authored
The build file wants to exclude TCMalloc, but it also excludes PartitionAlloc. This is incompatible with PartitionAlloc everywhere. Bug: 998048 Change-Id: I5c234c70bd0e3b73d69fd8e648ac36be1510d872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377710Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jordan Oroshiba authored
Change is being made in order to enable future changes in behavior between the All Site Setting pages and other categories. Bug:1074245 Change-Id: I59d50af6a5c1f681ffb9b0ff9ebdf89cd14ebcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252560 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#801766}
-
Antonio Gomes authored
... instead of base::EndsWith(). BUG=787254 R=guidou@chromium.org Change-Id: Ia14a71fc3d04918cbc8d65738ad7bca3b0cb6dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363553 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#801765}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1303230f0260..b77998026e82 2020-08-26 alexrudenko@chromium.org Simplify the grid tooling settings 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/BlackboxManager.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/ListControl.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/ListWidget.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I899bfa5e974729b0c75fcb3d246e5027a8c21361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377856Reviewed-by:
-
Jeremy Roman authored
This reverts commit 6a1fac8e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Mostly remove refcount thrashes of value in setAttribute. > > Relanding https://chromium-review.googlesource.com/c/chromium/src/+/2351950 > > This mostly removes the refcount thrashes in Element::setAttribute() > which accounts for nearly 13% of regression in blink_perf.bindings > set-attribute.html story when StringImpl is made threadsafe. > > Because of some reentrant behavior in Element::setAttribute() -> > Element::SetAttributeInternal() -> Element::DidModifyAttribute() -> > Element::AttributeChanged() -> Element::ParseAttribute() -> > Element::setAttribute(), the qname for the Attribute, the old value, > and the new value cannot be easily transfered into the Element's internal > ElementData::Attributes() collection while also publishing the change to > observers via the DidModifyAttribute() call. Removal of that thrash will > be done in a follow-up CL. > > Bug: 1083392 > Change-Id: I7f7f4bfa22a2e553e703c0375bd04bb77f71de23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369348 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801214} TBR=ajwong@chromium.org,jbroman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1083392,1121429 Change-Id: Ia42214b62e1efc218afb055fcc60bea52039587c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376705Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#801763}
-
Amr Aboelkher authored
This reverts commit 154433da. Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 Original change's description: > [Perfect Negotiation] Re-enable temporarily disabled WPTs. > > Now that https://webrtc-review.googlesource.com/c/src/+/180620 has > rolled into chromium, we can re-enable the disabled tests and update > the expectations that more tests are passing. > > Follow-up CLs will make us pass even more tests. > > Bug: chromium:1060083 > Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801716} TBR=hta@chromium.org,hbos@chromium.org Change-Id: I3250545b0fff846a8c4c3a9352f5a342ae613599 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377872Reviewed-by:
-
Fergus Dall authored
Bug: None Change-Id: Ifbda9222895575bb2471036df15c4778fe7b89bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374935 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#801761}
-
Alice Wang authored
This CL renames AccountPickerBottomSheetState as ViewState to make the code more readable. There is no behavior change in this CL. Bug: 1121499 Change-Id: Idaa9d72238e6012fe6f71dec7928ed41760d8582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375291Reviewed-by:
-
Weilun Shi authored
The split histogram_suffies_list.xml under histograms_xml/ should also be pretty-printed. Bug: 1121852 Change-Id: Icbdc0891c214be95b51a94c0a8520b2eb2e6aaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376885 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#801759}
-
Alice Wang authored
This CL cleans up AccountPickerBottomSheetTest. Bug: 1121536 Change-Id: I00d8e5506bf38411bfd16a664c1667ebbd074379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374867Reviewed-by:
-
Elly Fong-Jones authored
These importer tests rely on loading some dylibs out of //chrome/test/data/firefox3_nss_mac, which aren't yet (and may never) be available for arm64. Bug: 1121685 Change-Id: Ifb316784e3ffd851d3b507baa630f746695bdb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375895Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801757}
-
