GitLab

Revert 95552 - Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserContext> instead of a Source<NavigationController>.

We do this since SSLManagers want to hear all the notifications coming from different NavigationControllers; not just from the one they are associated with.

BUG=87457
TEST=none
R=abarth
TBR=darin

Review URL: http://codereview.chromium.org/7542029

Sorry about this. The tree stubbornly refuses to go green and yours is the only remaining patch in the blamelist.

TBR=erg@google.com
Review URL: http://codereview.chromium.org/7575035

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7550025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95571 0039d316-1c4b-4281-b951-d872f2087c98

Histograms that "clip" data (discard samples
over a given point) make it hard or impossible
to contrast results (such as via trimmed means).
As a result, a long standing note asked that these
histogram form no longer be used.
This CL removes all remaining uses, and discards
so histograms that are no longer significant (to
SDCH experimentation).  We transition to 
CUSTOM_HISTOGRAMS for all cases where the data
appears to be useful (and we provide new names
for the histograms).

r=rtenneti,wtc

Review URL: http://codereview.chromium.org/7553025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95570 0039d316-1c4b-4281-b951-d872f2087c98

Also added helper functions _CheckHistory and _NavigateAndCheckHistory used by the tests below to verify that the correct changes are made to the history list. 

Tests included: 
--------------- 
testNavigateBringPageToTop: 
--- Verify that navigation brings the current page to the top of the history list. 

testReloadBringPageToTop: 
--- Verify that reloading a page brings that page to the top of the history list. 

testBackForwardBringPageToTop: 
--- Verify that back/forward brings the current page to the top of the history list. 

testAppendTabAddPage: 
--- Verify that opening a new tab adds that page to the history list. 

testOpenWindowAddPage: 
--- Verify that opening a new window to a page adds that page to the history list. 

TEST=none 
BUG=none 

Continuation of CL 7544032.

Review URL: http://codereview.chromium.org/7574028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91682
TEST=Open Chrome, open incognito window, check app menu to make sure there is an item for sync


Review URL: http://codereview.chromium.org/7511024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95568 0039d316-1c4b-4281-b951-d872f2087c98

And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager.
- TaskManagerBrowserTest.ShutdownWhileOpen
- ExtensionApiTest.ProcessesVsTaskManager
- PrerenderBrowserTest.PrerenderTaskManager

BUG=chromium-os:13885
TEST=trybots

Review URL: http://codereview.chromium.org/7550004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran unit_tests

Review URL: http://codereview.chromium.org/7497028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95566 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Click favicon. Page info bubble shouldn't jump around
after 1s but look nice instead (mostly. Now the text at the
bottom jumps now, but that looks way better than everything
but the text jumping.)


Review URL: http://codereview.chromium.org/7575025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7572039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95563 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6304: (mcgrathr) Remove magic to get IRT-compatible linking layout for browser-targetted nexes
r6305: (ncbray) Add a hard timeout for the browser tester to stop runaway tests.
r6306: (mcgrathr) Define private __aeabi_read_tp for IRT
r6307: (mcgrathr) Load IRT for spec2k runs
r6308: (jvoung) Bump toolchain deps. Pull in pdox's windows changes:
r6309: (mcgrathr) Remove -lppapi hack for nacl_irt_test
r6310: (sehr) Make __launchExecutableFromFd take a continuation rather than returning success
r6311: (sehr) Remove possible use-after-free attack from console logging.
r6312: (mseaborn) Cleanup: Remove obsolete reference to SDL from comment in sel_main.c
r6313: (bradnelson) Allow branch to get either native_client (as on the buildbots)
r6314: (jvoung) Fix pnacl glibc builder -- no more platform libs in sdk() after removal of link_segment_gap.o:
r6315: (mseaborn) Cleanup: Fix typo in comment
r6316: (mseaborn) Cleanup: Fix spelling: "seperate" -> "separate"
r6318: (mcgrathr) Clean up buildbot context tests, get browser tests re-enabled on trybots
r6319: (ncbray) Fixed how NaCl's build system used asserts.
r6320: (ncbray) Added a stress test for determining now many nexes can be loaded simultaneously.
r6321: (ncbray) Fixed breakage introduced in r6320.
r6322: (mseaborn) Only set SDKROOT for standalone builds - redo r4926.

Also, disable a thread safety stress test that is known to be flaky on
Windows (run_ppapi_ppb_var_browser_test).

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/7566045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95562 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7523051

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7491048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95561 0039d316-1c4b-4281-b951-d872f2087c98

platforms.

TBR=apatrick
Review URL: http://codereview.chromium.org/7575019

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7583001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95560 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses the uninitialized-variable-used errors in sync_ui_util::ConstructAboutInformation() caused probably by r95536 <http://crrev.com/95536>.

TBR=timurrrr,glider,thestig
BUG=91771
TEST=make the "Linux Tests (valgrind)(6)" bot greener.
Review URL: http://codereview.chromium.org/7582001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95559 0039d316-1c4b-4281-b951-d872f2087c98

This is so that webui based login can be automated.

BUG=chromium-os:18740
TEST=None

R=zelidrag@chromium.org

Review URL: http://codereview.chromium.org/7575032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95555 0039d316-1c4b-4281-b951-d872f2087c98

Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserContext> instead of a Source<NavigationController>.

We do this since SSLManagers want to hear all the notifications coming from different NavigationControllers; not just from the one they are associated with.

BUG=87457
TEST=none
R=abarth
TBR=darin

Review URL: http://codereview.chromium.org/7542029

Sorry about this. The tree stubbornly refuses to go green and yours is the only remaining patch in the blamelist.

TBR=erg@google.com
Review URL: http://codereview.chromium.org/7575035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95552 0039d316-1c4b-4281-b951-d872f2087c98

- Respect account settings by using the users list and other flags passed into
  WebUILoginDisplay::Init;
- Limit max 5 users to avoid scrolling in account picker;
- Increase account picker width to 1100px to avoid crop on user pods;
- Properly remove a user, i.e. go through UserManager::RemoveUser instead
  of delete it directly using RemoveUserFromList;
- Improve the tab order;
- Switch to Gaia sign in if user failed login three times in a row;
- Turn off init animation;

BUG=chromium-os:18532,chromium-os:18668,chromium-os:18312,chromium-os:18307
TEST=Verify fix for chromium-os:18532,chromium-os:18668,chrmoum-os:18312 and chromium-os:18307.

Review URL: http://codereview.chromium.org/7461142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18740
TEST=make sure pass-through auth extension is working when we start chrome with --skip-oauth-login switch.
Review URL: http://codereview.chromium.org/7575030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91729
Review URL: http://codereview.chromium.org/7575021

TBR=apatrick@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7480032

TBR=scottfr@chromium.org
Review URL: http://codereview.chromium.org/7566054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7480032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95542 0039d316-1c4b-4281-b951-d872f2087c98

Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserContext> instead of a Source<NavigationController>.

We do this since SSLManagers want to hear all the notifications coming from different NavigationControllers; not just from the one they are associated with.

BUG=87457
TEST=none
R=abarth
TBR=darin

Review URL: http://codereview.chromium.org/7542029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91729
Review URL: http://codereview.chromium.org/7575021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7572032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95538 0039d316-1c4b-4281-b951-d872f2087c98

This test has failed a few times on the waterfall lately, and this will help
me understand what's going on.

BUG=91753
TEST=none

Review URL: http://codereview.chromium.org/7511028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91134
TEST=Set up sync, inspect chrome://sync


Review URL: http://codereview.chromium.org/7550023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95536 0039d316-1c4b-4281-b951-d872f2087c98

past the first frame.  Added a call to notifyPixelsChanged on the bitmap to 
invalidate the associated texture chache entry, so that the frame will update
correctly.

BUG=57695
TEST=http://www.craftymind.com/factory/html5video/CanvasVideo.html

Review URL: http://codereview.chromium.org/7572027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=XXX
TEST=XXX

Review URL: http://codereview.chromium.org/7355025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95534 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Starting DumpRenderTree will assert without this after I land a change in WebKIt.

Review URL: http://codereview.chromium.org/7578013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95533 0039d316-1c4b-4281-b951-d872f2087c98

When the user logs in, auto connect to preferred network if appropriate.
BUG=chromuim-os:3559
TEST=manual
Review URL: http://codereview.chromium.org/7566015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91719
TEST=Manual

Review URL: http://codereview.chromium.org/7574019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=71130
Review URL: http://codereview.chromium.org/7545020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual


Review URL: http://codereview.chromium.org/7578009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91745
Review URL: http://codereview.chromium.org/7576022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95525 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit


Review URL: http://codereview.chromium.org/7574009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95523 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7574023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91715
Review URL: http://codereview.chromium.org/7579001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7465016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95520 0039d316-1c4b-4281-b951-d872f2087c98

message_pump_libevent_unittest.cc uses libevent directly, and it must get USE_SYSTEM_LIBEVENT symbol to work correctly with libevent. To make that work, base_unittests must depend on libevent.gyp, which uses direct_dependent_settings to set USE_SYSTEM_LIBEVENT.

This is upstreaming a Gentoo Linux patch.

BUG=none

Review URL: http://codereview.chromium.org/7578011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95519 0039d316-1c4b-4281-b951-d872f2087c98

XIB changes:
- Add new "Enter Presentation Mode" menu item with Cmd-Shift-F.
- Change key equivalent for "Enter Full Screen" to Cmd-Opt-F.

On Lion:
This CL separates the concepts of "fullscreen mode" and "presentation mode."
Fullscreen mode uses Lion's fullscreen mode and places the window in its own
space.  Presentation mode is an extra option to additionally hide the UI when in
fullscreen mode.  On Lion, clicking on the fullscreen button takes you into
fullscreen mode, in which there is a button to toggle presentation mode on or
off.  While in normal windowed mode, there are two menu options to either "Enter
Full Screen" or "Enter Presentation Mode" directly.

On Snow Leopard:
This CL does not change much on Snow Leopard.  To maintain consistency with the
new Lion terminology, the "Enter Full Screen" menu item has been renamed to
"Enter Presentation Mode."

BUG=74065
TEST=Fullscreen works in Lion.  Fullscreen continues to work as before in Snow Leopard.
Review URL: http://codereview.chromium.org/7566016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95518 0039d316-1c4b-4281-b951-d872f2087c98

my favorite part is:

  static bool first_view = true;
  if (first_view) {
    first_view = false;
  }

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7562019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95517 0039d316-1c4b-4281-b951-d872f2087c98