GitLab

BUG=137411
TEST=unit_tests --gtest_filter='*GDataFileWritingTest*'
TEST=press Ctrl+P and then the save button, choose Google Drive, and verify it is correctly saved.

Review URL: https://chromiumcodereview.appspot.com/10827068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149799 0039d316-1c4b-4281-b951-d872f2087c98

We should grant read permission to the file returned by CreateFileSnapshot since the file must have given for reading

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149798 0039d316-1c4b-4281-b951-d872f2087c98

Added check for invalid histogram data, added additional diagnostics to find the source of troubles on ChromeOS.

BUG=140301
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138588, 131203, 139887
TEST=

Review URL: https://chromiumcodereview.appspot.com/10832019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139769
TEST=manually open the page and test

Review URL: https://chromiumcodereview.appspot.com/10825095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149795 0039d316-1c4b-4281-b951-d872f2087c98

Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*

Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.

Review URL: https://chromiumcodereview.appspot.com/10704026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149794 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149793 0039d316-1c4b-4281-b951-d872f2087c98

r1449/r1450: Pass defines to midl.exe.
r1447: ninja windows: Add build.ninja variable to turn on dep_database.

r1448 was reverted in r1451.

BUG=140324

Review URL: https://chromiumcodereview.appspot.com/10823151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149792 0039d316-1c4b-4281-b951-d872f2087c98

This is a clean rewrite of ajwong@'s add-gdb-index script.

BUG=NONE


Review URL: https://chromiumcodereview.appspot.com/10843037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6944
TEST=sbox_integration_tests
Review URL: https://chromiumcodereview.appspot.com/10823134

TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10828142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2937
TEST=From Dust, ppapi tests

Review URL: https://chromiumcodereview.appspot.com/10824156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136438


Review URL: https://chromiumcodereview.appspot.com/10823156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120608
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149785 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10830103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6944
TEST=sbox_integration_tests
Review URL: https://chromiumcodereview.appspot.com/10823134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149782 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149781 0039d316-1c4b-4281-b951-d872f2087c98

For classes with long package/class names, this can extend over 80 characters
when preceded by a #ifndef, etc..

BUG=


Review URL: https://chromiumcodereview.appspot.com/10850030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149780 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=2
CID=104562,104563
BUG=none
R=khorimoto@chromium.org
TBR=rch


Review URL: https://chromiumcodereview.appspot.com/10828138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149778 0039d316-1c4b-4281-b951-d872f2087c98

testNewTabDocs loads Google Docs and then waits until an expected
substring appears on the page before continuing.  Previously, the test
waited for a string that only appears when viewing the "my drive" folder,
because it was assumed that we'd always see that folder when opening google
docs.

However, sometimes the "shared with me" folder appears on page load.  This
appears to be because google docs opens the last folder opened by the
account.  Since we have another perf test that clicks on the "shared with me"
folder, then the current test will sometimes fail to realize the page loaded,
since an unexpected screen is displayed after page load.

The fix is to have this test wait for a different substring on the page,
which appears regardless of which folder shows up when loading google docs.

BUG=None
TEST=Verified the test runs for 10 iterations whereas previously it failed
after only 1 or 2 iterations.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10832127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149777 0039d316-1c4b-4281-b951-d872f2087c98

Reverting because r149766 broke "Linux ChromiumOS Tests (2)".
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/5610

Dependent upon https://chromiumcodereview.appspot.com/10568014

TBR=brettw@chromium.org

BUG=130212
TEST=included


Review URL: https://chromiumcodereview.appspot.com/10656052

TBR=mitchellwrosen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125043

Review URL: https://chromiumcodereview.appspot.com/10823067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149775 0039d316-1c4b-4281-b951-d872f2087c98

Remove WebAuthFlowWindow and its implementation on all platforms. We don't need it anymore since we now use browser popups.

TBR=ben

Review URL: https://chromiumcodereview.appspot.com/10823149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149774 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=104605
BUG=none
R=khorimoto@chromium.org
TBR=aa,sky


Review URL: https://chromiumcodereview.appspot.com/10826127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140401

Review URL: https://chromiumcodereview.appspot.com/10824160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149772 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149771 0039d316-1c4b-4281-b951-d872f2087c98

It appears the sizeof change was to make the code more future proof:

sizeof(float) -> sizeof(audio_data[0])

However, audio_data[0] is a float*, not the intended float.  Adding the deref
to fix this.

CID_COUNT=1
CID=104561
BUG=none
R=scherkus


Review URL: https://chromiumcodereview.appspot.com/10832123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149770 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10850032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149769 0039d316-1c4b-4281-b951-d872f2087c98

Parent means a folder containing a file in Drive v2 API.
If a file does not contain any reference to its parent, it should be
interpreted as the file is under the root directory.
Changed existing unit test for checking the case that parent is missing.

BUG=chromium:127728
TEST=unit_tests --gtest_filter="DriveAPIParserTest.*"

Review URL: https://chromiumcodereview.appspot.com/10829139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149768 0039d316-1c4b-4281-b951-d872f2087c98

Mapping from extension.location():

INTERNAL -> 'normal'
LOAD -> 'development'
EXTERNAL_POLICY_DOWNLOAD -> 'admin'
EXTERNAL* -> 'sideload'
(all others) -> 'other'

BUG=135564
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10750010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149767 0039d316-1c4b-4281-b951-d872f2087c98

Dependent upon https://chromiumcodereview.appspot.com/10568014

TBR=brettw@chromium.org

BUG=130212
TEST=included


Review URL: https://chromiumcodereview.appspot.com/10656052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149766 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=104610
BUG=none
R=khorimoto@chromium.org
TBR=sky


Review URL: https://chromiumcodereview.appspot.com/10829154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149765 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to re-enable it after tuning parameters in http://codereview.chromium.org/10782017/

BUG=


Review URL: https://chromiumcodereview.appspot.com/10823152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149764 0039d316-1c4b-4281-b951-d872f2087c98

SpawnCleanup may trigger the destruction of a partially created TargetProcess.

BUG=139898
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10831133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149763 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10850035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149762 0039d316-1c4b-4281-b951-d872f2087c98

This is often uninitialized in UI and browser tests. This blocks issue 10829031
from landing.

BUG=139093


Review URL: https://chromiumcodereview.appspot.com/10831104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149761 0039d316-1c4b-4281-b951-d872f2087c98

Revert 149610 - Extension resources should only load in contexts the extension has permission to access.

See http://codereview.chromium.org/10792008/ for background.

BUG=139592

Review URL: https://chromiumcodereview.appspot.com/10828067

TBR=mkwst@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10826134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149760 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10834037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149759 0039d316-1c4b-4281-b951-d872f2087c98

default_defines is no longer set in untrusted.gypi
Using normal define merging instead.

R=bbudge@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10825145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149758 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136438
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149757 0039d316-1c4b-4281-b951-d872f2087c98