GitLab

Reland "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time"

This reverts commit 2df0c83a.

Reason for revert: official android should be fine with this after #583420

Original change's description:
> Revert "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time"
> 
> This reverts commit ef36dc19.
> 
> Reason for revert: This turns out to break the official android build, which apparently was relying on a broken aspect of the build that this fixed :(. See https://crbug.com/871173.
> 
> Original change's description:
> > win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time
> >
> > We used to set the timestamp to a hash of the binary, similar to
> > https://blogs.msdn.microsoft.com/oldnewthing/20180103-00/?p=97705
> > However, that caused an appcompat warning on Windows 7 to appear, which
> > interpreted the hash as a timestamp. (It's possible that https://llvm.org/PR38429
> > could help with that, but my guess it won't have an effect on Windows 7,
> > which likely always believes that the the coff timestamp field always stores
> > a timestamp).
> >
> > So currently we write the current time during linking in that field, but that's
> > bad for build determinism and that in turn is bad for swarming test result cachability.
> >
> > build/write_build_date_header.py already creates a deterministic BUILD_DATE
> > with several tradeoffs. Cachability wants this to change infrequently, but
> > things like HSTS need a "real" build date and want this to change frequently.
> > The compromise is: The date changes once per day in official builds, and
> > once a month in regular builds.
> >
> > (We could use /Brepro in ldflags instead of /TIMESTAMP for unofficial builds to get
> > the binary hash in the timestamp, but having the header timestamp match the BUILD_DATE
> > define seems nice.)
> >
> > So let's use that same time as timestamp in the PE/COFF header. lld-link has a
> > /TIMESTAMP: flag we can use to pass in an explicit timestamp.
> >
> > Since tools can't have deps, we need to compute the timestamp at gn time,
> > so split write_build_date_header.py in two pieces: build/compute_build_timestamp.py
> > that just prints the timestamp we want to use, and the old write_build_date_header.py, which
> > now takes that timestamp and writes the header file.
> >
> > Call compute_build_timestamp.py at gn time so that we can pass it in ldflags, and
> > pass the resultl to write_build_date_header.py which keeps running as an action
> > during build time (so that we at least don't need to write a file at gn time).
> >
> > An additional wrinkle here is that the PE/COFF timestamp is used as one of just two
> > keys per binary for uploading PE binaries to the symbol server, the other being file size.
> > https://bugs.llvm.org/show_bug.cgi?id=35914#c0 has a good description of this, and
> > tools/symsrc/img_fingerprint.py's GetImgFingerprint() is our implementation of it.
> > But since we only upload binaries with symbols for official chrome builds to the symbol server,
> > a timestamp that changes once a day should be still enough. (32-bit and 64-bit chromes
> > have the same filename, and we might rarely build canary and beta and stable all on the
> > same day, but them all being the same size seems highly unlikely.)
> >
> > Bug: 843199,804926,330260
> > Change-Id: I1d4193cc537ae0c4b2d6ac9281fad29de754dd6c
> > Reviewed-on: https://chromium-review.googlesource.com/1161104
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Hans Wennborg <hans@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580585}
> 
> TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org
> NOTRY=true
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 843199, 804926, 330260
> Change-Id: Ib93697a82f8a9d3fb303b763609e82e0612887cd
> Reviewed-on: https://chromium-review.googlesource.com/1166203
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581485}

TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843199, 804926, 330260
Change-Id: I136e405c84eba3f61a4ac96b2017a34ade0cfba6
Reviewed-on: https://chromium-review.googlesource.com/1179281
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583945}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15b1778c2c45..ed0d273bfa51


git log 15b1778c2c45..ed0d273bfa51 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@ed0d273bfa51

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I8b10a74eabfae5d173fce36ba3a7b9aa5001a0d0
Reviewed-on: https://chromium-review.googlesource.com/1179321Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583944}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/c43b409d9688..6e5fd1672be5


git log c43b409d9688..6e5fd1672be5 --date=short --no-merges --format='%ad %ae %s'
2018-08-17 dschuff@chromium.org Use gsutil from PATH instead of assuming its location


Created with:
  gclient setdep -r src/native_client@6e5fd1672be5

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mseaborn@chromium.org

Change-Id: I079fd686f601d4d398ee86f1cc9d0ac1860389d5
Reviewed-on: https://chromium-review.googlesource.com/1179322Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583943}

https://skia.googlesource.com/skia.git/+log/cd8689f00427..0edb982602c6


git log cd8689f00427..0edb982602c6 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 stephana@google.com Upgrade to iOS 11
2018-08-16 mtklein@google.com Revert "avoid illegal enum values in GrGLGpu"
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-16 allanmac@google.com Documentation update.
2018-08-16 reed@google.com can't normalize non-finites
2018-08-16 djsollen@google.com Revert "Add ability to specify different GP textures for each mesh in a draw."
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-16 mtklein@google.com don't adapt any gray colors to 565
2018-08-16 robertphillips@google.com Adjust canFilterMaskGPU to only reject small rect blurs
2018-08-16 mtklein@google.com add p3 and ep3 configs to DM
2018-08-16 mtklein@google.com avoid illegal enum values in GrGLGpu
2018-08-16 allanmac@google.com Merge Vulkan Compute work into master.
2018-08-16 kjlubick@google.com Make verbose.log optional in upload_dm_results
2018-08-16 reed@google.com move patheffect virtuals to protected and rename
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@0edb982602c6

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: I3b6e0d49f9639d916aa1c8e428219880e4c9bde2
Reviewed-on: https://chromium-review.googlesource.com/1178943Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583942}

Screenshot: https://imgur.com/a/SxeRAu8

Bug: none
Change-Id: I9c11677b4a0e4bd24be5a5b43f3b9d1487458c55
Reviewed-on: https://chromium-review.googlesource.com/1173270Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583941}

Do not generate multiple TracingStatedInPage events. It was causing N^2 passes
over CPU profiles slowing down execution and consuming lots of memory.

Change-Id: Id8c3293a7cc92a2cc611746f68c92a2c9a0b63f6
Reviewed-on: https://chromium-review.googlesource.com/1179239
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583940}

Bug: 852590
Change-Id: I78e5723c29974aa43b48e1559a258c5830a7d220
Reviewed-on: https://chromium-review.googlesource.com/1178809Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583939}

This reverts commit d9fad9a3.

Reason for revert: Our Windows and Mac packages started failing the signing process the day after this CL was landed.  I would like to revert and see if our build succeeds tonight.

Original change's description:
> Reland "Generate deterministic zip file for remoting"
> 
> This is a reland of a9dac60b
> 
> I added an optional arg to ZipDir not to change zipped path.
> 
> Original change's description:
> > Generate deterministic zip file for remoting
> >
> > build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic.
> >
> > This is a part of effort to utilize cache of test execution on swarming.
> >
> > Bug: 870611
> > Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be
> > Reviewed-on: https://chromium-review.googlesource.com/1163349
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581034}
> 
> Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
> Bug: 870611
> Change-Id: Iffa3c8e2c4fd22b60c120052612f22491d588951
> Reviewed-on: https://chromium-review.googlesource.com/1164682
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581590}

TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,thakis@chromium.org,yuweih@chromium.org,tikuta@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870611
Change-Id: I27fa4b1ae9e3c93781e2a6de508695a775a5e57a
Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
Reviewed-on: https://chromium-review.googlesource.com/1179242Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583938}

Bug: 872369
Change-Id: I49e1b0398c93ae42acb57228050d0b56d779b002
Reviewed-on: https://chromium-review.googlesource.com/1178635Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583937}

So that the input_method_manager_impl_unittest won't depend on ash/.

Bug: 756059
Change-Id: Ibba9f87a05d322489a1778658c5bc4adffd908e4
Reviewed-on: https://chromium-review.googlesource.com/1177217Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583936}

This is essentially a revert of crrev/c/544480 as the function is not
used anymore; in preparation of moving viz::mojom::GpuHost
implementation to //components/viz/host/.

BUG=709332

Change-Id: Ib3b73a7250f3f838d2699a06261bb8079b93db3c
Reviewed-on: https://chromium-review.googlesource.com/1178327Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583935}

Current state on breakpoint shared between different models is hack
that should never work.

R=lushnikov@chromium.org

Bug: none
Change-Id: I60a0e5774c47c38a0f5f251f9e9d5f2437ceb9b4
Reviewed-on: https://chromium-review.googlesource.com/1179262Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583934}

Bug: 869687
Change-Id: Idb36fefc8809144809b2ef049e6d607d5bf27654
Reviewed-on: https://chromium-review.googlesource.com/1165944
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583933}

When a select is set in JS, if the user later changed it to its previous
value, onProcessSelectChange() was not being called.

Fix this by using a Polymer property and observer instead of tracking
the last value in the behavior. Also change to use debounce instead of
setTimeout().

Bug: None
Change-Id: I8f17e00900d130df68aeffd0a51ab2ee72c61aee
Reviewed-on: https://chromium-review.googlesource.com/1173667
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583932}

Bug: 875093
Change-Id: I7c2556c1a1ee64e77dc75bbe1562c22198050f56
Reviewed-on: https://chromium-review.googlesource.com/1179073
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583931}

This happens when AR device is the only device, because we were asking for
a non-immersive device, and if that didn't exist, default to the immersive
device, and if that didn't exist, reporting no devices, which misses out
any AR devices.

Bug: 875099
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I94f91c007694685551db07cdafa61d4aaca4aabe
Reviewed-on: https://chromium-review.googlesource.com/1179271
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583930}

This (probably) fixes rare flake in
SharedBufferTest.CreateAndPassReadOnlyBuffer and
SharedBufferBufferTest.CreateAndPassFromChildReadOnlyBuffer.

Right now the child process expects to receive a "quit" message
at the end, and then it fires an "ok" to acknowledge that. The parent
process sends "quit" and waits to hear "ok" before terminating
the test.

The problem is that the child process may terminate itself before
its IPC thread has had a chance to forward the outgoing "ok" message.
This is normal behavior for the system, and the test should not
rely on any contrary delivery guarantees.

This basically just swaps the order of operations: now the child sends
its "ok" and waits to read a "quit" message before terminating. The
parent waits to receive an "ok" and then fires a "quit" message before
waiting on the child process's death. Everything works out just fine.

This re-enables the latter test on Fuchsia, and both tests on Android
where they were disabled a long long time ago for unrelated and
no-longer-relevant reasons (see https://crbug.com/666356).

Bug: 874719,666356
Change-Id: I2977b5a00b5dd0f0653289fb550bac17cfbeb21a
Reviewed-on: https://chromium-review.googlesource.com/1179201Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583929}

Original CLs:

- https://codereview.chromium.org/7671034

  tcmalloc doubly-linked free-lists for thread caches

  Added the ability for free lists to be built out of doubly-linked
  lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set
  in order for doubly-linked lists to be used. By default flag is only
  set in Debug builds.

  BUG=None
  TEST=None

- http://codereview.chromium.org/8000001

  Catch some "easy to spot" double frees in TCMalloc

  This will only work when the double frees happen to be
  close enough in time, and both happen on the same thread...
  ...but it should have almost zero cost to do the check.

  r=jschuh
  BUG=75921

- http://codereview.chromium.org/8242017

  Enable TCMalloc doubly-linked freelist in release builds

  BUG=None
  TEST=None

- http://codereview.chromium.org/10262029

  Fix the logging. TCMalloc Log() does not recognize printf formatter.
  It also appends new line automatically.

- https://chromiumcodereview.appspot.com/10944024

  Mask freelist entries in tcmalloc

  The goal here is to prevent freelist spraying in exploits, and as a bonus
  to make UAF fail a bit more early and obviously.

- https://chromiumcodereview.appspot.com/10957067

  Ensure we mask freelist pointers properly on 32-bit Linux

- https://chromiumcodereview.appspot.com/11362046

  Tweak TCMalloc freelist pointer masking

  Previously I wasn't masking NULL freelist pointers because I didn't want
  to potentially leak address information. However, the branch for this is
  a hot point, and the leakage risk is still there for non-NULL known values.

- https://chromiumcodereview.appspot.com/12619004

  Speed up tcmalloc by allowing more inlining.

  Move some small functions in free_list.cc to free_list.h
  to improve the chance of intelligent inlining decisions.

  No functional changes.  This is a performance tuning change.

  From the ChromeOS point of view, this is clearly a good change.
  I didn't try it on Windows, but I suspect it will help there too.
  In any case, it shouldn't hurt.

  Preliminary results for the BloatFile benchmark, for example, are around
  a 3.2% speedup (averaged across a few runs on different platforms).
  I am collecting more data now.

  BUG=111726
  TEST=none

BUG=724399,b:70905156

Change-Id: Ib1fb6f83bb67448eb13606f92ac428cde62c39b7
Reviewed-on: https://chromium-review.googlesource.com/1130784
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583928}

When a device is "derelict" (idle at OOBE), we currently auto-launch a
very old Kiosk demo app. This CL changes the idle detector to enroll
into offline Demo Mode instead if Demo Mode and offline Demo Mode are
enabled.

More specifically, "derelict" is defined as:
* Spending a total of 8 hours on the Welcome screen, followed by
* Being idle on the Welcome screen for 5 minutes

So a device that has progressed past the Welcome screen shouldn't be
considered derelict; nor should a device that goes idle for 5 minutes
but has only been in OOBE for <8 hours.

We will follow this CL  with actual derelict policies; until then it
will fail to enroll and simply return to the Welcome screen.

Bug: 869273
Test: browser_tests, and manually at OOBE with the following command line:
      --enable-demo-mode --enable-offline-demo-mode --derelict-idle-timeout=1
      --derelict-detection-timeout=1 --oobe-timer-interval=1
      (manual testing requires copying policies from
      /usr/share/chromeos-assets/demo_mode_resources/policy/ to
      /usr/share/chromeos-assets/demo_mode_resources/derelict_policy/)

Change-Id: I81572e447ce5082c0bf534ab32b0c4b34f0570a0
Reviewed-on: https://chromium-review.googlesource.com/1164398
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583927}

BUG=874793
R=pkasting

Change-Id: I594189d310393c86bae4d8f4839b3ffcd43e220b
Reviewed-on: https://chromium-review.googlesource.com/1179276
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583926}

This CL adds logic to correctly get the MIME type of a file sent to the
MediaLauncherActivity with a file URI using MimeTypeMap. This fixes a
bug where MediaLauncherActivity would receive a file URI and determine
that it had no MIME type, and therefore cancelled opening the file.

In addition this adds a check in MediaViewerUtils.getMediaViewerIntent
that makes sure the given URI isn't a file URI for Android N and later,
since if so we can't add the share button (since creating the
PendingIntent throws a FileUriExposedException).

Bug: 869254
Change-Id: I3678671902b075450a97cdaf66b604aacd450b36
Reviewed-on: https://chromium-review.googlesource.com/1176867
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583925}

fingerprint-progress-arc is used to draw progress circle for enrolling
fingerprint, as well as display relevant animation.
This CL does the following:
1. Moved this element into ui/webui/resources/cr_elements so this
can be used by both OOBE and settings.
2. Make circle radius customizable because OOBE and settings use
different sizes.
3. UI polish based on the spec.


Bug: 873229
Change-Id: Ideaa3a12db3f5f3a6f1438353401a30b05e5afca
Reviewed-on: https://chromium-review.googlesource.com/1175002
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583924}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/e5f282cb55b2..3f621b000733


git log e5f282cb55b2..3f621b000733 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 chrome-bot@chromium.org Update config settings by config-updater.
2018-08-16 xixuan@chromium.org chromeos_config: Mark reef back as important.


Created with:
  gclient setdep -r src/third_party/chromite@3f621b000733

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia765aaa4bd6df26da8f0d00b3b305612c6c5fa9a
Reviewed-on: https://chromium-review.googlesource.com/1178903Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583923}

Bug: 871407
Change-Id: I7ac4e7370b1aadd2cf9c702a1218abb789f87c29
Reviewed-on: https://chromium-review.googlesource.com/1173507Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583922}

When Chrome OS System Tray is open, all notification popups should be
hidden. After it's closed, system priority notifications should be shown
again. The behavior was broken after new MessagePopupCollection and
subsequent fix https://crrev.com/c/1158118 .

TEST=MessagePopupCollectionTest.HighPriorityNotificationShownAgain
BUG=874345

Change-Id: I979adfe1c4632fec356a8ee23ea3544cb1024114
Reviewed-on: https://chromium-review.googlesource.com/1177294Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583921}

This CL fixes wrong background color of proxy warning
("Network may be monitored") in UnifiedSystemTray.

TEST=manual
BUG=870913

Change-Id: Id0a460652ee8431db947cc19aa49c61c434cf5cb
Reviewed-on: https://chromium-review.googlesource.com/1177088Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583920}

Bug: b/112704706
Test: Manual
Change-Id: I0450466ba871061b8535e790b14687c7b2e97ffb
Reviewed-on: https://chromium-review.googlesource.com/1179126Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583919}

We use "--vmodule=*/paint/*=3,*/graphics/*=3" to output verbose log
for painting. However it had been mismatching the graphics layer tree
log by renderer/core/frame/local_frame_view.cc after crrev.com/823365.

Move the verbose log for graphics layer trees into
renderer/core/paint/compositing/graphics_layer_tree_as_text.cc to
make the original vmodule string work again.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5ba5147904cf0cb7060a66c7cef8498a4e9fd001
Reviewed-on: https://chromium-review.googlesource.com/1178564
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583918}

Fallback SurfaceIds are no longer needed for SurfaceReferences thus
this CL removes the fix for https://crbug.com/827242


Bug: 874138
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I400fb64a69d4395f7463634db87b957ff7005788
Reviewed-on: https://chromium-review.googlesource.com/1174916Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#583917}

The legacy/default path was filtering X-Client-Data at
ServiceWorkerURLRequestJob.

The S13nSW/NetworkService path did not need to filter this yet, because
it gets injected by GoogleURLLoaderThrottle in that path, and throttling
happens after SW interception. However the plan is to move throttling in
front of SW interception, so the SW would start seeing the headers. This
is needed so the navigation preload request can have the header too, and
also looks right for correctness as some throttles also mutate the
request in ways that the service worker should observe; and also would
prevent wasteful double-interception when the request URL changes.

Since in S13nSW/NetworkService the header can also be injected by the
renderer and sent directly to the service worker, filter the headers
just before the event is dispatched.

Bug: 873061, 873575
Change-Id: I6a2011a2d1e6d1d6c08b1fc254b2cd7ae013d9f3
Reviewed-on: https://chromium-review.googlesource.com/1177418
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583916}

This CL allows SurfaceAggregator to track damage in all possible cases
of child_surface. This is done by storing the whole surface range instead
of just LocalSurfaceIds

Bug: 874249
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie2886ae6eda753ab8bb3bb8b168f3a7c507df187
Reviewed-on: https://chromium-review.googlesource.com/1174984
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583915}

Change content feature flag "WebAuthenticationCable" to be enabled by
default.

Bug: 875069
Change-Id: Id476b8995e764dd4451edca55dce0e14c9b4a70c
Reviewed-on: https://chromium-review.googlesource.com/1178968
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583914}

Since the instance of CrxComponent is provided by the clients of the
update_client::UpdateClient, it is possible that instance is missing in
some cases, such as when a CRX is uninstalled. That leads to corner
cases such as calls to UpdateClient::GetCrxUpdateState returning an
error, because an instance of CrxUpdateItem could not be returned.

This is a mechanical change to replace the std::unique_ptr wrapper of
the CrxComponent with a base::Optional wrapper, so that CrxUpdateItem
could have correct value semantics.

BUG=869663

Change-Id: I6aa805c2784af5ed959c8777f724322763404cb0
Reviewed-on: https://chromium-review.googlesource.com/1173018
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583913}

Add another experiment group to the Modern testing config so that Modern
isn't default enabled for tests. Enabling Modern requires restarting
Chrome twice, so having it default enabled for tests can lead to
flakiness.

BUG=

Change-Id: I822dfcdae7238782f9adf73a0ad0b65ac0a6e264
Reviewed-on: https://chromium-review.googlesource.com/1178900
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583912}

https://pdfium.googlesource.com/pdfium.git/+log/d5e282648a08..136342d950c9


git log d5e282648a08..136342d950c9 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 tsepez@chromium.org Remove arguments from CPWL_Edit::SetAlignFormatV().
2018-08-16 tsepez@chromium.org Remove optional argument from CXFA_LayoutProcessor::StartLayout()
2018-08-16 tsepez@chromium.org Replace optional bool bDrawFocus with enum type.
2018-08-16 tsepez@chromium.org Remove optional argument from ResolveNodes_GetParent().


Created with:
  gclient setdep -r src/third_party/pdfium@136342d950c9

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I200b3a375574eeb0688a5be125b3907b203f5fc9
Reviewed-on: https://chromium-review.googlesource.com/1179161Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583911}

R=khorimoto@chromium.org

Bug: 850823
Change-Id: Ibca38ed4f647bfae91a692664709beffb7d41623
Reviewed-on: https://chromium-review.googlesource.com/1179070Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583910}

Change-Id: I8c76cf49161daf8cccaa1cfc32db8fcd930f01da
Reviewed-on: https://chromium-review.googlesource.com/1178692Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583909}

This condition was added originally in this patch:
https://codereview.chromium.org/27200003

That patch was trying to trigger early deadlines when the compositor
thread had work to do but the main thread had aborted.

In a world where we have begin frame acks even when frames aren't
produced, it's worth triggering early deadlines even when the compositor
thread doesn't have any work to do either so that the display compositor
can go ahead and do work earlier.

This is intended as a short-term fix to solve smoothness issues with
surface for video with 30fps videos.  Ideally the DisplayCompositor will
have some followups as well so that one client that is slow to respond
will not cause smoothness issues with another client.

Bug: 874676
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8b6663570aba7d135c1f211a21c37b1e17d19577
Reviewed-on: https://chromium-review.googlesource.com/1176559
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583908}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/cadf57874526..c43b409d9688


git log cadf57874526..c43b409d9688 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 dschuff@chromium.org Only run 64 bit builds on mac


Created with:
  gclient setdep -r src/native_client@c43b409d9688

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:868204
TBR=mseaborn@chromium.org

Change-Id: If16532e2c0c00d46397143533d1b8321a971ca53
Reviewed-on: https://chromium-review.googlesource.com/1178543Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583907}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/95fb6dc81034..15b1778c2c45


git log 95fb6dc81034..15b1778c2c45 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@15b1778c2c45

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I2858367981054e1557c83956847866b82f5179ae
Reviewed-on: https://chromium-review.googlesource.com/1178944Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583906}