GitLab

This is a reland of 902e5475

The original patch discovered where NGPaintFragment still
in-use are destructed unintentionally. The problem has been
there when LayoutNGBlockFragmentation runtime flag was
enabled, but it did not cause many crashes fortunately.

Re-landing after keeping all NGPaintFragment in use in
r583980 (CL:1178081).

Original change's description:
> [LayoutNG] Store NGPaintFragment in LayoutObject
>
> This patch stores a one-way linked list of NGPaintFragment to
> their source LayoutObject. Looking up the HashMap consumes
> non-ignorable time during paint.
>
> This patch adds IsInLayoutNGInlineFormattingContext flag to
> LayoutObject. This flag represents whether the object is in
> LayoutNG inline formatting context, even if the object itself
> is laid out by legacy.
>
> With the flag, the storage used for storing InlineBox in
> LayoutText, LayoutInline, and LayoutBox are changed to union
> to store the first NGPaintFramgent.
>
> Bug: 714962
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I7dfd11fafa9b1527b8d77e1fa3a24abf0e7f551e
> Reviewed-on: https://chromium-review.googlesource.com/1170726
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583633}

TBR=eae@chromium.org, mstensho@chromium.org

Bug: 714962
Change-Id: Ie7c000c918e22e24f378eb14ca68243ed0e7bfa8
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1178441Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583983}

This reverts commit 3227909e.

Reason for revert:
This commit is originally a hack that should be reverted after CL:1134934
and other 3 related CLs are merged. See chromium:819930 for details.

Original change's description:
> V4L2SVDA: Add hack for shifting ChromeOS-specific control IDs
>
> This patch makes Chrome work before/after https://crrev.com/c/1134934
> (for chromiumos-overlay), https://crrev.com/c/1136336 (for v3.14) and
> http://crrev.com/c/1134929 (for v4.4) are merged, which change
> ChromeOS-specific controls' IDs to avoid cofliction with upstream.
>
> By calling QUERY_CTRL for new IDs, Chrome can detect whether the CLs are
> already merged at run-time. If they are not merged yet, Chrome will use old
> control IDs instead.
>
> This patch is needed because we cannot land the kernel change at the
> same time as new Chrome build. After new ChromeOS build contains these CLs,
> this patch should be reverted.
>
> Bug: 819930
> Test: Play VP8/VP9 video on veyron_jerry w/o CL:1134934 and CL:1136336
> Test: Play VP8/VP9 video on veyron_jerry w/  CL:1134934 and CL:1136336
> Test: Play VP8/VP9 video on kevin w/o CL:1134934 and CL:1134929
> Test: Play VP8/VP9 video on kevin w/  CL:1134934 and CL:1134929
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I293464d85c4ca28fd3413b89e77e242c0a7648c0
> Reviewed-on: https://chromium-review.googlesource.com/1134933
> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Pawel Osciak <posciak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578981}

TEST=Play VP8/VP9 video on veyron_jerry
TEST=Play VP8/VP9 video on kevin

Bug: 819930
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I108024ef0c0e78f18efb43fdc389659a19cd63d7
Reviewed-on: https://chromium-review.googlesource.com/1154772Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583982}

NOTRY=true
TBR=mythria@chromium.org,ulan@chromium.org

Bug: 875159
Change-Id: I63d955c029460e138988fa7137c25ecc10d5335f
Reviewed-on: https://chromium-review.googlesource.com/1179100Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#583981}

This patch stores fragmented NGPaintFragment as a list linked
from LayoutNGMixin.

The code path doesn't run (break_token is always nullptr) in
phase 1. But without keeping them, virtual/layout_ng_experimental
will crash randomly when CL:1170726 caches NGPaintFragment in
LayoutObject.

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6c7e4934dcb366d7dcb39412bf1aac40ebad7429
Reviewed-on: https://chromium-review.googlesource.com/1178081
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583980}

This CL moves permission checking from device/usb/mojo directory to
chrome/browser/usb. This is a preparation step for moving device/usb
to service/device.

BUG=699790

Change-Id: Ic30d6ff94b670950fcb2571d7036dd7c0f39a24b
Reviewed-on: https://chromium-review.googlesource.com/1172154
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583979}

https://skia.googlesource.com/skia.git/+log/40adb3c41f2a..bc414ed5dec5


git log 40adb3c41f2a..bc414ed5dec5 --date=short --no-merges --format='%ad %ae %s'
2018-08-17 reed@google.com clean up to more modeern conventions


Created with:
  gclient setdep -r src/third_party/skia@bc414ed5dec5

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: I6aa7125b7ec8c761da758c1acd966a01d6aa1e44
Reviewed-on: https://chromium-review.googlesource.com/1179328Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583978}

Bug: b:110464348
Change-Id: I356c9411d76cbbc5d0cad51a4aad65eadd600c6b
Reviewed-on: https://chromium-review.googlesource.com/1179118Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583977}

Introduces a class that will handle removing pre-installed demo mode
resources when needed.
First incarnation observes low disk space signal from cryptohome
service, and removes pre-installed resources when low space is detected
(provided that the device is not in demo mode).
When demo mode resources get removed from disk, this is recorded in
local state, to avoid future attempts to remove these resources.

More logic for requesting demo mode resources removal to come.

BUG=827368

Change-Id: I721d1995fa818fc2fc1d056e33ba513380bf441e
Reviewed-on: https://chromium-review.googlesource.com/1173670
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583976}

When a payload is compressed via zlib using a known-in-advance
dictionary symbols that are distant can cause the compression output
buffer to be overwritten.

This patch applies a fix that comes from upstream:
https://github.com/madler/zlib/commit/5c44459c3b28a9bd3283aaceab7c615f8020c531
That fix hasn't yet landed in the master branch.

This will prevent us from generating those invalid payloads.

BUG=874550

Change-Id: Ic421d7242450f866388c90cee67cbc48b92ed83c
Reviewed-on: https://chromium-review.googlesource.com/1176284
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583975}

GetResourceEntryCallback is really on a once callback, and by processing
multiple team drive entries in the loop we introduce a race condition that
can cause a SIGSEGV in private_api_drive when the callback is fired multiple
times.

Followup work is to get the Deduplicated name for the team drive and store that
as the path so that the lookup will only match once.

Bug: 875140
Change-Id: I35e381aa82d7c34e200ddc44b085205115fadd86
Reviewed-on: https://chromium-review.googlesource.com/1179483Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583974}

Bug reported these tests flaking on Mash, but these tests got disabled
on all bots. Disable them on Mash, not everywhere.

Tbr: xidachen@chromium.org
Bug: 874954, 410163
Change-Id: I80eb7b2cb185063d2e3e752fa0ae47d39fc97035
Reviewed-on: https://chromium-review.googlesource.com/1179427
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583973}

Since the enum is not used yet, I changed int values for
existing items.

BUG=b:112571387
TEST=Presubmit passed

Change-Id: I1d98cd961df80c455e996e24ea1d58b28574f57e
Reviewed-on: https://chromium-review.googlesource.com/1179426Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583972}

Change-Id: Id07bb2f1b8cc9c9a30b619b8f89ee6f41169f3f1
Reviewed-on: https://chromium-review.googlesource.com/1178243Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583971}

No longer needed now that media suspend is controlled by ContentRendererClient
and mojo IPC instead of a switch. This system breaks if apps change render
process (e.g. triggered by a cross-origin redirect).

Bug: b/73820381
Change-Id: Ie81b5b6cbaa5ecca8d0693f0ff56fdc4aebebdd8
Reviewed-on: https://chromium-review.googlesource.com/1175441Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583970}

Bug: 875042
Change-Id: I33dfb721ad6eeaa04509bb0c83ea92456cb52aaf
Reviewed-on: https://chromium-review.googlesource.com/1179423Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583969}

Bug: internal b/112555253
Test: cast_base_unittests
Change-Id: I5ce9bb1ebd4bbf0d72ad6c8953e67a73f4a3f78e
Reviewed-on: https://chromium-review.googlesource.com/1179367Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583968}

https://skia.googlesource.com/skia.git/+log/0edb982602c6..40adb3c41f2a


git log 0edb982602c6..40adb3c41f2a --date=short --no-merges --format='%ad %ae %s'
2018-08-17 khushalsagar@chromium.org fonts: Fix UAF bug in SkRemoteGlyphCache.
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-16 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 f0e3c19a0c02..3394a73db973 (2 commits)
2018-08-16 bungeman@google.com SkFontMgr::matchFamilyStyle can return nullptr.


Created with:
  gclient setdep -r src/third_party/skia@40adb3c41f2a

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:874740
TBR=kjlubick@chromium.org

Change-Id: If4cc8762edc31471fb4ef02d5cf98200970fdc47
Reviewed-on: https://chromium-review.googlesource.com/1179324Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583967}

When DefaultEventHandler is called, Event object was passed as a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 871637
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2d3a838ab38393e786ae6cdd184baf4b94343613
Reviewed-on: https://chromium-review.googlesource.com/1175753
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583966}

Suggestions and Feed preferences are removed from the persistent
storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ibe4c2545c0d9bab6efd82f1d0972c22bec176c1b
Reviewed-on: https://chromium-review.googlesource.com/1176804Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583965}

ChromeOS Audio preferences are removed from the persistent storage list
for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.
This CL won't affect changes from Settings page.

Bug: 861722
Change-Id: Id4f4bf82494188ac4501248ffdf4867187b77d3d
Reviewed-on: https://chromium-review.googlesource.com/1176807Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583964}

This CL sets up a preference for enabling startup tracing if needed.
Early java tracing is enabled if the preference is set. This will be
used by background tracing to setup startup tracing.

BUG=859260

Change-Id: Idf2c6cbfb8c2a4d5e1765a1d2c3256abe69368fe
Reviewed-on: https://chromium-review.googlesource.com/1159116
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583963}

Bug: 862864
Change-Id: Idacfb439011488cfb472907c480fb49a704e24fc
Reviewed-on: https://chromium-review.googlesource.com/1173760
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583962}

I had local build errors requiring explicit constructors and destructor
implementations of the PrefetchSuggestion struct but I forgot to add the
.cc file containing them to the CL that introduced that class. This
change fixes that mistake.

TBR: skym@chromium.org, harringtond@chromium.org
Bug: 841516
Change-Id: If81f9a3db128b9224d835af5cb7aa40959f093d3
Reviewed-on: https://chromium-review.googlesource.com/1179362Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583961}

Reference
https://chromium-review.googlesource.com/c/chromium/src/+/1158315

Bug: 821926
Change-Id: Iaf50ca97a9cceed98a915971b816ca7bdbcd515a
Reviewed-on: https://chromium-review.googlesource.com/1172307
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583960}

with it did not activate it.

Bug: b/112629940
Test: Put app into PIP mode, it no longer was activated. Interacting
Change-Id: I88cb307afe5a6aba573c27a5fc9d3f150c430649
Reviewed-on: https://chromium-review.googlesource.com/1175751
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583959}

https://pdfium.googlesource.com/pdfium.git/+log/9faabc5fc371..21068062a038


git log 9faabc5fc371..21068062a038 --date=short --no-merges --format='%ad %ae %s'
2018-08-17 tsepez@chromium.org Remove optionals in CXFA_LayoutPageMgr methods.
2018-08-17 tsepez@chromium.org Remove optionals from CXFA_NodeHelper::NodeAcc_TraverseSiblings().


Created with:
  gclient setdep -r src/third_party/pdfium@21068062a038

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic71642b01304c9737281e01af5f0fba09b738f54
Reviewed-on: https://chromium-review.googlesource.com/1179325Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583958}

This adds a new perf test case for camera-to-WebGL uploads.
This new case is intended to detect the performance improvements
being made in issue 867368.

Bug: 867368
Change-Id: Ia8b05f422e15bb7625491ac10f33903dcc1c55d0
Reviewed-on: https://chromium-review.googlesource.com/1170033Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583957}

The test is failing (flaky?) on Mac 10.12.

Bug: 874976
Change-Id: I913c6d39d7650e8298cd83eb2236f0f0d027f5d1
Reviewed-on: https://chromium-review.googlesource.com/1178639
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583956}

This reverts commit dccf844a.

Reason for revert: Broke some browser_tests on Mac.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4738

Original change's description:
> Convert dns_api.cc to mojo host resolver
> 
> Bug: 874658
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I576d2877ec71df8e489d349916f758ba6fe74263
> Reviewed-on: https://chromium-review.googlesource.com/1176725
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583878}

TBR=jam@chromium.org,wfh@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: Id845006ad303fca63c7c681fd259d3db379dfddd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874658
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1179383Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583955}

This reverts commit 8fd04b5f.

Reason for revert: TextSuggestionsTouchBarControllerTest.InvalidRange started failing

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28606

Original change's description:
> [Mac] Moved TextSuggestionsTouchBarController's Range Validity Check
> 
> Previously, -updateTextSelection:range:offset: could receive an invalid
> range from WebContentsTextObserver::DidChangeTextSelection(). This
> invalid range would then cause a crash in -requestSuggestions.
> 
> A check has been added to -updateTextSelection:range:offset: to make
> sure that a selection with an invalid range is not passed to
> -requestSuggestions. This should prevent future crashes.
> 
> TextSuggestionsTouchBarControllerTest.InvalidRange tests that an
> invalid range does not crash the controller and is handled
> properly.
> 
> Bug: 717553
> Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d
> Reviewed-on: https://chromium-review.googlesource.com/1178467
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Commit-Queue: Tessa Nijssen <tnijssen@google.com>
> Cr-Commit-Position: refs/heads/master@{#583815}

TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com

Change-Id: I7735c373052037bb377c1beac79d7b1132f3bc86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717553
Reviewed-on: https://chromium-review.googlesource.com/1179382Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583954}

(1) A SearchResultRanker class with a simple AppLaunchPredictor is
    added.

(2) SearchResultRanker lives inside AppSearchProvider and re-rank
    the suggested apps.

(3) training signal is passed from AppListClientImpl to
    SearchController, then to all SearchProviders; but only
    AppSearchProvider responds to that training signal by passing the
    signal to SearchResultRanker.


Change-Id: I9879bcf1932e2928720c43680ca37edf35c3a785

Bug: 871674
Change-Id: I9879bcf1932e2928720c43680ca37edf35c3a785
Reviewed-on: https://chromium-review.googlesource.com/1164863
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583953}

BUG=842291,875122
TBR=kylixrd@chromium.org,sky@chromium.org

Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1
Reviewed-on: https://chromium-review.googlesource.com/1066803
Cr-Original-Commit-Position: refs/branch-heads/3396@{#660}
Cr-Original-Branched-From: 9ef2aa86-refs/heads/master@{#550428}(cherry picked from commit 76c3965de85bcd28a57293cef653a88cbb6061af)
Reviewed-on: https://chromium-review.googlesource.com/1179341Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583952}

M65 removed the ability to manipulate a host's cookies via markup.
https://chromium-review.googlesource.com/800290
https://www.chromestatus.com/feature/6170540112871424

BUG=767813

Change-Id: Ib201015bb2cf570da299630c9edaaf674068114c
Reviewed-on: https://chromium-review.googlesource.com/1166264Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583951}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I6e350b1da9a0941f58481f5784d93b6af6cd7f77
Reviewed-on: https://chromium-review.googlesource.com/1179092Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583950}

The file python/plugin_pb2.py generated by newer version of
protobuf cannot be consumed by older versions on some bots.

Bug: 874509, 764774
Change-Id: I3045ba021263b204fbf6f0ab6af9a5da2bd96121
Reviewed-on: https://chromium-review.googlesource.com/1176823Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583949}

When InsertedInto is called, ContainerNode object was passed as a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If6eb4e4d0a927d4f6954bd177c16e58798292886
Reviewed-on: https://chromium-review.googlesource.com/1177530
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583948}

https://pdfium.googlesource.com/pdfium.git/+log/136342d950c9..9faabc5fc371


git log 136342d950c9..9faabc5fc371 --date=short --no-merges --format='%ad %ae %s'
2018-08-17 tsepez@chromium.org Remove optionals from CXFA_TextLayout methods.


Created with:
  gclient setdep -r src/third_party/pdfium@9faabc5fc371

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I738d3a02b49c16a9918d59e78eda9b2dae94dc15
Reviewed-on: https://chromium-review.googlesource.com/1179323Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583947}

Needed to be able to send try jobs for win-asan.

Bug: 869973
Change-Id: I8635fb79b298596de0b4488b911f98db320b66fc
Reviewed-on: https://chromium-review.googlesource.com/1179090Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583946}

Reland "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time"

This reverts commit 2df0c83a.

Reason for revert: official android should be fine with this after #583420

Original change's description:
> Revert "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time"
> 
> This reverts commit ef36dc19.
> 
> Reason for revert: This turns out to break the official android build, which apparently was relying on a broken aspect of the build that this fixed :(. See https://crbug.com/871173.
> 
> Original change's description:
> > win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time
> >
> > We used to set the timestamp to a hash of the binary, similar to
> > https://blogs.msdn.microsoft.com/oldnewthing/20180103-00/?p=97705
> > However, that caused an appcompat warning on Windows 7 to appear, which
> > interpreted the hash as a timestamp. (It's possible that https://llvm.org/PR38429
> > could help with that, but my guess it won't have an effect on Windows 7,
> > which likely always believes that the the coff timestamp field always stores
> > a timestamp).
> >
> > So currently we write the current time during linking in that field, but that's
> > bad for build determinism and that in turn is bad for swarming test result cachability.
> >
> > build/write_build_date_header.py already creates a deterministic BUILD_DATE
> > with several tradeoffs. Cachability wants this to change infrequently, but
> > things like HSTS need a "real" build date and want this to change frequently.
> > The compromise is: The date changes once per day in official builds, and
> > once a month in regular builds.
> >
> > (We could use /Brepro in ldflags instead of /TIMESTAMP for unofficial builds to get
> > the binary hash in the timestamp, but having the header timestamp match the BUILD_DATE
> > define seems nice.)
> >
> > So let's use that same time as timestamp in the PE/COFF header. lld-link has a
> > /TIMESTAMP: flag we can use to pass in an explicit timestamp.
> >
> > Since tools can't have deps, we need to compute the timestamp at gn time,
> > so split write_build_date_header.py in two pieces: build/compute_build_timestamp.py
> > that just prints the timestamp we want to use, and the old write_build_date_header.py, which
> > now takes that timestamp and writes the header file.
> >
> > Call compute_build_timestamp.py at gn time so that we can pass it in ldflags, and
> > pass the resultl to write_build_date_header.py which keeps running as an action
> > during build time (so that we at least don't need to write a file at gn time).
> >
> > An additional wrinkle here is that the PE/COFF timestamp is used as one of just two
> > keys per binary for uploading PE binaries to the symbol server, the other being file size.
> > https://bugs.llvm.org/show_bug.cgi?id=35914#c0 has a good description of this, and
> > tools/symsrc/img_fingerprint.py's GetImgFingerprint() is our implementation of it.
> > But since we only upload binaries with symbols for official chrome builds to the symbol server,
> > a timestamp that changes once a day should be still enough. (32-bit and 64-bit chromes
> > have the same filename, and we might rarely build canary and beta and stable all on the
> > same day, but them all being the same size seems highly unlikely.)
> >
> > Bug: 843199,804926,330260
> > Change-Id: I1d4193cc537ae0c4b2d6ac9281fad29de754dd6c
> > Reviewed-on: https://chromium-review.googlesource.com/1161104
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Hans Wennborg <hans@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580585}
> 
> TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org
> NOTRY=true
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 843199, 804926, 330260
> Change-Id: Ib93697a82f8a9d3fb303b763609e82e0612887cd
> Reviewed-on: https://chromium-review.googlesource.com/1166203
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581485}

TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843199, 804926, 330260
Change-Id: I136e405c84eba3f61a4ac96b2017a34ade0cfba6
Reviewed-on: https://chromium-review.googlesource.com/1179281
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583945}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15b1778c2c45..ed0d273bfa51


git log 15b1778c2c45..ed0d273bfa51 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@ed0d273bfa51

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I8b10a74eabfae5d173fce36ba3a7b9aa5001a0d0
Reviewed-on: https://chromium-review.googlesource.com/1179321Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583944}