- 29 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
Mark "Stars.*" histogram as obsolete since they are no longer recorded in the code (except "Stars.LaunchLocation" on Android which will be cleaned up in followup CLs). Bug: 928484 Change-Id: Iefb54af2240e1899ee6b00bf658eef1a0de610b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024887 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736323}
-
Johannes Kron authored
Bug: chromium:1029737 Change-Id: Ia2800617dd2e6c2dbbbd3c40203cdb79e9bcaed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025109Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736322}
-
Gauthier Ambard authored
This reverts commit b8760c06. Reason for revert: Hit a DCHECK in -[MainController mainBrowser] when running test (on the second run). Reproduced on iOS 13 iPad running settings_egtest. Original change's description: > Use Browser in CrashRestoreHelper instead of TabModel > > TabModel is provided to the CrashRestoreHelper as a SessionWindowRestore > protocol delegate. and it's used to restore sessions from there. Replace > that with browser and use sessionRestorationBrowserAgent from the > CrashRestoreHelper instead. > Also while at it, i changed the members ivars to use trailing underscore > instead of the leading underscore. > > Bug: 1010164 > Change-Id: I53360ac9a34f7f9e42aacd459e233f40c5def60b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024028 > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736047} TBR=marq@chromium.org,mrefaat@chromium.org Change-Id: Ie3c6c3517d502d92da7f7154972501ca95f0a355 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027549Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736321}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c768c76138f9..9769628aa1d8 git log c768c76138f9..9769628aa1d8 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 phoglund@google.com Use auto instead of google::protobuf in the histogram C++ API. Created with: gclient setdep -r src/third_party/catapult@9769628aa1d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: skyostil@google.com Change-Id: I613e2878a11b2fdf7b64152200d6f231f4378380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736320}
-
Alexandre Courbot authored
CreateOutputBuffers() was not checking that it was running in the right thread. Fix this. BUG=None TEST=VDAtest passes on Hana. Change-Id: Ia159b48ec9ca0a0f51049ff1753bdd213722ab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026837 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736319}
-
Nico Weber authored
TBR=hans Bug: none Change-Id: Icf7e780f1033e58dab17ae352eb50c9cd47390bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026473Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#736318}
-
Alex Chau authored
Bug: 1044600 Change-Id: I6f52e06d655a77bea816341a507153a8967be8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017519Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#736317}
-
Tobias Sargeant authored
Bug: 1045946 Change-Id: I2fa350e40648ca7851e97f2630d262c7c679f3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027467Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#736316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72e996f23962..4f16d6218d1d Created with: gclient setdep -r src-internal@4f16d6218d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0e690594c9261cf7a5b98993ad4940a4600ea3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736315}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ca050d1fdbb..13c44dfeb014 git log 5ca050d1fdbb..13c44dfeb014 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 07a55839eed5..9a80305c0897 (1 commits) 2020-01-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src e39b5cf6a1b6..ebe1b7497acb (1 commits) 2020-01-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 34e16df059f8..6c3dc3581eaf (2 commits) Created with: gclient setdep -r src/third_party/angle@13c44dfeb014 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I9714105c362dd7253af3603dc8e66211ffd71366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027220Reviewed-by:
-
Alex Clarke authored
The corresponding WebLayer changes are in a follow on CL. The TBR is for the new DEP file which needs content/public/browser. TBR=jam@chromium.org Bug: 1025781 Change-Id: Ie895ba7246761416d52c98ae3d4b241fed62fa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926505 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
arthursonzogni authored
This correspond to step 1.a from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao This merges: - content::CSPSource (removed) - network::mojom::CSPSource (kept) Only the mojo one remains: network::mojom::CSPSource. Future follow-up will apply do the same CSPSourceList, CSPDirective and ContentSecurityPolicy. The goal at the end is to have an unique mojo data structure for representing Content-Security-Policy. Bug: 1021462 Change-Id: I55618bcabed9cd4097f3c9f0dad7a2533084771f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019448 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Wez authored
This reverts commit a597a94d. Reason for revert: Remove unused keymapping argument. Original change's description: > Pumping keymap file > > TBR=agrieve@chromium.org > > Bug: 920824 > Change-Id: I670a64ae13a0d2d5fdbce35c8db037b47e5f7e30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518146 > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Commit-Queue: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640134} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920824, 1045960 Change-Id: I9252ba72f8ec1a3456d645b2ba81c03e9f292f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022652Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736311}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=djean@chromium.org Bug: 1042208 Change-Id: Iac7159dd676e9a94a9a671b4f3370c012f8acb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017369 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736310}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py eaabaf7e04fe98990a8177a3e053346395efde1c`. This increases the clang version from 10 to 11. Bug: 1030664 Change-Id: I4c0b5b3d2d36f785b957b25826530da6cf315adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025708 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
This reverts commit d7a7b9b0. Reason for revert: breaks the build of cronet (ios-simulator-cronet) as this stills targets iOS 32-bit platforms. The bot was not run on this CL due to a misconfiguration (which is addressed with the CL https://crrev.com/c/2026570). Original change's description: > Modernize assumptions in foundation_util > > * Assume building with a macOS SDK newer than 10.8 > * Assume C++11 strong enums > * Assume 64-bit compilation > > Bug: 1044838 > Change-Id: I5a21aa1dbd00c5d6999d67ae80f18979c1c49607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025988 > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736187} TBR=avi@chromium.org,mark@chromium.org Change-Id: If2544084068711aae7241483db52b33fac1e94ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027413Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736308}
-
anina koehler authored
modernize-use-equals-default and modernize-use-nullptr. Bug: none Change-Id: I9a3b10a78948d93af5e5b75562840bd115138f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019266Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Anina Koehler <aninak@google.com> Cr-Commit-Position: refs/heads/master@{#736307}
-
vitaliii authored
This reverts commit cb98eddd. Reason for revert: crbug.com/1046696 Original change's description: > Add legacy TLS interstitial warning > > This adds a new interstitial page for the legacy TLS warning. It > generally follows the SSL interstitial, but with different strings and > a different icon (the (i) info icon). > > The test interstitial is available at chrome://interstitials/legacy-tls > > Screenshot: https://drive.google.com/file/d/1MkWCqWKtQwo7k-ybYjKotYJDjTzRwcd0/view > > This also refactors the legacy TLS browsertest classes slightly, basing > them on SSLUITest rather than CertVerifierBrowserTest, brings in the > mock cert verifier explicitly. It also adds a SetPolicy() method to > SSLUITestBase (to complement the EnablePolicy() method, but for policies > that take base::Value types, in this case for the SSLVersionMin policy). > Overall, this makes for a slightly simpler class structure and lets us > reuse all of the infrastructure setup by SSLUITest (since > CertVerifierBrowserTest is fairly simple in comparison). > > The new cert error is introduced in https://crrev.com/c/1894616. Support > for the control site list will be added in https://crrev.com/c/1906779. > > Bug: 896013, 1039756 > Change-Id: Ic3242178239ac8c68d02fe0a2a21a52638146580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940707 > Commit-Queue: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736197} TBR=meacer@chromium.org,cthomp@chromium.org Change-Id: I56e27cf5c6cc0aa31144e9e200bcaca6dff9b8be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896013, 1039756, 1046696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027330Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736306}
-
Mohamed Amir Yosef authored
Prior to this patch: Sync was checking for the encryption key name upon receiving remote updates and if it doesn't match the expected one, entities were recommitted for reencryption. Since tombstones aren't encrypted, they didn't have an encryption key name, and hence the corresponding entities were always marked for reencryption. After this patch: encryption key names aren't checked for tombstones. This patch in addition adds a histogram test for an existing test to make sure there is only local deletion sent to the server (the original deletion) Bug: 1046309 Change-Id: I3d3a31ad5919f346b8e46390d3633d079b930de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027407 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736305}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ie8c3930498ffd03442ec828ffb34c218f31d87bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026338Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#736304}
-
Torne (Richard Coles) authored
Without explicitly specifying minSdkVersion in these manifests, the manifest merging process merges in permission/feature requirements that are automatically derived from the implied minSdkVersion of 1 (e.g. it adds the requirement for READ_EXTERNAL_STORAGE). Fixed: 1046380 Change-Id: Ia450e4337afdb03c6cb04567db89766c1b1ecaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024179 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
vitaliii authored
This reverts commit 0f668c37. Reason for revert: Fails Linux MSan Tests crbug.com/1046693. Original change's description: > Cleanup base::Optional use in Deep Scanning dialog code > > 2 instances of optional can be removed from DeepScanningDialog* code to > make it more readable: > - The access point no longer needs to be optional since all the access > points have been added to Chrome. A default value is still included > in order to simplify tests calling ShowForWebContents. > > - The state variable in DeepScanningDialogViews is better as an enum > than an optional bool indicanting pending/success/failure, especially > since a timeout state is very likely in the future. > > Change-Id: I767db78e428a607a7cc2dfe39d1d63c0f85c30d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020891 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735857} TBR=drubery@chromium.org,domfc@chromium.org Change-Id: Id4814d523935f867ab8fb69942281a6fc8fcf3b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026970Reviewed-by:
-
vitaliii authored
This reverts commit 75458c57. Reason for revert: to unblock reverting https://chromium-review.googlesource.com/c/chromium/src/+/2020891 (crbug.com/1046693) Original change's description: > Update Deep Scanning upload UI text > > Add code to use the appropriate drag-data, drag-file and paste strings > instead of just defaulting to the upload strings. Removes the optional > part of the access point since it's used to determine the appropriate > string now. > > Bug: 999145 > Change-Id: I115cd567f94d9c4ca7a4befdff386ba76163ae20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016965 > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735943} TBR=drubery@chromium.org,domfc@chromium.org Change-Id: I78b6b5c3c3fe10cdd731d84233d20c31cb1a9e00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999145,1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027547Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/390a4513..cabeec8b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6bf81fec596c29d2c0b32c81994201dc4a59842f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027261Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736300}
-
Jan Wilken Dörrie authored
This change removes set() and clear() from base::BasicStringPiece's API and replaces existing usages with appropriate calls to the assignment operator. While set() and clear() so far have been part of the StringPiece API, they are not present in std::string_view's API, thus removing them brings us one step closer to be C++17 compatible. TBR=dcheng Bug: 752720 Change-Id: I498d81e0df6350168fcbd2bae41fd9354e5b0685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020703 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736299}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=anthonyvd@chromium.org Bug: 1042208 Change-Id: I5ca57bdf47c642ea8e4acbae99e47d58405f35c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017404 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=fgorski@chromium.org Bug: 1042208 Change-Id: I0c199de9196dd99bafd78ff8ddb0e68c9d43d8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017366 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736297}
-
Eriko Kurimoto authored
This CL removes debug-output in referrer-policy web-platform-tests. This file shouldn't be added but unintentionally included in the CL: https://chromium-review.googlesource.com/c/chromium/src/+/2023710 Bug: 824646 Change-Id: If0775cebd63d53dd0510b5d64ce2a643998455cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026829Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#736296}
-
Monica Basta authored
As part of friendly settings project, we communicate the sWAA in sync setup page. This CL enables to query the sWAA bit independently from sync or history sync status. This is needed for the 2 following scenarios during which the |WebHistoryService| is null: 1- The advanced sync setup flow (click on settings from the turn syn on confirmation dialog). 2- Switching sync history from 'Off' to 'On'. This change does not take effect until we close the |syncSetup| settings page. Bug: 1035421 Change-Id: Id1651bd0d9508643e6218c6cef0c6f310109bef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012950Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#736295}
-
Colin Blundell authored
This CL has WebLayer Shell destroy its Profile at the point in the shutdown process where Chrome destroys its Profile. This change is concretely needed to enable the upcoming bringup of KeyedServices in WebLayer; without this change, the KeyedServiceFactory singletons DCHECK when they are destroyed at shutdown as they expect the context shutdown (i.e., BrowserContext destruction) to have already occurred. As part of this change we change session_service_browsertest.cc to delete the Tab objects that were created by session restore. These objects currently leak when not on Android, and a DCHECK deep in //content goes off with this CL without this part of the change (that DCHECK effectively expects that WebContents instances associated with a BrowserContext instance are destroyed before the BrowserContext). I have filed a bug for considering the long-term ownership model around BrowserImpl::CreateTabForSessionRestore(). Bug: 1030692 Change-Id: I62bfd73e5e4d9d1099e18fc66cdd51d7380497c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025367 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Julian Pastarmov authored
The getDeviceInfo API now properly checks the screen lock and disk encryption status from the OS at least for Debian or Ubuntu based distros using the Gnome based desktops. BUG=1037702 TEST=unit_tests and manually on a system with screen lock and cryptodisk Change-Id: Ibebf0c74b9f45085d0e55ecb15fcd1cd9cfd9460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020949Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#736293}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d88bb065eda..72e996f23962 Created with: gclient setdep -r src-internal@72e996f23962 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8ce645a650594e3533497f60b2c4c7b905744360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027196Reviewed-by:
-
Takashi Toyoshima authored
Adding a cors-and-webview-api.md to give WebView and chromium developers detailed knowledge to keep the compatible CORS and Origin related behaviors. Bug: 1035366 Change-Id: Ia7695011ef4b04d528af523cd2a4a0a4503eff2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024652 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Marina Ciocea authored
Previously an empty shared tab name would indicate that the infobar being constructed is for the shared tab. - Layout for the shared tab: Sharing this tab to |app_name| [Stop] - Layout for all other tabs: Sharing |shared_tab_name| to |app_name| [Stop] [Share this tab instead] However, sometimes the shared tab name can be empty (see bug), leading to incorrect infobars layout. Don't rely on the shared tab name for infobar construction, use a separate parameter. When the shared tab is untitled, create infobars for non-shared tabs using this layout: Sharing a tab to |app_name| [Stop] [Share this tab instead] Bug: 1011379 Change-Id: Iedf288060d20b8a97a4c769d83a83e74ac057bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023828 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736290}
-
Fredrik Söderquist authored
Based on [1], 'beginEvent' and 'endEvent' should only be dispatched for elements that are active at the seeked-to time and elements that were active at the previous/old/seeked-from time but are inactive at the seeked-to time (respectively). 'repeatEvent's should not be disaptched while seeking. To handle this, extend the TimingUpdate helper class with a map that tracks what interval the active elements had before the seek operation, and whether the timing update operation is a seek operation (called "fast-forward" since we end up moving in the forward direction regardless of the actual seek direction). Apart from that, the dispatching of 'repeatEvent's are also inhibited, as well as the notifications of repeats in general. [1] https://www.w3.org/TR/SMIL3/smil-timing.html#q114 Bug: 1039886 Change-Id: I17d91b1355858ee0b916d4fa46b9572e685e40e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020947Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#736289}
-
Luca Hunkeler authored
Bug: b/148450751 Change-Id: I055608c7a063f5772964712a10f726aca9e1145f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023896Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#736288}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: I0662606ee05132aaa3e9da65a25745f6e3b93e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017344Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736287}
-
Vasilii Sukhanov authored
Bug: 1028407 Change-Id: I11e8768ebb87f783be4bc1f419335f0ce1ad3da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023890Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736286}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2478a08. With Chromium commits locally applied on WPT: 1029b7e9 "SharedWorker: Add WPT for upgrade-insecure-requests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2d1a1e3d9c44188467e9ccc094bf0628b7595c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027256Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736285}
-
Yoichi Osato authored
This CL deletes the default copy constructor and introduce a move constructor and CopyFrom method instead. That's because we are planning to add a non-copiable member for streaming body to ResourceRequest ("fetch() upload streaming" design doc/ http://bit.ly/2RlBw6x), which is a instance member of WebURLRequest. Bug: 787704 Change-Id: I86f1b094df4df56e98172b46e63982f80fb510f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000402 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736284}
-
