GitLab

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180709:180779&mode=html
TBR=wibling@chromium.org,gavinp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/484033004

Cr-Commit-Position: refs/heads/master@{#291434}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291434 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291433}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291433 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13638: (sbc) Update glibc revision in tools/REVISIONS (9b15f6a->150657d)
r13639: (mseaborn) PNaCl dynamic loading: Add ELF dynamic loader
r13640: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13641: (mseaborn) Use uint32_t for untrusted pointer args: fstat() and some other syscalls
r13642: (dschuff) Build PNaCl target libraries on mac and run SCons tests on the toolchain bot
r13643: (petarj) [MIPS] Change output-format to elf32-tradlittlemips-nacl
r13644: (petarj) PNaCl: Update binutils revision in pnacl/COMPONENT_REVISIONS
r13645: (mseaborn) Use uint32_t for untrusted pointer args: gettimeofday() syscall
r13646: (yyanagisawa) Re-enable use of goma on Windows.
r13647: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/474113003

Cr-Commit-Position: refs/heads/master@{#291432}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291432 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Improve error reporting when indexing tab. (patchset #7 of https://codereview.chromium.org/449753002/)

Reason for revert:
This patch broke chromeos bot in https://code.google.com/p/chromium/issues/detail?id=406010

A reland of this must include fixes in:
https://codereview.chromium.org/484353003/
https://codereview.chromium.org/499453002/

TBR=tonyg@chromium.org,kbr@chromium.org,jennyz@chromium.org,achuith@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=405955,406010

Original issue's description:
> Improve error reporting when indexing tab.
> 
> If we created 3 new tabs, and 1 of them crashed, then there 
> is no guaranteed that  browser.tabs[1] return the correct tab 
> object. The tabs list can no longer be trusted in this case. Hence if 
> the number of inspectable contexts doesn't match the number 
> of expected tabs (based on the number of 
> tab_list_backend.New & tab_list_backend.Close calls), 
> tab_list_backend's __getitem__ throws a TabCrashException.
> 
> BUG=398467
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290974

Review URL: https://codereview.chromium.org/494753003

Cr-Commit-Position: refs/heads/master@{#291431}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291431 0039d316-1c4b-4281-b951-d872f2087c98

Resubmitting the patch 
https://src.chromium.org/viewvc/chrome?view=rev&revision=291365
which was reverted as it caused a FindBug failure due to not calling 
the Super method in the setUp method in PopupZoomerTest class.

Adding call to to super.setUp() to fix the warning.

BUG=405477, 406272

Review URL: https://codereview.chromium.org/497753003

Cr-Commit-Position: refs/heads/master@{#291430}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401644

Review URL: https://codereview.chromium.org/496873005

Cr-Commit-Position: refs/heads/master@{#291429}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291429 0039d316-1c4b-4281-b951-d872f2087c98

extensions::InfoMap lives in src/extensions, so run its test suite as part of extensions_unittests.

Two tests are left in Chrome's unit_tests because they depends on the "notifications" permission being available to hosted apps.

BUG=397164
TEST=unit_tests ChromeInfoMapTest, extensions_unittests InfoMapTest

Review URL: https://codereview.chromium.org/473913006

Cr-Commit-Position: refs/heads/master@{#291428}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291428 0039d316-1c4b-4281-b951-d872f2087c98

Remove largest_observed_ from QuicSentPacketManager, since it's also in
QuicUnackedPacketMap.

Merge internal change: 73713269
https://codereview.chromium.org/491663003/


Optimize QUIC's EntropyTracker in QuicReceivedPacketManager by using a
deque.

Merge internal change: 73709652
https://codereview.chromium.org/496133002/


Add logic for a client to enable pacing via config to the QUIC sent
packet manager.

Merge internal change: 73685838
https://codereview.chromium.org/497553003/


Clear the QUIC ping alarm when a connection in closed.

Merge internal change: 73684904
https://codereview.chromium.org/475173005/


Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's
actual functionality, and to only be called when there is an error.
Clean up some logging when packets are sent.

Merge internal change: 73651039
https://codereview.chromium.org/483093004/


Refactor QuicConnection's async write behavior to record a packet as
sent as soon as the write starts, not when it completes.

In QuicStreamFactoryTest, MockClock's now() is returning 0 and that
was causing a DFATAL in QuicUnackedPacketMap::GetLastPacketSentTime().
Noticed, in QuicConnection unittests, we are advancing clock by 1 second
and made a similar change to QuicStreamFactoryTest's MockClock.

Merge internal change: 73648585
https://codereview.chromium.org/473763004/


QUIC minor clean up to keep in sync with internal sources.

+ Use int64 for MaxBandwidthTimestamp (per rjshade).
+ Use DVLOG(1) instead of DLOG(INFO).
+ Reorder class statements.

This CL has changes that were found while merging (or back porting) the
following chroimum specific changes into the internal source tree.

Merge internal change: 73640117
Merge internal change: 73638556
https://codereview.chromium.org/495233002/


Move least_packet_awaited_by_peer_ from QuicReceivedPacketManager to
QuicSentPacketManager.

Merge internal change: 73630593
https://codereview.chromium.org/493183002/


Remove timestamp_receiver. Not used.

Merge internal change: 73627146
https://codereview.chromium.org/495173002/


Remove unused protected received_packet_manager_ accessor in
quic_connection.

Merge internal change: 73626837
https://codereview.chromium.org/496823002/


Convert QUIC's SentEntropyManager to use a deque instead of a map in
order to improve memory and CPU efficiency.

Merge internal change: 73625323
https://codereview.chromium.org/479543004/


When talking >=QUIC_VERSION_22, regularly send updated bandwidth
estimates to the client (in SCUP messages).

The main work is in QuicConnection, where a new alarm regularly checks
for substantially changed bandwidth estimates and sends them to the
client if so. The majority of the rest of this CL is plumbing, and test
code.

Feel free to suggest better values for:
- Timeout between bandwidth estimate alarms
- Definition of "substantial change" in estimate

The flow is:

- on every congestion event (ACK, packet loss) the sent packet manager
  passes a bandwidth estimate to the sustained bandwidth recorder
- on every congestion window change, the QuicServerSession checks to see
  if the bandwidth has changed sufficiently *and* enough time has passed
  since last time we sent an update to the client
- if so, it populates the CachedNetworkParams proto, and passes this to
  the CryptoStream which sends a SCUP message to the client

Merge internal change: 73579021
https://codereview.chromium.org/490263003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/497553004

Cr-Commit-Position: refs/heads/master@{#291427}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291427 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Move actions after browser Start in cros_browser_backend.Start to DidStart. (patchset #1 of https://codereview.chromium.org/499453002/)

Reason for revert:
The original patch of this (https://codereview.chromium.org/449753002/) broke chromeos bot in https://code.google.com/p/chromium/issues/detail?id=406010

Original issue's description:
> Move actions after browser Start in cros_browser_backend.Start to DidStart.
> 
> BUG=406010
> NOTRY=true
> NOTREECHECKS=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291310

TBR=jennyz@chromium.org,achuith@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=406010

Review URL: https://codereview.chromium.org/502503002

Cr-Commit-Position: refs/heads/master@{#291426}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291426 0039d316-1c4b-4281-b951-d872f2087c98

Sanity DCHECK for IncognitoModePrefs skipped for guest profile.

BUG=395044

Review URL: https://codereview.chromium.org/496713003

Cr-Commit-Position: refs/heads/master@{#291425}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291425 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove the assertion that number of expected tabs must equal to number of live tabs temporarily. (patchset #1 of https://codereview.chromium.org/484353003/)

Reason for revert:
The original patch of this (https://codereview.chromium.org/449753002/) broke chromeos bot in https://code.google.com/p/chromium/issues/detail?id=406010

Original issue's description:
> Remove the assertion that number of expected tabs must equal to number of live tabs temporarily.
> 
> BUG=405955
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291368

TBR=tonyg@chromium.org,dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405955

Review URL: https://codereview.chromium.org/495393002

Cr-Commit-Position: refs/heads/master@{#291424}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291424 0039d316-1c4b-4281-b951-d872f2087c98

 * AppListViewDelegate was accessing deleted search_provider.
 * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted
 * Explicitly delete FilePathWatcher. This was causing
   recursive callback to FilePathWatcherImpl::Cancel from
   FilePathWatcherImpl::CancelOnMessageLoopThread, which
   caused crash.

Clean ups
 * change OnIO to OnFILE as they run on FILE thread.
 * removed unused singleton related code.

BUG=None
TEST=Run athena_main on desktop and close window.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291214

R=flackr@chromium.org, mukai@chromium.org

Review URL: https://codereview.chromium.org/490033003

Cr-Commit-Position: refs/heads/master@{#291423}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291423 0039d316-1c4b-4281-b951-d872f2087c98

This CL forces update of system tray state on new IME State even if
current input method has not changed.

BUG=406186
TEST=manual

Review URL: https://codereview.chromium.org/496993003

Cr-Commit-Position: refs/heads/master@{#291422}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291422 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mtklein@chromium.org,caryclark@google.com
BUG=406425

Review URL: https://codereview.chromium.org/497793002

Cr-Commit-Position: refs/heads/master@{#291421}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291421 0039d316-1c4b-4281-b951-d872f2087c98

There was a downstream unit test package invoking these, not just native
callers.  In order to let downstream autoroll cleanly, bring them back for
now.  These can be deleted later in the same cleanup CL as the others.

NOTRY=true
TBR=tedchoc@chromium.org
BUG=406332

Review URL: https://codereview.chromium.org/477133006

Cr-Commit-Position: refs/heads/master@{#291420}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402050

Review URL: https://codereview.chromium.org/496853002

Cr-Commit-Position: refs/heads/master@{#291419}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403810
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/488093004

Cr-Commit-Position: refs/heads/master@{#291417}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291417 0039d316-1c4b-4281-b951-d872f2087c98

Shell operations may cause 3rd-party shell extensions to be loaded into the calling process. Isolating them in a utility process protects the browser process from potential instability.

BUG=73098

Review URL: https://codereview.chromium.org/487453002

Cr-Commit-Position: refs/heads/master@{#291416}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291416 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug introduced in https://codereview.chromium.org/427903004

BUG=406114
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/492373002

Cr-Commit-Position: refs/heads/master@{#291415}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291415 0039d316-1c4b-4281-b951-d872f2087c98

TBR=piman@chromium.org
BUG=169282

Review URL: https://codereview.chromium.org/488133004

Cr-Commit-Position: refs/heads/master@{#291414}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291414 0039d316-1c4b-4281-b951-d872f2087c98

R=jkarlin@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/495953003

Cr-Commit-Position: refs/heads/master@{#291413}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291413 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291412}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291412 0039d316-1c4b-4281-b951-d872f2087c98

Undo Blink rolls before https://codereview.chromium.org/491773002/ since it's causing most android tryjobs to fail with that asssert.

Review URL: https://codereview.chromium.org/501493002

Cr-Commit-Position: refs/heads/master@{#291411}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166959

Review URL: https://codereview.chromium.org/495193004

Cr-Commit-Position: refs/heads/master@{#291410}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291410 0039d316-1c4b-4281-b951-d872f2087c98

Bluetooth detection on Mac triggers 500ms adapter polling and causes
performance regression. Since Easy unlock is only offered on ChromeOS
at the moment, disable Bluetooth detection for other platforms while
the polling problem is investigated.

BUG=404482,399067

Review URL: https://codereview.chromium.org/498453002

Cr-Commit-Position: refs/heads/master@{#291409}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291409 0039d316-1c4b-4281-b951-d872f2087c98

If the recommended locales for a public session are invalid/unavailable,
public sessions should default to the current UI language, not the
locale that happens to be first in alphabetic order (Arabic for Chrome OS
running in English).

BUG=403550
TEST=Extended unit and browser tests

Review URL: https://codereview.chromium.org/483523005

Cr-Commit-Position: refs/heads/master@{#291408}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291408 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291407}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403571
TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/470953005

Cr-Commit-Position: refs/heads/master@{#291406}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291406 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392974
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/480663003

Cr-Commit-Position: refs/heads/master@{#291405}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291405 0039d316-1c4b-4281-b951-d872f2087c98

TBR=finnur@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/500543002

Cr-Commit-Position: refs/heads/master@{#291404}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291404 0039d316-1c4b-4281-b951-d872f2087c98

Move RenderPass::Id out of RenderPass and make it an isolated class
called RenderPassId, so RenderPassDrawQuad and AppendQuadsData will not
need to depend on entire RenderPass class.

BUG=344962

Review URL: https://codereview.chromium.org/404563005

Cr-Commit-Position: refs/heads/master@{#291403}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291403 0039d316-1c4b-4281-b951-d872f2087c98

The stats is intended for the low latency case, hence removing other cases.

NOTRY=true

Review URL: https://codereview.chromium.org/486633003

Cr-Commit-Position: refs/heads/master@{#291402}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291402 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Keep a copy of page id in RenderViewHost. (patchset #1 of https://codereview.chromium.org/493853002/)

Reason for revert:
This hit canary and we're getting instrumented crashes. That's what we were looking for so let's back it out.


Original issue's description:
> Keep a copy of page id in RenderViewHost.
> 
> This is an instrumented version of the patch that will be reverted in a few days.
> This is meant to catch crashes in edge cases and log enough for us to repro
> them.
> 
> BUG=99379, 369661
> TEST=this is gonna crash for a few people
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291077

TBR=rsesek@chromium.org,creis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=99379, 369661

Review URL: https://codereview.chromium.org/500533002

Cr-Commit-Position: refs/heads/master@{#291401}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405957
TEST=SplitViewControllerTest.SplitModeActivation

Review URL: https://codereview.chromium.org/488153003

Cr-Commit-Position: refs/heads/master@{#291400}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328847

Review URL: https://codereview.chromium.org/422233009

Cr-Commit-Position: refs/heads/master@{#291399}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291399 0039d316-1c4b-4281-b951-d872f2087c98

Credential Management API is Javascript API that can be used by sites to sign user in or correctly store the credentials in the password manager.

BUG=400674

Review URL: https://codereview.chromium.org/459103005

Cr-Commit-Position: refs/heads/master@{#291398}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291398 0039d316-1c4b-4281-b951-d872f2087c98

Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test failures on the ASAN bot.

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=2862

> Fixes three crashes
>  * AppListViewDelegate was accessing deleted search_provider.
>  * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted
>  * Explicitly delete FilePathWatcher. This was causing
>    recursive callback to FilePathWatcherImpl::Cancel from
>    FilePathWatcherImpl::CancelOnMessageLoopThread, which
>    caused crash.
> 
> 
> Clean ups
>  * change OnIO to OnFILE as they run on FILE thread.
>  * removed unused singleton related code.
> 
> BUG=None
> TEST=Run athena_main on desktop and close window.
> 
> Review URL: https://codereview.chromium.org/490033003

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/467003003

Cr-Commit-Position: refs/heads/master@{#291394}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291394 0039d316-1c4b-4281-b951-d872f2087c98

The manifest_parser.{h,cc} files are colliding with new files I'm
creating for the Web Manifest feature. Appcache manifest files should
be prefixed by "appcache".

BUG=None
NOTRY=true
TBR=torne (for third_party_files_whitelist.txt)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291388

Review URL: https://codereview.chromium.org/469413003

Cr-Commit-Position: refs/heads/master@{#291393}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291393 0039d316-1c4b-4281-b951-d872f2087c98

Include the stack trace of the code that triggered the error.
Refactored the error generation method to prevent extension
code from breaking the state of the internals.

BUG=404406

Review URL: https://codereview.chromium.org/482603002

Cr-Commit-Position: refs/heads/master@{#291392}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291392 0039d316-1c4b-4281-b951-d872f2087c98

Fails check_licenses

> Rename appcache/manifest_parser* to appcache/appcache_manifest_parser*.
> 
> The manifest_parser.{h,cc} files are colliding with new files I'm
> creating for the Web Manifest feature. Appcache manifest files should
> be prefixed by "appcache".
> 
> BUG=None
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/469413003

TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/493383003

Cr-Commit-Position: refs/heads/master@{#291391}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291391 0039d316-1c4b-4281-b951-d872f2087c98