- 26 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46505d3c656f..df4ad0d1e00a git log 46505d3c656f..df4ad0d1e00a --date=short --no-merges --format='%ad %ae %s' 2018-11-26 lalitm@google.com trace_processor: fix bug with scoped slices in Chrome traces Created with: gclient setdep -r src/third_party/perfetto@df4ad0d1e00a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:119806420 TBR=perfetto-bugs@google.com Change-Id: I5a2ce1d8d3fae3e760f4ba5ffb37f2f2d9beb2aa Reviewed-on: https://chromium-review.googlesource.com/c/1350232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610834}
-
Manuel Rego Casasnovas authored
Layout containment elements are treated as having no baseline, when that's applied to table cells, flex or grid items that are baseline aligned that means that they should use their synthesized baseline. The patch adds simple check in LayoutBlockFlow::FirstLineBoxBaseline() similar to what we have in other methods. If the element has layout containment it has no baseline (it returns -1). The same thing is done in LayoutNGMixin<Base>::FragmentBaseline() for LayoutNG. Two tests from the WPT suite has been modified in order to avoid baseline alignment as they are not checking that feature of layout containment but something else. BUG=907709 TEST=external/wpt/css/css-contain/contain-layout-baseline-002.html TEST=external/wpt/css/css-contain/contain-layout-baseline-003.html TEST=external/wpt/css/css-contain/contain-layout-baseline-004.html Change-Id: Id393787dd24bf3e34aaf73476e446fb9d0a4e593 Reviewed-on: https://chromium-review.googlesource.com/c/1348892 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610833}
-
Colin Blundell authored
When tests set the refresh token for a given account, IdentityManager must already know about the account (i.e., the account must be seeded in AccountTrackerService). However, the error that occurs if tests invoke SetRefreshTokenForAccount() rather than MakeAccountAvailable() is cryptic and hard to debug. This CL adds a DCHECK to make the error more transparent and give instructions on the proper invocation. Change-Id: I26e38bbccfd16e3e9b0e5c45931edb26ea0e4f0d Bug: 798699 Reviewed-on: https://chromium-review.googlesource.com/c/1350610Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610832}
-
Sergiy Byelozyorov authored
R=tandrii@chromium.org Change-Id: I6900c75a96f1cd7d7c49240de4409d1bc7dde028 Reviewed-on: https://chromium-review.googlesource.com/c/1349693Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610831}
-
Marc Treib authored
See documentation at https://sites.google.com/a/chromium.org/dev/developers/contributing-code/flag-ownership Bug: none Change-Id: I0a985d8f2cfbc991aef90b5ae1077f1f0de0f0af Reviewed-on: https://chromium-review.googlesource.com/c/1348110Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610830}
-
Rune Lillesveen authored
Correct autoplay test should be marked now. TBR=mlamouri@chromium.org Bug: 908347 Change-Id: I45c3b971769c8de9fe97ec47f3c4d490a841212b Reviewed-on: https://chromium-review.googlesource.com/c/1350615Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610829}
-
Eric Seckler authored
Previous attempts to deflake this test weren't successful yet, so here's another one. Replaces actually clicking on the categories pref and waiting for the new activity + fragment with starting it directly via startActivitySync instead. TBR=twellington@chromium.org Bug: 908118 Change-Id: I3c91dea54b8628d71bedab687e727fc791f8da6b Reviewed-on: https://chromium-review.googlesource.com/c/1350188Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610828}
-
Andreas Haas authored
WebAssembly trap handlers are about to be enabled in a field trial, see http://cl/222217200. R=jwd@chromium.org Bug: chromium:906565 Change-Id: Ibf9ffe707cc16c5d76f004f75f397627be6fcbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1346089Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#610827}
-
Rune Lillesveen authored
storage_setitem.html TBR=drott@chromium.org Bug: 908276 Change-Id: I8bc578f24845a3b0d60bdc3fd9b2de691408ad46 Reviewed-on: https://chromium-review.googlesource.com/c/1349984Reviewed-by:
-
Michael Lippautz authored
- Free up unusued "is free bit". This information was double encoded in the header. - Use uint32_t for masks to allow the compiler to help with out of bounds shifts. - Reorder declarations in HoH. Bug: 843903 Change-Id: Ibd6a95ef9b38c41ed469f91ff07d35a0738082d1 Reviewed-on: https://chromium-review.googlesource.com/c/1350613Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610825}
-
Adam Rice authored
R=ellyjones@chromium.org Change-Id: I2a7937345d696331d21659c4c06b26c9bd3f69ff Reviewed-on: https://chromium-review.googlesource.com/c/1341747Reviewed-by:
-
Mythri Alle authored
Change the soon to be deprecated API calls to use the alternate non-deprecated versions Bug: v8:8238 Change-Id: I9a6fff7c23cef953d8cf941e5cc32c7da451195e Reviewed-on: https://chromium-review.googlesource.com/c/1349692Reviewed-by:
-
Ross McIlroy authored
BUG=v8:7287,v8:8238 Change-Id: I7dfbc89ac4ec02adf7a4275efd752cee2d142d40 Reviewed-on: https://chromium-review.googlesource.com/c/1349713Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610822}
-
Mugdha Lakhani authored
BackgroundFetchRecord is currently storing a Response as a private class member. This change makes it a local variable that can be passed in by SetResponseAndUpdateState() to resolve the ResponseReadyProperty with it. Keeping the response in a private member is unnecessary, since ResponseReadyProperty stores it as a class member anyway. Bug: 875201 Change-Id: I1d186ed26b2835df535b320c02cd73662daaa7cd Reviewed-on: https://chromium-review.googlesource.com/c/1349651 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610821}
-
Yuki Shiino authored
This is a reland of 756bea38 Original change's description: > v8binding: Do not hold a cross origin ScriptState in IDL callback function > > Make IDL callback function not hold a ScriptState of its > creation context when it's cross origin from the incumbent > realm. > > Not holding a cross origin ScriptState, there is much > less risk to access a cross origin context. > > IDL callback interface will follow the same approach in > a separate patch. > > Bug: 892755, 886588, 904218 > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1314023 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609662} Bug: 892755, 886588, 904218 Change-Id: I78ca7050e659cdb533ae09dab792bc699d2b48bf Reviewed-on: https://chromium-review.googlesource.com/c/1343881 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
David Jean authored
Change-Id: Ic5e843b077e36e54e9ce107d865084c8bf6f4258 Reviewed-on: https://chromium-review.googlesource.com/c/1350612Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#610819}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/992b7128656e72..574d888c8a Compare https://github.com/harfbuzz/harfbuzz/issues/1410 Bug: 894354 Change-Id: Ibfaa54ed22e72ed36731f2ca22037d5deb15f81b Tbr: eae, behdad Reviewed-on: https://chromium-review.googlesource.com/c/1349978Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#610818}
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: I299212c75c2dbfa302e31f24313185296067d0d1 Reviewed-on: https://chromium-review.googlesource.com/c/1350183Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#610817}
-
Arthur Sonzogni authored
RenderFrameHostImpl::OnDetach() is not expected to be called for the main frame. |parent| was not checked. It used to be checked in FrameTree::RemoveFrame, but this function is no more used in OnDetach. Bug: 902964 Change-Id: I8ec758dfcc7a382f3d3ec6554ea94ad857c5a6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1348449 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610816}
-
Hans Wennborg authored
This reverts commit 7883e6b9. Reason for revert: video_decode_accelerator_unittest fails to link in Windows component builds Original change's description: > media/gpu/test: Cleanup and split test helpers build target. > > This change splits up the test helpers target in separate encode, decode and > other helpers. Tests now only depend on what they actually need. This change > doesn't introduce any new code, but some things are moved to avoid weird > dependancies (such as encode helpers depending on frame mapper which depends on > decode helpers). > > This change also moves code in the video_accelerator_unittest_helpers.h file > from the media to the media/test namespace. > > TEST=ran video/jpeg encode/decode tests on nocturne > > CQ-DEPEND=CL:1345670 > > BUG=879065 > > Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50 > Reviewed-on: https://chromium-review.googlesource.com/c/1345701 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610757} TBR=hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org Change-Id: If341a83edf8b0ad74180895860f9ebfbb396e5f6 No-Presubmit: true No-Tree-Checks: true Bug: 879065, 908360 Reviewed-on: https://chromium-review.googlesource.com/c/1349981Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#610815}
-
Boris Sazonov authored
This reverts commit 1b4b09c6. Reason for revert: re-enabling the test, as the failure should've been fixed by https://crrev.com/c/1345069. Original change's description: > [Bookmarks] Disable testSearchBookmarks on Oreo. > > Conditionally disables this test due to flakiness on this configuration. > > BUG=906788 > > TBR=twellington@chromium.org > > Change-Id: Ief4f08ae1d9f8c73b3055d136af655498a97892f > Reviewed-on: https://chromium-review.googlesource.com/c/1343361 > Reviewed-by: Donn Denman <donnd@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609507} TBR=donnd@chromium.org,twellington@chromium.org Bug: 906788 Change-Id: I838cc7bfa80059bb3b2e23668e2e32cfcd9edcb4 Reviewed-on: https://chromium-review.googlesource.com/c/1349982Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610814}
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: I4d9e49dead34f9fddc47222c723c38c6ed11b3b0 Reviewed-on: https://chromium-review.googlesource.com/c/1349318Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610813}
-
Anand K. Mistry authored
The original change didn't handle the case where the injected code to click "Cancel" button was run after the dialog page has fully loaded. In this case, the DOMContentLoaded event has already fired. BUG=808300 No-try: true Change-Id: Ibf8408a7a44ef8bc8029764d31bc9a5171119cc8 Reviewed-on: https://chromium-review.googlesource.com/c/1350444 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610812}
-
Dan Elphick authored
Bug: v8:7279, v8:8238 Change-Id: I35f921255c1a1700f2340120952ff9ceb1949e8a Reviewed-on: https://chromium-review.googlesource.com/c/1349320Reviewed-by:
-
Noel Gordon authored
- add these files to the BUILD file, fix all closure errors - change externs FileOperationManager to be an @interface - rename FileOperationManager to FileOperationManagerImpl, and use it as the implementation in FilesApp - remove FileOperationManager.DELETE_TIMEOUT, it is unused - update class MockFileOperationManager, an implementation of FileOperationManager for tests, and add missing base class methods needed to Closure compile it. - re-order file_operation_handler_unittest.html scripts: the simple scripts first, the unittest-related scripts last. - make util.addEventListenerToBackgroundComponent have an EventTarget to satisfy Closure compile now EventTarget is used to define the externs FileOperationManager @interface No change in test behavior, no new tests. Bug: 908299 Change-Id: I5b03596b6beb3e6bce3bd8a140525fff4cb30d2d Reviewed-on: https://chromium-review.googlesource.com/c/1350447 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610810}
-
Keishi Hattori authored
Convert M*, N*, O* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I6d45bc7752a63f423515357d712d00157f77ffe6 Reviewed-on: https://chromium-review.googlesource.com/c/1350448Reviewed-by:
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: I5fa49f67c25d7343835e70bf244242f7855da3a1 Reviewed-on: https://chromium-review.googlesource.com/c/1349259Reviewed-by:
-
Rune Lillesveen authored
This reverts commit 63f4ae00. Reason for revert: Still fails with leak detector on Linux Trusty Leak. Original change's description: > TestExpectations: do not skip document-user-activation.html as the test seems to pass. > > Tested locally and everything is fine. > > Bug: 733494 > Change-Id: I23f3cde42b14d2461fc94a391c6427d5c2aa9e1d > Reviewed-on: https://chromium-review.googlesource.com/c/1263569 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610670} TBR=mlamouri@chromium.org,beccahughes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 733494 Change-Id: I509b798f79e64b8fb67be392d17a91834fd9c05a Reviewed-on: https://chromium-review.googlesource.com/c/1350184 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
Now SubmissionIndicatorEvent is part of PasswordForm. But for using it with NewPasswordFormManager it should be a field of FormData. This CL extracts it to a separate file and to add FormData::submission_event field. The following CL will implement processing it in NewPasswordFormManaager. Bug: 831123 Change-Id: If5e886c29fdfa95396827291436ace66679cd83b Reviewed-on: https://chromium-review.googlesource.com/c/1341910Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#610806}
-
Sergio Villar Senin authored
It was using the SigninManager to set the authenticated (primary) account. Replaced by a call to the identity API. Bug: 903863 Change-Id: Ib82685ddd13e907d8f318e3079207763fd3c9f51 Reviewed-on: https://chromium-review.googlesource.com/c/1348329 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610805}
-
David Roger authored
Bug: 908123 Change-Id: I721da9b87f677f4e68c255537dd67436d5316721 Reviewed-on: https://chromium-review.googlesource.com/c/1349655Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#610804}
-
Vaclav Brozek authored
Due to issues with moveable arguments in GMock, the password_manager_unittest.cc uses the technique where instead of mocking a method with a std::unique_ptr argument, it forwards the raw pointer of that argument to a *Ptr variant of the original method and mocks that. This works as long as the expectations on the *Ptr method are always specified and handle freeing the argument properly. Assuming that every EXPECT_CALL on the *Ptr method is handling the argument correctly, there are two ways to complete the protection against leaks: (A) Make the whole mocked object a StrictMock. (B) Provide an ON_CALL default which deletes the raw pointer argument This CL goes with (B) because it does not take away the flexibility to use normal or NiceMock for the other mocked methods. Bug: 907794 Change-Id: I498c2cb4fd69c232406baad41278fab4defc5ac9 Reviewed-on: https://chromium-review.googlesource.com/c/1349656Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610803}
-
Ross McIlroy authored
Moves to MaybeLocal version in api_event_handler.cc. This code should never through when creating the function, so explicitly converting with ToLocalChecked(). BUG=v8:7290,v8:8238 Change-Id: I542384b457133b37d6279313bcabf874ad690591 Reviewed-on: https://chromium-review.googlesource.com/c/1349218Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7284f296f47b..c40fe7c74edc Created with: gclient setdep -r src-internal@c40fe7c74edc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie764b2984a034491ad75f1ede5dfe218fab8f95a Reviewed-on: https://chromium-review.googlesource.com/c/1350573Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610801}
-
Mikel Astiz authored
Prior to this patch, desktop favicon downloading would only stop when a truly ideal icon is found, which means a favicon with perfect bitmaps sizes for all supported screen densities (often a .ico file with a 16x16 AND a 32x32 bitmap). This often leaded to all icons being downloaded, even for cases where it's obviously unnecessary. The patch adopts the logic we currently use on mobile within FaviconHandler::UpdateFaviconCandidate() in order to stop processing favicon candidates if there is little hope that the next ones will be any better. This requires some smartness for favicon candidates without an explicit 'sizes' attribute, which would score very low prior to this patch and hence would rarely be processed (if other candidates exist). Hence, we special-case them for desktop and score them highest during initial sorting, which mimics the behavior prior to this patch and guarantees they will be processed unless an ideal favicon is found before. It's rather trivial to rule out regressions for the following common scenarios: A. Mobile platforms: no behavioral changes as score stays zero for candidates without explicit 'sizes' attribute. B. A single favicon is listed by the page. C. Multiple favicons are listed and none have a 'sizes' attribute (sorting does nothing and all are processed unless an ideal one is found). D. Multiple favicons are listed and they all have an accurate 'sizes' attribute (scenario improved in this patch). The more complex scenario is when a web page lists multiple favicons and only some have a 'sizes' attribute. In this case, there is some minor risk for regressions given that the patch scores highest the favicons without a 'sizes' attribute, so they will be downloaded and processed earlier. Bug: 895175,705900,672076 Change-Id: I8216652ede25f55332cacc54d3e0a806fd8b7bc3 Reviewed-on: https://chromium-review.googlesource.com/c/1323551 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610800}
-
David Jean authored
Bug: 907873 Change-Id: I45f4723dd2e999175c4fc0d5168275a17fb3eaf4 Reviewed-on: https://chromium-review.googlesource.com/c/1348113 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This patch makes network::cors::OriginAccessEntry to use mojom::CorsOriginAccessMatchMode rather than inter-class enum. This also allows mojom::CorsOriginPattern to use the mojom::CorsOriginAccessMatchMode rather than bool so that it can represent complete OriginAccessEntry content. This is needed to have an entry set copy outside NetworkService. TBR=haraken@chromium.org Bug: 908324 Change-Id: I5a29e877baecdcd77dea0c7c16dd90dc66f93302 Reviewed-on: https://chromium-review.googlesource.com/c/1350554 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#610798}
-
Gustaf Ullberg authored
Enable tracking of the level of clockdrift seen by the WebRTC acoustic echo canceller. The histogram has three bins: 0: No clockdrift detected. 1: Clockdrift probable. 2: Clockdrift detected. Bug: webrtc:10014 Change-Id: Ide08da65177cc0fe32c96fcad19d87d6ab8c7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/1341919Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#610797}
-
Yoav Weiss authored
This fixes a couple of bugs with the CSSPReloadScanner that made it miss rules in which the URL wasn't quoted or the rule didn't end with a semicolon. It also adds tentative WPT tests for that functionality, as the tests are also relevant for WebKit. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1331042 Bug: 903785 Change-Id: I401c252a42fbb96dee9c7942e0a4f8d5b6850244 TBR: kouhei Reviewed-on: https://chromium-review.googlesource.com/c/1349980Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#610796}
-
Keishi Hattori authored
This reverts commit b3203d70. Reason for revert: crbug.com/908352 MyFilesVolume test is failing. Original change's description: > Fix some tests when flag MyFilesVolume is enabled > > Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads > folder: "" when MyFilesVolume is disabled, which means Downloads is the > root; "/Downloads" when MyFilesVolume is enabled, which means that > Downloads it's a folder at root. > > Change tests that uses entry.fullPath to prefix with > RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag > MyFilesVolume. > > Enable some tests to run with flag MyFilesVolumeEnabled which were > failing before this CL. > > NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with > /Downloads will be in-lined when MyFiles as Volume is fully rolled out. > > --gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*" > --gtest_filter="CreateNewFolder/FilesAppBrowserTest*" > > Test: browser_tests > Bug: 873539 > Change-Id: I72f6dc314e50103c3cadf2299f582dcf84f4d9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1350019 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610771} TBR=noel@chromium.org,lucmult@chromium.org Change-Id: Ibc50141f6bb9d60ae36693c252a9e9ac74a2c9c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873539 Reviewed-on: https://chromium-review.googlesource.com/c/1350561Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610795}
-
