- 03 Aug, 2018 40 commits
 - 
- 
Wez authored
Migrate the net::NetworkChangeNotifier implementation for Fuchsia off of using the deprecated fuchsia::netstack::NotificationListener to receive network interface change events, to use the OnInterfacesChanged event on the netstack::Netstack interface, instead. TBR=eroman Change-Id: I492a05209a27a6c5d41220b82b6bcd07dae407eb Reviewed-on: https://chromium-review.googlesource.com/1162305Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580604}
 - 
Michael Thiessen authored
Now that all VR code is behind the VR module, the VrClassesWrapper and a bunch of other interfaces are redundant. TBR=yfriedman@chromium.org Bug: 862639 Change-Id: I52d10c319a255515469414346c4f3730084bd617 Reviewed-on: https://chromium-review.googlesource.com/1161110Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#580603}
 - 
Artur Khachatryan authored
Change-Id: I247dd746fd2e559d8e2d752ff7878e68fb54846f Reviewed-on: https://chromium-review.googlesource.com/1162501Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580602}
 - 
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ecae0ae..12c70426 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6cd8703cf3635fc5a5c1cb984de0b57c16e25c2b Reviewed-on: https://chromium-review.googlesource.com/1162307Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580601}
 - 
Chromium WPT Sync authored
Using wpt-import in Chromium 0856d23e. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22272 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers TBR=foolip No-Export: true Change-Id: I7c4b226374d3e80ccccef3f2a4c3a0e35b6a4476 Reviewed-on: https://chromium-review.googlesource.com/1162273 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580600}
 - 
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5cf02ac2c4a..d54f5f5c763c git log f5cf02ac2c4a..d54f5f5c763c --date=short --no-merges --format='%ad %ae %s' 2018-08-03 sakal@webrtc.org Rename rtc_instrumentation_test_apk targets to end with _test_apk. 2018-08-03 magjed@webrtc.org Android: Remove custom matrix helper functions in RendererCommon 2018-08-03 mbonadei@webrtc.org Remove definition of FEATURE_ENABLE_VOICEMAIL, FEATURE_ENABLE_PSTN. 2018-08-03 philipel@webrtc.org Reland "Remove RTPVideoHeader::h264() accessors." 2018-08-03 oprypin@webrtc.org JNI generation: Replace base::subtle::AtomicWord with std::atomic<> 2018-08-03 buildbot@webrtc.org Roll chromium_revision 4dd959af..06e87fb3 (579686:580149) 2018-08-03 oprypin@webrtc.org Don't allocate an array of size 0, it causes a UBSan failure 2018-08-03 kthelgason@webrtc.org Remove dead code. 2018-08-02 zstein@webrtc.org Add AsyncResolverFactory interface and basic implementation. 2018-08-02 srte@webrtc.org Always sends probes when they are generated. 2018-08-02 nisse@webrtc.org Delete class TelephoneEventHandler and related code. 2018-08-02 kthelgason@webrtc.org Fix occasional crash in iOS ADM. 2018-08-02 nisse@webrtc.org Delete telephone-event handling from RTPReceiverAudio. 2018-08-02 oprypin@webrtc.org Fix a warning about comparison of integers of different signs 2018-08-02 philipel@webrtc.org Add members for the codec agnostic descriptor to RTPVideoHeader. 2018-08-02 sakal@webrtc.org Delete MockRenderer and replace it with identical MockSink class. Created with: gclient setdep -r src/third_party/webrtc@d54f5f5c763c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:867475,chromium:None,chromium:868776,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If94dce305aee0c40ca6d1f33f6b41d966662affe Reviewed-on: https://chromium-review.googlesource.com/1162105Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580599}
 - 
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d0339950377..b33f9ebe9057 git log 7d0339950377..b33f9ebe9057 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 borenet@google.com [infra] Update vpython CIPD package 2018-08-03 kjlubick@google.com Add job for building PathKit to WASM using Docker 2018-08-03 timliang@google.com validate GrMtlBuffer after forcing it to be static 2018-08-03 brianosman@google.com Avoid coverage bleed for AA arcs with tiny sweep angles 2018-08-03 jvanverth@google.com Revert "Hoist path check" 2018-08-03 bsalomon@google.com Make fixed dynamic states be conditionally allocated 2018-08-03 rmistry@google.com Revert "Disable bookmaker CLs automatic CQ+2 for now" Created with: gclient setdep -r src/third_party/skia@b33f9ebe9057 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/112018278 TBR=scroggo@chromium.org Change-Id: Ia94bc367429863fbd1096aadaa88f1303d1486f0 Reviewed-on: https://chromium-review.googlesource.com/1162111Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580598}
 - 
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee09b25fcad3..51da39f993c8 git log ee09b25fcad3..51da39f993c8 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vapier@chromium.org upload_gce_image: drop 2018-08-03 vapier@chromium.org cros_collections: split out collections related logic to a new module 2018-08-03 lannm@chromium.org cbuildbot: Remove UpdateGitRepo 2018-08-03 lannm@chromium.org cbuildbot: Remove CanaryCompletionStage._ComposeTreeStatusMessage 2018-08-03 lannm@chromium.org cbuildbot: Remove PrepManifestForRepo 2018-08-03 vapier@chromium.org gs: update to 4.33 2018-08-03 derat@chromium.org chromeos_config: Add bvt-tast-{android,chrome}-pfq. Created with: gclient setdep -r src/third_party/chromite@51da39f993c8 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I58983b99110688ab017f5b66fa9b7bdce46d1571 Reviewed-on: https://chromium-review.googlesource.com/1161151Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580597}
 - 
Amy Qiu authored
Now that it's been a week since key_desktop_move_cases was refreshed, remove the old pages. Bug: 852530 Change-Id: Ic439646390d3acafc9d59f26a089e7ca94fc2466 Reviewed-on: https://chromium-review.googlesource.com/1162341Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#580596}
 - 
Clark DuVall authored
This is a reland of db560919 Reland disables flaky ExtensionWebRequestApiTest.WebRequestTestOSDD on Windows. Original change's description: > Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service > > Getting this test working required a few fixes: > - Modifying a header rather than Set-Cookie for some tests, which > required switching to XMLHttpRequest (crbug.com/827582) > - Handling redirect from http:// -> chrome-extension://, and bypassing > security checks if this is from web request > - Plumbing through whether the request is async or not > > This is not handling subresource redirects because subresource > redirects to schemes other than http/https/data are not supported > yet with network service (crbug.com/868545). > > Also adds a bunch of tests for redirects. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1145956 > Reviewed-by: Nick Carter <nick@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580365} TBR=nick@chromium.org,jam@chromium.org,reillyg@chromium.org,karandeepb@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8c37f335c96aa8f43548e9118e96f095f2ae6362 Bug: 721414 Reviewed-on: https://chromium-review.googlesource.com/1162274 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#580595}
 - 
Fredrik Hubinette authored
We hide some network state changes when loading cross-origin videos. The idea is that non-videos will look exactly like non-existing resources. However, if preload=none, no loading is actually occuring, so there is no reason to hide the preload state. Also, since the player will not naturally progress to an error or "have metadata" stage, it will be stuck loading without this patch. Bug: 852119 Change-Id: I660b6167e1783dae79c90aa5479c504f9d302a6b Reviewed-on: https://chromium-review.googlesource.com/1149143Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#580594}
 - 
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d69a5f124d9b..b8430dd749b0 git log d69a5f124d9b..b8430dd749b0 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 geofflang@chromium.org Use FixedVector for storing textures referenced by a framebuffer. Created with: gclient setdep -r src/third_party/angle@b8430dd749b0 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I462a6809aa3ef6f83da376f2b5afdf57c827b196 Reviewed-on: https://chromium-review.googlesource.com/1162109Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580593}
 - 
Yue Li authored
Show the notification when existring user update to M70. Bug: b/111936939 Test: Manual Test Change-Id: I46df54c1ec360aa9110b679f858d30cc665171a8 Reviewed-on: https://chromium-review.googlesource.com/1155975 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580592}
 - 
Fritz Koenig authored
Filters can use the pixels of the images they overlay. When using hardware planes the final composition is done on the display controller, so the filter doesn't have a chance to get the pixel values of the underlaying plane. BUG=chromium:854790 TEST=UnderlayTest.DisallowFilteredQuadOnTop Change-Id: Id8e7e2031343c61c1334071a368cb367c0cd5eb3 Reviewed-on: https://chromium-review.googlesource.com/1156878 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#580591}
 - 
Sami Kyostila authored
TBR=altimin@chromium.org Change-Id: I9db618aee880f0d0ad2a49f581d6b7ac60f7152b Reviewed-on: https://chromium-review.googlesource.com/1162328Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#580590}
 - 
Xida Chen authored
The previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1151094 was reverted. The reason is that there were some crashes. This CL solve the problem. PS#1 is exactly the same as the previous CL which was reverted, so that it is easier for review. TBR=creis@chromium.org Bug: 851644 Change-Id: I80a8c3b7dfd94e7abace4e3281b959f9fc1dcd2a Reviewed-on: https://chromium-review.googlesource.com/1157698Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580589}
 - 
Andrey Kosyakov authored
Change-Id: I70275386caedc3a1b2bf695b26008006b9fe023f Reviewed-on: https://chromium-review.googlesource.com/1160939Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580588}
 - 
Ella Ge authored
When UseZoomForDsf enabled, need to convert node location from physical pixel to dip before passing it to Java api. Bug: 870230 Change-Id: I0b5a010e768f6d1ac32187e550a16685af20bda4 Reviewed-on: https://chromium-review.googlesource.com/1161322 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580587}
 - 
Moe Ahmadi authored
- This CL facilitates deprecation and replacement of kAutofillEnabled by finer grained prefs. - This CL also removes unnecessary usages of kAutofillEnabled. The only remaining usages are where the pref is registered or observed which will be replaced by appropriate pref(s) once kAutofillEnabled is deprecated. Bug: 870328 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I30f410d11b6c4e4cd9d87bf532ebefeaa5f565f8 Reviewed-on: https://chromium-review.googlesource.com/1160865 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580586}
 - 
Nico Weber authored
We used to set the timestamp to a hash of the binary, similar to https://blogs.msdn.microsoft.com/oldnewthing/20180103-00/?p=97705 However, that caused an appcompat warning on Windows 7 to appear, which interpreted the hash as a timestamp. (It's possible that https://llvm.org/PR38429 could help with that, but my guess it won't have an effect on Windows 7, which likely always believes that the the coff timestamp field always stores a timestamp). So currently we write the current time during linking in that field, but that's bad for build determinism and that in turn is bad for swarming test result cachability. build/write_build_date_header.py already creates a deterministic BUILD_DATE with several tradeoffs. Cachability wants this to change infrequently, but things like HSTS need a "real" build date and want this to change frequently. The compromise is: The date changes once per day in official builds, and once a month in regular builds. (We could use /Brepro in ldflags instead of /TIMESTAMP for unofficial builds to get the binary hash in the timestamp, but having the header timestamp match the BUILD_DATE define seems nice.) So let's use that same time as timestamp in the PE/COFF header. lld-link has a /TIMESTAMP: flag we can use to pass in an explicit timestamp. Since tools can't have deps, we need to compute the timestamp at gn time, so split write_build_date_header.py in two pieces: build/compute_build_timestamp.py that just prints the timestamp we want to use, and the old write_build_date_header.py, which now takes that timestamp and writes the header file. Call compute_build_timestamp.py at gn time so that we can pass it in ldflags, and pass the resultl to write_build_date_header.py which keeps running as an action during build time (so that we at least don't need to write a file at gn time). An additional wrinkle here is that the PE/COFF timestamp is used as one of just two keys per binary for uploading PE binaries to the symbol server, the other being file size. https://bugs.llvm.org/show_bug.cgi?id=35914#c0 has a good description of this, and tools/symsrc/img_fingerprint.py's GetImgFingerprint() is our implementation of it. But since we only upload binaries with symbols for official chrome builds to the symbol server, a timestamp that changes once a day should be still enough. (32-bit and 64-bit chromes have the same filename, and we might rarely build canary and beta and stable all on the same day, but them all being the same size seems highly unlikely.) Bug: 843199,804926,330260 Change-Id: I1d4193cc537ae0c4b2d6ac9281fad29de754dd6c Reviewed-on: https://chromium-review.googlesource.com/1161104Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580585}
 - 
Shakti Sahu authored
This CL migrates the download home list property model to use a PropertyModel instead. Bug: 870432 Change-Id: I6f1f2f5f523f5fb66726e3991e3d3d8dd0f760fa Reviewed-on: https://chromium-review.googlesource.com/1161216Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580584}
 - 
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d38bbdff043d..f6027ed1df0b git log d38bbdff043d..f6027ed1df0b --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vovoy@chromium.org Only download necessary wprgo files in story_runner Created with: gclient setdep -r src/third_party/catapult@f6027ed1df0b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:869762 TBR=sullivan@chromium.org Change-Id: Ic657f700e58d458dfdf90ae2f8a3ccaeed5f76c6 Reviewed-on: https://chromium-review.googlesource.com/1162113Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580583}
 - 
Anna Offenwanger authored
Renaming BrowserXRDevice to BrowserXRRuntime, and all variables associated with it to runtime as well, to reduce the amount of confusion with blink's XRDevice. Also renaming vr_device_manager to xr_runtime_manager, becaues it managed BrowserXRRuntimes and their providers, not the blink XRDevices. Bug: 842025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie177d5c778526ed1ecc25b8577c1d3bf51da1b76 Reviewed-on: https://chromium-review.googlesource.com/1161495Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#580582}
 - 
Scott Violet authored
I'm putting all the '.h' files into public. We can refine the list as necessary later. I'm doing this as I would like to have private headers that other targets can't include (well, except tests). BUG=none TEST=none Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85 Reviewed-on: https://chromium-review.googlesource.com/1161498 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#580581}
 - 
Alexey Kozyatinskiy authored
The related CLs on V8 side were not landed. TBR=lushnikov@chromium.org Bug: chromium:595206,v8:7753,v8:7858 Change-Id: I8e5bbf2f2e9d59a20ff79917671e910e76148700 Reviewed-on: https://chromium-review.googlesource.com/1162310Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580580}
 - 
John Abd-El-Malek authored
chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly. This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work. Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: I85d78d25b1905c68524e0636cec3006102d17749 Reviewed-on: https://chromium-review.googlesource.com/1161610Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580579}
 - 
Bill Orr authored
Third party code will be blocked in the browser process. We'll need to host VR input outside the browser process. To support that, we need some IPC mechanism to get gamepad data over to the browser process where the device/gamepad service is hosted. For now, we'll host OpenVR gamepad data in the same place we host the OculusRenderLoop. This is not the final shipping location, but adding an IPC mechanism moves us closer to the final architecture. BUG=795510, 860821 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8385d1c4222df9636259743366f64eafbb40fa3a Reviewed-on: https://chromium-review.googlesource.com/1153561 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580578}
 - 
Avi Drissman authored
BUG=870341 TEST=as in bug Change-Id: Ia9ede9c30d95b9f569890eff242582129967dd11 Reviewed-on: https://chromium-review.googlesource.com/1161251Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580577}
 - 
Alex Moshchuk authored
Previously, if the last active frame in a renderer process was going away, it was possible to send out a process shutdown request (see RenderProcessHostImpl::ShutdownRequest()) prior to actually sending the swapout ACK, and potentially even prior to finishing tasks posted from the unload handler, such as postMessages. This CL postpones the process release until after the swapout ACK has been sent. As part of this, it slightly refactors process refcounting for swapped out transitions to happen in RenderFrameImpl rather than RenderWidget. This is because when the swapout ACK is sent from a PostTask, the widget that had been swapped out might've been destroyed, but we still want the process to be released. Bug: 794625, 867274 Change-Id: I76b492461ce5a9317e71e184118ee02057143565 Reviewed-on: https://chromium-review.googlesource.com/1157530 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580576}
 - 
Derek Cheng authored
MediaRouter.Dial.CreateRoute - records result of a CreateRoute call. MediaRouter.Dial.TerminateRoute - similarly for a TerminateRoute call. MediaRouter.Dial.ParseMessage - records result of parsing a message coming from the Cast SDK. MediaRouter.Dial.FetchAppInfo - records reuslt of a app info request. Note we already have metrics for device description. Bug: 808720,798861 Change-Id: Ic48eba338298e7086fcab290f24ab490e5944ab3 Reviewed-on: https://chromium-review.googlesource.com/1153648Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580575}
 - 
Max Moroz authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/d62662686b22..9dfdc2758f26 $ git log d62662686..9dfdc2758 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 dor1s [libFuzzer] Initial implementation of weighted mutation leveraging during runtime. 2018-08-02 kcc [libFuzzer] use absolute distance in addition to the hamming distance in value profiling; our A/B testing have (somewhat weak) indication that this provides an additional signal for corpus expansion Created with: roll-dep src/third_party/libFuzzer/src Bug: 854277 Change-Id: If7b083d5b3d983d7b8a2fe139a0f8a7494fea559 Reviewed-on: https://chromium-review.googlesource.com/1162074Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580574}
 - 
Bernhard Bauer authored
The USE_STORAGE category type can't be represented as a ContentSettingsType, which would make the UI fall back to displaying all categories. Bug: 856110 Change-Id: I434742d9fd330e4ff78f4ce69655da67a050e310 Reviewed-on: https://chromium-review.googlesource.com/1162237Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580573}
 - 
Peter Collingbourne authored
A future change will move the calls to this function into the individual subprocess implementations. Also simplify the API by leaking the field trial list instead of requiring the caller to keep it on the stack. This is similar to what we do in the browser process (see ChromeBrowserMainParts::SetupFieldTrials). Bug: 855193 Change-Id: Idf5fbd18d8a6b6f5831d7d5ef63293c22d60d127 Reviewed-on: https://chromium-review.googlesource.com/1159740Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#580572}
 - 
Justin Donnelly authored
The point of the text indent is to align with the suggestions in the dropdown. But if the location icon has text, it won't align anyway so the indent is not useful and looks odd. Bug: 859543 Change-Id: I355c81016a2691bcc237b108eec80318dccf1b50 Reviewed-on: https://chromium-review.googlesource.com/1159229Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#580571}
 - 
James Cook authored
AXWindowObjWrapper::OnWindowVisibilityChanged is using AXAuraObjCache::GetInstance()->GetOrCreate() to look up itself in the AXAuraObjCache. It's not clear to me what that will do during views::Widget teardown. It's theoretically possible this will do the "create" code path and end up with two AXWindowObjWrappers for the same aura::Window. Instead use |this| for the fired event rather than GetOrCreate(). I've manually verified with CHECK_EQ that they are the same object both in ordinary usage and on the bots. I noticed this while investigating a Widget close crash in the keyboard shortcut viewer mojo app on Chrome OS. Bug: 869608 Test: bots Change-Id: Ifdba944e9ea9bca2c2572875ba212063ec7dd66d Reviewed-on: https://chromium-review.googlesource.com/1161396Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#580570}
 - 
James Cook authored
Instead of twice. Right now the superclass also calls Hide(). This is a theoretical fix for an accessibility related crash during mojo app window close. Bug: 869608 Test: window close animations look fine, both for shortcut viewer and for mash browser windows Change-Id: I9782f07d9084902b4a26aa29285ff2e20e16c6bb Reviewed-on: https://chromium-review.googlesource.com/1161442Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#580569}
 - 
sczs authored
By calling reloadCellsForItems at the cell indexPath, the cell gets reconfigured and also redrawn since [tableView reloadRowsAtIndexPaths:withRowAnimation:] is called. This causes the cell height to adjust to the new content. Bug: 869838 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iadd0a7f9a80d321015f654bd51dfeb084861f2cf Reviewed-on: https://chromium-review.googlesource.com/1159328Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580568}
 - 
Pawel Osciak authored
This reverts commit ae29b155. Reason for revert: crbug.com/868190. Original change's description: > RELAND: vaapi: decode on client NativePixmaps > > This CL relands crrev.com/c/1021675 that got reverted as predecessor > to crrev.com/c/1104394 (but was otherwise innocent AFAIK). The said > predecessor situation has been corrected by crrev.com/c/1117606 (that > landed in ChromeOS 10840.0.0 [1]) > > [1] https://crosland.corp.google.com/log/10837.0.0..10840.0.0 > > TBR=dcastagna@chromium.org (same code as reviewed before) > > Original CL description ----------------------------------------------- > vaapi: decode on client NativePixmaps > > This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving > a buffer copy and removing a costly blit (DownloadFromSurface) on the > GPU Main thread. Three groups of changes: > > 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a > VaapiPicture with a VASurfaceID, we use those to decode onto and set a new > flag: |decode_using_client_picture_buffers_| > > 2. When the decoder calls CreateVASurface(), instead of giving it the first > |available_va_surfaces_|, we need to figure out the first VASurfaceID in > this |available_va_surfaces_| such that the corresponding VaapiPicture in > |pictures_| is available (i.e. in |available_picture_buffers_|). > Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one > correspondence like on ToT. > > 3. When we're ready to OutputPicture() to |client_|, instead of using the first > |available_picture_buffers_|, we find the corresponding one for the > passed |va_surface_id| (we could search all over |pictures_| but there's > always less |available_picture_buffers_|. > > Some other notable developments: > > - s/output_buffers_/available_picture_buffers_/ > - OutputPicture() loses a parameter. > - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 > or the ImportBufferForPicture() path. > - Pictures is made a base::small_map. (Originally from crrev.com/c/988512). > > resolutions for a long time. No hickups, no dropped frames. > > Bug: 822346, 717265 > Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ie1fb21a7a302476bceee3dd905278d53f13b1475 > Reviewed-on: https://chromium-review.googlesource.com/1021675 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Reviewed-on: https://chromium-review.googlesource.com/1147143 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577226} TBR=mcasas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346, 717265 Change-Id: I8b91c852d94061771fc0ff8caea6616c74f9454a Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1161621Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#580567}
 - 
Manu Cornet authored
This removes everything related to panels in the shelf code. Some more code should be deprecated/deleted after this CL. For instance: views::Widget::InitParams::TYPE_PANEL aura::client::WINDOW_TYPE_PANEL ash::kPanelAttachedKey ui::mojom::WindowManager::kPanelAttached_Property extensions::LAUNCH_CONTAINER_PANEL Bug: 805612 Bug: 788033 Bug: 153447 Change-Id: I06a64ff44c3104a4eddb4e6f136b2e73abbebcff Reviewed-on: https://chromium-review.googlesource.com/1141267 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580566}
 - 
Carlos IL authored
This is a reland of 49040ae7 Original change's description: > Changed committed-interstitials flag from switch to feature. > > Removed 'committed-interstitials' switch and added SSLCommittedInterstitials > base::Feature. Name was changed to SSLCommmittedInterstitials since we are now > doing separate rampups for each kind of committed interstitial. Switch was > changed to Feature so that it can be enabled via variations. > > Bug: 755632 > Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56 > Reviewed-on: https://chromium-review.googlesource.com/1118975 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574621} Bug: 755632 Change-Id: I9ef1fa141d9481537740569c4af6504998c619e2 Reviewed-on: https://chromium-review.googlesource.com/1138516Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#580565}
 
 -