- 05 Oct, 2019 18 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7f271e7f2645..4c82a9fc83a5 git log 7f271e7f2645..4c82a9fc83a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 brianosman@google.com Roll third_party/externals/angle2 2328d65ab30d..5549ef0451f9 (8 commits) Created with: gclient setdep -r src/third_party/skia@4c82a9fc83a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: I246784d52bf7dbf8ce49ed60ef40919bc38613c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703119}
-
Mathieu Binette authored
Moved config from this file: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/chrome/browser/policy/e2e_test/infra/config.pyl No change except config name from 'win-celab' to 'celab_release_bot' for consistency with other names here. This needs to be done in multiple CLs to prevent builder breaks: 1) Move configs to //tools/mb/mb_config.pyl [this change] 2) Recipe change to use the default mb_config_path 3) Delete chrome/browser/policy/e2e_test/infra/config.pyl Verified that we still generate the same build files: https://ci.chromium.org/raw/build/logs.chromium.org/chromium/led/mbinette_google.com/971b834147dd1151b62cfa0ee52308422ec9e0cd6d1b27d8f41dd93e567b8811/+/annotations?server=chromium-swarm.appspot.com (unrelated test failure tracked in https://crbug.com/1008922) Bug: 1011508 Change-Id: Ic1a81ac4b651b4707b10ba64fc97ee2f78c01b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841581Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#703118}
-
David Tseng authored
Change-Id: I9bfbf38f64f0a498e71c5cf38ec5908f2b3de03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827469 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703117}
-
Hesen Zhang authored
- Fix some lint issues detected by "git cl lint" command. Bug: 1011525 Change-Id: I31cb2d19d847c46d4440cf0280e5d872cd3a4111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842515 Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703116}
-
Scott Violet authored
This addresses two problems that triggered CHECKs/use-after-free: LayoutBlock, for -webkit-box, needs to add children to anonymous blocks in some cases. LayoutFlexibleBox should not merge anonymous flex items for -webkit-box. BUG=1010706 TEST=none Change-Id: Ic8cb22f4f031813c1e1447bc23f4bfb930b3caec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838754 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703115}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/76548ed5..14b4bc0d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0235c73a08eebd876278747feb71a1653a9b8a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842075Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703114}
-
Evan Stade authored
Instead of using NOTIFICATION_PROFILE_CREATED, listen for OnProfileAdded. This will automatically filter out incognito profiles, which are not "added" to the ProfileManager. Also, there's no need to listen for profile destruction as ProfileManager and its profiles are only destroyed after SafeBrowsingService is shut down. Bug: 268984 Change-Id: I73f8163d6488968fec019f878951172d348e9e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836433Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#703113}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f7ad03aa869b..1ba72546da4c git log f7ad03aa869b..1ba72546da4c --date=short --no-merges --format='%ad %ae %s' 2019-10-04 jmadill@chromium.org GN: Allow building without /build/ folder. Created with: gclient setdep -r src/third_party/angle@1ba72546da4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I941e7966ee4857e14ba9dcf3ac3dbe8ce5f80555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703112}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ce64248fdc9..57a5b927de7d git log 6ce64248fdc9..57a5b927de7d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 vapier@chromium.org failures_lib: rework handling of Exception.message 2019-10-04 vapier@chromium.org infra_libs: drop unused imports Created with: gclient setdep -r src/third_party/chromite@57a5b927de7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic42ffc7359bf31e907990a52750df3a7ed22772b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703111}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifc08e837d17feb3402cb779a3a18d20e87ff166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703110}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8151b15c. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4157aa3be40682e2e4a7cadf610cd9d6d8c05e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842074Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703109}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9b9ccf7ac88a..61297bd64bfd $ git log 9b9ccf7ac..61297bd64 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 yusukes system_api: Add cpus field to StartArcVm proto 2019-07-02 cylai system_api: compile attestation_ca.proto to golang Created with: roll-dep src/third_party/cros_system_api BUG=b:142144019,b:139752657 TEST=try Change-Id: Ib5721ae0d5c0403dfac5880ec04bef4030444389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841897 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703108}
-
Matt Menke authored
Also turn the ReportingEndpointManager tests into unit tests, so that this is testable without wiring up NetworkIsolationKey through all the reporting code. Bug: 993805 Change-Id: I0d511dd7eb5f1418bf0a29e853198c39b4b4ea97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842131 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#703107}
-
Bettina authored
Bug: 1010764 Change-Id: I0a37a1f275f74860cc4df79747f9df97f7d22be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842503Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#703106}
-
Brandon Wylie authored
Change-Id: I0c52401587eda127ae9e48515fbd20db8b63d41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841582Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703105}
-
chrome://managementdpapad authored
Bug: 965770 Change-Id: Ie978f3b8331275693f883ae6b11058f0a2ad3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836604 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#703104}
-
Carlos IL authored
Removes the active mixed content shield from the omnibox and adds an 'Insecure Content'content setting to toggle allowing it on a per site basis. Currently behind a default off flag. Bug: 987294 Change-Id: Ic4c5238261eabc9606101a5227c6479a40f6633f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757740 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703103}
-
kylechar authored
Remove some usage of deprecated callback types in services/viz/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Bug: 714018 Change-Id: I241bbfff47b705f448790e13b2089fe10425e280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841235Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#703102}
-
- 04 Oct, 2019 22 commits
-
-
Benjamin Beaudry authored
When navigating by word or by character with ATs on Windows (i.e. Narrator), links were not announced by the screen reader or were announced one word earlier. This was caused by two different bugs: 1. GetEnclosingElement() used to return the child text node of the link instead of returning the link node. I believe this might cause multiple other bugs related to other controls, such as buttons, and will look into a more general fix soon. This bug as been addressed in CL:1828124. 2. For Narrator to announce links and other control types properly, the |start_| and |end_| endpoints of a range must be in the same anchor for by word and by character navigation. Otherwise, "link" will be announced multiple times where not expected. This CL introduces a fix for the second bug. We reposition the |end_| endpoint to the end of the |start_| anchor if they are not in the same anchor. Bug: 928948 Change-Id: Ie455cdee26d233b6b97347345d0e3cdaa99b9f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825490Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703101}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40ba239931e2..6822e098c873 Created with: gclient setdep -r src-internal@6822e098c873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ibe1b98fb2227f356e93c5573a4754f7682bda6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842398Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703100}
-
Maggie Chen authored
This DCHECK in the default initialization path prevents Chrome from running in Windows. Remove this DCHECK and use a error log instead when Vulkan is enabled. Bug: 1010584 Change-Id: I52dfab8ee07c2a555c155722e632f974cfbbdf59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842039Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/571177f01598..7f271e7f2645 git log 571177f01598..7f271e7f2645 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7f271e7f2645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I50f9896803b167b4667c34c0fa56ef71b47216ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842498Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703098}
-
Sergey Ulanov authored
Previously WidevineKeySystemProperties was initialized with hw_secure_codecs containing only video codecs, which was preventing playback on sites that require HW_SECURE_ALL robustness. Bug: b/141148085, b/141251412 Change-Id: Ia2909e47fa844a50655047132bfa04cfe317c222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841744 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703097}
-
Joe DeBlasio authored
This CL updates the Safety Tip UI to add a 'learn more' link, an explicit ignore button, a revised edit distance button string. It also prepares the code to facilitate a new graphical header. This CL omits the placeholder image for the header while we are figuring out the final UI. Using the a tentative image, it looks roughly like this: https://storage.cloud.google.com/chromium-translation-screenshots/df14c960857c08e55816d0cd50445988f337be8a Bug: 996731 Change-Id: I8db71f843a23e89c370b7cc3fbb9c79346bafd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816805 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703096}
-
Johann authored
Change-Id: I2e52c0c27b049b8af8af205b7d6d497139bc071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838529 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#703095}
-
Collin Baker authored
This CL: * Exposes function for getting Browser* from a window ID in ExtensionTabUtil * Moves TabRendererData creation logic into c/b/ui/tabs * Makes the tab strip JS notify TabStripUI of its window ID * Observes the window's TabStripModel in TabStripUI Bug: 1006946 Change-Id: Ie9650cf9070c140d7ae23415f57d96bfcb8d76d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836455 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#703094}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/f518a2641c6d..ef79a5fa1b2c $ git log f518a2641..ef79a5fa1 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 dschinazi Improve logging by adding more ToString methods and refactor 2019-10-04 bnc Fix crasher in QpackProgressiveDecoder destructor if QpackHeaderTable is already destroyed. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I74618e93beb91846c3f65783c796bd9b0b610f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841584 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703093}
-
Tina Lu authored
Bug: 1009844 Change-Id: Ibf6b878061f30c93541f29dad41520cf399dc2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830090Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tina Lu <ltina@google.com> Cr-Commit-Position: refs/heads/master@{#703092}
-
Danan S authored
The WallpaperControlClient is referenced by the SessionControllerClient via the following code path: WallpaperControllerClient::RemoveUserWallpaper() policy::WallpaperImageExternalDataHandler::RemoveForAccountId() chromeos::ChromeUserManagerImpl::RemoveNonCryptohomeData() user_manager::UserManagerBase::RemoveUserFromList() user_manager::UserManagerBase::RemoveNonOwnerUserInternal() chromeos::ChromeUserManagerImpl::RemoveUserInternal() user_manager::UserManagerBase::RemoveUser() chromeos::ChromeUserManagerImpl::PerformPostUserListLoadingActions() user_manager::UserManagerBase::EnsureUsersLoaded() user_manager::UserManagerBase::GetUsers() chromeos::ChromeUserManagerImpl::GetUsersAllowedForMultiProfile() SessionControllerClientImpl::GetAddUserSessionPolicy() SessionControllerClientImpl::SendSessionInfoIfChanged() SessionControllerClientImpl::Init() Because the WallpaperControllerClient singleton hasn't been created yet, this results in a crash when running tests that activate the code path. This was discovered while working on http://crrev.com/c/1836457. This fix is necessary to fix a crash in that CL. Bug: 1010707 Change-Id: I239a743536afd97c99ba5e8e1fb1d6031c4a9805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842318Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703091}
-
Alison Maher authored
WebThemeEngineImplDefaultBrowserTest.GetSystemColor was disabled due to failure on Win7: https://chromium-review.googlesource.com/c/chromium/src/+/1837225 The test now takes Win7-specific system colors into account. Bug: 1010924 Change-Id: If14e79d90ed9cda1cbbfdc2a2144751cdd493754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839013 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703090}
-
Renjie Tang authored
Bug: 1011036 Change-Id: Ic0cd9cb59240c65efe1702da605b3898fb2aa69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838952Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703089}
-
Vladimir Levin authored
This patch updates the perftests to use rendersubtree attribute instead of the imperative displayLock. Also adds an activatable perftest. For this change to be equivalent to the previous one, the perf tests also need to run with CSSContentSize enabled, which this adds as well. R=chrishtr@chromium.org, crouleau@chromium.org Change-Id: I6447b467aa9cd58da9f572bca0eca7eda04f3216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841233Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703088}
-
Alex Cooper authored
This test page can help validate scenarios where a page is behaving or performing poorly. Bug: 1009813 Change-Id: I0e31bc919194e0db19b0b346f9568a45828834ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842278 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703087}
-
Toni Barzic authored
Disables events within apps container subtree when the apps container is shown (faded) behind search results. Change-Id: I80e83a584ec206f059e2ab34300d338479e6c6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842008 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703086}
-
Nate Fischer authored
No change to logic. This refactors WebView's metrics files into a separate folder (//aw/browser/metrics/, //aw/java/.../metrics) and refactors the native files into a separate build target. I've also added OWNERS files for the subfolders, proposing myself as owner. Bug: 934152 Test: gn check out/Default/ Test: ninja -C out/Default/ webview_instrumentation_test_apk system_webview_apk android_webview_unittests Change-Id: I049e1336ba6d452527069f49d16495bd985224bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842533Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703085}
-
Matt Mueller authored
CertVerifierWithTrustAnchorsTest: test both CertVerifyProcChromeOS and CertVerifyProcBuiltin(with SystemTrustStoreProviderChromeOS) Bug: 410574 Change-Id: I8f1eaa03c0c5497ab51b72dda4d96f75a53c5a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836383 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#703084}
-
Philip Rogers authored
Removed CompositeAfterPaint-specific mask-composite-missing-image expectation that caused the test to fail. Triaged composited filter failures (crbug.com/1008501). Bug: 1008501 Change-Id: I67472958ed19a7f32afa7971559ef6ec437d8adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841734Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703083}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6474a450e961..23463e8bb77f git log 6474a450e961..23463e8bb77f --date=short --no-merges --format='%ad %ae %s' 2019-10-04 amaiorano@google.com Remove unused SamplingRoutineCache::Key::operator< Created with: gclient setdep -r src/third_party/swiftshader@23463e8bb77f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141863676 Change-Id: I7eb624b192ee7964c8452ad2a7e28ac822941919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703082}
-
Fredrik Söderquist authored
Move the priority comparison between two timed elements into the new SVGSMILElement::IsHigherPriorityThan() method. This ought to make fixing the existing FIXME easier. Bug: 998526 Change-Id: I05492faa770cb9eaf8589e88cbf86845f870c9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841131 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#703081}
-
Daniel Cheng authored
Bug: none Change-Id: I4c065e8257c54ff9d731fca17c3786764e9a774a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841504Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#703080}
-