- 02 Apr, 2018 40 commits
-
-
Ryan Landay authored
My CL https://chromium-review.googlesource.com/801979 exposed a bug with PlainTextRange::CreateRange() when passed a collapsed range at the beginning of a table cell. TextIterator outputs a tab character ('\t') when iterating over a table cell boundary; PlainTextRange() is currently counting the tab character in its character count for this case, but returning a start/end position (they're the same since it's a collapsed range) before the <td> element, causing an off-by-one error. xiaochengh@ found a fix for this issue, so CreateRange() now returns a position inside the text node, instead of before the <td> element. Bug: 826615 Change-Id: Ief427ea6aeb0b93cf82bae3b6901cf1b2a8cb4c7 Reviewed-on: https://chromium-review.googlesource.com/987385Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#547447}
-
Matthew Jones authored
The bottom container that hosts infobars and snackbars now listens to the bottom sheet. This allows the bottom container to stack on top of the sheet when it is showing. Bug: 827541 Change-Id: Ib130cf4149223afc892945f84483467b88c28588 Reviewed-on: https://chromium-review.googlesource.com/988063Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547446}
-
Rohit Rao authored
Fixes minor issues with an underspecified "Cancel" button matcher and updated swizzling to use the new LocationBarCoordinator instead of the old LocationBarLegacyCoordinator. BUG=825431 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6ef8c3d585f8575939ed74c7ec6eb189d31d6f22 Reviewed-on: https://chromium-review.googlesource.com/989271Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#547445}
-
Dan Harrington authored
These are all the tasks required to save, load, and cleanup thumbnails. base change: https://chromium-review.googlesource.com/c/chromium/src/+/984952 Bug: 794828 Change-Id: I1ce081f53913a9b4c24b7f00a9d173c3fc061696 Reviewed-on: https://chromium-review.googlesource.com/985014 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#547444}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/371913c4e6f0..fd5d1859f1e0 $ git log 371913c4e..fd5d1859f --date=short --no-merges --format='%ad %ae %s' 2018-03-26 achuith cros_vm: Safely create vm_dir. Created with: roll-dep src/third_party/chromite BUG=chromium:782664 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5e35d45bd91fd417ef123d40fcf3db5f9580469e Reviewed-on: https://chromium-review.googlesource.com/989845Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547443}
-
Eugene But authored
Previously BVC used self.view as superview for tab.view to animate NTP opening. This disallowed to create a view controller for _contentArea because views hierarchy should always match view controller's hierarchy. To allow view controller creation, this CL always uses _contentArea as superview for tab.view. In order to avoid animation issues, _contentArea is temporary resized during NTP opening animation. Doing this resize is fine in the short term, because _contentArea always hosts NTP for this specific case. In the long term this code will be removed because we will need a different NTP opening animation. A separate _contentArea view controller will allow to fix download manager presentation. That view controller will be a base view controller for download manager coordinator, so download manager will be presented in _contentArea behind the bottom toolbar. _contentArea is created in a separate CL: crrev.com/c/981684 Bug: 818264 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6e642d9e8fd856ef4c1a0fceb1cf7615dad050a7 Reviewed-on: https://chromium-review.googlesource.com/985150Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#547442}
-
Ian Swett authored
Enable better crypto retransmission in Quartc. This fixes an issue where sending empty Brain sync messages reset the timer for retransmitting lost crypto stream packets (most notably, the SHLO). This means Quartc will no longer fail to connect whenever the SHLO is lost. n/a (only changes the Quartc library) Merge internal change: 190280389 https://chromium-review.googlesource.com/c/chromium/src/+/988393 Base the QUIC crypto retransmission timer on the last sent crypto packet. Protected by FLAGS_quic_reloadable_flag_quic_better_crypto_retransmission Merge internal change: 190269115 https://chromium-review.googlesource.com/c/chromium/src/+/988974 Remove special logic for headers stream from QuicWriteBlockedList and replace it with a static streams map. Protected by FLAGS_quic_reloadable_flag_quic_register_static_streams Merge internal change: 189971751 https://chromium-review.googlesource.com/c/chromium/src/+/988972 In QUIC, initialize packet_number_length in QuicPacketHeader to be PACKET_4BYTE_PACKET_NUMBER instead of PACKET_6BYTE_PACKET_NUMBER. Not protected. No functional change expected. Also replace PACKET_6BYTE_PACKET_NUMBER used in tests to be PACKET_4BYTE_PACKET_NUMBER as well. Merge internal change: 189965758 https://chromium-review.googlesource.com/c/chromium/src/+/988474 Remove AndTypeByte from IETF methods in QuicFramer because they all append the type byte, and update other comments. n/a (method renames) Merge internal change: 189887458 https://chromium-review.googlesource.com/c/chromium/src/+/988494 Change the QUIC/Quartc write model to buffer all stream data up front. This isn't so much a change in model as a recognition of how things actually work and some tweaks to make handle that correctly. Whenever Quartc writes an outgoing frame (eg. video, audio, data, or control message) to QUIC, it writes the entirety of the frame to a new QUIC stream, followed immediately by a FIN. QUIC buffers all this data, sends as much as it can immediately, and saves the rest to write later. QUIC never calls OnCanWrite(), because Quartc gives it a FIN bit for the first write on every stream. Hence, this change replaces OnCanWrite() with OnBufferChanged(), a callback which occurs whenever the amount of data buffered by a QUIC stream increases or decreases. This change replaces bytes_written() with bytes_buffered(), which gives direct access to the data Quartc needs: how many bytes QUIC still needs to send. Whenever the buffer size changes, Quartc will report bytes_buffered() to the Brain. The initial call to Write() triggers a change in buffer size, and calls OnBufferChanged(), so Quartc no longer needs extra logic to report the initial buffer size. n/a (quartc change only) Merge internal change: 189824431 https://chromium-review.googlesource.com/c/chromium/src/+/988277 Remove call to Initialize from the MockQuicSession and MockQuicSpdySession constructors. n/a - test-only change Merge internal change: 189783811 https://chromium-review.googlesource.com/c/chromium/src/+/988276 deprecate flag FLAGS_quic_reloadable_flag_quic_close_session_on_too_many_outstanding_sent_packets. Merge internal change: 189774270 https://chromium-review.googlesource.com/c/chromium/src/+/988373 Add framers/deframers for IETF-format Quic BLOCKED, MAX_DATA, MAX_STREAM_DATA, MAX_STREAM_ID, STREAM BLOCKED, and STREAM ID BLOCKED frames in support of eventual migration to IETF Quic. Not applicable, code not used in production All of these frames have been done in one CL since they all are very similar. Merge internal change: 189569936 https://chromium-review.googlesource.com/c/chromium/src/+/987479 R=rch@chromium.org Change-Id: I3ef18060e76ecf66343a0d7f151402cc8c28bd6c Reviewed-on: https://chromium-review.googlesource.com/988597 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#547441}
-
Steven Bennetts authored
In mash, Shell::local_state_ is loaded asynchronously. Components that require access to local state should implement ShellObserver::OnLocalStatePrefServiceInitialized. Bug: 678949 Change-Id: I72917db3f83f56335333a3e7b40210c289f58a0c Reviewed-on: https://chromium-review.googlesource.com/988213 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#547440}
-
Bailey Berro authored
This change does some cleanup of SmbService, SmbFileSystem, and SmbProvider. These changes include: - Use AsWeakPtr() for SmbService. - Add an SmbService::GetSmbProviderClient() helper method. - Store provider_id_ as a member variable on SmbService. - Remove provider_id as a parameter from SmbService::Unmount() - Remove provider_id from the UnmountCallbacks held by SmbProvider and SmbFileSystem Bug: chromium:757625 Change-Id: Iaec9388b04f8bcd2aa781c654b00268ba0948aa2 Reviewed-on: https://chromium-review.googlesource.com/986629 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#547439}
-
https://skia.googlesource.com/skia.git/+log/5ab52f6a3805..01a1cf92603c $ git log 5ab52f6a3..01a1cf926 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 kjlubick More nans causing infinite recursion in GrPathUtils::convertCubicToQuads Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: If1257cf17825bff214f8406007cc69f8176066d1 Reviewed-on: https://chromium-review.googlesource.com/990032 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547438}
-
John Abd-El-Malek authored
Bug: 825242 Change-Id: Ifb779d7bdc42dc98558803298576568d65a95bc5 Reviewed-on: https://chromium-review.googlesource.com/988806 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547437}
-
Nico Weber authored
Bug: none Change-Id: Iacc611282edb2d53bf213b75c07e4b724b2ac0ac Reviewed-on: https://chromium-review.googlesource.com/989246Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547436}
-
Rohit Rao authored
Modifies the test to use the TabSwitcherMode enum instead of checking IsIPadIdiom(). Adds some EG matchers for various elements of the tab grid. BUG=825431 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29de41c895696627f37cc26b0c7853ab068f1834 Reviewed-on: https://chromium-review.googlesource.com/988273 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547435}
-
https://skia.googlesource.com/skia.git/+log/c6a19f1d044e..5ab52f6a3805 $ git log c6a19f1d0..5ab52f6a3 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 caryclark fix a couple of minor surface doc changes Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I5f8c2fcfcf216d331629779dc8ce4e086268d3b9 Reviewed-on: https://chromium-review.googlesource.com/989843 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Chandan Padhi authored
Currently, default resolution is set to 2880x1800. This CL now sets it to the actual screen size. Bug: 257097 Change-Id: I547262c563453e31cd8be30e79148d4b92d8c90a Reviewed-on: https://chromium-review.googlesource.com/989531 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#547433}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f11c0604. With Chromium commits locally applied on WPT: ad7d8f49 "[css-grid] Fix resolution of percentage paddings and margins of grid items" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15230 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=ajuma No-Export: true Change-Id: I41891be12620bcbf667e60d2906e56f3f8dfb949 Reviewed-on: https://chromium-review.googlesource.com/989247 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547432}
-
https://webrtc.googlesource.com/src.git/+log/0ffe03d2ef6f..23ffbe78f3b3 $ git log 0ffe03d2e..23ffbe78f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5eeef4598a152d8cd89c058390b67b036d4e2a2e Reviewed-on: https://chromium-review.googlesource.com/989842 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547431}
-
Koji Ishii authored
While working on supporting LayoutNG, it turns out that there are several cases where the selection range becomes start > end. e.g., fast/text/selection/emphasis.html Layout functions generally prefer proper checks are done in the callers, rather than input arguments automatically corrected in lower-level functions. This patch makes LayoutText::LocalSelectionRect match to it. Bug: 636993, 827925 Change-Id: I3068e70886f7cd425a2fd5f701ac0b7d77a8a978 Reviewed-on: https://chromium-review.googlesource.com/989474Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547430}
-
Findit authored
This reverts commit 3017d428. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 547425 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMwMTdkNDI4ZTI2NzNlYjdkM2E1MDhlYWI1MzIxMzliODc0ZTAzZmEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4999 Sample Failed Step: browser_tests Original change's description: > Reland "Enforce user gesture requirement on browser side for WebUI." > > This is a reland of f6953215 > > Original change's description: > > Enforce user gesture requirement on browser side for WebUI. > > > > Also, don't trust the renderer process to send the correct URL. > > > > Bug: 823864 > > Change-Id: I1f5c1c7908d8157240b5a7d5fc2df944267cf537 > > Reviewed-on: https://chromium-review.googlesource.com/979399 > > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#547114} > > Bug: 823864 > Tbr: sky@chromium.org > Change-Id: I9751f0f63524aa52bc5af326cd00e99a84dc1009 > Reviewed-on: https://chromium-review.googlesource.com/987694 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547425} Change-Id: I100d8b7bdcf95693a3ee8a7d70af76bfc0ea9654 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823864 Reviewed-on: https://chromium-review.googlesource.com/989992 Cr-Commit-Position: refs/heads/master@{#547429}
-
Tatsuhisa Yamaguchi authored
This will avoid exposing in-progress zip file to the destination folder. It will resolve the issues like: - the zip file is synced to Drive with incomplete state, having multiple revisions - when cancelling zip packing, the file appears in the trash of Drive Bug: 714579,785096,785093,785086,797873 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b32515d5e896d87e1dee499f1eea40dd7a481f0 Reviewed-on: https://chromium-review.googlesource.com/844442 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547428}
-
Adam Rice authored
Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/YEHinDOBaBw Move TransformStream.js from v8_experimental_extra_library_files to v8_extra_library_files in //.gn. Also update the stable webexposed interface expectations. Bug: 780689 Change-Id: Ia16a9c2d7a45a00a0cdf72b1e53f72d60dd07e71 Reviewed-on: https://chromium-review.googlesource.com/985933 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547427}
-
Kent Tamura authored
The old names were confusing because they looked to handle any TextControlElement instances like other IsFoo/ToFoo but actually they don't handle non-text-field input types. This CL has no behavior changes. Change-Id: Ibd504e8bfb164550c33cb37d463acdbcda0b17ad Reviewed-on: https://chromium-review.googlesource.com/989524 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Daniel Cheng authored
This is a reland of f6953215 Original change's description: > Enforce user gesture requirement on browser side for WebUI. > > Also, don't trust the renderer process to send the correct URL. > > Bug: 823864 > Change-Id: I1f5c1c7908d8157240b5a7d5fc2df944267cf537 > Reviewed-on: https://chromium-review.googlesource.com/979399 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547114} Bug: 823864 Tbr: sky@chromium.org Change-Id: I9751f0f63524aa52bc5af326cd00e99a84dc1009 Reviewed-on: https://chromium-review.googlesource.com/987694 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#547425}
-
Kent Tamura authored
Bug: 821831 Change-Id: I5b3e1978e37ce34e6fb885ca1077ea90ab2f494c Reviewed-on: https://chromium-review.googlesource.com/987972Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547424}
-
Yoshifumi Inoue authored
This patch changes |Sample| class used in |assert_selection()| by reusing IFRAME for making |selection_test()| and |assert_selection()| faster. # Changes of tests ## assert_selection.html Because of |assert_selection| doesn't remove IFRAME used by |Sample|, this patch changes assertion to check IFRAME, which "id" is "sample", available. ## overtype.html This patch changes each test starts with overwrite mode is off, because of the overwrite mode state is state of |LocalFrame|, each test should reset it. ## spellcheck_test.js This patch changes |spellcheck_test()| not to reuse IFRAME used by |Sample|. Change-Id: I6513a2ffa01caeb0ad18360b543d0ebb4bad253a Reviewed-on: https://chromium-review.googlesource.com/987632 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
Blink scheduler code is transitioning to a new directory structure. This patch moves files for ChildScheduler and its children, and rewrites affected include paths. This patch only renames files; the class names are not changed yet. The file names reflect the new names of the classes, instead of the current names, to avoid renaming include paths twice. The class names will be updated in a follow-up patch. The renaming scheme of those classes is a bit complex. Look at the design doc linked from the bug for details. TBR=kinuko@chromium.org,dalecurtis@chromium.org Bug: 826203 Change-Id: I72c10ee15f3510c11e9d0520d7f6e7d4a5715b66 Reviewed-on: https://chromium-review.googlesource.com/986112 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#547422}
-
Yoshifumi Inoue authored
This patch changes test cases using out of bounds positions to use valid positions. It seems these tests passes offset in Text node rather than child index in container node. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/987655 Validate offset parameter of Position constructor with introducing Position::CreateWithoutValidation() Change-Id: Ia14788eb4f9d9a7123795f9ef3cd6abeca8e094a Reviewed-on: https://chromium-review.googlesource.com/989521Reviewed-by:
-
Adam Rice authored
Add use counters to the constructors for ReadableStream, WritableStream and TransformStream. A new function, binding.countUse(), is added to the V8 Extras binding object and called from the constructors. See the V8 Extras Design Doc for more details on how this works: https://docs.google.com/document/d/1AT5-T0aHGp7Lt29vPWFr2-qG8r3l9CByyvKwEuA8Ec0/edit#heading=h.334ekprhracb binding.countUse() is registered by a new C++ function, AddUseCounterFunctionToV8ExtrasBindings() which is called when setting up the Javascript contexts for windows and workers. To help implement tests for the new function, some test functions have been factored out of core/streams/ReadableStreamOperationsTest.cpp into V8ExtrasTestUtils.{h,cpp}. There are also new layout tests to verify that the use counters are correctly set. Internal creation of a ReadableStream by creating a Response object does not set the counter. Currently constructing a TransformStream also set the ReadableStream constructor use counter. This will be fixed once ReadableStream has been updated to the latest standard version (http://crbug.com/710728). Bug: 769663 Change-Id: I484ef6843cbb800b345d56cf67d09e45b97ab3a3 Reviewed-on: https://chromium-review.googlesource.com/985345Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#547420}
-
Zhuoyu Qian authored
This CL introduce "StyleCommands.cpp" with moving |StyleCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Icb9a4f48ec4855d178e7b2932cc7f1bc7eef6666 Reviewed-on: https://chromium-review.googlesource.com/987652Reviewed-by:
-
Kent Tamura authored
We have no reason to restrict links to specific WebKit sub-directories. Bug: 622551 Change-Id: If0ebcb1b1241cb99e80d4bfffac2a24300fd3a02 Reviewed-on: https://chromium-review.googlesource.com/989812Reviewed-by:
-
Manuel Rego Casasnovas authored
We were not resolving properly percentage paddings and margins for tracks that have something like minmax(auto, 100px). The reason was that while computing the minimum size of a grid item, the percentages were resolved against the inline size of the grid container. But for grid items we shouldn't never use the grid container size, but the grid area size, as that's their containing block. The patch modifies ContainingBlockLogicalWidthForContent() and ContainingBlockLogicalHeightForContent() in LayoutBox, so for grid items we return 0 if the area size hasn't been set yet. We never want to use the grid container's sizes in these cases. BUG=808758 TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-margins-* TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-paddings-* Change-Id: Ib142e51aee1fe623d38688469b179f01f82eb07b Reviewed-on: https://chromium-review.googlesource.com/980756Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#547417}
-
cathiechen authored
This patch supports image list marker in LayoutNG, including: 1. Display image list marker. 2. Switch between image and text. 3. Deal with image error. 4. Support svg image marker. This approach creates a LayoutNGListMarkerImageContent which is subclass of ListStyleImage as marker_'s child. Use ListStyleImage as its ImageResource. The reason to create a new class is that: When image error occurred, marker should display text instead which needs updating layout tree. LayoutNGListMarkerImageContent overrides ImageNotifyFinished to send NotifyOfSubtreeChange when ErrorOccurred. So that list item could update layout tree before layout. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I43d2ac80f823b603a0c52c872abb78785453450e Reviewed-on: https://chromium-review.googlesource.com/970131Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#547416}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: If828d17072875fddc12936f3f158fec380f2ea13 Reviewed-on: https://chromium-review.googlesource.com/989516 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
tzik authored
This CL adds two rewriters to //tools/clang/base_bind_rewriters: - pass_by_value converts pass-by-cref base::Callback parameters to pass-by-value. - add_std_move inserts std::move() to pass-by-value base::Callback and local base::Callback variables where it looks relevant. add_std_move rewrites a occurrence of a reference to base::Callback if: - it's a pass-by-value parameter or non-const local variable. - the occurrence is the latest in its control flow. - no pointer is taken for the variable. - no capturing lambda exists for the variable. Change-Id: I83dfef7d8189ee43d052a203461bfb4ad1a25c1d Reviewed-on: https://chromium-review.googlesource.com/970143 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547414}
-
Kenichi Ishibashi authored
r547407 fixed a deadlock which caused timeout in fetch-request-xhr.https.html when S13nSW is enabled. Update the expectation file as it is no longer timed out. Note that the test is failing currently (w/ or w/o S13nSW). Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If6aca08a4ee513a331772f73e3c7bc24da8114ba Reviewed-on: https://chromium-review.googlesource.com/989518 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#547413}
-
Yoshifumi Inoue authored
This patch changes "android-longtap-not-select-empty.html.html" to utilize |selection_test()| for ease of maintenance. Following patch will move "android-longtap-not-select-empty.html.html" to "mouse/" directory for test classification. Bug: 679977 Change-Id: Iebab8184db6d228320748cf0b8f3090889ba247f Reviewed-on: https://chromium-review.googlesource.com/987837 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Satoshi Niwa authored
Bug: chromium:811679 Bug: chromium:816678 Bug: b:76128680 Test: Manually tested steps in b:76128680 Change-Id: Ia997588424e90af97aac2f89de1fe1e84266b6fc Reviewed-on: https://chromium-review.googlesource.com/987634Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#547411}
-
Koji Ishii authored
Following bot results are included. 4470 4474 4477 4484 4486 4487 4488 4489 4490 4491 4492 4493 4495 2 lines were removed and 4 lines were deflaked by consecutive results since 4426. ~150 image/image+text failures probably due to CL:986812, another incremental CL to change fonts on Linux in crbug.com/787020. Among them, 1 was changed from a ref test to test harness, and that text dump was removed. A few of them seem new failures and that they are not rebaselined. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I95a87e51f0fbcacbf58f0c89cce03334d0440d8d Reviewed-on: https://chromium-review.googlesource.com/988153 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I4a062ac1db4631215d1ec58bd5d79cc3acc5ba33 Reviewed-on: https://chromium-review.googlesource.com/987833Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547409}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: Id34d9b90a1e78b4cc72af1d0a0e1f6a6b009cd6b Reviewed-on: https://chromium-review.googlesource.com/989374 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
