- 12 Oct, 2018 40 commits
-
-
Quan Nguyen authored
Bug: 890912 Change-Id: Idc11767c37580c540cbb741a4cce5cabc3a0f29f Reviewed-on: https://chromium-review.googlesource.com/c/1277989 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599337}
-
bsheedy authored
Removes the explicit hard timeout on VR tests on Nougat. This makes it instead use the default of 1 hour, which is the same as the Oreo bot and should make the tests stop timing out after the recent addition of lots of tests. Change-Id: Icb290a23732977b305d6d0a779c69909e401f806 Reviewed-on: https://chromium-review.googlesource.com/c/1277884Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#599336}
-
Christopher Cameron authored
Cut-and-paste these classes into separate files, because their current location is getting crowded. Bug: 859152 Change-Id: I9bc9fe8225589f91ba1cbc9daaccfbe58288197f Reviewed-on: https://chromium-review.googlesource.com/c/1277581Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#599335}
-
Chan Li authored
This reverts commit 9846f362. Reason for revert: Compile failure on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Linux%20Builder/134994 Original change's description: > [Autofill] Save form submission button's title for FormData > > Save a button title into FormData for crowdsourcing. > > Title is inferred in two ways: > Type 1) Value attribute of an <input type="submit">. > Type 2) Text content of <button> > > If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>: > $ <input type="submit"> > # <input type="button"> > & <button type="submit"> > % <button type="button"> > > The value is truncated if the length is more than 200. The same value is used for labels. > > TODO: introduce title inference when there is no <form> tag. > TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>) > > Bug: 850606 > Change-Id: I54783cfdd0134b3aec52e9404740a3e1495a8176 > Reviewed-on: https://chromium-review.googlesource.com/c/1272356 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599333} TBR=rogerm@chromium.org,kolos@chromium.org,mkwst@chromium.org Change-Id: I5f72413c856b359045df86a532db24ad69922e0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850606 Reviewed-on: https://chromium-review.googlesource.com/c/1279163Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599334}
-
Maxim Kolosovskiy authored
Save a button title into FormData for crowdsourcing. Title is inferred in two ways: Type 1) Value attribute of an <input type="submit">. Type 2) Text content of <button> If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>: $ <input type="submit"> # <input type="button"> & <button type="submit"> % <button type="button"> The value is truncated if the length is more than 200. The same value is used for labels. TODO: introduce title inference when there is no <form> tag. TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>) Bug: 850606 Change-Id: I54783cfdd0134b3aec52e9404740a3e1495a8176 Reviewed-on: https://chromium-review.googlesource.com/c/1272356Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599333}
-
Stephen Chenney authored
We were submitting UMA every time we recorded a update time measurement, but some metric, particularly ForcedStyleAndLayout, may run multiple times per frame. In such cases we want the per lifecycle time, to make it comparable to UKM data and to avoid considering lots of small updates to be less bad than one big update. R=vmpstr@chromium.org BUG=869966 Only report UMA once per lifecycle update Change-Id: If4eebd782b4d109b18a608ece2a351226bb74732 Reviewed-on: https://chromium-review.googlesource.com/c/1277549 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599332}
-
Torne (Richard Coles) authored
Various places that use the JNI functions for accessing array elements directly either forgot to release the array elements afterward, or are doing something that can be done with one of the array helpers in base. Fix them up to behave properly. Change-Id: Iab3fe07949c67c884d60f7ffaaf0bd0faf0f13dc Reviewed-on: https://chromium-review.googlesource.com/c/1279005Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#599331}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I79ca1ec2869afec3c51b1a7d5f9faf830e325558 Reviewed-on: https://chromium-review.googlesource.com/c/1279092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599330}
-
Mikel Astiz authored
This became specially relevant recently due to ongoing adoption of ModelTypeStoreBackend for allmost all sync datatypes. Let's keep an eye of whether any of them is hammering disk I/O. Bug: 870624 Change-Id: I739ad4feaf9ef0ba3d74d0444d2c9fcb7ef48455 Reviewed-on: https://chromium-review.googlesource.com/c/1275852Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599329}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I377414b2858dec1b847811853ac50f30bf4042e8 Reviewed-on: https://chromium-review.googlesource.com/c/1279089Reviewed-by:
-
Koji Ishii authored
This patch fixes LayoutNGListMarker::TextAlternative to not to rely on it has LayoutText child. This can happen if the list marker is an image marker (for bullet lists) or the function was called before layout completes. LayoutListMarker always computes from its list item. LayoutNG took a shortcut because we store the result in its LayoutText child, but cases where we don't store was missed. AXLayoutObject::TextAlternative() calls this function. Bug: 894691 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6c13c6f00920702e17188858d15c674d38698dfb Reviewed-on: https://chromium-review.googlesource.com/c/1277132 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#599327}
-
Varun Khaneja authored
Bug: 750327 Change-Id: I1e29f70a8628f7ac85f66d86a5949ee4a3477545 Reviewed-on: https://chromium-review.googlesource.com/c/1278956Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599326}
-
Pete Williamson authored
Make sure sites in the blacklist are not returned as part of a catalog get operation. This builds upon Site blacklisting part 1. Bug: 893845 Change-Id: I38686753167bbcb8e9f9d75d6c323bda813cab31 Reviewed-on: https://chromium-review.googlesource.com/c/1274058 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#599325}
-
Wei Li authored
In recent change crrev.com/c/1263566, HeadlessContentUtilityClient will be exported in component build on Windows. As usual, it should be exported in headless.dll. However, library headless_shell_lib also includes this class which results compilation errors. This CL excludes HeadlessContentUtilityClient from headless_shell_lib in component build to resolve the breakage. BUG=894835 Change-Id: I44853a4c7a0701b9ea29cc16b18e9c3b358cb148 Reviewed-on: https://chromium-review.googlesource.com/c/1277883 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599324}
-
Nasko Oskov authored
The underlying bug that caused this test to fail with Network Service is now fixed, so the test can be enabled in that configuration. Bug: 866549 Change-Id: I7ad64a2b58f31293b0d9e93ec6865618df0d5924 Reviewed-on: https://chromium-review.googlesource.com/c/1278064Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599323}
-
Joel Einbinder authored
The shortcuts were looking for the SourcesPanel, when only the SourcesView was present. Bug: 875434 Change-Id: I6095ccaab4d7ab0c35f98153031e7204f023a30e Reviewed-on: https://chromium-review.googlesource.com/c/1277988Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#599322}
-
Peng Huang authored
Enable those two options which may improve skia performance. Bug: 894492 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d Reviewed-on: https://chromium-review.googlesource.com/c/1273267 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#599321}
-
Jacob Dufault authored
If the lock screen was shown on the non-primary user, fingerprint auth would not display because it only checked the primary user. Bug: 882688 Change-Id: Ibbc479f4e393f587594b3915d8afe3492246c303 Reviewed-on: https://chromium-review.googlesource.com/c/1272026Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599320}
-
Sahel Sharify authored
The original cl is reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1251901 The reland calls waitForCompositorCommit before starting the test to make sure that the compositor is ready. To Sheriffs: Please update the test expectations in case of a flaky test instead of reverting this cl since I need to convert middleClickAutoscroll tests to use gpuBenchmarking to land the fix for autoscroll coordinates: https://chromium-review.googlesource.com/c/chromium/src/+/1239174 GpuBenchmarking makes the tests prone to flakiness, input team will work on the flakiness of the tests using gpu benchmarking in Q4. Bug: 875945 Change-Id: Ic722fbd8a08bee7bc1e51143ae9a6cb738807fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1277806Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599319}
-
Aidan Wolter authored
The Multizone buffer must be flushed when we change the playback. The simplest way to do this is to stop the backend each time. This is equivalent to what is done in MediaPipelineImpl for cast devices that use CastRenderer. Bug: b/116795513, b/117497043 Test: cast_media_unittests, MZ and non-MZ pause/seek/skip Change-Id: I885f1be625944b907859b99bd86b4eb2ef1e9bbd Reviewed-on: https://chromium-review.googlesource.com/c/1271937 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#599318}
-
chrome://flags/#enable-ephemeral-flash-permissionBalazs Engedy authored
Bug: 892156 Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6 Reviewed-on: https://chromium-review.googlesource.com/c/1264660 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599317}
-
Ryan Hansberry authored
R=jhawkins@chromium.org Change-Id: Ic1b65341c11279c450322223fe87ff565faa36e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278953 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#599316}
-
Becky Zhou authored
Fix site settings and detail link not shown on page info under URL with certain unescaped characters. Bug: 874455 Change-Id: Icf31bee1b644136d285c5286938b16bc2b3de88c Reviewed-on: https://chromium-review.googlesource.com/c/1278205 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599315}
-
Charlie Harrison authored
This API is being used for abuse. Bug: 880863 Change-Id: I122e23f589d62eecc01a4418db3573c53779de7f Reviewed-on: https://chromium-review.googlesource.com/c/1275165Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#599314}
-
Etienne Pierre-doray authored
ScopedBlockingCall is now used to label blocking calls. There is no need to annotate calls to blocking //base APIs (base::File) since those are already annotated. Original CL intention was: This CL uses ScopedBlockingCall to mark blocking calls in /components/filename_generation. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. Bug: 874080 Change-Id: Iaa06bd88ea651b96f69b594158ee859124b890d8 Reviewed-on: https://chromium-review.googlesource.com/c/1191662Reviewed-by:David Trainor <dtrainor@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599313}
-
Christian Biesinger authored
R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I272879d680d0960944224e581855df9bd51aebf1 Reviewed-on: https://chromium-review.googlesource.com/c/1278950Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599312}
-
Gang Wu authored
Bug: 894861 Change-Id: I67fe7f9e2f77e71af570bb8bd85793d02a41272f Reviewed-on: https://chromium-review.googlesource.com/c/1278932Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599311}
-
erikchen authored
It was previously on an A/B experiment to assess the performance overhead. This overhead is <1%, so I'm turning the feature on by default. Bug: 859155 Change-Id: I555637a294cf8c5d7ce97f57b8aebe7f2fb73734 Reviewed-on: https://chromium-review.googlesource.com/c/1277574 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Bettina Dea authored
Existing PhishGuard warning flow is a 2 step warning: modal warning -> change password card on chrome://settings -> accounts.google.com Based on our data, users are more likely to change their passwords when they reach accounts.google.com. Thus, to boost action rates, this CL skips the settings page. In addition, this CL refines the text in the modal dialogs. Bug: 889936 Change-Id: I0322a4a13a3f285d7db1db7173645b7682765b51 Reviewed-on: https://chromium-review.googlesource.com/c/1263340Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#599309}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ae38f99451d..f9da224859f3 git log 3ae38f99451d..f9da224859f3 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 gmx@chromium.org elm: enable new tcmalloc Created with: gclient setdep -r src/third_party/chromite@f9da224859f3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie54ec4e14ec3dd8091cec3f144ea73394dcf1819 Reviewed-on: https://chromium-review.googlesource.com/c/1278202Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f8930395748..4bc3c99c2672 Created with: gclient setdep -r src-internal@4bc3c99c2672 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9b8838c505a99871954e99d9bbb35adf47507a1e Reviewed-on: https://chromium-review.googlesource.com/c/1278203Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599307}
-
Sahel Sharify authored
This cl has the following clean ups: -ShouldDiscardFlingCancelEvent is no longer needed in GEQ since the fling controller discards redundant GFC events. -fling_in_progress_ in GEQ was only used in ShouldDiscardFlingCancelEvent by removing the function it is not needed anymore. -FlingHasBeenHalted is removed since it was only in charge of resetting fling_in_progress_ which we don't need in GEQ anymore. -Instead of handling GFS/GFC events in ShouldForwardForBounceReduction and QueueAndForwardIfNecessary, DCHECKs are added to make sure that these events are filtered by the fling controller before reaching GEQ. Bug: 249063 Change-Id: Ibc46aa3a47cc1e1bc28abad7ebf68b432c68b4ef Reviewed-on: https://chromium-review.googlesource.com/c/1274827 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Instead of passing bare jarray pointers into the JNI array helper functions, pass in JavaRefs to avoid the caller having to use .obj() everywhere. TBR=asanka@chromium.org,sadrul@chromium.org,hubbe@chromium.org,carlosk@chromium.org,ctzsm@chromium.org,sdefresne@chromium.org,piman@chromium.org Bug: 519562 Test: base_unittests Change-Id: Ib01509aa73ada6adb2605011a8160b53cf957895 Reviewed-on: https://chromium-review.googlesource.com/c/1255702Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94f3ca931552..29b708e7af32 git log 94f3ca931552..29b708e7af32 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 thestig@chromium.org Mark the bigint target as XFA only. 2018-10-12 thestig@chromium.org Make PDF_DataDecode()'s buffer out parameter a std::unique_ptr. Created with: gclient setdep -r src/third_party/pdfium@29b708e7af32 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I770ea2845a105850d44065334d3532cca04ed8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1278947Reviewed-by:
-
Mike Wasserman authored
Replaces PointerWatcher with a more generalized EventObserver. EventObserver supports local code and remote window-service clients. Ash & remote client aura::Envs host their respective EventObservers. Ash notifies local observers via a pre-target event handler adapter. WindowTreeClients forwards requested event types to WindowTree. WindowTree notifies WindowTreeClients of input and observed events. Needed to support more existing ws client pre-target event handlers. Replaces the remaining ws mouse/touch->pointer event conversions. A followup CL will rebase views::EventMonitor on EventObserver: https://chromium-review.googlesource.com/c/chromium/src/+/1258217 Bug: 887725, 872450, 865781 Test: No --show-taps, immersive, touch edit handle, etc. changes. Change-Id: I5ed870a3be948bf48448ed1a5e54a2bf4512e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/1269806Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599303}
-
Josh Karlin authored
TBR=csharrison@chromium.org Change-Id: I4098f454fcd981536238f92c0ec43abf63d9a6ba Reviewed-on: https://chromium-review.googlesource.com/c/1207510Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599302}
-
Min Qin authored
DeviceService retrieves system SharedURLLoaderFactory on creation. If ServiceManagerContext is created before browser process, the SharedURLLoaderFactory cannot be accessed. This CL provides a wrapper for system SharedURLLoaderFactory, and pass it to DeviceService, so that it can be used later when network service is created. BUG=894167 Change-Id: Ibd7ed15399d247f7dc5b9eee99edf331b85ac04b Reviewed-on: https://chromium-review.googlesource.com/c/1274485Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599301}
-
Peter Boström authored
When kHighlightPath is in use the ink-drop effects are masked. As such we can use a flood-fill ripple and default highlight path that cover the entire view (that will be masked to the correct shape). This allows removing custom ink-drop ripples and significantly simplify highlights for toolbar-related buttons. This change makes use of these simpler inkdrops in for bookmark-bar buttons and menu buttons. Bug: chromium:888204 Change-Id: I32f21dde80783cdd262351596a4a4a504505e21c Reviewed-on: https://chromium-review.googlesource.com/c/1277268 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#599300}
-
danakj authored
RenderViewImpl clears the |webview_| in DidCloseWidget() which happens from RenderWidget::Close() which is a posted task from OnClose() which removes the IPC route to the RenderWidget. So no IPCs are received after OnClose(), and we don't need to worry about IPC handlers running after DidCloseWidget(). Also RenderViewImpl::SetScreenMetricsEmulationParametersForWidget() is called from RenderWidget::SetScreenMetricsEmulationParameters which is a delegate method for the RenderWidgetScreenMetricsEmulator. The emulator is created and destroyed, and updates parameters in response to IPCs, so it should not be calling to the RenderWidget after OnClose(). The LayerTreeView is destoyed in RenderWidget::Close() which comes after OnClose() so null checking for that in IPC handling code is not needed either. However it's possible the browser could not send the IPC to destroy the SetScreenMetricsEmulationParameters, at least theoretically, in which case it would try to set parameters when it was destroyed later, and that could crash. So we should be sure that we destroy the RenderWidgetScreenMetricsEmulator when we close the IPC route. It is already destroyed in RenderWidget::Close() /before/ we destroy the LayerTreeView or call DidCloseWidget() so working as intended. R=avi@chromium.org Change-Id: I52fa395af4ae7ba89eb4641f16b4a00fb77728fc Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1278854 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
David Bertoni authored
Bug: 805600 Change-Id: If740354ab8f664d4b89f722ec50d718fe94c71f2 Reviewed-on: https://chromium-review.googlesource.com/c/1274391Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#599298}
-
