- 06 Mar, 2019 40 commits
-
-
Leszek Swirski authored
The script streamer thread has now been replaced with posting tasks to the scheduler, so remove the flag picking between the two options and the dedicated streaming thread itself. Also, remove the streaming task re-posting now that the blocking/ non-blocking worker pools are merged. Bug: 874080 Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#638031}
-
François Beaufort authored
This CL makes sure ActivateContents() is implemented for Chrome App windows so that Back to Tab button in the Picture-in-Picture window focuses back the window. Bug: 938250 Change-Id: I4814c52553b8b938bff4005f032a3f83f2e54ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503255Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#638030}
-
Jia authored
This cl contains the following changes 1. ModellerImpl will become an observer of ModelConfigLoader. 2. ModellerImpl will receive some parameters from ModelConfigLoader: (i). global curve spec (ii). model_als_horizon_seconds 3. ModellerImpl will have "average_log_als" param removed. 4. An equality operator for ModelConfig. Bug: 881215 Change-Id: I17cc5f2962b57e70921591bd84d862658a82a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496412 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638029}
-
Gayane Petrosyan authored
Bug: 936830,931806 Change-Id: I056956df2c7831b15f84cda5969a42ba583fe319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501493Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#638028}
-
Gayane Petrosyan authored
Add default NTP font and make it platform specific by setting font on the document.body. Elements can further overwrite it if needed. Bug: 867759 Change-Id: Ia9332ce0f768474ba33e7b7948f7b4596d2e3271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490450 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#638027}
-
Tao Bai authored
This is for QA to test the feature. Bug: 924681 Change-Id: Ia9856b4970197fc9da4ae04fbb83528d5482247d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498382 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#638026}
-
Jinsuk Kim authored
This CL extends the present trusted_cdn.* to be a provider of the CDN publisher url for Java layer. Bug: 925242 Change-Id: I232b427cbc1a5ba66d6dcc6c9f0c64b2f314892d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493335 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#638025}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad22645bad55..eb748c338927 git log ad22645bad55..eb748c338927 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tikuta@google.com Merge "proto: deserialize build dependency" Created with: gclient setdep -r src/third_party/perfetto@eb748c338927 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I664ba2714ac4d0044ddc008e6d5720bb5af8bb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638024}
-
Yuki Shiino authored
Animate no longer needs to take a ScriptState, v8::Isolate is enough for its implementation. Change-Id: I8fed12dea5aa88309d6b8f26ace55ac4949b7717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503272Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#638023}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f5f6e3c40e44..dbdb7ae5c8ed Created with: gclient setdep -r src-internal@dbdb7ae5c8ed The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790708,chromium:790672 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I6f15f292fb2441a68aba25aafb6c51c29696c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504976Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638022}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9390154c557e..cc4a756d48e9 git log 9390154c557e..cc4a756d48e9 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 cepheus@frii.com Build: Update to latest SPIR-V header. Created with: gclient setdep -r src/third_party/glslang/src@cc4a756d48e9 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I262f1d1d32ae93ca5bc35be9bd2485d7600c97fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504974Reviewed-by:
-
Wenzhao Zang authored
Bug: 894270 Change-Id: Ibc35d9986fad4ec326806455389899959d280806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497539Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#638020}
-
Darren Shen authored
TBR=flackr@chromium.org NOTRY=true Bug: 938780 Change-Id: I7cdcb81b8801cfafd19a1e9a56616ba0b85e5ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504480Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638019}
-
Ian Kilpatrick authored
Previously the -webkit-line-clamp implementation didn't use the bottom edge of the line-box, instead using the bottom of any content inside it. While simple in the old layout engine, this adds complexity for the Firefox compat implementation, as well as an implementation on LayoutNG. Additionally Google front-end engineers are requesting we try and fix this issue. (see bug). The added test relies on the implementation of text-overflow to behave the same. Bug: 937931 Change-Id: I3cac20dc79e2487da59cd28ac453f900d4898f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495439 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#638018}
-
Christopher Thompson authored
The flag still had the old "HTTPBadPhase3" trial name, which was causing a DCHECK failure due to the conflict between the old field trial name and the new "HTTPReallyBadFinal" field trial name. Change-Id: I563ec74b1005aa360168d3ee918fdd3be5252d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500024Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638017}
-
Tim Song authored
Currently, when the uninstall dialog is opened from the Launcher, the Launcher is dismissed, which is confusing to the user. By parenting the dialog to the Launcher, the UX is much better. Because we cannot directly access Ash windows anymore, this fix requires us to explicitly set the dialog's parent window via MUS properties. TEST=manually verified + new browser tests BUG=814619 Change-Id: Ic25cb376191aaba8048f95fa5d0032b0328b8bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496447Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#638016}
-
Yue Li authored
If activity control consent has not been accepted, launch the Assistant opt-in flow instead of voice enrollment flow. Bug: None Test: Manual Test Change-Id: I3960715e17422b11c073942575c96557c2747112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500849Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#638015}
-
Pin-chih Lin authored
Some devices could not reach 30 FPS for 2160p (4K, UHD) h264/vp8 encoding. Since we want to gather FPS performance data from devices which have 4k encoding capability, we disable the check of FPS larger than kMinPerfFPS, and just a warning log instead. BUG=chromium:927277 TEST=video_encode_accelerator_unittest on Eve and Caroline Change-Id: I3ff3fac117a6423d5e5949e49920ec6f3428410e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503178 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Auto-Submit: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638014}
-
Alex Danilo authored
Quickview used an icon for the 'Open' action which is different to the 'Open' action in the main File Manager view. This CL changes the icon to the internationalized label for consistency. Bug: 762628 Change-Id: I059014dcead85028227b10a86ff75e2289d8046d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504596Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638013}
-
Darren Shen authored
Disabling: QuartcEndpointTest.ServerAcceptsOldVersion QuartcEndpointTest.ServerNegotiatesForOldVersion Culprit CL could not be reverted due to merge conflict, so disabling tests instead. TBR=vasilvv@chromium.org,rch@chromium.org NOTRY=true Bug: 938773 Change-Id: Id0c78e8d88519de1cfe62e2e5822e5b7db236f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504598Reviewed-by:
-
Alex Danilo authored
Selecting a file and then dragging the splitter to the left as far as possible causes the 'Cancel Selection' text to be cropped and the end replaced by an ellipsis. This change adds a tooltip so that hovering over the button will show it. Bug: 814273 Tests: Added test for this tooltip. Change-Id: I22465b933f562261c661add50bf336cf244fab81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502256Reviewed-by:
-
Gyuyoung Kim authored
Apply new review comments to the original CL more. This CL makes to use alternative ones instead of LocalFrame in the first argument of UseCounter::Count. Bug: 936187 Change-Id: I432a68708af7280c997fb5e2d61a7774eb8d2a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498735 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638010}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/network with the macros of Allocator. After some analyzes, it was concluded that for the case of ServerTimingHeader, EncodedFormData classes, they make sense to use USING_FAST_MALLOC because they have been used as a member variable with new() or smart pointers. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I01489ed3ccc1f4e2b61850d3ebfc930431c59290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504476Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb71e01e26d0..f5f6e3c40e44 Created with: gclient setdep -r src-internal@f5f6e3c40e44 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I01022ddbfc8972d3f7353f6760b0a8b12a03bdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504973Reviewed-by:
-
Kent Tamura authored
Add counters to investigate - if 'textarea' and 'searchfield-cancel-button' can be unexposed - if 'textfield' can be limit to textfield input types and temporal input types. Also, improve Menulist*ForOthersRendered counters. They should exclude input[type=color][list] and temporal input types on Android. Bug: 892586 Change-Id: Ic209f1d64be21a28f0f059ec8928e733368c8fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503173Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#638007}
-
Abhijeet Kandalkar authored
The primary motivation is that the function argument is not following the snake_case naming convention. As per current implementation function argument names in *probes_inl.h follow |paramFoo| naming convention. This CL modify build_param_name() in make_instrumenting_probes.py to rename function argument names to adopt |param_foo| naming convention. Bug: 936684 Change-Id: Idb63f1e6b78c98bb1830e74165b6cc69a8515a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503179Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#638006}
-
Alexey Baskakov authored
BookmarkAppHelper supports concurrent installs: many instances of BookmarkAppHelper can be created at call sites. Example: You can open 3 browser windows, initiate an install in each of them. And you see 3 modal dialogs to accept/dismiss. Bug: 915043 Change-Id: Ib7c1422bf341a43f4b45a82aa3204eb29c572369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498795Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638005}
-
Yann Dago authored
In the chrome://management page, the "Safe browsing" text that appears in the browser reporting section is now a link to the safe browsing page. Bug: 936558 Change-Id: I88cc056e19b1cde29ae62cbd7e450cfb5fc8c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492731 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638004}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I142d4e8a8d2a79e9236b0d3aaca73675b8be0b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504843Reviewed-by:
-
Christopher Lam authored
This CL fixes permission toggling which had an erroneous assert, and adds a regression test. Bug: 906508 Change-Id: Ie026ac246c48b19290da5784199c6a8d75c71e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502259 Auto-Submit: calamity <calamity@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638002}
-
Kunihiko Sakamoto authored
Before this patch, encodedBodySize [1] and decodedBodySize [2] fields of navigation / resource timing entry for Signed Exchanges were not populated. After this patch, these fields will have the sizes of Signed Exchange's inner response body, before and after decoding mi-sha256 encoding. [1] https://www.w3.org/TR/resource-timing-2/#dom-performanceresourcetiming-encodedbodysize [2] https://www.w3.org/TR/resource-timing-2/#dom-performanceresourcetiming-decodedbodysize Bug: 928589 Change-Id: I6b7800497e411822172dea4769ab8fc9d4955b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496261 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I7227a29e99627145b19288ab8e0615570a53a9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505114Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638000}
-
Eliot Courtney authored
It turns out PrepareForDrag calls into CaptureController via ScopedWindowResizer which inspects the gesture state. Transferring the events earlier avoids us from receiving gesture cancelled events. not moving anywhere. Bug: b/124026845 Test: Drag-to-move via touch of an Android PIP window works instead of Change-Id: Ib1a4bb5c09bff6d9529805e0a778c10f5dcaf852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498803 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#637999}
-
Victor Vasiliev authored
Refactor QuicFramer connection ID read code This CL refactors how we read connection IDs to allow future changes that will use different default lengths based on what is configured for this connection. Merge internal change: 236935043 https://chromium-review.googlesource.com/c/1504509/ Make a test involving connection IDs more future-proof Merge internal change: 236924820 https://chromium-review.googlesource.com/c/1504508/ Remove some fixed packet lengths. This CL moves us yet another step closer to being connection ID length agnostic in the lower layers such as the QuicFramer. More specifically, it replaces instances of PACKET_8BYTE_CONNECTION_ID with connection_id.length(). This is safe to use without flag protection because we have code in all connection ID entry points to ensure that their length is 8. Merge internal change: 236894613 https://chromium-review.googlesource.com/c/1504506/ R=rch@chromium.org Change-Id: I488160120ad125ff342e5983cba22946dc437183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504510 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637998}
-
Darren Shen authored
This reverts commit 108146f8. Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=938020#c6 Original change's description: > Fix flatbuffers_unittests failure-mode > > This is failing on Win7 Tests (dbg)(1): > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29?limit=200 > > Failures are causing python errors because the "failures" element must be a list. > The actual cause of the failure is not yet known. > > Bug: 938020 > Change-Id: I53742dbf49f97a8828af5675a0360e431ed376c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503614 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637839} TBR=dpranke@chromium.org,csharrison@chromium.org Change-Id: Iebb35ee8e42272f742497b25713d0927fb00ff14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 938020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504597Reviewed-by:
-
Matthew Braithwaite authored
This makes the blacklist behave identically to the |BlockedSPKIs| member of the CRLSet. Formerly, the blacklist had been applied after path building, which meant that the path builder did not have the opportunity to favor paths that did not include blacklisted certificates. If any such cases exist, this change might cause them to be newly accepted. It should not cause any certificate chains to be newly rejected. TBR=mmenke Change-Id: Idd6c4d5b5725497f951e749159cd58fd0413b444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497387 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637996}
-
Alan Cutter authored
This CL makes the PWA install plus icon animate in with an "Install" label once installability checks pass for a site. The frequency of this animation is not yet decided by UX and is subject to change. Screencast of animation: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382575&signed_aid=0ZIH354P-QQs-3Fnl4CVEg==&inline=1 This icon is hidden behind the --enable-features=DesktopPWAsOmniboxInstall flag. Bug: 907351 Change-Id: Ie74b037533a67f2c00ddd5689df4dbd98ece83cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502313 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637995}
-
Darren Shen authored
TBR=droger@chromium.org,lwchkg@chromium.org,msarda@chromium.org NOTRY=true Bug: 938707 Change-Id: I3b421e177f303135d633987d5429eaada474243a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504656Reviewed-by:
-
Jinsuk Kim authored
TabFavicon is Tab userdata that provides API for the active web contents' favicon. This was a part of Tab class but factored out into its own class. Bug: 877878, 925242 Change-Id: I49eba08918a2a86985f2b8aea5d4c7e15d666108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482434 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#637993}
-
Devlin Cronin authored
Update EmbeddedWorkerInstanceHost to use the blink::mojom::ConsoleMessageLevel enum, rather than an int32. This also percolates out to the ServiceWorkerVersion, ServiceWorkerContextCore, and ServiceWorkerContext observer classes, and the content::ConsoleMessage struct. Bug: None Change-Id: I1e392ae7ab5ca2ff679c30057d45817358d3bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501498 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
