- 01 Mar, 2019 40 commits
-
-
Sunny Sachanandani authored
Use selenium so that it's easy to run the script on different browsers such as Edge. As a result add support for fullscreen video by double clicking on the video element which works for common sites. Bug: 848093 Change-Id: Iacf0b7bca2c7a162643e2bb08deb8638b297c121 Reviewed-on: https://chromium-review.googlesource.com/c/1487452 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636686}
-
Yusuf Ozuysal authored
This moves away from a constant margin at top to read values from the fullscreen manager. This way we fix Duet+Grid and also leave any other users of TabList on their own to set the margins as needed. (The strip mode for example won't use any margins at all). BUG=934070 Change-Id: I810ced611eb0358757ed0f706f1c67a845b669f2 Reviewed-on: https://chromium-review.googlesource.com/c/1496436Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636685}
-
Nicholas Hollingum authored
Due to the way that the crostini terminal works, the shelf_id was being overwritten because it was: - On a technicality being "DidFinishNavigation"'d when it loads. - Assumed to be a browser window (because we run crosh in a window) - Failed to be associated with an extension (because crostini isn't) - Failed to be associated with an app app_id - Therefore: defaulted to the browser's shelf id. This fix catches the special case for crostini apps, which is to set the app_name of the browser on creation. We also propose a unit test to maintain this behaviour. Note that all of these measures are temporary, pending a better implementation of the crostini terminal. Bug: 839676 Change-Id: I46a43960cbc3820968fbb9872c142923d753039e Reviewed-on: https://chromium-review.googlesource.com/c/1491876Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#636684}
-
Aga Wronska authored
Define two PIN keyboard styles and update view layout accordingly: * Alphanumeric Keys display digit and a part of the alphabet below. This is the exact style of existing LoginPinView. * Numeric Keys only display digit, therefore keys height is different. This is the new style. Use Alphanumeric PIN style for login PIN input and Numeric PIN style for parent access code input. Bug: 911326 Test: LoginPinViewTest Change-Id: Id164d8580cd64db6891348b5de4638be52ab5c0d Reviewed-on: https://chromium-review.googlesource.com/c/1483675Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#636683}
-
chrome://flagsTim Song authored
BUG=921250 Change-Id: I09ebc0d4d3acc931d5d3ad28152f5040c83bfca6 Reviewed-on: https://chromium-review.googlesource.com/c/1492834 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#636682}
-
Rachel Wong authored
This is because we should retrieve the oldest requests from the end of the queue. Bug: 916420 Change-Id: I0232eb73d2c922297833a93adb22da39c91047e2 Reviewed-on: https://chromium-review.googlesource.com/c/1493339Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#636681}
-
Tao Bai authored
- Moves the session related code to TaskSession. - TaskSession categorizes the captured content and the detached nodes into DocumentSession. - ContentCaptureTask uses the DocumentSession to send the data though the LocalFrame's WebContentCaptureClient. Bug: 924681 Change-Id: I8cd5c96c1ab183e7a567a70fef813881c8b2ab4a Reviewed-on: https://chromium-review.googlesource.com/c/1493400Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#636680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe5a160336aa..5c212bf59cf6 Created with: gclient setdep -r src-internal@5c212bf59cf6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I624bcbc47c0c4660f22acf34d45afb1de4f05d6a Reviewed-on: https://chromium-review.googlesource.com/c/1495778Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636679}
-
Keishi Hattori authored
The code calculated the deltas with uint64_t, causing negative values to be reported incorrectly. This CL fixes the subtraction. And also clamps the samples to 1000 buckets (-500MB to 500MB). Bug: 917293 Change-Id: Ie2b48ddbf1a47577692c4c2013c7a9d365c786ea Reviewed-on: https://chromium-review.googlesource.com/c/1488475Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636678}
-
Christian Biesinger authored
R=eae@chromium.org Change-Id: Iedcf3f24205beea7a0de08f0544f745eb434404f Reviewed-on: https://chromium-review.googlesource.com/c/1496439 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#636677}
-
Dan Beam authored
Screenshots: https://imgur.com/a/EwqTzly R=hcarmona@chromium.org BUG=936524 Change-Id: I5ed3a43dc4273c1179eddca56a8138cf394c10a6 Reviewed-on: https://chromium-review.googlesource.com/c/1496246Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636676}
-
Fergus Dall authored
Currently, starting up crostini apps while switching profiles causes two issues. First, windows other then the terminal are owned by whichever profile is active when they become visible, not the profile that owns crostini. Second, if a window becomes visible while it's owning profile is inactive, then its icon will still be added to the shelf. On switching to the correct profile, the icon is added again. If the app is then closed, only one of these shelf entries is removed, causing crash if the other is used. As we don't currently support using crostini from non-primary profiles, this CL fixes the first issue by associating all crostini app windows with the primary profile, and prevents app icons from being added to the shelf unless the primary profile is active. Bug: 846213, 896996, 909590 Change-Id: Ibc888d22eb9567d822ce3e7d1af3603afb02a98e Reviewed-on: https://chromium-review.googlesource.com/c/1491873Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#636675}
-
Miyoung Shin authored
Add a PRESUBMIT check to ensure new |unsigned short| use don't come in. Bug: 929986 Change-Id: Ib4031362495ceedd94bc7e33fcbb913aea1e6ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1493642Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636674}
-
Stephen McGruer authored
Before this CL, we always treated endScrollOffset as inclusive, against the spec. The spec was recently updated to treat endScrollOffset as inclusive but only when it is equal to max-offset: https://github.com/WICG/scroll-animations/pull/37 Bug: 934989 Change-Id: I7cd9cf4619e804a54cef33ef8d3ec7395166bace Reviewed-on: https://chromium-review.googlesource.com/c/1483682 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636673}
-
Eric Karl authored
We've found visual corruption on this GPU / driver combination. Blacklisting very restrictively for now. If we find this issue in future drivers we can change the blacklist to >=. Bug: 890688 Change-Id: I996fb8b9c7f83230aa9cd0f5fd39038d3f686eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1496536 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636672}
-
Marijn Kruisselbrink authored
Bug: 937069 Change-Id: Ic00c4ea761b16c685ca200df03e0c856765d450f Reviewed-on: https://chromium-review.googlesource.com/c/1496276Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636671}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b2565b18d03e..906430d4b40c git log b2565b18d03e..906430d4b40c --date=short --no-merges --format='%ad %ae %s' 2019-02-28 csmartdalton@google.com Make GrMesh compatible with instanced draws that have no attribs 2019-02-28 reed@google.com Move responsibility to onMakeContext for device colorspace decision 2019-02-28 kjlubick@google.com [canvaskit] Add support for external fonts 2019-02-28 csmartdalton@google.com Revert "Drop unused shader support for sample variables" 2019-02-28 brianosman@google.com Particles: Removed emitters, added more full-featured position affectors 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c6eb41bebc27..a1924739029e (2 commits) 2019-02-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bc63cf9c511b..c6eb41bebc27 (3 commits) 2019-02-28 jvanverth@google.com Fix a couple of Mac windowing issues. 2019-02-28 bsalomon@google.com Remove support for SkDeferredDisplayListRecorder::DelayReleaseCallback::kNo. 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 201f136c9907..bc63cf9c511b (1 commits) 2019-02-28 thakis@chromium.org skia: Fix -Wextra-semi warnings in non-dcheck builds. 2019-02-28 michaelludwig@google.com Reland "Add general quad API to SkGpuDevice" 2019-02-28 brianosman@google.com Fix scaling error in SkLights::makeColorSpace 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 61d99852..1dc32aec (2053 commits) 2019-02-28 benjaminwagner@google.com Remove OS condition from isolate files 2019-02-28 kjlubick@google.com [canvaskit][pathkit] Remove flaky/low-utility Debug tests Created with: gclient setdep -r src/third_party/skia@906430d4b40c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926235 TBR=scroggo@chromium.org Change-Id: I2a0c17a6302d2c30f78292305307e689af7541d0 Reviewed-on: https://chromium-review.googlesource.com/c/1495896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636670}
-
Ryan Hansberry authored
Bug: 935683 Change-Id: Ie8c77f6a896810eb8e04032857570dd449dce02e Reviewed-on: https://chromium-review.googlesource.com/c/1490952Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#636669}
-
Kelvin Jiang authored
Summary of changes: - Move the clear activities button under the history/stream tabs - Add extension name and icon to activity log page - Add headings above activity log items Refactoring of styles may be done in a follow up CL Screenshots included in: https://bugs.chromium.org/p/chromium/issues/detail?id=932768#c5 Bug: 932768 Change-Id: I249cee13e1b5c7e4bd319b5b788a0c05718ba8da Reviewed-on: https://chromium-review.googlesource.com/c/1483738Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#636668}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96fc7ac1..16c76cb9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie7c9ac6c88ad2abc84a83c97f8666563c79bc8b1 Reviewed-on: https://chromium-review.googlesource.com/c/1496247Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636667}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I2e90056db5b017b34eeba901904371854bd41ff4 Reviewed-on: https://chromium-review.googlesource.com/c/1496241Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#636666}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5117888302cf..a6d41e2396bd git log 5117888302cf..a6d41e2396bd --date=short --no-merges --format='%ad %ae %s' 2019-03-01 vadimsh@chromium.org [cipd] Update to 2.2.18. Created with: gclient setdep -r src/third_party/depot_tools@a6d41e2396bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936911 TBR=agable@chromium.org Change-Id: Ib0ef96a5be975415f0ced01df4bae638f4d815d9 Reviewed-on: https://chromium-review.googlesource.com/c/1496161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636665}
-
Charlie Andrews authored
The story is already disabled on other version of system health and is causing the shard to hang indefinitely. NOTRY=true TBR=crouleau@chromium.org CC=perezju@chromium.org Bug: 934270 Change-Id: Ia5b6328fa1311009cb8da0c6267a3585df5ad46b Reviewed-on: https://chromium-review.googlesource.com/c/1496540Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#636664}
-
Karan Bhatia authored
RulesetMatcher is a class in the extensions layer but it is unit-tested at the chrome layer. Fix this by moving the tests to the extensions layer by removing dependencies to chrome's extension loading code. This also means we don't check the extension loading in these tests, but that is taken care of in the browser tests. BUG=930961 Change-Id: Ic971bce981a65cda8928a8e3d9e3b49f960b4aef Reviewed-on: https://chromium-review.googlesource.com/c/1496314Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636663}
-
Robert Liao authored
This is a mechanical execution of tools/git/mass-rename.py. BUG=937018 Change-Id: Idf6f45d4507106e17137c577496e909b3aafc765 Reviewed-on: https://chromium-review.googlesource.com/c/1496234Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636662}
-
Julie Jeongeun Kim authored
This CL moves web_feature.mojom in public/platform to public/mojom/web_feature and updates paths for web_feature.mojom. It also moves PRESUBMIT.py for web_feature.mojom to public/mojom/web_feature. Bug: 919393 Change-Id: I1d22645fdd081a81bf18a85511d208c2e7b0bf7a Reviewed-on: https://chromium-review.googlesource.com/c/1488487 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#636661}
-
Yutaka Hirano authored
Remove FetchContext::DidLoadResource and move the operations in it to DispatchDidFinishLoading and DispatchDidFail. This leads to code duplication but I think this change is overall a good change because: - DidLoadResource is called only twice. Repeating yourself twice is not that bad. - DidLoadResource is confusing; Whether that precedes or succeeds DispatchDidFinishLoading, whether it should be called in DispatchDidFail, etc. Previously FetchContext::DispatchDidFinishLoading and DispatchDidFail were called before Resource::Finish, but now they are called after Resource::Finish. That affected a few devtools tests because some tests finished as soon as resource loading finishes and some error messages got missing with the new semantics. This CL delays test completion a bit in order to keep the expectations. Bug: 914739 Change-Id: I5245dca240ebc7496d1de51909d458a6ed5a61d2 Reviewed-on: https://chromium-review.googlesource.com/c/1474887 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#636660}
-
Gyuyoung Kim authored
According to the plan to replace |const LocalFrame*| arguement with |const Document&|, |ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document&) in frame directory. Bug: 936187 Change-Id: I41f03b9908258881d4a1d932defb7e42e2deae9a Reviewed-on: https://chromium-review.googlesource.com/c/1491060Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#636659}
-
Anne Lim authored
Adds and removes strikes under the following conditions: User closes LocalCardMigrationDialog: Add 3 strikes User closes LocalCardMigrationBubble: Add 2 strikes User adds new local card: Remove up to 2 strikes (keep strike count > 0) User de-selected some local cards during migration: Add 3 strikes And don't offer local card migration if strike limit has been reached. Bug: 884817 Change-Id: I9853e2b5d1a1692fd47650aa6598f4d6df27a27c Reviewed-on: https://chromium-review.googlesource.com/c/1474689Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#636658}
-
Jarryd authored
The Finch configs for the Quota Expansion experiment were updated to use groups that better suited our experiment. This change rectifies the disconnect between the field trial testing config which is a prequisite to moving an experiment into the beta channel. Change-Id: I469ff653bac1a6634c762a7c49ac6e75bb7ce7ea Reviewed-on: https://chromium-review.googlesource.com/c/1492672 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#636657}
-
chrome://policyYann Dago authored
Bug: 930708 Change-Id: I0848524c1d637bd83cf40ddf2ac0402033ee1d5c Reviewed-on: https://chromium-review.googlesource.com/c/1484496 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636656}
-
Kurt Horimoto authored
This CL updates DialogPresenterDelegate's dialogPresenterDelegateIsPresenting property to follow delegate naming guidelines. Additionally, rather than storing this value as a property, this CL updates the implementation to calculate on the fly whether BVC or any of its children are modally presenting a UIViewController. Bug: 893660 TEST: Follow repro steps in c#0 on crbug.com/893660 Change-Id: Id75e4e72bac6365d47caed11317c8a6a11a08dbc Reviewed-on: https://chromium-review.googlesource.com/c/1492364 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#636655}
-
David Bokan authored
Reland #2 Note: { Previously (re-)landed: https://crrev.com/b37e23cbd52ba447ab89c6d18f4ea0ecdc3fa5c0 Reverted: https://crrev.com/a9aa35a2fb904074cddb4e2d889217a899177721 More leaky tests. Though we now resolve gesture callbacks at the end of the test, the callback may come in after the test. This re-land fixes the leaky tests by finishing the test only once the gesture is completed. Previously landed CL uploaded as PS1, fixed in PS2. NOTE TO SHERIFF: If this is causing issues on the leak bots, please ping me or disble the test rather than reverting, if possible. } This CL makes synthetic input - the kind used in web tests and telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame has been submitted by the renderer and displayed by the display compositor before resolving the completion callback. This means client code that wants to wait until any observable side-effects of this input is visible to further input need only wait on the gesture's completion callback. To give a motivating example: suppose we wish to write a test that scrolls an out-of-process iframe into view and clicks on a button in the frame. The code might look something like this: gpuBenchmarking.smoothScroll(1000, () => { gpuBenchmarking.tap(0, 0); }); This code contains a race today. The callback for smoothScroll is invoked as soon as the ScrollEnd is received in the renderer. However, until a new compositor frame is submitted from the renderer, the tap may occur against stale hit testing geometry. This is a major source of flakiness in our tests. This CL fixes the problem by forcing the renderer to perform a full redraw at the end of each gesture. The redraw produces a compositor frame and we invoke the callback once the compositor frame is displayed. We do this by reusing the RequestPresentation mechanism in RenderWidget. RequestPresentation required two modifications to work in web tests which use a single thread proxy with no scheduler: - LayerTreeHost::Composite needs to check the forced redraw flag to determine whether we need to raster, otherwise it won't produce a frame - RequestPresentation must request a main frame since there's no scheduler to perform the commit, which is what SetNeedsForcedRedraw requests. The timing change exposed an issue in the overlay-play-button-tap-to-hide.html test so this CL also cleans that test up to listen to the animation changes in media controls properly. Finally, it's possible we may get input in a RenderWidget that's not currently displayed. e.g. A click event sent via ChromeDriver causes a TouchStart followed by a TouchEnd. The TouchStart causes a window.open which opens and focuses a new tab. The TouchEnd then happens on the background tab. In this case, we should resolve the callback rather than waiting on a CompositorFrame that'll never come. See ChromeDriver test testNetworkConnectionTypeIsAppliedToAllTabs for an example of this. TBR=dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org,peter@chromium.org Bug: 902446 Change-Id: I0f818168b3f36070f72369a072e7f5eac64eb77c Reviewed-on: https://chromium-review.googlesource.com/c/1496244 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636654}
-
Dana Fried authored
Logic for max size is now consistent with animation/dragging. Animation correctly plays if drag does not end at exact size. This is not a complete fix for extensions dragging. Bug: 916209 Change-Id: Iccb0d11bbe540a16edec0720105d272e091cf43d Reviewed-on: https://chromium-review.googlesource.com/c/1492049 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#636653}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a365aff3ed0b..fe5a160336aa Created with: gclient setdep -r src-internal@fe5a160336aa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2487c44442221abbe2e4e57a4aeade55f71e8bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1495960Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636652}
-
Shelley Vohr authored
Prior to macOS 10.13.2, the only way to check for TouchID was to check for the ability to evaluate the LAPolicyDeviceOwnerAuthenticationWithBiometrics policy. 10.13.2 introduced a more granular check for LABiometryTypeTouchID. This PR ensures on systems after macOS 10.13.2 that we check for this specific biometry, and fall back to to the old check if we do not have access to this new enum. R=martinkr@google.com Bug: N/A Change-Id: I3a3d2d332547b09cf3c6e062709ed06b6e1a052d Reviewed-on: https://chromium-review.googlesource.com/c/1487811Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#636651}
-
Tommy Martino authored
Per UX request, increasing the dropdown min-width. Bug: 936914 Change-Id: I7a8f12ad9489337d65d369502ce0bb0bdedfcf7c Reviewed-on: https://chromium-review.googlesource.com/c/1495040 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#636650}
-
Dan Beam authored
Screenshots: https://imgur.com/a/juHC3Fz R=dpapad@chromium.org BUG=936977 Change-Id: Ibef2af96df3599b79d3c94e979f8039a2cea42f0 Reviewed-on: https://chromium-review.googlesource.com/c/1496295 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636649}
-
Keishi Hattori authored
Adds a crash key so we can identify oom intervention related crashes. Bug: None Change-Id: I96722ec0af4362aa42536d119f92c06084cd9012 Reviewed-on: https://chromium-review.googlesource.com/c/1484396 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#636648}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 932fdb31. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" a6d9cfda "[WPT] Changes to generated files by CL 1476144" 4665f96b "RestrictDeviceSensorEventsToSecureContexts by default." 03505df6 "[Origin Policy] Implement error reporting via Reporting API" 2c455f7b "Move outputContext from XRSession to XRRenderState" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I4657b21944de6dfc1a0f35c8aa408e0dc4684260 Reviewed-on: https://chromium-review.googlesource.com/c/1495746Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636647}
-