- 08 Jan, 2021 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d379d2f..ff24c712 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab1cb0cb4fe365e6a0d0f7062369bee5f06ec0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617211Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841402}
-
Archie Pusaka authored
This adds the following histrograms: * BlueZ.AdvertisementMonitor.NumOfMonitors * BlueZ.AdvertisementMonitor.<SW|MSFT>.FilterPatternsPerMinute * BlueZ.AdvertisementMonitor.<SW|MSFT>.<Add|Remove>.Result Corresponding BlueZ metrics implementation can be found at: go/croscl/2565089 Bug: b/169584341 Test: Verify BlueZ.AdvertisementMonitor* on chrome://histograms Change-Id: Ibab7145580b3ddd3369ee83940090ae0f8052dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596585Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#841401}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cdb3bc3b93da..4681cecb4151 2021-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aff08690..82fccc55 (841210:841356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I87582f19171db11bd20e19b9b62af9af2c3af3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841400}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610063718-47f197c900d6e73c3c9b6aad05d4a947c6371a56.profdata to chrome-win32-master-1610074312-912225aaa44122e4b1a4b8a45da36dc4daa402b9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibf5ae1a87fb8f495943820d329c48a527ef2cb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617638Reviewed-by:
-
Fergal Daly authored
This was happening in https://crbug.com/1146573 and could happen if a WebContentsObserver triggers synchronous navigation in response to a the RenderFrameDeleted call. This adds a RenderFrameState::kDeleting that is only used during RenderFrameDeleted. Bug: 1146573,1163815 Change-Id: I6f3ff264d5788135a79d90a1dba0e7e6a16adad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599568 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841398}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610063718-6db51055255b71b3272f9db93116d992601c9633.profdata to chrome-win64-master-1610074312-1e61cca385dcdccbd239aae3d699d6888b006a9e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia255d529decf71b09d9f5351324c12c7abf0f0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617640Reviewed-by:
-
Jan Krcal authored
This CL changes ProfilePickerView to use it's custom widget class instead of the default one provided by DialogDelegate. This allows to define a theme provider for the widget, based on a profile that (sometimes) gets created throughout profile creation flow. This is a preparatory CL for later CLs (such as CL 2569752) that will add native views into the hierarchy that actually rely on the theme provider. Bug: 1126913 Change-Id: Ifed3f645a4c60035ced4b7562ab21f5d4d5b840a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608206Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841396}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4380.0-r1 to 89-4367.0-1609757097-benchmark-89.0.4381.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If7e0d5a8cab2d2a524d5eab76dcd5101818eb300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616753Reviewed-by:
-
Eric Willigers authored
Avoids Step "compile confirm no-op" failing on builder "win32-archive-rel" from https://chromium-review.googlesource.com/c/chromium/src/+/2615664 Bug: 1144920,1164175 Change-Id: Ib8c8d3ac5869547d82cfd89740b1f057affccb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615729Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d39c0ebe595d..48240126b9fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Ib03e71c29c46e2af76dde77bbb5cd8fe043eb2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841393}
-
Aleks Totic authored
Autosizer was being called twice, which made some tests fail. 1st call was inside ComputeTableInlineSize, 2nd call was in Layout. Removed call in Layout, and now all autosizing tests look good. I do not understand autosizing code very well. My guess is that running autosizer twice in the same layout leads to bad things, because it tries to size already sized layout object, and ends up with a wrong multiplier. Without this, fast/text-autosizing/tables/table-cell-inflation.html fails. Change-Id: I5deba326d6f3b1b178f994a7bb03bef67ccc2cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616750Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841392}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4380.0-r1 to 89-4367.0-1609764762-benchmark-89.0.4381.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie8594068b7d7d13277f094559c76a6a7ebd33f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617645Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9a91aed82e95ca5bfdbc6cc93bc8fe70aaf2fe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616855Reviewed-by:
-
Hayato Ito authored
Enable CORB protection for subresource loading in WebBundle. WebBundle design doc is here. https://docs.google.com/document/d/1_AqUBS4Gr45MPPtXGTUl7Q0DMIEw2zUeWO0zo6Sj0z4/edit#heading=h.pi5jgk8nqwh4 This implementation uses CrossOriginReadBlocking::ResponseAnalyzer to decide whether to block resources or not, as network::URLLoader does. Bug: 1082020,1149258 Change-Id: I6aa53db5fc0839e8a74bf834da2d26a017d2e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585250Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#841389}
-
Jan Krcal authored
This CL creates a new variant for the chrome://sync-confirmation page that fits to the design of the new profile creation flow. This will eventually become the default design. Screenshot: https://screenshot.googleplex.com/9KbMGdLDnF8N3P8 Bug: 1126913 Change-Id: Idecc93d92985fd5c2275fcbeecb2792eea322e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583902Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4ea30580c91..f7ce1cd243f2 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7b2f93895418 to 937395c1ed5d (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Icee62362da54a6d6ff044985606fe11e20a7b38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616854Reviewed-by:
-
Bao-Duy Tran authored
This first batch of metrics are similar to existing metrics for PK Assistive Autocorrect but adapted to scope to CrOS 1P experimental multilingual input methods. Other metrics to be added in follow-ups. Bug: 1159297 Change-Id: I4684d7b8bdbae570e428e08b79de4eb642a3945e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596484Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841386}
-
Joel Hockey authored
Python3 does automatic utf-8 decode/encode when reading/writing files and it throws an exception when reading binary files in normal 'r' mode. When we detect such an error, we will read and write the file as binary 'rb' / 'wb' without doing any text substitutions. The script is tested locally and works for python2 and python3 Bug: 1163386 Change-Id: I46f53dcafbdb43a367e5418bab84cf7a0ebd84a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617408 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841385}
-
Daniel Cheng authored
The intent appears to be to execute script in an isolated world in the child frame's context. However, the iframe completion callback's global scope is the main frame's global, not the child frame's global. The test worked anyway, because window.parent simply points to window in the main frame. Change-Id: I24915e06ef1dd67cbf4a2de33018da979f39fb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617135Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841384}
-
Alan Cutter authored
This is a reland of 7aca7756 The original was reverted due to test flakiness. We weren't waiting for the Extensions toolbar to appear after test Extension installation before testing its visibility. Diff of additions to the original: https://chromium-review.googlesource.com/c/chromium/src/+/2602305/1..2 Original change's description: > desktop-pwas: Add "Extensions" menu item to web app windows > > This CL: > - Hides the Extensions icon in web app windows unless the Extensions > menu is opened. > - Adds an "Extensions" menu item to the web app three dot menu to > open the Extensions menu. > > This change is behind the DesktopPWAsElideExtensionsMenu flag. > > Minor change in behaviour to browser window extension menu > (regardless of flag state): When the last extension is removed the > container will wait for its layout animation to complete before hiding > itself. > > Before: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=480233&signed_aid=3saz6ZsTFVwVy1W5EoAbXQ==&inline=1 > > After: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=481189&signed_aid=tZhlRb6XLB8XimALjMCn6g==&inline=1 > > Bug: 1155421 > Change-Id: I80d5b382610895021c2cdf861d253edbdabe8630 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573897 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838031} Bug: 1155421 Change-Id: I4c0c3f90c78c0dd4e1f582a4f36a462bbb6f05fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602305 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#841383}
-
Angela Gyi authored
This CL adds a single file title preview for share sheet feature on Chrome OS devices. Note: This feature is not in its final form and is still open to extension Bug: 1157628 Change-Id: I44acc5a0c3fc231e66f1a77b77542d39931bb772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584632 Commit-Queue: Angela Gyi <angelagyi@google.com> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841382}
-
Sergei Glazunov authored
If the MiraclePtr PA extras are enabled, Alloc() returns a pointer past the end of a slot for zero-sized allocations, which leads to problems when a function needs to determine the slot from a given pointer. Adjust the requested allocation size to avoid that. Bug: 1162769 Change-Id: I7c398a99a257f443ef704b87ac188acef0bcc5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613974 Auto-Submit: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Daniel Cheng authored
This is a reland of d24a515a, which triggered false positives in the Blink leak detector. Now that isolated worlds are correctly reinitialized after a navigation, they remains live as long as the associated browsing context is live, persisting across navigations. At the end of the test, the leak detector navigates to an empty page and performs a comparison of live objects against the captured baseline, causing leak detection to incorrectly report the isolated world contexts as leaked. To address this, the web test harness now also disposes any isolated worlds created for a test when resetting the state at the end. Original change's description: > Reinitialize isolated world window proxies on navigation if needed. > > When a window proxy is initialized for a child frame, it must be > reinitialized on every subsequent navigation to correctly hook up the > window proxy (which may have cached JS references). > > Previously, this was only happening for the main world window proxy. One > visible side effect is that if an extension cached a window proxy > reference to a frame that was then navigated, the cached reference would > not work until something else forced the window proxy to be > reinitialized. > > Fixing this has an unintended side effect in an inspector protocol test > which logs context creation: since isolated world window proxies are > reinitialized in an arbitrary order (specifically, HashMap iteration > order), the expected results become arbitrary as well. Instead of hoping > that iteration order remains consistent, update the test to only log the > context creation events it actually cares about. > > Change-Id: I11d7e13f7c2810d1c662ccf40f37c880e5026db5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607680 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840983} Change-Id: I77c62a790566815a6e5287bdb465b374c0210bee Bug: 1163893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616238Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841380}
-
Hirokazu Honda authored
This CL enables AV1Decoder feature during VaapiUnittest so that it can confirm av1 decode capability. Bug: b:175895251 Test: vaapi_unittest on volteer Change-Id: Id2aa79a1e02c19c337e946306c984f6018d159e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612549 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#841379}
-
Leonid Baraz authored
Signature is now mandatory in client when encryption is enabled. Bug: b:170054326 Change-Id: I1b884b5b39d326446c24794c10cab1ced443312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615662 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#841378}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b43fbe8a06ea..87d362bb2c4d 2021-01-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6ebbaeb1a2b6897fecff15d2994e689ad6a4a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616851Reviewed-by:
-
Chris Cunningham authored
API and motivations described here: https://github.com/WICG/web-codecs/issues/98 Spec PR here: https://github.com/WICG/web-codecs/pull/120 Bug: 1141707 Test: new layout tests Change-Id: I3e53da5961119b4b36ec76666ad1a67cca19b963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612684 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#841376}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610052964-a33bb7f09ef1aa4be028cda8573fe902d004ec4a.profdata to chrome-win64-master-1610063718-6db51055255b71b3272f9db93116d992601c9633.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7524bcb489a28cfe1ccaa73831cba89c21f75af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616967Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e33046d8bd5..d39c0ebe595d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Iea0f21cf0c2a83655158fc2d9c4bb1a92ca7b542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617300Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d87c3006..4d379d2f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If4d7bfc57f594f566966b444af8f9ab608ac7e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617137Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610052964-246b43420c64aac53ecf14d1b97c19dc58b69e86.profdata to chrome-win32-master-1610063718-47f197c900d6e73c3c9b6aad05d4a947c6371a56.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98e97b361e99104ccca27e3bbaf8ee50c7c4c7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616923Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibc7bab91b96364e35308205bcd6abbe8babb1224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616920Reviewed-by:
-
Bartek Nowierski authored
My crrev.com/c/2601894 broke the code, because it stopped reserving memory for PCScan on 32-bit, without realizing that PCScan still runs in Blink on 32-bit. The problem occurs only if PCScanBlinkPartitions experiment is on. Bug: 11297512, 1163824 Change-Id: I3a116d3b33ea3f83db1e413d3ae12005a07980a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617402 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I09c4298cbbeca724dde94b2e01df9177cd5e79b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617538Reviewed-by:
-
Alan Screen authored
This reverts commit ef8825ff. Reason for revert: A reliable method for reproducing this behavior has been identified in b/176864633. Remove this induced crash to reduce the impact being caused to a larger number of users while we work on moving forward with a proper fix to the underlying issue. Original change's description: > Turn a DCHECK() into a CHECK() in WebLocalFrameImpl. > > Turn |blink::WebLocalFrameImpl::is_in_printing_| from a variable only > used for DCHECKs into one that is always CHECKed. Do this to help debug > a printing crash that happens to users but not with any printing tests. > > Bug: 1121077 > Change-Id: Ieac894c4efdb67f028de13fc2a4bf5ed3a84c258 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373217 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801268} TBR=tkent@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121077 Change-Id: I551fbc8229eea16d6a5cd95bf9306a6a0e0a9f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616878Reviewed-by:
Alan Screen <awscreen@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841368}
-
Dale Curtis authored
R=chcunningham Fixed: 1164070 Change-Id: Ib3227d36de787bca195cffdb500f3688b3209cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616999 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#841367}
-
Etienne Bergeron authored
On windows, the Timezone modifications is detected by listening to WM_TIMECHANGE event but that event is emitted for any time property change. We are observing in slow-reports that on power suspend/resume that event is always sent (one or more time) which is triggering multiple Timezone notification to be sent to observers (a.k.a renderers). The proposed solution is to filter the time change by ensuring the platform specific timezone has changed. We do not rely on ICU timezone API since it's heavy to be added on the startup path. The goal is to detect platform changes to filter out the time change events. R=gab@chromium.org,fdoray@chromium.org,mark@chromium.org Bug: 1074036 Change-Id: I296e0735a04d6258a659688a987c58399d4c7ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583012 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#841366}
-
Tal Pressman authored
Change-Id: I28900d4ca5da0d1683828fb82fdb12e88386a1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617478 Commit-Queue: Tal Pressman <talp@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@google.com> Reviewed-by:
-
Luciano Pacheco authored
Manually checked that there were no JS errors in the background page. Test: browser_tests --gtest_filter="*FilesAppBrowserTest.*" Bug: 1133186 Change-Id: I71790b232204d09424ee7b7383ebad6e4bbaf596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612677Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841364}
-
Ken Rockot authored
This was fixed for StorageAreaImpl usage in the Local Storage implementation, but Session Storage was overlooked. It turns out that Session Storage namespaces also own StorageAreaImpl objects, and these too can outlive their backing database. This ensures that the map of namespaces is cleared before SessionStorageImpl resets its database, avoiding the UAF. Bug: 1152800 Change-Id: I946841b20fa73754e8b8ac611b352db0319ce4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617239 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841363}
-
