- 24 Feb, 2020 40 commits
-
-
Ben Pastene authored
This reverts commit fafef524. Reason for revert: Should be enough space now after crrev.com/c/2065419 Original change's description: > Temporarily remove net_unittests from chromeos-amd64-generic-rel. > > To unblock LKGM rolls. Will still run on the betty bot in the meantime. > > Bug: 1053547 > Change-Id: Ifb2ffc7f06a6183265209d5e06c63a16215b1316 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065414 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742909} TBR=stevenjb@chromium.org,bpastene@chromium.org,malaykeshav@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1053547 Change-Id: I5892a41f300425b1dd97730bad2fee72d8279870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067615Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#744000}
-
Tom Anderson authored
When I initiailly created this hack in [1], the intention was to always use fcntl() over fcntl64(), however the hack was written to invert the _FILE_OFFSET_BITS=64, but not when it's set to a value like 32, as is the case in some projects. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1862623 BUG=b/147463741 R=thakis Change-Id: I4e9b58dbe45888573fa5789ca487e8ed87d8c99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070025Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743999}
-
Clark DuVall authored
This will make it easier to move these into //components/permissions. Bug: 1025609 Change-Id: Ic0745279a303c447beac0c3072dd59e494a15d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065620 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#743998}
-
Andrew Grieve authored
Doing so is a bit surprising, and makes local development not match what users see. Bug: 1027123 Change-Id: I5f05de15b75c0ba0bf5d022ae9be50405415df99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069544 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743997}
-
kylechar authored
There are four tests that are flaky on the Win10 FYI x64 SkiaRenderer GL (NVIDIA) bot. The failures might be related to running the test on a real GPU so just mark them as flaky for now. Bug: 1026375 Change-Id: I825873b70f4ad7a2cffcfa75a30da635c144b248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070101Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#743996}
-
Andrey Kosyakov authored
This reverts commit 52dbe8bb. Reason for revert: that broke navigation to facebook.com, see bug for details. BUG=1055450 Original change's description: > Move WebInsecureRequestPolicy values to mojom > > This CL is a precursor to converting > FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom. > It moves WebInsecureRequestPolicy values to mojom to use the values > in content and blink and removes WebInsecureRequestPolicy. > > Bug: 1047284 > Change-Id: If030952dbd0c9e98bb0c4a11479ea175ade91fc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045293 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743880} TBR=kinuko@chromium.org,haraken@chromium.org,dtapuska@chromium.org,jkim@igalia.com Change-Id: I6885d524a41b21fbdb0066b2cc2513408fe15943 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070109Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#743995}
-
James Cook authored
Right now it opens OS settings, which has the same set of sync options as browser settings. Soon the OS sync settings page will be different, and we want to send users to the browser settings page either way. This also helps if a user checks both "Review sync options" and "Review Google Play options" during OOBE. They will see two windows, OS settings and browser settings. Making syncSetup a browser settings, rather than OS settings, subpage requires changing ARC++ URL handling in ChromeNewWindowClient for mojo enum ChromePage::SYNCSETUP. I think this is OK, because it's closer to the original ARC++ behavior before split settings, and also I can find no usage of the SYNCSETUP code path in the ARC++ code (or anywhere else in google3). This CL is a partial revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1977139 Bug: 1054980, 901184 Change-Id: Ide777363aa83e9a7b0f87068c318bd1f274c7e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068948Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#743994}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f1834b06ad1..207c622c1ef0 Created with: gclient setdep -r src-internal@207c622c1ef0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8f6c81898d87d0d4080fb0a4b1d4cd264c69acd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070430Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743993}
-
Yi Xu authored
Both UMA metrics Canvas.Repaint.Bounds.Percentage and Canvas.Repaint.Region.Percentage will be expired in the upcoming version. Since the partial update study is not finished, extend the expiry date to M84. Bug: 1014246 Change-Id: I3ea893a04702382ed7897ae7660541e5eeeef153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067812Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#743992}
-
Andrey Kosyakov authored
This reverts commit 99fe56da. Reason for revert: depends on https://chromium-review.googlesource.com/c/chromium/src/+/2045293 that broke navigation to facebook.com, see bug for details. BUG=1055450 Original change's description: > Convert FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom > > This CL converts FrameMsg_EnforceInsecureRequestPolicy to method on > blink RemoteFrame mojom. It also updates the unit test with > intercepting RemoteFrame and removes checking the IPC message. > > BUG=1047284 > > Change-Id: I9578c49cfcc08b3a682ec2899627dc6503965654 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038513 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#743924} TBR=kinuko@chromium.org,haraken@chromium.org,dtapuska@chromium.org,jkim@igalia.com Change-Id: I39e9cdaa9e63df07cfdca5105a1933ef3c6a860d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068683Reviewed-by:
-
Lukasz Anforowicz authored
After this CL renderer crashes won't be allowed after RenderProcessHostWatcher::Wait returns. Note that even before this CL, RenderProcessHostWatcher could only be used once (i.e. for one process exit). In particular, |std::move(quit_closure_).Run()| would have hit a DCHECK when run a second time. Fixed: 1052257 Change-Id: Id1cbd9f59de57d5fe51131a5c7ac5ee14302d0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068950 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743990}
-
Xida Chen authored
In the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2037836 We deprecated throughput UKM and created a new UKM called PercentDroppedFrames. But we forgot to update the UKM reporting for the new UKM. This CL fixes it. With the fix, I can see UKM being reported locally. Bug: 1048780 Change-Id: Iece951a7be3b5731413fd1aa86569691ba8128a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062752Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743989}
-
Patrick Monette authored
This CL also changes the SharedWorkerService::Observer interface so that SharedWorkerId replaces SharedWorkerInstance to uniquely identify shared workers outside of content/. The motivation behind this change is to make it cheaper to use the shared worker identifier as a key into a map, since copying a SharedWorkerInstance is quite expensive. Bug: 1054596 Change-Id: I7270d9e5fabac2d2e00aecd407a745a1cc779791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067389 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#743988}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/db63601344ca..3bde4517dec7 git log db63601344ca..3bde4517dec7 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 ilkos@google.com Substring matcher for focus mode Created with: gclient setdep -r src/third_party/perfetto@3bde4517dec7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:149833691 Tbr: perfetto-bugs@google.com Change-Id: Iee9017c048ccc40d25544a5c2c1dae4ec7b754d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743987}
-
David Black authored
The team working on Assistant/Quick Answers will now also watch: - Assistant files in ambient/ui. - Quick answers directories. Bug: None Change-Id: I732e4e9f2bfdf1fea5d23d48b604c46099ac09ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068932Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#743986}
-
Bo Liu authored
Several attempts at de-flaking this test on the L bots did not help. The flake cannot be reproduced locally using the same device and OS. L coverage is not super important and the bot is not on CQ. So just disable it on L. This also reverts the last de-flake attempt: https://chromium-review.googlesource.com/c/chromium/src/+/2063539 Bug: 1035894 Change-Id: I850b96360c08a0d7029729a4a08f7c51efa22b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068783Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743985}
-
Reilly Grant authored
This reverts commit 22b25dd3. Reason for revert: NFC settings crash on Android L and M. (crbug/1055216) Original change's description: > [WebNFC] Enable feature flag by default for Origin Trial > > For the WebNFC Origin Trial the feature flag needs to be enabled by > default and configured as "disable only" in runtime_features.cc so that > it can still be used as a kill switch but will not enable the feature > on sites which don't have a valid Origin Trial token. > > Bug: 1035048 > Change-Id: I139a79dd0f93013bc59d5023017b49c820532fb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052198 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743309} TBR=creis@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035048, 1055216 Change-Id: I6617ee1b2bc6b3d1fb719d0454d4f8f4735bd44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070106Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743984}
-
Ben Pastene authored
test_env.py isn't compatible with python3 due to dict.iteritem() calls, and perhaps more. Consequently, when running the script via the shebang on an environment that defaults to python3, the script will fail. This fixes that by explicitly setting invocations of `./test_env.py` to use the system's python2 (if it has one). Bug: 942720 Change-Id: I6dc18b5fedace510c61628e88701e89410715ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068896Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#743983}
-
Roman Sorokin authored
Keep the token for the whole lifetime. So it could be reused in case user returns to the lock screen page. Also if the token expires on the fingerprint setup dialog - get back to the lock settings. Fixed: 899195, b/144105775 Change-Id: I918bb7186f37c8f5c41add1e14556ecc01de30f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035968 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743982}
-
Wolfgang Beyer authored
As preparation to revert commit Bug: chromium:1035309 Change-Id: I91417547e188f2ef4028cd556b4b3026302dbd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069142Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743981}
-
Daniel Rubery authored
The server will be reporting failure as a separate verdict, rather than using the status field (right now the status field is always unset). The corresponding server-side change is cl/296334194 Change-Id: Iea78604e6d07871f7e5c798dab5b933969d21d25 Bug: 1045986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068038 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743980}
-
Ming-Chuan Lin authored
Bug: None Change-Id: I27fe19f5d1df2d36f42d711ab3bc7e4622f7c940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068267Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ming-Chuan Lin <mingcl@google.com> Cr-Commit-Position: refs/heads/master@{#743979}
-
Andrew Grieve authored
5853fbdc did this for .jar files. This CL addresses compile_resources.py. Bug: 1036426 Change-Id: I991132f4b2b1bc99002ec2a153d35ab815bd84b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070370 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Eric Boren authored
borenet@chromium.org -> borenet@google.com Change-Id: I190fde6ee81e3b4804b73f05d813ef165fc7c44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067867Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Boren <borenet@google.com> Cr-Commit-Position: refs/heads/master@{#743977}
-
Shawn Pickett authored
Bug:1027046,984851 Per issue tracked in http://crbug.com/1027046, the functionality tied to the 'turn-off-streaming-media-caching' flag will be leveraged as part of an experiment to determine whether it should be permanently enabled. Since the flag is set to expire in M82, this change extends the expiration to M86 (given we do not have a clear timeframe for the experiment at this time). Change-Id: I8b8778bc836b5e738860dd104156d4927a931af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068726Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Shawn Pickett <shawnpi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743976}
-
ckitagawa authored
Use onPageLoadFinished() rather than onDidFinishNavigation() for capture experiments. This ensures the page is loaded and most of the content is renderered before we attempt a capture. At present this is happening as a navigation occurs which is too soon as there is often no content. Known Issue: some sites may trigger too soon as they lazily load resources. It would be better to trigger on navigate away, but AFAICT such a trigger/handler doesn't exist as we normally avoid doing work when unloading the page (requires further investigation). Bug: 1055353 Change-Id: I33b99835f96543c476a858dd629ce1b41c130b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070104Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#743975}
-
Eric Seckler authored
This prepares for crrev.com/c/2066976 by plumbing the PerfettoService pointer down into MockProducerHost, which will require it to obtain a reference to the service's task runner. Bug: 1006753 Change-Id: I947357d56b4abc3b8435ededc8165e70f5b44286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070199Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#743974}
-
Peng Huang authored
Vulcan functions are loaded from shared library dynamically. Calling those function pointer with cfi will cause SIGILL / ILL_ILLOPN. So blacklist cfi sanitize for Vulcan function calls. Bug: 1016885 Change-Id: I73989cebc9ab35d6f35fac508e8f0bcfc23cbd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066937Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743973}
-
Daniel Rubery authored
This CL expands the per-file ownership to all the files that exclusively contain functionality related to enterprise scanning (in contrast to APP scanning) Change-Id: Ia8a7ee1012fc81d12651ff79a6861bc43c538132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065908 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#743972}
-
Roman Sorokin authored
Hide Gaia screen when switches from 0 to >0 users, and show the account picker screen otherwise. Also remove can_close_ param from ShowGaiaSignin - relies on the user list now. Bug: 647451 Change-Id: Iec4e8182b6e07393a10d2336a9818d7d1b2d0b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035670Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743971}
-
Ionel Popescu authored
With FormControlsRefresh, the used native theme web instance is NativeThemeAura instead of NativeThemeMac. Prior to this CL, there was no support to initialize the dark mode, preferred color scheme and high contrast states for NativeThemeAura. Note that these states are going to be sent to the renderer processes by using the communication mechanism introduced by [1]. [1]: crrev.com/c/1728056 Bug: 1054725 Change-Id: I45f0d382b70bd1e616cfb8e4a59bc3db392d744a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068870Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743970}
-
Vladimir Levin authored
This patch removes the attribute version of display locking. It also removes updateRendering() which could be easily added back in. It also updates all of the tests and removes some of the earlier tests that aren't very good (they were testing promises and js APIs, none of which makes sense if we're only using CSS version). Also removed some render-subtree sizing tests, since those should be covered by contain-intrinsic-size tests instead. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I03fe9a35a4ed821c800488c316ea13f1a8be6e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054328Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743969}
-
Andrew Grieve authored
Change-Id: Id371e32b1b7f172b252eab6e853d918fee9971bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067236 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
When --no-startup-window is passed in combination with remote debugging, browser is controlled by automation software. In this case, we keep the application running until explicit Browser.close call over protocol. Otherwise, application just exits because no browser window is opened. Drive-by: apparently, this introduced a first test with DevToolsPipeHandler, which exposed a DCHECK. Shutting down the pipe handler posts a task to delete threads which joins them and requires sync primitives task trait. Bug: 1054831 Change-Id: I1fcfdad11ec10661a2163b18a7547668655f25bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068043Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Bug: 1038710 Change-Id: I84610e4ca4f4aa2204dee4ecff28d4d501280449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069139 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Toni Barzic authored
The flakiness seems to have been fixed by CL:2067814 BUG=1053980 Change-Id: Iabe7ff55945d4321ff18cafa05a585bfed42a205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069852Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743965}
-
Theodore Olsauskas-Warren authored
As part of the privacy settings redesign to the capability to surface recently changed permissions is required. A previous CL introduced the capability to retrieve these changes and this CL introduces a Polymer element to display them. This CL also places that element in the site_settings_page hidden behind the privacySettingsRedesignEnabled flag. Bug: 1032584 Change-Id: I744f2a57de65200c2c0684b4777bd77549496e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030525 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#743964}
-
Ben Joyce authored
Cannot update all of tab_ui to use androidx yet because it'd require changes to modelutil/SimpleRecyclerViewAdapter.java which necessitates a whole host of other changes. Bug: 1052460 Change-Id: I7064f33d672ff404d46778af8fc25aaa96da6e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069198Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#743963}
-
Elly Fong-Jones authored
Clicking the "Continue" button on this dialog would end up trying to call through a null delegate pointer. There was no test coverage for this. Oops! This change fixes the bug and adds test coverage. Bug: 1054866 Change-Id: Ia92f51c24a6053a0762e70e7216b5cc2de37d33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068304 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743962}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9642b31a71fc..108a494984da git log 9642b31a71fc..108a494984da --date=short --first-parent --format='%ad %ae %s' 2020-02-24 benjaminwagner@google.com Omit crashing bench on iOS Metal 2020-02-24 robertphillips@google.com Add a program iterator to SkDeferredDisplayList Created with: gclient setdep -r src/third_party/skia@108a494984da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Id614df757d105e824816f73955e5409aa256d21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067235Reviewed-by:
-
