GitLab

TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I1ecb94c52f9accad18bd8da5986daf23bcb61066
Reviewed-on: https://chromium-review.googlesource.com/580308
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488498}

Bug: 746502
Change-Id: I883596553eb46ccb5b927cd5eb0d98a2beb93607
Reviewed-on: https://chromium-review.googlesource.com/576455Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488497}

Bug: 735701
Change-Id: I99b4e0c075c8c4787ae84eaf45351e5e69d1fa20
Reviewed-on: https://chromium-review.googlesource.com/575308Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488496}

Currently there are some entries in W3CImportExpectations that do not closely
follow the syntax and hence cannot be picked up by DirectoryOwnersExtractor.
This CL fixes these entries. It is also in prepartion for converting the [Pass]
entries to OWNERS files, as the conversion script will be based on
DirectoryOwnersExtractor. (I could make these changes locally and then run the
script, but that would make the conversion process harder to trace and debug, in
case there is any need in the future.)

Bug: 713987
Change-Id: Iab1ed744e6fedbf9e805113badd4ff50e9e0347c
Reviewed-on: https://chromium-review.googlesource.com/580395Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488495}

Lots of things want to anchor off the page info icon. E.g.,
permission prompts, the device chooser UI, the first run bubble
and the page info bubble itself.

Unfortunately, the page info bubble is not always present (in
fullscreen for example), and we want to anchor toolkit-views bubbles
off a BrowserView as well as off a BrowserWindowCocoa. So anchoring
is not simple. Currently the logic that deals with this is scattered
around the codebase, and some of it is broken (e.g. crbug/745291).

This CL consolidates the anchoring for permission prompts and the
device chooser UI, for both of their Cocoa and Views versions. The
first run bubble will also use this in a follow-up.

The PageInfo bubble anchoring is a bit simpler since it can't be
shown in fullscreen. It's consolidated partially, but it has some
unnecessary plumbing as well, so more cleanups there are left for
another follow-up).

Bug: 728160, 745291
Change-Id: Id8b3bb9284f8dcc83299aa92123d4ee6e58dddc4
Reviewed-on: https://chromium-review.googlesource.com/575791
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488494}

Bug: 746653
Change-Id: I5ce0bfb68527968feff3da5e034dee78163f36b3
Reviewed-on: https://chromium-review.googlesource.com/578988
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488493}

Using wpt-import in Chromium 8fc1f929.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/349

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/custom-elements

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I1cc6e148aba2ef921fa55c8ddb010da489b57cf9
Reviewed-on: https://chromium-review.googlesource.com/580394
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488492}

Bug: 
Change-Id: I932892f3cc4c9f01d31139a0744f8049a1b7a332
Reviewed-on: https://chromium-review.googlesource.com/580545Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488491}

There are still tests that wraps NavigationBarDoneButton with a local
helper function, which is unnecessary, instead, we should call EarlGrey
explicitly like following:

[[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
      performAction:grey_tap()];

So, this CL cleans them up.

Bug: 741898
Change-Id: I74ea738cb1e58b1ee44da57c1dfaf74b7c348405
Reviewed-on: https://chromium-review.googlesource.com/568271Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mihai Sardarescu (OOO) <msarda@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488490}

TBR=danakj@chromium.org

Bug: Documentation update
Change-Id: I47be9a2f109001643c9910ae4db49e056baccc08
Reviewed-on: https://chromium-review.googlesource.com/580544Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488489}

The notification can be shown during two point in time: when the user logs in,
and when the user disconnects from the Internet. In order for the notification
to be shown, Bluetooth must be disabled, the device must be disconnected from
the Internet, and there must be nothing besides Bluetooth preventing a Tether
scan from beginning.

This CL also changes the ownership of TetherNotificationPresenter. Now, one
instance is created and owned by TetherService and is passed through to the
Tether component when needed. Previously, the instance was owned by the Tether
component, but this no longer worked due to the fact that TetherService needed
to be able to display the "enable Bluetooth" notification when Tether was left
uninitialized (due to Bluetooth being disabled).

Lastly, now TetherService only sets Tether's TechnologyState to
UNINITIALIZED when Bluetooth is disabled, which fixes an issue in which
an "enable Bluetooth" message is shown in Quick Settings when Bluetooth
is on but Cellular is disabled.

Bug: 672263, 740635
Change-Id: Id19a847a9efb7a31d23d2ffb6308fad7d46ca948
Reviewed-on: https://chromium-review.googlesource.com/580349
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488488}

- The 'Learn More' button on the incognito NTP either opens a new
  activity or a new non-icognito tab. Both is not supported in VR.
  As a workaround for now, request to exit VR and if we succeed show the
  'Learn More' page in 2D.

Bug: 742668
Change-Id: I23b9a2447ab297468dd9612c3e3e351ef59b3e40
Reviewed-on: https://chromium-review.googlesource.com/578169
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488487}

Bug: 734150
Change-Id: I8b6aac965c5b627197f62f9f732f154452bfe3d4
Reviewed-on: https://chromium-review.googlesource.com/579607
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488486}

Move all tablet mode related events from shell observer to a new tablet mode observer.

Test: all trybots especially ash tests
Bug: 743148
Change-Id: Idbc601cbf59476c3928fa7ba63ef1dd58fb83893
Reviewed-on: https://chromium-review.googlesource.com/572053
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488485}

Hopefully, this can help to make your code reviews slightly less
bottleneck-y.

Bug: 
Change-Id: Ic56d9c213927e97d4e756e8e4cf52d8b8c38b412
Reviewed-on: https://chromium-review.googlesource.com/580504Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488484}

Follow up to https://chromium-review.googlesource.com/c/579937/ which
removes //tools/auto_bisect. Reason: These are no longer used and will
no longer work after removing //tols/auto_bisect.

Change-Id: Ibe90a9ced87ee34a6673cd7f77645eb20b735f9f
Reviewed-on: https://chromium-review.googlesource.com/580492Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488483}

BUG=726972

Review-Url: https://codereview.chromium.org/2978713002
Cr-Commit-Position: refs/heads/master@{#488482}

Bug: 740070
Change-Id: I9d0a7371c22856a641ad88910d55ba844aca4191
Reviewed-on: https://chromium-review.googlesource.com/572332
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488481}

This CL adds support for specifying a short blacklist of hosts in a
field-trial param of the Client-side LoFi field trial, which will
prevent Client LoFi from being used on those hosts.

TBR=petewil@chromium.org

Bug: 745032
Change-Id: I55a7ae8b3ebcdb5a98c7229a9f714757754b7d29
Reviewed-on: https://chromium-review.googlesource.com/578588Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488480}

This CL moves some hardcoded texts into remoting_string.grd so that
they can be localized.

Bug: 747091
Change-Id: Id9f57bd7d48338635d2c7d0567df1b8e24a83b0b
Reviewed-on: https://chromium-review.googlesource.com/578949
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488479}

Adds a call to hideKeyboard when the sheet is closed

Bug: 746803
Change-Id: Ib9d7a6a4696e7bf8f1864d0aaf3d6d3bb734f8d5
Reviewed-on: https://chromium-review.googlesource.com/579790
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488478}

Make our git diffs decent!
Preparation for:
https://chromium-review.googlesource.com/c/572164/

Bug=667560

Review-Url: https://codereview.chromium.org/2982263002
Cr-Commit-Position: refs/heads/master@{#488477}

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

I'm renaming this method to GetSpellCheckMarkerUnderSelection() to try to make
the name less misleading.

BUG=736181

Review-Url: https://codereview.chromium.org/2954763002
Cr-Commit-Position: refs/heads/master@{#488476}

This adds UMA histograms for keeping track of how long it takes for
the Chrome Cleaner to scan and clean user's machines as well as the
time it takes for users to interact with the Chrome Cleaner prompt
dialog.

Bug: 746987
Change-Id: If4d70c196f68c462834cb0c1e8a82a8bfaa6ea05
Reviewed-on: https://chromium-review.googlesource.com/580087
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488475}

Instead of transitioning to HALF or FULLSCREEN_SEARCH whenever the
search query is not empty, transition only when the query is not empty
and contains some non-whitespace characters.

This will be changed when Zero Query State is introduced, at a later
date.

for-Commit-Position: refs/heads/master@{#487254}
Bug: 746048
Change-Id: I78a2eb73589d3a13c2213d9f4f1d26f2c6162dc8
Reviewed-on: https://chromium-review.googlesource.com/578470Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488474}

Change some of the strings on the palette tray buble.

Test: none
Bug: 747148
Change-Id: I22a2a2480f2884091bffb1f5b9ac4bd04581990c
Reviewed-on: https://chromium-review.googlesource.com/580365Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488473}

Bug: 742990
Change-Id: Ibe303f5e0f5a94015adad2b0d90de963b25d61fb
TBR: tsepez (removing params from ipc message)
Reviewed-on: https://chromium-review.googlesource.com/572222
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488472}

BUG=738495

Review-Url: https://codereview.chromium.org/2962353002
Cr-Commit-Position: refs/heads/master@{#488471}

This allows transitions on UiElements to leverage visibility animations.

Bug: None
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c362d2d6b90de5fa9702660ef7b3decaa0c0ff2
Reviewed-on: https://chromium-review.googlesource.com/579827
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488470}

Drive-by: Fix Save profile button alignment
Change-Id: I2ebafe68d006ec070285b1e6b2cda593e4101486
Reviewed-on: https://chromium-review.googlesource.com/579797Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488469}

This reverts commit 95176184.

Reason for revert: Revert code for investigation before going to beta,
as planned.

Original change's description:
> Add CHECK()s to investigate Issue 737392
> 
> ImageResourceContent::content_status_ is suspected to be reset to
> kNotStarted (i.e. 0) during ImageResourceContent::UpdateImage(),
> but therer is no code that sets content_status_ to kNotStarted
> explicitly.
> 
> This CL adds CHECKs() to
> - Check whether |this| is garbage collected unexpectedly during
>   UpdateImage(), and
> - Investigate where |content_status_| becomes kNotStarted precisely.
> 
> This is to be reverted before going to beta.
> 
> Bug: 737392
> Change-Id: I2879bc54771a295a2dd77fed6808c1c08668e262
> Reviewed-on: https://chromium-review.googlesource.com/572036
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486986}

TBR=kinuko@chromium.org,yoav@yoav.ws,haraken@chromium.org,hiroshige@chromium.org,japhet@chromium.org,kouhei@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 737392
Change-Id: Ia13efe886e50873f3ad0c2375ac12819a0cfb46f
Reviewed-on: https://chromium-review.googlesource.com/580427Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488468}

Also update the browser_tests for renewal messages to verify that at least
one renewal message was actually received.

BUG=
TEST=browser_tests for renewal still work

Change-Id: Idad0059aec02dae4f0910fd9f39846c0a4ac660f
Reviewed-on: https://chromium-review.googlesource.com/569198Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488467}

Bug: 746294
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie50a57965ca0cea2d5415ac3a6ffea88d6d38201
Reviewed-on: https://chromium-review.googlesource.com/578294Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488466}

Enables compiling Media Remoting code on Android.
Uses remoting::RendererController to get updates on the WMPI data source and
pass the information as well as the codec compatibility info to RemotePlayback.

Bug: 517102
Change-Id: I064a223854c1d857434ff228fe47dc89849a0af8
Reviewed-on: https://chromium-review.googlesource.com/538338
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488465}

TBR=phajdan.jr@chromium.org

Change-Id: I37975dc4f4db873685696955e7739305b2be8b7f
Reviewed-on: https://chromium-review.googlesource.com/579067
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488464}

The feature is described in https://github.com/WICG/device-memory
and the intent to ship is here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8qlTjzRY9Mc

Bug: chromium:710702,chromium:718622
Change-Id: If738affc6e171c60ad4b4540c2fec19959a1561a
Reviewed-on: https://chromium-review.googlesource.com/579795Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488463}

TBR=bmcquade

Change-Id: Id0933c23c20b818dc322ca7f487d1a242df61b4b
Reviewed-on: https://chromium-review.googlesource.com/530095
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488462}

RGB texture backed by native GMB cannot be bound to FBO on Intel, but BGR
texture backed by native GMB can be bound.

When GL_EXT_texture_format_BGRA8888 is supported, as-is chromium doesn't allow
BGRA and glTexStorage2D together, because the extensions doesn't define BGRA8
storage format.

Now native GBM needs BGR for WebGL hardware overlay, so this CL allows
both of them for WebGL context.

It's safe because WebGL API doesn't expose BGRA, and DrawingBuffer never use
glTexStorage2D(BGRA8).

BUG=746069
TEST=run WebGL Aquarium on eve
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0e74f738beff16826dcc7af5684791712923851c
Reviewed-on: https://chromium-review.googlesource.com/576967
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#488461}

It was landed almost a year ago, but was never used. If it turns out we
really do need it, can bring it back.

Bug: none
Change-Id: I8635219b8a3af3c46711ff7931403bf32854f351
Reviewed-on: https://chromium-review.googlesource.com/580387Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488460}

This service is currently used only within the same process, and
potentially large amounts of data are transfered over its interfaces, so
this seems a prime candidate for lazy serialization, and should help
some with mojo localstorage performance.

Bug: 730475
Change-Id: Iff573b33f1bfda2193d6bfb5366b9d24f8190150
Reviewed-on: https://chromium-review.googlesource.com/580509Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488459}