- 04 Nov, 2019 29 commits
-
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: Ia0db93c0a48324bd5059f77bd9107f2832bb5d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883508Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712063}
-
Giovanni Ortuño Urquidi authored
Similar WebUI tests are scattered throughout chrome/ and content/. This Cl aims to slightly improve things by consolidating tests under content/browser/webui. Now we have: content/browser/webui/web_ui_browsertest.cc content/browser/webui/web_ui_mojo_browsertest.cc content/browser/webui/web_ui_navigation_browsertest.cc content/browser/webui/web_ui_security_browsertest.cc Change-Id: I6f869df20743872c8b84a3458bc096b80bc8773e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875900 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712062}
-
Dominik Röttsches authored
external/wpt/webstorage/storage_setitem.html does not time-out locally and original flakiness analysis culprit identification seems to have identified an unrelated CL. Local testing with 20 repeats on Mac 10.13 does not result in any timeouts. Bug: 908276 Change-Id: I81179b39c222f8bce954eda6280491515036d6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893263Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#712061}
-
Anand K. Mistry authored
crrev.com/650170 renamed SearchResult to DriveMetadataSearchResult. This change fixes those closure references. chrome.fileManagerPrivate.SearchMetadataParams.types is of type SearchType. Use that type instead of a string. Both thse changes bring us closer to using a generated externs file instead of a hand-updated one. Bug: 613096 Change-Id: If3a007c8c9e3b9e8183578a740433e9847966be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892633Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712060}
-
Michael Ershov authored
This CL implements handler for request from authenticator.js that calculates response for a challenge to perform device attestation during SAML authentication. Bug: 1000589 Change-Id: I98ef94c2598fae5a741b7b639b4ede425c913e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849375Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#712059}
-
Hsin-Yu Chao authored
Bluetooth wideband mic was tracked under the generic type 'InputDeviceBluetooth' and it has been separted to its own type 'InputDeviceBluetoothWideBandMic'. This change also updates the documentation for generic bluetooth types to make it clear that it's a fallback type if device doesn't belong to any category we defined. The CL on CRAS side: http://crrev.com/c/1890111 Bug: 971568 Change-Id: I56057f87afd5578ec0c5c0b9ed206326bdcec59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895024Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712058}
-
Yang Guo authored
We now use the external version pulled via DEPS. TBR=agrieve@chromium.org Bug: 1011259 Change-Id: If34101d2f9a1fe82e3e96fb3b616a082cd2abaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893272 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#712057}
-
Yoshifumi Inoue authored
This patch introduces member functions to |NGInlineCursor| for preparation of the patch[1]: - MoveToNextInlineLeaf() - MoveToNextInlineLeafIgnoringLineBreak() - MoveToPreviousInlineLeaf() - MoveToPreviousInlineLeafIgnoringLineBreak() along with helper functions: - MoveToPrevious() * MoveToPreviousPaintFragment() * MoveToPreviousSiblingPaintFragment() used in |AbstractInlineBox|, |AXInlineTextBox| and |AXLayoutObject|. Note: These functions are similar to |NGPaintFragmentTraversal|, but these functions doesn't skip adjacent inline leaf when starting from non-inline leaf fragment. PFT |<b>abc</b><b>def</b> => next =>|<b>abc</b><b>|def</b> IC |<b>abc</b><b>def</b> => next => <b>|abc</b><b>|def</b> This change affects only |{Next,Previous}OnLineInlineNG()| for |AXLayoutObject|. [1] http://crrev.com/c/1888242 Utilize NGInlineCursor for inline box traversal Bug: 982194 Change-Id: I0eac23fde8e4eb1028c98c76c17bc584d4e86bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895258 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712056}
-
Julie Jeongeun Kim authored
It converts remote_cocoa::mojom::Application from application.mojom to new Mojo types using PendingAssociatedReceiver, AssociatedReceiver, PendingAssociatedRemote, and AssociatedRemote. Bug: 955171 Change-Id: I5c8979e8509cb064878f133457c20d95c6a38b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895022 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712055}
-
Julie Jeongeun Kim authored
It converts TextInputHost from text_input_host.mojom to new Mojo types using PendingAssociatedReceiver, AssociatedReceiver, PendingAssociatedRemote, and AssociatedRemote. Bug: 955171 Change-Id: I39b94453e0bbfe6bf713cdad8cc288347d49a736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893607 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712054}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I894e1745ffcbf5b9715ad8a49e1dab70cc222793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712053}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dda199292eed..48be9ec54eea git log dda199292eed..48be9ec54eea --date=short --no-merges --format='%ad %ae %s' 2019-11-04 cjmcdonald@chromium.org DependencyService: Use host overlay for SDK package source paths 2019-11-04 cjmcdonald@chromium.org DependencyService: Handle BDEPEND packages more robustly Created with: gclient setdep -r src/third_party/chromite@48be9ec54eea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibde4cd3a1943785befc8433474e7b3b5650af76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896146Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712052}
-
Julie Jeongeun Kim authored
It converts NativeWidgetNSWindowHost to new Mojo types using PendingAssociatedReceiver, AssociatedReceiver, PendingAssociatedRemote, and AssociatedRemote. Bug: 955171 Change-Id: Iec4a1dceaf904a7b4552216900d43c683d3ece7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895095Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#712051}
-
Antonio Gomes authored
... and use WTF::String instead. BUG=78725 R=guidou@chromium.org, haraken@chromium.org Change-Id: I24b5c1c5cee12c82f9ab5f57caccaed502f1336e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882131 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712050}
-
Anand K. Mistry authored
This change only adds the new volume type and associated plumbing. The icon is the same icon taken from //chrome/app/theme/default_100_percent/cros/smb_icon.png Bug: 939235 Change-Id: Ie735fa35752c82a195e83fda94425eb295a37c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890375Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712049}
-
Julie Jeongeun Kim authored
It converts NativeWidgetNSWindow to new Mojo types using PendingAssociatedReceiver, AssociatedReceiver, and AssociatedRemote. Bug: 955171 Change-Id: I1da0bd8961616cb6f819a0cef44c9bcb03f0215b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895092 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712048}
-
Jason Lin authored
This is the first step to allow users to install Crostini with a custom username. Bug: 1016195 Change-Id: I18b6bd3c99198ff733c987dd25ae2d46029a6c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880411Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#712047}
-
Melissa Zhang authored
Adds an optional flag for devices with tablet form factor. BUG=1019549 Change-Id: I24a95d473fa59d9efe582986b6e19330afa75b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888857Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712046}
-
Alex Danilo authored
When a file operation completes, it generates a completed (done) panel item indicating success or failure. The failure panel items are placed in the same hosting element replacing the progress panel item. Move the success (done) panel items into the same hosting element as the progress panel items to keep all the feedback panels in the same area in the UI. When there are no operations in progress and no errors and multiple success (done) panels exist, the summary panel shows the success icon and '100% complete'. Bug: 1014771, 989666 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: I6889cd7839e0856cbe8c7d8b8c20254d6198fff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895014Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712045}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9dd3e34fd3c3..6a4037d9f325 git log 9dd3e34fd3c3..6a4037d9f325 --date=short --no-merges --format='%ad %ae %s' 2019-11-03 primiano@google.com Merge changes I8956e3c0,I28fd0043,I29e5b6f5,I7f6222ce Created with: gclient setdep -r src/third_party/perfetto@6a4037d9f325 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idab9e6816229fc9641c720c8121721a7c2f3e2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712044}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Id375876c2d44e0a2cddf6231b7b3f9b76857e10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894702Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712043}
-
Alex Danilo authored
Bug: 989635 Change-Id: Ife7bc12d404256420c4c2af3810a9f10077dc259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896485Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712042}
-
Mitsuru Oshima authored
When the wallpape is small, directly paint the image with blur. Bug: 1020235 Test: manually tested on kohaku and on linux. Change-Id: I63ae84149f743e837ff735e236aff333162b932e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896059 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712041}
-
Alan Cutter authored
RAPPOR is deprecated in favor of UKM. As part of BMO we plan on revisiting our metrics as a whole so for now these RAPPOR metrics can be removed. Bug: 1016906 Change-Id: If2de040847161c7d6f4d980fc8e99d480399a61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890377 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#712040}
-
nancy authored
kAppServiceAsh is the flag to integrate AppService in UI app_list. Since it has been enabled for a few months for M78, M79 release, it should not be disabled, so the flag kAppServiceAsh can be removed. BUG=1016159 Change-Id: I0235521beb53bdda1b50c07e8a6e4e11298ba71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895254Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712039}
-
Eric Willigers authored
web_app_constants.h now defines web_app::DisplayMode as an alias for blink::mojom::DisplayMode Code in the web_app namespace no longer uses web_app:: to refer to other members of the web_app namespace. Bug: 1009909 Change-Id: I870c3d640c8d62f9b7fc4aa0714fe04079cd0b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892980Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#712038}
-
Joel Hockey authored
Refactor only change TBR=benwells@chromium.org TBR=stevenjb@chromium.org Bug: 1004708 Change-Id: Icc6e0d686cde3071eb78246089f62440f317c829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893475 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#712037}
-
Anand K. Mistry authored
Filter out invalid entries in a provided filesystem's ReadDirectory() results list. Entries are expected to have a valid type and a name that does not contain certain invalid characters. Bug: 992321 Change-Id: Ie7e3b47da349892537643cba239d7f88ed4f60ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888867Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712036}
-
Dominick Ng authored
This CL addresses a bug where engagement cleanup is continually run in incognito mode because we do not write a pref value for the last engagement. When in incognito, engagement is never regarded as going stale, meaning that cleanup is never run. A test is added to ensure the correct behaviour. The frequency of calls to Clock::Now() is also reduced in this CL. BUG=947835 Change-Id: I7c91caa98a3c7e7c6e39aec314682f382bb2581b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895097 Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712035}
-
- 03 Nov, 2019 11 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6774083a. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idf8b749954566475df67b50df550735e758e9e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897094Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712034}
-
Antonio Gomes authored
... and use WTF::String instead now that RTCCertificateGenerator resides solely in blink/renderer. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie87bdada35e05a868763b52ffc2ae8778c0e355f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882130 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712033}
-
Harald Alvestrand authored
Bug: none Change-Id: I73dd05b052f0162093ac4f47118d8756efe3077c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893875 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712032}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5fdf4d653c899c77b576e1ccfd6b4264066af9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712031}
-
haozhe authored
Firefox and Chrome passed. Bug: 900581 Change-Id: Ib738538dc5a8e3f12d1e403d9b9ad96c4fd5f6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894177Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#712030}
-
Antonio Gomes authored
Note that, given that this cl interfaces with libwebrtc, some std::string usage was deliverately left untouched. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Idb7a877c100a05400d0ce8daad0f870945c65ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880962 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712029}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2cac050cfb6e415b7e67ee38a6c3d6a65730c5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896657Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712028}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e083eee8ece..4cc2dc64ff13 git log 8e083eee8ece..4cc2dc64ff13 --date=short --no-merges --format='%ad %ae %s' 2019-11-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@4cc2dc64ff13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I0d195ed4443e8024569a102f9825380541f8053e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896994Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712027}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b68a279ce188..6c7208f93d6e git log b68a279ce188..6c7208f93d6e --date=short --no-merges --format='%ad %ae %s' 2019-11-03 jmadill@chromium.org Capture/Replay: Implement mid-execution replay. Created with: gclient setdep -r src/third_party/angle@6c7208f93d6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I9884d02d60295982bc6003b6b1994ed69205e19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712026}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5889bbba2f7e890dd653491bc85e6de3a20ad1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712025}
-
byoungkwon ko authored
There are unreachable case state that it returns when it meets first switch-case. So we need to delete and combine them for unreachable case. Bug: 1020475 Change-Id: I014190e3b7373d86da08912eacdc509d3ccc2cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894667 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712024}
-