- 24 Jun, 2020 40 commits
-
-
James Cook authored
Bug: none Change-Id: I4abbefaddd045a8deea708bb13056fc137ba7a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262112 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781826}
-
Raphael Kubo da Costa authored
This is sort of a reland of https://crrev.com/c/2260872, but rather than calling bytes.decode() on every line we pass |universal_newlines=True| to subprocess.Popen() so that |lines| is still a string and not a bytes object in Python 3. This approach does not cause the significant slowdown during linking that led to the previous CL being reverted. Bug: 941669 Change-Id: I92bc14d4dea01085f9f81153f610663960cc2fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263712 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781825}
-
Alex Danilo authored
Creates a new 'multi_menu_button.js' file that encapsulates all the menu button logic in there and moves all the sub-menu specific code to 'multi_menu.js'. Result is that the cr.ui.MultiMenu type can be used anywhere a cr.ui.Menu is used with the sub-menu functionality encapsulated in the implementation so that a caller using cr.ui.MultiMenu doesn't need to know it behaves differently to a normal cr.ui.Menu (which can have only one level of menu). Uses the 'decorate' pattern class cr.ui.MultiMenu to extend the functionality of cr.ui.Menu by chaining decorate() calls to combine the properties and methods of both classes onto the one object. Adds an 'activate' listener on any active sub-menu which fires on the parent element so that any element attaching a cr.ui.MultiMenu will have it's activate listeners fired from either the top level or child (sub) menus. Monkey patches a few methods to hide the existence of multiple layers of menu from the hosting element. No change in behavior, minor update in unit tests to directly reference the menu itself since the menu button is now distinct from the menu it hosts. Bug: 1002396 Tests: browser_tests --gtest_filter="*MultiMenu" Change-Id: Id61eb161730656cd2916c85a2188359e8403fca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248389 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#781824}
-
Clemens Arbesser authored
This CL moves ownership of the radio button controller into the generic-ui controller. It also moves the implementation into autofill_assistant component, which allows easier unit-testing. The change of ownership is required for an upcoming refactoring, where nested UI controllers should not create their own independent radio button controllers. Bug: b/145043394 Change-Id: I1a2998b682463892160378d2111899e98d7ce18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253856Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781823}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1c99a943d920..b021d08278b8 2020-06-24 tvanderlippe@chromium.org Extract e2e-test fixes in prepartion of e2e-tests-on-build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1088463 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8bf29fecf73528a29281297678dfdb846e692a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781822}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0f5a11e32143df0d046905e6744f46011e16cfa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263476Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592971072-917710ea24284ef9aa6ebcca30f6d2746c0234cd.profdata to chrome-win64-master-1592981921-d7f3480d3d068518c011ab351ddf99cd52e5b689.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8008b2f9dd8f95775e8b8d19092f809e91885b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263179Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e0c317566197..2975a0d2f04a 2020-06-24 treehugger-gerrit@google.com Merge "Remove unused file." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6e317bda69c475b5d766bcb6968d7fa9ae1f5af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263180Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I64fd8246c491c36211504b2e9b3fcee96564f9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263475Reviewed-by:
-
Oriol Brufau authored
The marker-list-style-position.html WPT test was created by Mozilla, and it relies on inside list markers being affected by ::first-line. However, that doesn't happen in Chromium and WebKit, and the relevant issue (https://github.com/w3c/csswg-drafts/issues/4506) is still open. Therefore I'm adding a 2nd expectation in order to allow both behaviors. Bug: 457718 Change-Id: Id61fbdd07940d541eb7a9638a0fc1aefc13bb545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260618Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#781817}
-
Ramin Halavati authored
Non-Primary OTR profiles are not supposed to be used to create browser windows. "DevTools::BrowserContext" are an exception to this ban and |AllowsBrowserWindows| is added to cover them. Bug: 1033903 Change-Id: Ib7ee274887943106f36ebaf915d48a7843bf73d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250181Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#781816}
-
Cheng Zhao authored
Pen may also send non client pointer events on Windows 10, by treating them as normal touch events we can properly handle them in one place. Without this non client messages from pen would be ignored, and users would not be able to use pen to interact with window's native frame, like dragging titlebar or clicking the close button. Bug: 1093125, 841580 Change-Id: I45703932ee2729f93e3446fdecd1d4633fbf0aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237535 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#781815}
-
Mohamed Amir Yosef authored
This CL is generalizing the ResetSelectedLine() test Before this CL: The test had strong assumptions about the number of entries in the autofill suggestions. After this CL: This is relaxed to be compatible with upcoming feature that adds a new entry in the autocomplete menu to hide the suggestions. Bug: 1030649 Change-Id: I3ce570f295ae211a2d4f4d0e113a7bfb162617fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250599Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#781814}
-
Carlos Caballero authored
TabSpecificContentSettings is bound to the page (aka main frame) and might be null at times this TabSpecificContentSettings clients should be able to tolerate null instances. Bug: 1096101 Change-Id: I6aa51f710a92cd883727525a2adf65b2588b5e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260617 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781813}
-
Rune Lillesveen authored
This seems to work with googlesource.com urls and hopefully still will if googlesource decides to rename master. Also, use main instead of master for a github url. Change-Id: I5a7d799fe37535b622be270d3ae9b30d6aa54b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263732Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781812}
-
Oleh Lamzin authored
Make all battery info fields optional to be more flexible in the future, e.g. we may filter some items due to PII filtering policy. Bug: b:158658869 Test: unit_tests Change-Id: I65dff7f637db70860060c79dab9b418b809ee73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252242 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#781811}
-
Bret Sepulveda authored
This reverts commit b2e67312. Reason for revert: Caused compile failure on Linux ChromiumOS MSan Builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/19874 Original change's description: > Add CrostiniController class to manage foreground tasks > > This is a refactor to move code out of file_manager.js and > into crostini_controller.js in preparation to add more features > for showing messages. > > Updated UI tests to use FILES_NG_ENABLED and work with all files > that import from chrome://resources such as files_message.html. > > Bug: 1095889 > Change-Id: I9c9f34304e26dca8df4c0aa64a51c124650385b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259873 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781773} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: I91a7bd3837cf2ab2108ba672c36b3e5a5d5c743c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263833Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1496de215a39..654e6c9ed0c3 2020-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 36b5bb701da9 to 7a1af5878594 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I05c9d691c7da9993ef9a4af56e7e7a7b07494703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263177Reviewed-by:
-
Rune Lillesveen authored
The remaining references to master is from dom code apis and branch names in documentation. Change-Id: I7a1524ba2bcef3ecac612df6e513a701573e2a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263533Reviewed-by:
-
Marc Treib authored
If the user presses the "No, thanks" button, Chrome shouldn't ask to move this particular password again. That requires hooking up the button to PasswordFormManager::BlockMovingCredentialsToAccountStore() which this CL does. Bug: 1060128 Change-Id: I706bffd07d9883db1544363524628d24f56e4272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263214Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781807}
-
Omar Morsi authored
This CL does the following: - Allows adding "VPN" to ONC's DisableNetworkTypes list. - Adds a VPN device state entry in the list returned by CrosNetworkConfig::GetDeviceStateList() to be used by UI. - If VPN is disabled by policy: * Removes VPN pod from the system tray. * Removes VPN entry from the network summary page in settings. * Disables (but not removes) the "Add OpenVPN/L2TP..." button in the network summary page. Bug: 1064893, 1082327 Change-Id: I0441e3ab0eae27b2af7eafc7dd7b0f2ad5fcd5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190216 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781806}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/36b5bb701da9..7a1af5878594 2020-06-23 ehsannas@gmail.com Support OpCompositeExtract pattern in desc_sroa (#3456) 2020-06-23 vasniktel@gmail.com spirv-fuzz: Implement FuzzerPassAddParameters (#3399) 2020-06-23 vasniktel@gmail.com spirv-fuzz: Add GetParameters (#3454) 2020-06-23 vasniktel@gmail.com spirv-fuzz: Permute OpPhi instruction operands (#3421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I453d338a268eb73014f43fc8aca55866b6645112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262798Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 6536130a. Reason for revert: crbug.com/1098633 Original change's description: > [PTZ] Add mocking points to VideoCaptureDeviceFactoryWin > > This CL refactors video capture device creation on Windows, removes some > code duplications related to DirectShow device enumeration and adds > mocking points for unit testing. This CL has no functional changes. > > Bug: 934063 > Change-Id: I2df08b3a361ffd702761bd9d6b400f4418390c99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247797 > Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> > Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781357} TBR=eero.hakkinen@intel.com,guidou@chromium.org Change-Id: I967f2eccd57c9847d85201ad57d28ad804691fff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263193Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781804}
-
Mikel Astiz authored
The field hasn't been populated in a long time so it can be deleted from the protobuf definition, and the old legacy code (not actually exercised) deleted. Change-Id: Iaf65d73e76841c2758679cfd26a93432a438b4ae Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262992 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9111c7e4..88ed5b1e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17337fe6a850878bffe67cd79e018e774423cc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263332Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781802}
-
Colin Blundell authored
This CL augments WebLayer's infobars implementation by handling accessibility as Chrome's does: while accessibility is enabled the infobar container view does not scroll out of view. The implementation is a port of that of //chrome's InfoBarContainer.java extended to handle the wrinkle that WebLayerAccessibilityUtil drops its observers when there are no more Browsers and doesn't re-add them on addition of a new Browser. Bug: 1093846 Change-Id: Ic58d17823068d60c9d0d25a80f7ddcf420f9a2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254020 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
We don't use this metrics recently. Let's remove this. Bug: 1084027 Change-Id: Ic097e893c36f86e552c0cb4277c95727b1d707c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259701Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781800}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5062f6b5bcd..e0c317566197 2020-06-24 treehugger-gerrit@google.com Merge "Presubmit: remove NULL ban" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I77c8db8bd8a34fd4fefe40904f9ae8324777bd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263176Reviewed-by:
-
Bret Sepulveda authored
This reverts commit 225f6f4c. Reason for revert: I think this is causing failures in: virtual/omt-worker-fetch/external/wpt/workers/modules/dedicated-worker-import.any.worker.html http/tests/workers/worker-usecounter.html virtual/omt-worker-fetch/http/tests/workers/worker-usecounter.html and the "webkit_lint" step. See example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/47132 Original change's description: > Add StoragePartitionConfig class. > > Introducing StoragePartitionConfig to make it easier for code to > directly request the StoragePartition they need instead of having to > go through the indirection of site URLs. Grouping the 3 attributes of > a config into a class also makes several call sites simpler. This is > being done as part of an effort to reduce the amount of code that > depends on site URLs. > > - Created class for storing the storage partition > <domain, name, in_memory> tuple. > - Update GetStoragePartitionConfigForSite() and related code to use > this new class. > - Create BrowserContest::GetStoragePartition() method that takes > StoragePartitionConfig as a parameter so future callers do not need > to construct a site URL to get a storage partition. > - Remove StoragePartitionImplMap::StoragePartitionConfig struct and > convert StoragePartitionImplMap to use the new StoragePartitionConfig > class. > > Bug: 1085275 > Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240 > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Auto-Submit: Aaron Colwell <acolwell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781691} TBR=acolwell@chromium.org,alexmos@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org Change-Id: Iec47df87cb66a779d2d569e825c9b4ecccf1f2ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263216Reviewed-by:
-
Oleh Lamzin authored
Add unit tests for probe service. Bug: b:158658869 Change-Id: I3feff23e437d1883b7f4be9c9dcb97910f3ad85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248185 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Bret Sepulveda authored
TBR=dgozman@chromium.org Bug: 1098676 Change-Id: I23a31f259679aba894d75b6d17ec1d6b90895495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263157Reviewed-by:
-
Omar Morsi authored
This CL changes NetworkHealthUnittest after CrosNetworkConfig starts to report VPN device state when CrosNetworkConfig::GetDeviceStateList function is called. Bug: 1064893, 1082327 Change-Id: I958f530676f4847b7c62dc491a86480184a9b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253765 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592967357-1044ce77a8c2825b6c9c5357d74768eafbc87565.profdata to chrome-win64-master-1592971072-917710ea24284ef9aa6ebcca30f6d2746c0234cd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I926fdf3a7d7715d992f037b424494798ca82e091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263172Reviewed-by:
-
Anders Hartvoll Ruud authored
I'm guessing it differed from the main longhand order at some point, but currently it's identical to the shorthand that's generated. R=ericwilligers@chromium.org Change-Id: I388d3dd4d51ba18948246cb07083e1f48926f0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253740Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/839704450200..fbb9dc2cf1af 2020-06-24 johnkslang@users.noreply.github.com Merge pull request #2285 from proydakov/msvc-rtti-compilation-warning-fix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ice58ab440fa5d2537e43a0121c00a9ac147aebbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263173Reviewed-by:
-
Christoph Schwering authored
This CL cleans up the UMA metric code for the Autofill.FormDynamicity metric, which is not needed anymore. Bug: 1082744 Change-Id: I4a5efe995edae005b7a431ad2d0975b06dd05d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252181Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#781791}
-
Friedrich Horschig authored
The new metrics ReauthToUnlockAccountStore.* report whether reauth succeeded or was aborted/failed. It's split by access points: - Filling dropdown - Generation - Settings - Saving/Updating - Moving password Bug: 1063852 Change-Id: Ifd90ae032405d2677f5a5bb554275a2c14e9a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252809 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781790}
-
Kushagra Sinha authored
Change-Id: Ia9a8794d62e11ca294583c524a9f6256ee7b048a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256218 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781789}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I505c982ee92bf7ef4c58f419989ee64e3a50415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260601Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#781788}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I1fb8dc3865279f34be2fbb7bc7012dfb0e12d456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262953 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
