Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 08 Sep, 2014 11 commits
    • pbos's avatar
      Roll usrsctplib: e6e1833:8975bd5 · 96e9e19f
      pbos authored 
      Syncs to tip of tree to bring in fix for memory leak detected by LSan
and locally in memcheck on WebRTC code. Fixes were in usrsctplib
r8988-r8990.

R=tommi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/550023002

Cr-Commit-Position: refs/heads/master@{#293681}
      96e9e19f
    • burnik's avatar
      Preparing |SyncSocket|'s handle for the peer process is different for POSIX and Windows · 3d670050
      burnik authored 
      which leads to code duplication, platform #ifdef checks on multiple levels and
general confusion on how to work with the SyncSocket.

Typical use case for |SyncSocket|:
1. Browser creates and connects the socket pair - one for browser and one for renderer.
2. Browser prepares the foreign socket (Windows duplicates, POSIX creates file descriptor).
3. Browser relays the foreign socket handle to the renderer via IPC.
4. Renderer receives the IPC and creates the socket using the handle provided.
5. Sockets are ready for send/receive on both ends.

Steps 1-4 get simplified since there is no need to check the platform in order to prepare the socket for transit.

What this CL brings:
1. Adds |SyncSocket::TransitDescriptor| type which wraps the socket handle and is cross-platform.
2. Adds |SyncSocket::PrepareTransitDescriptor| method which is implemented depending on the platform.
3. Adds |SyncSocket::UnwrapHandle| method which unwraps |SyncSocket::Handle| from |SyncSocket::TransitDescriptor|.
4. Removes #ifdefs for platform-checks in code using |SyncSocket| and simplifies preparing the SyncSocket.

Note:
- There is still some less evident duplication in the ppapi and pepper-broker code which should be addressed.
- SyncSocket unit test should also be reviewed.
- There is a similar pattern when using SharedMemory.

BUG=409656

Review URL: https://codereview.chromium.org/525313002

Cr-Commit-Position: refs/heads/master@{#293680}
      3d670050
    • mtomasz's avatar
      Rename DriveProvider to ExternalProvider. · 41894532
      mtomasz authored 
      Since metadata properties fetched by DriveProvider in MetadataCache are going
to work for FSP also, it is renamed to ExternalProvider (since Drive and FSP
are both on the external backend).

TEST=Tested manually that Files app and the gallery work.
BUG=408017

Review URL: https://codereview.chromium.org/529413002

Cr-Commit-Position: refs/heads/master@{#293679}
      41894532
    • mohan.reddy's avatar
      Changing the order of weak_ptr_factory in src/sync module, to ensure proper... · 0e6caf90
      mohan.reddy authored 
      Changing the order of weak_ptr_factory in src/sync module, to ensure proper cleanup while object is inactive.

BUG=303818

Review URL: https://codereview.chromium.org/509853003

Cr-Commit-Position: refs/heads/master@{#293678}
      0e6caf90
    • iseki's avatar
      Support StreamCopyOrMoveImpl in sandbox. · 9d31d519
      iseki authored 
      StreamCopyOrMoveImpl has some issue.
* Return infelicity error code.
* Don't notify to observer.
This issue is fixed in Issue 522543002 so we can support it in sandbox.

BUG=360088
TEST=content_unittests passed

Review URL: https://codereview.chromium.org/541363002

Cr-Commit-Position: refs/heads/master@{#293677}
      9d31d519
    • jackhou's avatar
      Add AppWindow.setVisibleOnAllWorkspaces. · c76ef732
      jackhou authored 
      For platforms that support multiple workspaces (currently Mac and Linux), this
allows app windows be visible on all workspaces simultaneously.

API proposal:
https://docs.google.com/document/d/1RC3CYwsrVxS_5hXg6nE3zA9y59G98z9Ezmmmq_Gzx9o/edit?usp=sharing

BUG=384644

Review URL: https://codereview.chromium.org/469993003

Cr-Commit-Position: refs/heads/master@{#293676}
      c76ef732
    • zhaoqin's avatar
      disable RangeHistoryWebUITest.* browser tests on Dr.Memory bots · 9f11d3bc
      zhaoqin authored 
      TBR=bruening@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/549053002

Cr-Commit-Position: refs/heads/master@{#293675}
      9f11d3bc
    • rfevang's avatar
      Introduce ItemPosition class for enhanced bookmarks. · a3db1c4f
      rfevang authored 
      This class will be used for setting/reading the string positions
used by the enhanced bookmarks.
BUG=411412

Review URL: https://codereview.chromium.org/510543002

Cr-Commit-Position: refs/heads/master@{#293674}
      a3db1c4f
    • calamity's avatar
      Make page switch on drag happen at top and bottom for experimental app list. · 2014111c
      calamity authored 
      This CL makes dragging an app in the experimental app list change pages at
the top and bottom of the apps grid rather than at the sides. This matches
the scroll behavior of the experimental app list.

BUG=406222

Review URL: https://codereview.chromium.org/518673008

Cr-Commit-Position: refs/heads/master@{#293673}
      2014111c
    • jrummell's avatar
      Update Pepper interface for EME · 1e9a7b14
      jrummell authored 
      To support CDM_6, make the following changes:
- add SetServerCertificate
- add GetUsableKeyIds
- rename ReleaseSession to CloseSession
- add RemoveSession
- add SessionKeysChange event
- add SessionExpirationChange event

Includes changes to cdm_adapter for the new functionality. Changes to
use these new interfaces in blink in a future CL.

BUG=358271
TEST=existing EME tests still pass + manual testing

Review URL: https://codereview.chromium.org/496143002

Cr-Commit-Position: refs/heads/master@{#293672}
      1e9a7b14
    • cjhopman's avatar
      Add content_shell_apk target (and a bunch of its dependencies) · cd7694af
      cjhopman authored 
      The content_shell_apk does not have the full native part that it should.
It builds, installs, starts, loads the native library, and then crashes
when it tries to access missing native parts.

This requires fixes to a bunch of little things:
1. Should only extract java files to compile from srcjars.
2. The way we were creating the single combined resources zip was wrong
because we were clobbering xml files (we should only clobber images, xml
files need to be handled more carefully). Instead of trying to properly
handle xml files, the combined zip now just puts all the different
dependencies in different folders (0/, 1/, etc) and then when packaging
we detect that type of zip and pass all the subdirs to aapt.
3. java_cpp_template with multiple sources needs to have a unique
depfile path for each source
4. jni_generator needs to clear the classlist variable in each loop of
foreach (otherwise gn complains about assigning to non-empty list)
5. a couple parts of apk native lib handling was not skipped for an apk
with no native lib

This adds a bunch of targets:
//base:base_java_test_support
//content/public/android:content_java_resources
//content/public/android:content_java
//content/public/android:content_strings_grd
//content/public/android:gesture_event_type_java
//content/public/android:page_transition_types_java
//content/public/android:popup_item_type_java
//content/public/android:result_codes_java
//content/public/android:selection_event_type_java
//content/public/android:speech_recognition_error_java
//content/public/android:top_controls_state_java
//content/public/android:screen_orientation_values_java
//content/public/android:content_gamepad_mapping_java
//content/public/android:content_jni_headers
//content/shell/android:content_shell_jni_headers
//content/shell/android:libcontent_shell_content_view (partial)
//content/shell/android:content_shell_java_resources
//content/shell/android:content_shell_java
//content/shell/android:content_shell_apk_resources
//content/shell/android:content_shell_apk
//net/android:net_java
//net/android:remote_android_keystore_aidl
//net/android:net_java_test_support
//net/android:net_javatests
//net/android:net_errors_java
//net/android:certificate_mime_types_java
//net/android:cert_verify_status_android_java
//net/android:private_key_types_java
//net/android:net_unittests_apk (disabled)

TBR=yfriedman,thestig
BUG=359249

Review URL: https://codereview.chromium.org/507523002

Cr-Commit-Position: refs/heads/master@{#293671}
      cd7694af
  3. 07 Sep, 2014 29 commits