- 06 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9030e1f5b01..0b1579a826af git log e9030e1f5b01..0b1579a826af --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com metrics: make null values passed to repeated fields more obvious Created with: gclient setdep -r src/third_party/perfetto@0b1579a826af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic206d0d7c0b3cd0a69fce2440b52c3b77a67bfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747695}
-
Stepan Khapugin authored
Reparents the tab grid to SceneController. Note that the lazy getter loses a DCHECK - it seems too hard to cleanly port to SceneController at the moment, though once multiwindow is operational we should add new invariant checks everywhere. Bug: 1045657 Change-Id: I7e4eecd58bea4338a634f9e01e2cbc255c49c328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087337 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747694}
-
Surma authored
The WebAssembly Web API spec[1] prescribes that the responses for `WebAssembly.{compile,instantiate}Streaming()` must have the `Content-Type` header `application/wasm` without any extra parameters. So far we ignored extra parameters, causing interop issues with Firefox. [1]: https://www.w3.org/TR/wasm-web-api-1/#streaming-modules Bug: 1057973 Change-Id: I2273e2b5577dc6a11343536d55fa72b9e518c0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085257 Commit-Queue: Surma <surma@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747693}
-
Ehimare Okoyomon authored
OnJavascriptDisallowed does not get called to remove the observer if the incognito ntp tab is closed, which can result in a crash (see bug). To fix this, add RemoveObserver call to the destructor. Bug: 1058769 Change-Id: I18413d0ae54593adc032aa017f39f5787bd5bc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088713 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#747692}
-
Mike West authored
This patch checks in failing expectations instead to make our existing behavior clear. Bug: 1024786 Change-Id: I1cf5b536cc410b7798ce69a6a140b01f61ca2481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089704 Commit-Queue: Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#747691}
-
Kevin Ellis authored
This patch resolves most of the known cases for resolving potential conflicts between play state changes originating from web-animation API calls and animation-play-state. Next steps: - resolve the behavior of methods that indirectly call play such as reverse. Additional tests will likely be required for these cases. - fix pending. When pending is called from JavaScript on a CSSAnimation, the style must be flushed to ensure than any pending change to play state is resolved; however, there are other call sites to pending that should simply check the status without a forced style update. An additional method is needed to separate the two use cases. The change is straightforward, but potentially bulky, and thus deferred to a separate CL. Bug: 1006086 Change-Id: I65d1f51c3c2fd026255099ac7f200257b3ece7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078414 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747690}
-
Monica Basta authored
This CL removes the history usage hint for the sWAA on and updates the strings for the sync setup page. Bug: 1035421 Change-Id: Ife04c81e5994874e3f437adecd4f4d5afd923456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089872Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#747689}
-
Omer Katz authored
On-stack buffer used as the target of the copy (in hash_table.h) needs to be force-aligned. Bug: 1058777 Change-Id: Id70f54ce0c44c780e0dfa9c1e0b97e9e37f3d632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089833Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747688}
-
Victor Hugo Vianna Silva authored
The feature has been successfully enabled by default, so this CL removes it, as well as the favicon cleanup logic for pseudo-USS introduced by https://crrev.com/c/1917173. Bug: 978775 Change-Id: I8539cda6166e6a03e434b9545278b7b6abda3a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089823 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747687}
-
Viktor Semeniuk authored
This change adds UI for the case when no leaked credentials were detected after password check. Bug: 1047726 Change-Id: Ifa383a09e764a2dbd5286ef542f78c6c95f63692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087711Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#747686}
-
Gabriel Charette authored
These missing includes are preventing removal of unused headers from task_runner_util.h and consequently migration from task_runner_util.h to task_runner.h's new PostTaskAndReplyWithResult member method. The following script was run on every file in the codebase, prioritizing .h over matching .cc to best enforce the rule of not include a header included by your .h : def Fix(file_path): content = refactor_lib.ReadFile(file_path) # Assume fwd-decls are correct in first pass. fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content) if fwd_decls_match: print 'fwd_decls_match in %s' % (file_path) return False bind_helpers_match = re.compile( # Doesn't begin with a comment. r'\n *[^/\n][^/\n]' # Anything else after a non-comment start (and don't allow this to capture a comment start either) r'[^/\n]*' # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo. r'[^<]' # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed. r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content) callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content) ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content) if not bind_helpers_match and not callback_helpers_match and not ptr_util_match: return False updated_content = content if bind_helpers_match: updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h") if callback_helpers_match: updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h") if ptr_util_match: updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) return True TBR=danakj@chromium.org (mechanical change for //base API) Bug: 1026641 Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971Reviewed-by:Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#747685}
-
Christos Froussios authored
The API change was proposed in https://docs.google.com/document/d/1M_Tzgap5_mdSNBWJwBVrsX_bFoJ0AYM0mmi9-LYs26g/edit# The callbacks were simplified to VoidCallback, because an event already covers this functionality. Bug: 1047726 Change-Id: I9aa297d1d15a0815c5e81af965c88b237cd81758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084596 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
jonross authored
We already have measurements in place for the Gpu's peak memory allocation over various user interactions. However when we see spikes there is no way to attribute them. This change builds out attribution for the source of the allocations being done. It also includes this in the existing trace events. Bug: 1001168 Change-Id: Ibf9256eae51e076457218ee558aa25b5caa94c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024920 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747683}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b3d09c15. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ie3e3daa1a8b7a5614c1020c796329970a24ed840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090732Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747682}
-
Michael Lippautz authored
Migrate: - RegionTree->PageMemoryRegionTree: Keep track of all PageMemoryRegion regions in a BST for lookup of arbitrary addresses. - PagePool->NormalPagePool: All normal pages are kept in a page pool for fast retrieval. Currently, PageMemoryRegion used for normal pages is never returned to the operating system but pages are kept in the NormalPagePool until shutdown. This can be improved in future. Introduce: - PageBackend: Entry point for higher-level abstractions. Provides bottlenecks for allocation/freeing of PageMemory objects (large and normal) as well as new ones. Change-Id: Ia46daef501a8bd4785885d68f3b420157bf153b6 Bug: 1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083474 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#747681}
-
Olivier Robin authored
Change-Id: Iab7bbe97f00eed841465dd27adbb0a3f24164f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090419Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747680}
-
David Roger authored
These histograms are used to monitor the AccountReconcilor, which is a core component of the signin infrastructure. The related histograms should never expire, as they are used to check the health of the system and detect/fix bugs and outages. Fixed: 1037292 Change-Id: I0a66e1afd6d9bd3929b33039894f09daeb81556f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089871 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747679}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c899036d79f7..51afe2e3ccf5 git log c899036d79f7..51afe2e3ccf5 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 petermarshall@chromium.org [docs] Update l10n docs to fix some markup Created with: gclient setdep -r src/third_party/devtools-frontend/src@51afe2e3ccf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01d80c51c6bb888e783ed99f66e36bf702699cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091408Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/582e51453444..9e85398565d3 Created with: gclient setdep -r src-internal@9e85398565d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib42546e9f9fa86bb75de562d5a2c1d5ecedd4222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091407Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747677}
-
Javier Ernesto Flores Robles authored
Verifies that the first responder is valid when the keyboard appears and when a text input ends editing. If not valid, the custom keyboard is paused, else it is resumed. Bug: 1051907, 1058328 Change-Id: I5540ffb2560b798bb6649b71109cfd2b0974e1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088104Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#747676}
-
Mohamed Amir Yosef authored
Bug: 1032992 Change-Id: I91a8aac1d668e42c8e6fe5ae6fd86c86343a2ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089764 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#747675}
-
Milica Selakovic authored
Bug: 1053522 Change-Id: I968877db3dc2e3749c872f748502276002fea07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089680 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747674}
-
Ewann authored
The coordinator now handle PageInfoNavigationCommands which contains commands related to the page info navigation. Now by pressing "site security" item, on the root of page info, a new view related to the site security is presented. Bug: 1038919 Change-Id: I174a011efd532e46187c6403c7a19b79923e8da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089818 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747673}
-
Nico Weber authored
This requires goma client 193. Without it, this will cause every compile job to fall back to local. It was released ~7pm Eastern on Mar 4 2020. Goma should auto-update. You can see your current version in `cat ~/goma/MANIFEST` / `type c:\src\goma\goma-win64\MANIFEST` (the VERSION= line). If it's out-of-date, you can explicitly update with `~/goma/goma_ctl.py update` / `c:\src\goma\goma-win64\goma_ctl.bat update` This flag omits system includes from /showIncludes output. This matches what we do on non-Win (-MMD instead of -MD). We already make sure we compile after system header updates (win sdk, libc++, compiler builtin headers) due to changing the compile commandline after updates, so there's no drawback to using this flag. It reduces the size of .ninja_deps after a full build from 126MB to 49MB, reduces incremental build time by 0.8s on Linux in a cross build (according to faster deps load and fewer stats and a lower average stat time according to -d states, probably because the SDK headers are in a fuse mount with relatively slow stat()ing), and reduces the amount of data that ninja needs to parse out of the compiler during a build of 'chrome' from 1.3GG to 627MB (according to `ninja -t deps`). Since that's on the critical job scheduling path, it probably helps goma build speed too. The flag was added in https://reviews.llvm.org/D75093 Bug: none Change-Id: I7afe7ce2260b86993ba0cef9cb5a3da0b6803aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078738 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#747672}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e47609cf293..e9030e1f5b01 git log 7e47609cf293..e9030e1f5b01 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com Merge "tp: add support for parsing systemTraceEvents from JSON traces" Created with: gclient setdep -r src/third_party/perfetto@e9030e1f5b01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie79971cdcd864736af538ad528a408b3d7bbc4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091409Reviewed-by:
-
Mikhail Khokhlov authored
Last time I accidentally uploaded an outdated trace_processor_shell version that doesn't support all the necessary features. This caused the run_tbmv3_metric test to fail. This CL rolls a new version. Change-Id: Id6256b66a68f709f55cffa4d112011b3f7672b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089827Reviewed-by:
Deep Roy <dproy@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#747670}
-
Oriol Brufau authored
The indices of both implicit grid lines defined with grid-template-areas and explicit ones defined with grid-template-rows/columns used to be stored together in NamedGridColumnLines and NamedGridRowLines. However, this was problematic, because the former indices already refer to the final explicit grid so they don't have to be increased when expanding an auto repeat(), but the latter ones should. Therefore, this patch stores the indices in separate fields and uses the correct logic for each one. BUG=966090 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-005.html TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-006.html Change-Id: I6d423148af0e4dd865f130742f7a927a325cef90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081823Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#747669}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/c7e392d65eb9..c3316f30c075 $ git log c7e392d65..c3316f30c --date=short --no-merges --format='%ad %ae %s' 2020-03-05 dschinazi Replace QUIC_VERSION_99 with QUIC_VERSION_IETF_DRAFT_27 2020-03-05 renjietang Remove static stream checks in QuicSession::OnRstStream() and let static sub-streams handle it. 2020-03-05 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_use_get_handshake_state. 2020-03-05 renjietang Change QuicSession::WriteCryptoData() to QuicSession::SendCryptoData(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie4457ea6de0aab5ae76cf6c69896ac6bb0dce1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090728Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747668}
-
Dominique Fauteux-Chapleau authored
This test validates that the correct message and top image are shown for a given access point and a given scan type. Bug: 1041890 Change-Id: I07ae10fb36b30b9627432bb3c5ac2e976c9e7585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089838 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#747667}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a41937a5321..81cee994e1d2 git log 1a41937a5321..81cee994e1d2 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src c6a4c6d3d8b5..aa95c80e1a89 (2 commits) 2020-03-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 1af57a3ec414..94ed4c384c34 (1 commits) 2020-03-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader a095711c5d77..51b2800bb317 (1 commits) Created with: gclient setdep -r src/third_party/angle@81cee994e1d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Iecf542bbc960c4538e69d0f1dea687c58d79f3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091405Reviewed-by:
-
David Roger authored
These histograms are very useful to understand user behaviors related to signin. It gives information such as their number of accounts, of often they signin/signout and whether their Sync account is also signed into the web. Bug: 1037290 Change-Id: I3cba0ef19bd4c9c6fd14fa614e2ee449f14f7c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089813Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae9641b6d8b4..33be9dfe7a23 git log ae9641b6d8b4..33be9dfe7a23 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 eshr@google.com Replace AdaptCount with a single counter. 2020-03-06 nisse@webrtc.org Move EventWrapper class to target video_coding_legacy. Created with: gclient setdep -r src/third_party/webrtc@33be9dfe7a23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I26b58c17083f88dc11bec8d8766a4a6f2fcfc45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091406Reviewed-by:
-
Rushan Suleymanov authored
Some bridges may generate empty storage key for the new entities. This may happen when the bridge receives invalid data from the server and may lead to inconsistent state of model type processor. In this patch the processor will skip such entities as invalid update items. Bug: 1045641 Change-Id: I4b6dae086192ebe809496b5a7560afaf9bf8b003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083475Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#747663}
-
Hitoshi Yoshida authored
This CL moves handling of generated files for testing from core/BUILD.gn to bindings/core/v8/BUILD.gn. And supports the new code generator case. Bug: 839389 Change-Id: Ie76713167c949e9987a983833d08b6c69c80026d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089561Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
David Roger authored
This histogram is going to be useful in the short term as we are planning ont improving the multiprofile experience. This histogram is an indicator about how often users try to sync with different accounts in the same profile, which is a scenario we want to discourage more in the future. Fixed: 1037289 Change-Id: I195c8c4be447ee858d96f5b4c5d86068d0ec8f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089814Reviewed-by:
-
David Roger authored
This histogram is going to be useful in the short term as we are planning ont improving the multiprofile experience. This histogram is an indicator about how often multiple users share a single Chrome profile, which is a scenario we want to discourage more in the future. Fixed: 1037291 Change-Id: I8d535b28ac8e8354a1c58c6248177721c70a09d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089760Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/* files - chrome/browser/views This CL has no behavior changes. Bug: 1001360 Change-Id: Id955833471664f57d4cf3a42b67a7bacfda54674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089179Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#747659}
-
Tom Anderson authored
The issue can be reproduced by creating and closing windows really fast (like when you're using a tiling WM and dragging tabs and it sort of bugs out). In that case the following was getting hit: CHECK(!swap_closures_.empty()); The solution is to do loop through |swap_closures_| and remove only the matching element. BUG=1057943 R=nickdiego Change-Id: Ib55f6326df6c444adf1bdc6f710785a05cb0d619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090354 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#747658}
-
Ewann authored
The root of the info page consists of a table view, we added a "Site security" item to it. This item indicates whether the site is secure or not and depending on this displays an icon. Bug: 1038919 Change-Id: I29cd0e3b535e44b65837210ce67f40248750da9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087818 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The new feature flag passes --stress-per-context-marking-worklist flag to V8, which instructs the GC to use per-context marking worklist. Bug: 1038180 Change-Id: Ia7255e0ca70129cbaec7b568667a319cec8a743f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089865Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747656}
-
