- 18 Aug, 2020 40 commits
-
-
Guido Urdaneta authored
This reverts commit eb0887d9. Reason for revert: Speculative revert. Will see if it fixes some persistent video failures on Windows. Will reland if the revert doesn't work. Example failed bot: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/106480 Original change's description: > [media/gpu/vaapi/test] Add Vp9Decoder. > > Add basic VP9 decoding for an IVF video stream, with > functionality to save the last decoded frame as PNG. > > BUG=crbug:1062407 > > Change-Id: I0e9272a50e269af658a9427e8b01548443dd467d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296872 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798886} TBR=mcasas@chromium.org,jchinlee@chromium.org,andrescj@chromium.org Change-Id: Id80ba32e2a73aa83dde3bda453fc02e0ddd7d25b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crbug:1062407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362851Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#799092}
-
Jan Krcal authored
This CL makes sure that the profile picker window fits on the current screen. Moreover, it forces the window to be somewhat smaller then the current screen so that it still looks like a dialog window. Bug: 773501 Change-Id: If5fef1920387c6fd421c3b7257426e6bacd6fdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362887 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799091}
-
Sam Maier authored
This is a reland of a0c9fe7f I fixed the dependency checker issue it was causing by disabling it for this new target. Original change's description: > Adding androidx.window to android_deps > > Also fixes warning in android_deps where buildCompile or test targets were > triggering vulnerability errors when they aren't shipped. > > androidx.window is being added to implement Web APIs related to dual screen > and foldable devices. See: > https://groups.google.com/a/chromium.org/g/blink-dev/c/_1_ljYsaqrU/m/qOoHJ7MhAgAJ > > TBR: OWNERS check broken for new android_deps OWNERS file > Change-Id: I350a1f464be2ecb0111004c89aaa87477c7e7e96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354599 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798709} Change-Id: Ibdc2a03727c2234267a237d1c697eb5e4f410a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360225Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#799090}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597708766-1039a8f039b278bc6845dae261350aff5bb3b369.profdata to chrome-mac-master-1597751915-4ae12f45519e9d683fdf6edd45cc3e8b84e80d22.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I93436ab5670d4af124d253d882513710b7a81c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799089}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8cf23871. With Chromium commits locally applied on WPT: 5599375e "[WPT] Only load *.mojom.js through loadMojoResources" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Icc5517f1a6b687566c5f2eb0b277205049552096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362767Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799088}
-
Rohit Rao authored
This reverts commit c0c1dee7. Reason for revert: Continues to crash on iOS 12.4 iPhone X when built with the iOS 14 SDK. Original change's description: > [iOS] Reenable PassKitEGTest/testPassKitDownload > > The test was disabled due to flakiness, but it looks fine on try bots. > > Bug: 1109131 > Change-Id: I9f113a468e5b415344b70510918ef07e791bfd75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354947 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798285} TBR=eugenebut@chromium.org,zhaoyangli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109131 Change-Id: I3adf02d233cbf055858ca6dd37fe8c0bef697903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361845Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799087}
-
Taras Antoshchuk authored
SupervisionTransitionScreenHandler::profile_ field was initialized in ::Initialize method. By the time profile_ was used in ::Show, current active profile was already changed, causing screen handler to interact with wrong profile. This CL moves initialization of profile_ field, to ensure that screen handler interacts with actual current active profile. Bug: 1105127 Test: manual gellerization/degellerization flow Change-Id: Ib2563d3fd7d0910e1b11c3a4962905601950a07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356424Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Taras Antoshchuk <tantoshchuk@google.com> Cr-Commit-Position: refs/heads/master@{#799086}
-
Hirokazu Honda authored
Bug: 1045825 Test: video_encode_accelerator_tests Change-Id: I094d75a21c0d75fe9adb079ec2d31f1179d89edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359853 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#799085}
-
Sigurd Schneider authored
Design doc: http://doc/1ZwBd-j5fEJhSNz3Nry-L7qV4TyOO1erHYRXQ9Cax7mo#heading=h.7nki9mck5t64 Bug: chromium:1051466 Change-Id: I27089c294642178102401696b6154aa731eed69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351992 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799084}
-
Takashi Toyoshima authored
CorsMitigationList and CorsLegacyModeEnabled policies are hidden by default from m84, but still alive in the code behind field trial flags just in case. Now that we ensure that these policies are not needed any more, this patch removes the flags and enterprise policies support completely. Bug: 1053866 Change-Id: Ia4662949d27bb0c9f303fdf8b95973693d1d8ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360053 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799083}
-
Fred Mello authored
https://docs.google.com/document/d/1A0VNbt6MMhJUCxHFgigPGoSqvR_ifRi8TeMcoYm2ZwE Bug: 1112872 Change-Id: I682971f80c3f3f9877f96aa8c8d3c08bfa56f2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360236Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#799082}
-
Side Yilmaz authored
This CL replaces deprecated |createImageFetcher| function by using newer one passing profile.|setProfile| function is triggered on start of application and anytime when profile changes. Therefore, when tab model selector change from regular to incognito mode (or vice versa), |setProfile| is triggered and creates a new image fetcher with the current profile, instead of using always regular profile as today. Bug: 1041781, 1083923, 1075562 Change-Id: If5ed73b133457ca430e9caed9ddf278a3c6c75ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302851Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799081}
-
Robert Ma authored
With https://github.com/web-platform-tests/rfcs/pull/28, we can now use assert_* freely in any (including the first) test function without worrying about turning the test into a single-page test accidentally. This CL takes advantage of that and makes better use of assert_implements to convey failure messages. Change-Id: I328fdbb31195b02e3f97e16cc9f1f1cacbe03f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359163 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#799080}
-
Michael Tang authored
Change-Id: I94d7526807c7204ef13f0ad42a5c95499211c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334005 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799079}
-
Guido Urdaneta authored
This reverts commit f97ca58f. Reason for revert: While the bot got green, the revert did not seem to be the cause. Reverting to confirm. Original change's description: > Revert "Reland "RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive"" > > This reverts commit 49422e89. > > Reason for revert: Speculative revert. > Suspect of causing some failures that report Gpu issues with Wayland. > https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1109 > Will reland if the revert does not fix the bot. > > Original change's description: > > Reland "RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive" > > > > This is a reland of 02aec841 > > > > Speculative revert was incorrect > > > > Original change's description: > > > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > > > > > The relanded CL was reverted due to crashes when used from ARC++: > > > Video Frames coming from this path are not GpuMemoryBuffers, so there's > > > a DCHECK not verified, and then a crash. This CL addresses that > > > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > > > see crrev.com/c/2359734/1..3. > > > > > > Bug: b:163920993 > > > > > > Original RELAND description ------------------------------------------- > > > > > > The original CL was reverted due to crashes in betty initialization: > > > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > > > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > > > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > > > > > TBR=andrescj@chromium.org > > > > > > Original CL description ----------------------------------------------- > > > > > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > > > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > > > error in the tracking of the VASurfaces lifetime in the driver: every > > > time we get a new resource from the pool to decode onto, this is > > > imported into libva as a VASurface: this works fine almost everywhere > > > but doesn't play well in these old platforms (see CreateSurface() body). > > > > > > This CL adds a map that keeps the ref-counted VASurfaces alive and > > > indexed by the unique GpuMemoryBufferId until the VA Context is > > > destroyed. In so doing, we're basically observing the "contract" of > > > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > > > contexts using these surfaces have been destroyed". > > > > > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > > > > > Bug: b:142019786 b:143323596 > > > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > > Cr-Original-Commit-Position: refs/heads/master@{#795026} > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > > > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > > > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > > > Auto-Submit: Miguel Casas <mcasas@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#798931} > > > > TBR=mcasas@chromium.org,andrescj@chromium.org > > > > Bug: b:163920993 > > Bug: b:142019786 b:143323596 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Change-Id: I6124e960d93f6985dbf9a546bc9d34372815e002 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359975 > > Reviewed-by: Fergus Dall <sidereal@google.com> > > Commit-Queue: Fergus Dall <sidereal@google.com> > > Cr-Commit-Position: refs/heads/master@{#798968} > > TBR=mcasas@chromium.org,andrescj@chromium.org,sidereal@google.com > > Change-Id: I5a6c92e18abcfd4d16f67942fa882fdb6cbe4001 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:163920993 > Bug: b:142019786 b:143323596 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362247 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799038} TBR=mcasas@chromium.org,guidou@chromium.org,andrescj@chromium.org,sidereal@google.com # Not skipping CQ checks because this is a reland. Bug: b:163920993 Bug: b:142019786 b:143323596 Change-Id: I17db054c9f09739a3b9486b53bad3bec42af40ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362747Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#799078}
-
Batalov Vladislav authored
There is a moment between requesting manifest and providing the answer when destroying (detaching) of execution context leds to crash. E.g. without waiting for the promise to be triggered, detach the frame by navigating to a different URL. Change-Id: I6cfcfc26daac62d76aa0323f68d315315799a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358739Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799077}
-
Chris Sharp authored
This reverts commit 5db0bd08. Reason for revert: Test is failing on Mac10.14 Tests Original change's description: > [system_health] add infinite scrolling for Twitter using performance.mark metrics > > R=johnchen@chromium.org > CC=cbruni@chromium.org,jdecaires@twitter.com > > Bug: 1114635 > Change-Id: I8d569776bd0f6fdbb656d70172f70c6f08ca3cbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352939 > Auto-Submit: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Tamer Tas <tmrts@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799056} TBR=johnchen@chromium.org,tmrts@chromium.org,tmrts@google.com Change-Id: I15f87c0a0374759a7d12b61415f38c11df60a537 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363067Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#799076}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/688e0966cb16..f9fb0716512d 2020-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a9b199b05c1f to dceaabb18162 (11 revisions) 2020-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from abe07b943855 to 6f74415e2f74 (2 revisions) 2020-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 39dd8685 to 06c431ff (443 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Test: Test: Test: Capture and replay first 1200 frames of COD.Test: Test: MEC capture of COD:Mobile Change-Id: I32d45e253386a9d606074388f67a682fff92f7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799075}
-
Hirokazu Honda authored
Since the test checks the frame qualities, the test fails if the bitrate is low. This CL increases the default bitrates so that an hardware-accelerated video encoder can produce sufficiently good quality stream. Bug: 1045825 Test: video_encode_accelerator_tests on rammus Change-Id: I3282ce3dfda996e7002b894f4dbfac16081f693b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358727Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799074}
-
Side Yilmaz authored
This CL replaces deprecated |IdentityServiceProvider#getIdentityManager| with the newer getter with profile parameter. PickerAdapter provides contacts for contacts picker by using email info coming from identity manager. Since this is read only operation, this CL always passes |Profile#getLastUsedRegularProfile| to be able to provide contacts information even in incognito mode. Note: This is only clean up and does not change any code behaviour. Bug: 1041781, 1075562 Change-Id: I05c9ded3d5ca1f878bbd855c123d04362dc97a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340963Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799073}
-
Illia Klimov authored
Since permission delegation is enabled by default and soon the feature flag will be removed, we simplify the indicator bubbles for geolocation and midi_sysex since the top frame is the one that is responsible, and delegates feature availability based on its access to said features. Bug: 1090541 Change-Id: I49b3e0175ceaae4dcda96d01cf61dcad0dbaaafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346386 Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799072}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/384ea8475558..297207f64cc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1103274,chromium:1105096,chromium:1112687,chromium:1113795,chromium:1114862,chromium:1115022,chromium:1115826 Tbr: guidou@google.com Change-Id: I983adcdfbdb7afd184bd65bc8dca519392a067ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799071}
-
David Roger authored
This CL adds histograms recorded when the signin interception bubble is closed. Histograms for enterprise interception: Signin.Intercept.Enterprise Signin.Intercept.Enterprise.Sync Signin.Intercept.Enterprise.NoSync Signin.Intercept.Enterprise.NewIsEnterprise Signin.Intercept.Enterprise.PrimaryIsEnterprise Histograms for multi-user interception: Signin.Intercept.MultiUser Signin.Intercept.MultiUser.Sync Signin.Intercept.MultiUser.NoSync Histograms for profile switch interception: Signin.Intercept.Switch Signin.Intercept.Switch.Sync Signin.Intercept.Switch.NoSync Bug: 1076880 Change-Id: I4de93ed7d872325608eb829fb6d1cec1b69c7d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352649Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799070}
-
Marc Treib authored
Bug: none Change-Id: I2499bc3c0c78e19bad3c67341d90dae74d2c0cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360269 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#799069}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5cd6ab4d06b18ac8ade0eddbc9876e30b1dd9db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362082Reviewed-by:
Krishna Govind <govind@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#799068}
-
Jinsuk Kim authored
This CL adopts SceneOverlay for overscroll glow effect. Previously the glow effect was rendered on a cc layer attached to the current WebContent's cc layer. This requires that the WebContents be used as View property, and swapped for every tab/WebContents change. Rendering it on scene overlay saves us from maintaining the logic above, and having to use the heavy object like WebContents for MVC view properties. Bug: 1112573 Change-Id: I0b80c7e78007051d2d94c76a14dcd265cb0607c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351267Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#799067}
-
dpapad authored
- Change border width to 4px (previously 6px). - Change color to google-blue-refresh-300 (previously google-blue-refresh-700) Both changes are according to the mocks. Bug: 1110756 Change-Id: I8b5fbac0f12448e80931d104e3af23eb51d687fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358887 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799066}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1756465158d3..b6a272ffee65 2020-08-18 hjd@google.com Git ignore libbase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifdf3eacf002ddf320a9e4e9566c89712ebc91cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362507Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799065}
-
Alice Wang authored
This CL sets up the sign-in general error UI screen when web sign-in encounters some general error like connection failed. Bug: 1114589 Change-Id: I5f2784283be1e49c715840ee03fab8b7af864cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360074Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799064}
-
Takashi Toyoshima authored
As the fyi bots were turned down, this flag specific expectation is not needed any more. Bug: 1116928 Change-Id: I1f5f9498a7f6acc9dd338971002174bac0e659e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362064 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#799063}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596045560-6c3207dc8f6ea5df1e0c422b4fa4d700088c0a24.profdata to chrome-win64-master-1597599037-37d4838cd87f22a0e9d22daa07afdb6346a7ed70.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1cd60abe10854e0892ff6aa2e871acbddf5829e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360423 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799062}
-
Vasilii Sukhanov authored
The test should wait until the password value is autofilled instead of checking immediately. Bug: 1116886 Change-Id: I69c851d9cfa462d4638a763b079feb08eaaaafea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359082Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799061}
-
Anatoliy Potapchuk authored
During profile startup, some of the a11y preferences were not reset -- those related to the mutualof tts engines used by extensions. Here we reset them as well. Bug: 1049566 Change-Id: If4c57cc3a165871eaa812af58e6d698c25be36e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360018Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799060}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/863115fb49d7..8150670ddd8d 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b8de4f57e983 to e28436f2b8a2 (3 revisions) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 527e67e9d933 to 30b3f3857835 (13 revisions) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c1db3b8e7960 to 9d431ae2eeb4 (1 revision) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from abe07b943855 to 6f74415e2f74 (2 revisions) 2020-08-18 jmadill@chromium.org Vulkan: Clean up handleDirtyTexturesImpl. 2020-08-18 jmadill@chromium.org Vulkan: Clean up ImageHelper barrier functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I7163ccc4f979f41987326e8da920af8c145d2e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799059}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596045560-16c58258c8890a214570e6099d355ac47072ea3d.profdata to chrome-win32-master-1597611060-adf0ab6d7715dfdb592c8864718732c417ac4f3f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If9dc8e7727d55351af0f5b5d88ecc0744c1bbf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799058}
-
Michael van Ouwerkerk authored
Change-Id: I75b5f69130559ad2cc70cc26aa61807f0697bc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352947Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799057}
-
Tamer Tas authored
R=johnchen@chromium.org CC=cbruni@chromium.org,jdecaires@twitter.com Bug: 1114635 Change-Id: I8d569776bd0f6fdbb656d70172f70c6f08ca3cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352939 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799056}
-
Jan Krcal authored
This CL adds a 2px circular border around the avatar image (in the new design). To simplify the code, it also reimplements the margin between the avatar and the titles below. After this CL, it is a top margin of a new container around the titles. Bug: 1099286 Change-Id: I95081776193335e0d17a6b7451cbca40ec132d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360276 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#799055}
-
Sergei Datsenko authored
Set up bidirectional communication between WebUI page and the backing browser and set up a "hello world" example. Bug: 1111229 Change-Id: I8a8ad38a02952a13a69723f33f5fbaa2fdf195d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353970 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799054}
-
Zhuoyu Qian authored
This CL rename Web IDL |Unforgeable| to |LegacyUnforgeable| to make its usage more clear. Bug: 1072773 Change-Id: I534ee3610f5e866ed4aa14ffcd6b6f6a90d648ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351603Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#799053}
-