- 16 Oct, 2019 2 commits
-
-
John Emau authored
Marking the checkbox container as a group role and labeling it meets the following WAI WCAG 2.1 success criteria and allows for screen readers to announce the group label when focusing on a checkbox. 1.3.1 Info and Relationships - Level A https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships 3.3.2 - Labels or Instructions - Level A https://www.w3.org/WAI/WCAG21/quickref/#labels-or-instructions Screenshot (NVDA Speech Viewer): https://i.imgur.com/ptmRGzu.png Screenshot (Accessibility Tree): https://i.imgur.com/EUTyhTV.png Bug: 963183 Change-Id: Ia801a9a74ca897b6bc94705d72109bd231b00653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695853Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706228}
-
Andrey Kosyakov authored
Bug: 859382 Change-Id: I42dcd7219cb0dba659f201d022444265a6a4b183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864012Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706227}
-
- 15 Oct, 2019 38 commits
-
-
John Emau authored
Previously the accessible name for the audio context selector was 'BaseAudioContext'. With this change the accessible name becomes `Audio context: ${content title}` and if no context is selected: `Audio context: (no recording)`. This is a much better experience for screen reader users and meets success criteria for WCAG 2.5.3 Label in Name https://www.w3.org/WAI/WCAG21/quickref/#label-in-name Test page: https://mdn.github.io/webaudio-examples/audiocontext-states/ Screenshot (NVDA Speech Viewer): https://i.imgur.com/m5pKYnx.png (NOTE: This screenshot was taken with https://crrev.com/c/1626643 applied to better screen reader support) Screenshot (Accessibility Tree): https://i.imgur.com/e04n8m9.png Bug: 963183 Change-Id: I89e14599313766e7bd2be8a6a953df28c648dbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711008Reviewed-by:Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706226}
-
Ahmed Mehfooz authored
Change-Id: Id28394f3d11e190c58b05e37dbdfbef34d95a7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862857 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706225}
-
Daniel Rubery authored
This CL allows the user to select "open now" to open a download, while the deep scanning is still pending. This is important for enterprises which don't want the large increase in user friction caused by blocking access to the file. New UI screenshots: https://screenshot.googleplex.com/xwXViHi2u3R.png https://screenshot.googleplex.com/RE102LjRAA2.png Mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0 Bug: 980777 Change-Id: I8a2e6844ff5ab68c4faa3e75a0e4eed2064a3be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848357 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706224}
-
Peng Huang authored
Bug: 1012878 Change-Id: I9c4c887d9fb5465d38da1cabbe1b52437235f948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863468Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706223}
-
Nate Fischer authored
This is a roll using my internal change to the exporter script (http://cl/274893271). The main motivation is to roll the change to the BUILD.gn file (to get the proto_java_library target), although this also rolls miscellaneous proto changes which have landed since the last roll. Bug: 1011991 Test: None Change-Id: Ibcbe003f0c386bd2081944c77ecc26a3cd88d559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862727 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#706222}
-
Greg Kerr authored
As the macOS GPU sandbox now allows LaunchServices connections, remove the API call telling it not to connect to LS. Bug: 871280 Change-Id: Ic70da6796b6980c60c2e9ebdd897ccd4f588ea9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863630 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#706221}
-
Joel Hockey authored
Use the attached browser CreateParams rather than BrowserList GetLastActive. It feels safer that the attached browser will always be the one that we want whereas BrowserList GetLastActive may not be so reliable. Bug: 1012169 Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706220}
-
Robert Sesek authored
With the Service Manager going away, the manifest files that previously mediated access to Mojo services across processes are going away too. Under the new system, various //content classes have methods that bind mojo::Receiver<T> objects via GenericPendingReceiver. Since these call sites control access to objects across a privilege boundary, they should be under the SECURITY_OWNERS review system. This first pass splits out several //content and //chrome ones, but more to come. Bug: 1012033 Change-Id: Ic09c825c8503c570393fa7ce4d89b58bb6efe391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848416 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#706219}
-
David Van Cleve authored
This patch is one of a series of changes adding support for resolving ESNI DNS responses [1] to the built-in resolver. It contains - a new RecordRdata subclass representing an ESNI record - relevant parsing logic for ESNI-type RDATA - unit tests exercising this parsing logic A follow-up CL will contain additions to HostResolverManager and HostCache to handle parsed records of the new type and propagate the results up the callstack. [1]: https://tools.ietf.org/html/draft-ietf-tls-esni-04 R=ericorth Bug: 1003494 Test: Added unit tests to record_rdata_unittest.cc Change-Id: Ib4446b46b19633fba92a8d14d34cf2f38ed14d1d Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845793 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706218}
-
Peter Kasting authored
Invalidate() is called more frequently (e.g. on color changes), while SetMatch() is called only when the match actually changes. So anything that is tied to the match's content (e.g. the suggestion or keyword contents/description) can be updated in SetMatch() instead of Invalidate() to save work without visible change. Also tweaks Layout() to check the keyword view's visibility instead of the underlying state that controls it. Bug: none Change-Id: Ia0b7ca2566a621ad9315e54313f584c21f999668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857649Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706217}
-
John Budorick authored
This reverts commit 2fcffb28. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1014742 Original change's description: > Record latency for Impl thread in case of no begin main frame. > > This CL reports the latency in case of no begin main frame. > This can happen in any of the scenarios below: > > 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame > > 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted -> > DidFinishImplFrame -> DidSubmitCompositorFrame > > 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame -> > BeginMainFrameAborted -> DidSubmitCompositorFrame > > In these cases there will be no latency to report for stages of: > - SendBeginMainFrameToCommit > - Commit > - EndCommitToActivation > But the latency will be reported for the remaining stages. > > Bug: chromium:1003038 > Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705964} TBR=sadrul@chromium.org,behdadb@chromium.org Change-Id: Ide47f697ba94bdaf4b89564272afe1d7634296c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1003038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863840Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706216}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f18342d8..65084e6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic501f15c5258d482064f35e802a2e5281b5e6055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863435Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706215}
-
Jimmy Gong authored
- Introduces a Show more button that expands the printer list and shows the complete printer list. - With this change, we only show the first 3 saved printers while the rest are hidden beneath a "Show more" button. - Adds browser test to test all corner cases with the list behavior. Bug:993822 Test: end to end manual, browsertest Change-Id: Ia2128482b02ce759fa94cf9345473664b37877bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808079 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#706214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0fba1fdff325..9c927784e714 git log 0fba1fdff325..9c927784e714 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org gconv_strip: port to python3 & new ahocorasick module Created with: gclient setdep -r src/third_party/chromite@9c927784e714 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I371aeeea792bbba704798fe6ae979ee6d3abbb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706213}
-
Haiyang Pan authored
Currently the builder test-n-tablet has flaky test failure due to timeout in apk installation. Adding logging to see which apk spent the most time. This CL can be reverted after the issue 1004322 is resolved Bug: 1004322 Change-Id: Ic51694add3666aa0e0442cb6f8c11131e04ae13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859904Reviewed-by:
-
John Emau authored
This change expands existing screen reader capabilities of the quick open dialog by replacing the use of aria alert with standard ARIA attributes: role=combobox/listbox/option, aria-activedescendant, and aria-autocomplete. The effect is the screen reader announces the selected options and their position in the results, giving the user the total result count. This change follows the WAI ARIA guidance: https://www.w3.org/TR/wai-aria-1.1/#aria-autocomplete Screenshot (NVDA Speech Viewer): https://i.imgur.com/4vJkHfq.png Bug: 963183 Change-Id: I5c3b1b1f80c0a11defdfd66a4b6860df75e5e717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737872Reviewed-by:
-
Avery Musbach authored
When the MultiDisplayOverviewAndSplitView feature flag is enabled, every root window controller shall own a split view controller. Note: Code that ends clamshell split view generally shall do so just by ending overview, with no opportunity to specify a SplitViewController::EndReason like kPipExpanded. As kPipExpanded behaves no differently from kNormal anyway, the present CL simply removes kPipExpanded. Test: ash_unittests SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.* Bug: 970013 Change-Id: I2fba66bd2bdd006908bbd1ec023a9bb87e3e57ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856869Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#706210}
-
Torne (Richard Coles) authored
This method (now) just wraps ContextUtils.activityFromContext and adds a trace, but it's not used consistently. The trace was added to diagnose performance issues caused by class verification failures, but we should have this under control now. Change-Id: I2415cd99f0e9f337956888918388d36aaf6d05af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862729 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706209}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4615c7b252f1dca946dfd35bb93a837bb0d5f0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862263Reviewed-by:
-
Johann authored
Removing these caused build errors because assembly files don't properly depend on header files. Change-Id: I00f4b7a47a8965ea7261a415230d19146f0940b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862726 Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#706207}
-
Parastoo Geranmayeh authored
GeolocationBrowserTest.PromptForOffTheRecord TBR=benwells@chromium.org Bug: 1014506 Change-Id: Ia9e5f5ae9554ab4d49dfa981f6decaa7a1c29c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863031 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706206}
-
Owen Min authored
Once user requests an extension, the extension id will be stored in the Profile's pref until: 1) User cancels the request. 2) Admin approves or deny the request. Bug: 1006899 Change-Id: Id003bfceb9d67dfe685ee75926f792f2444469da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856800 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#706205}
-
Andrew Luo authored
This is a reland of 850e8d2b Original change's description: > Add withTextString, withDescString locators, and some refactorings. > > Refactorings include replacing *ByIndex with withIndex wrapper, renamed > locators that take variable number of resource ids to have "Any" in the name, removed > unnecessary params in the Page Controller tests build target. > > Bug: 924194 > Change-Id: I0a2b01c4d1d7ca52243988c8f028553135843441 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846480 > Commit-Queue: Andrew Luo <aluo@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703953} Bug: 924194 Change-Id: Iac3c3d0f7150704068e432b3402ad4397f471aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854644Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
-
Yuwei Huang authored
This CL removes the no longer used host service script and updates installer and other plist to use the new script. Locally tested both fresh install and upgrade from M78 host and both scenarios work. Bug: 1013692, 10142116 Change-Id: If59e6a16fd1c3f86bfb76ddb5fbf850874d389a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863735Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#706203}
-
David Benjamin authored
It's still in //crypto, but now it's a bit more self-contained. Bug: 125848 Change-Id: I8596aa9f66630625234206986636edcb29853c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857046 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706202}
-
Tomasz Wiszkowski authored
Change-Id: I7b8c12ad22ed4d70218012448b8aa9f087a65238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835658 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#706201}
-
Kevin McNee authored
This reverts commit 5d01e87e. Reason for revert: Caused regression https://crbug.com/1014385 Original change's description: > Define guest view custom elements synchronously > > Previously, we've had to wait for readystatechange before defining > the guest view custom elements because > 1) there were circular dependencies that would cause errors if we > tried to perform the definition immediately, and > 2) the Custom Elements V0 registration context was scoped to the > document rather than the window, so if we defined the elements > while the document was still on about:blank, the definition would > be available on about:blank, but not for the extension. > > Now that the circular dependencies are fixed and guest view is > migrated to Custom Elements V1 (whose registration context is > scoped to the window), it is no longer necessary to wait for > readystatechange. > > We now perform the definition immediately. > > Bug: 810012 > Change-Id: Ib5e8ba6f4e302eaae56c5566765521d64b1a0e15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1278287 > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700425} TBR=wjmaclean@chromium.org,mcnee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 810012, 1014385 Change-Id: Ie43a88bc07036fc392079cc8f2593e28440de104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863691Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706200}
-
Gavin Williams authored
-In error input scenarios, current implementation will display useful error text but is not read out by screen readers. This change forces these alerts to be read by screen readers. Bug: 1012532 Change-Id: Iadd263d17bf648660f6e365495093543cab86666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854529Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Aga Wronska authored
The feature is enabled since July 2018. Bug: 1013650 Change-Id: I23fdbb2a15ec68c6fc7f975c1d800dacb85ca5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857197Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#706198}
-
Tomasz Wiszkowski authored
The embedded change updates prefetch fake page classification from NTP to INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS to allow the request to be correctly categorized by ZeroSuggestProvider in cases where ZeroSuggestVariant:6 parameter (for INSTANT_NTP...) includes RemoteNoUrl source, whereas ZeroSuggestVariant:1 parameter (for NTP) doesn't. Bug: 1004932, 1004925 Change-Id: Ia797b490b90f1b596b1e175c91d37c975b0d45e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861099 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706197}
-
Marcin Wiącek authored
Add missed entry. Change-Id: I59d8ae5d67b42f8ea5cb52cae56d82db819ff8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829264Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#706196}
-
Lukasz Anforowicz authored
imported/wpt/html/syntax/parsing/html5lib_tests19.html used to be disabled in presence of site-per-process / Site Isolation, because it might trigger a crash. It seems that the crash is not happening anymore, so let's try removing the Crash/Failure expectations for the test from TestExpectations. This also means that running the test via not-site-per-process virtual test suite is not needed anymore. Note that this CL does not modify html5lib_tests19-expected.txt - some test cases inside tests19 are expected to fail. This expectation came from the very beginning - when WPT were being imported in https://codereview.chromium.org/1164243002 Bug: 645641 Change-Id: Ib0584faac35f09703821c441fdca10726ceb0d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863539 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706195}
-
tby authored
Because the Drive QuickAccess API starts up quite slowly, our attempt to warm the cache almost always fails. Let's remove it. Bug: 1011221 Change-Id: I59b4d3c1a24a81f5c343dd8d26c1f15442fe9876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861796 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706194}
-
Gabriel Charette authored
TBR=dcheng@chromium.org Bug: 992483 Change-Id: I20ab6c566d22994fd098a06e625aa9e7f1173e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863752Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#706193}
-
Robert Ma authored
The only remaining match was a dead link in common/net/file_uploader.py, which has been replaced with a permalink (pinned to the correct line & revision) to GitHub. Bug: 770329 Change-Id: I89d15897882c8e5b0d73ff61ff401c7f47ff6924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863072 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706192}
-
Wenbin Zhang authored
Currently most of the presubmit checks are following a similar routine. Per discussed in the following CL, we should refactor those functions. https://chromium-review.googlesource.com/c/chromium/src/+/1850353 Bug: 1006771 Change-Id: I380c9793f446b0c6e8ab814381b797d5f12ffff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857239 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706191}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43253cb0a391..a6dd74cc6ed0 Created with: gclient setdep -r src-internal@a6dd74cc6ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005965,chromium:None Change-Id: I3c7db353aef526dc4f64dfcd1ff8638a12355ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706190}
-
Peter Kasting authored
This simplifies the reasoning about when these are present, and will make managing them with a layout manager slightly easier. Bug: none Change-Id: I5868dbb31bd4022010936611fe794185014e878d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857195Reviewed-by:
-
