GitLab

Cr-Commit-Position: refs/heads/master@{#418796}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812

Review-Url: https://codereview.chromium.org/2341693002
Cr-Commit-Position: refs/heads/master@{#418795}

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.

Review-Url: https://codereview.chromium.org/2334293002
Cr-Commit-Position: refs/heads/master@{#418794}

This reverts commit d0125b8f.

Reason:
Warnings from ServiceWorkerGlobalScope doesn't show up in devtools' console

BUG=594160
TBR=eostroukhov, pfeldman

Review-Url: https://codereview.chromium.org/2344813002
Cr-Commit-Position: refs/heads/master@{#418793}

There isn't much support from platforms and devices for GATT over BR/EDR so
to avoid confusing users and wasting power, perform a LE scan only.

BUG=643625

Review-Url: https://codereview.chromium.org/2339033003
Cr-Commit-Position: refs/heads/master@{#418792}

Revert of Temporary: Detect WebSocket destruction order problem (patchset #2 id:20001 of https://codereview.chromium.org/2315213002/ )

Reason for revert:
We have learnt everything we are going to learn
from this CHECK. Reverting as intended.

This does not need to be relanded.

Original issue's description:
> Temporary: Detect WebSocket destruction order problem
>
> Add a CHECK() to crash the browser if a destruction order problem is
> encountered.
>
> This will be reverted once the information is collected.
>
> BUG=641013
>
> Committed: https://crrev.com/23169a0f5421e6759d89b1feaa83b06b197a7039
> Cr-Commit-Position: refs/heads/master@{#417522}

TBR=yhirano@chromium.org,mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=641013

Review-Url: https://codereview.chromium.org/2340253002
Cr-Commit-Position: refs/heads/master@{#418791}

Revert of Set crash key if WM_QUIT message is received on GPU message loop. (patchset #2 id:20001 of https://codereview.chromium.org/2342713002/ )

Reason for revert:
Forgot key registration.

Original issue's description:
> Set crash key if WM_QUIT message is received on GPU message loop.
>
> Threads seem to be exiting unexpectedly, so to help debugging set a
> crash key if an unexpected WM_QUIT message is received.
>
> BUG=647068
>
> Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c
> Cr-Commit-Position: refs/heads/master@{#418753}

TBR=dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647068

Review-Url: https://codereview.chromium.org/2339123003
Cr-Commit-Position: refs/heads/master@{#418790}

Based on the experiments, ThinLTO does not scale beyond that,
and the default setting is the number of cores on a machine, which
is often 32 or more for Chrome devs, where ThinLTO is slower than at 16:
https://docs.google.com/spreadsheets/d/18vi9p8ffIYNVPTyxtJwr-YrP4WJRbaQr_2nZ1AKKBs4/edit?usp=sharing

BUG=645295

Review-Url: https://codereview.chromium.org/2341983002
Cr-Commit-Position: refs/heads/master@{#418789}

This is the first step in making this element usable by WebUI pages
other than MD History.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2282403005
Cr-Commit-Position: refs/heads/master@{#418788}

BUG=616322

Review-Url: https://codereview.chromium.org/2344793002
Cr-Commit-Position: refs/heads/master@{#418787}

BUG=402536

Review-Url: https://codereview.chromium.org/2340453002
Cr-Commit-Position: refs/heads/master@{#418786}

Previously the partial magnifier border was difficult to see on white colored backgrounds. I add a textured layer instead of a solid color, so the border is outlined in black, so that it is visible on all backgrounds.

BUG=638996
TEST=none

https://screenshot.googleplex.com/htWDLX1Bxdp

Review-Url: https://codereview.chromium.org/2269383002
Cr-Commit-Position: refs/heads/master@{#418785}

This patch removes NonValidatingReloadOnRefreshContent entry that was
already replaced with V2, and adds NonValidatingReloadOnNormalReload as
I did for desktops before.

BUG=591245

Review-Url: https://codereview.chromium.org/2344503002
Cr-Commit-Position: refs/heads/master@{#418784}

Basically,
- components/memory_coordinator/public/interfaces -> content/common
- components/memory_coordinator/common -> content/common
- components/memory_coordinator/browser -> content/browser
- components/memory_coordinator/child -> content/child

BUG=644022

Review-Url: https://codereview.chromium.org/2321313002
Cr-Commit-Position: refs/heads/master@{#418783}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2339683005
Cr-Commit-Position: refs/heads/master@{#418782}

After https://codereview.chromium.org/2270463002,
gl::init::GetAllowedGLImplementations assumes GetSurfaceFactoryOzone to
be non-null on the GPU side. The remaining Ozone platform violating
this assumption is addressed in this CL.

BUG=640613
R=rjkroege@chromium.org

Review-Url: https://codereview.chromium.org/2346433002
Cr-Commit-Position: refs/heads/master@{#418781}

Exiting overview mode may leave overview header widget still animating.
It is important not to attempt any window manipulation such as
re-stacking when the animation completes because the affected windows
may be gone by then.

BUG=646350
TEST=WindowSelectorTest.SafeToDestroyWindowDuringAnimation

Review-Url: https://codereview.chromium.org/2337383003
Cr-Commit-Position: refs/heads/master@{#418780}

This is a temporary fix until Dirk can change the closure_compilation
uses of gyp_chromium correctly.

Stolen from Dirk Pranke <dpranke@chromium.org> and stripped of 'includes':
https://codereview.chromium.org/2331423005/

TBR=brettw@chromium.org, dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=646969

Review-Url: https://codereview.chromium.org/2345503005
Cr-Commit-Position: refs/heads/master@{#418779}

Only perform media scanning if a scan has not been performed since the file update event.

Building up the timestamp map is also moved off the FILE thread and on to the blocking pool.

BUG=628223
TEST=create a large (~10k) set of files under /home/chronos/user/Downloads
Enable ARC++
create a profiler snapshot at chrome://profiler
create one more new file under Downloads
Create another snapshot in chrome://profiler
Verify that there are no long-running tasks on the FILE thread, and that DelayBuildTimestampMap is only called once.

Review-Url: https://codereview.chromium.org/2310833002
Cr-Commit-Position: refs/heads/master@{#418778}

This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use
w3c test harness to simplify test script for improving
code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2333193002
Cr-Commit-Position: refs/heads/master@{#418777}

This patch fixes BreakingContext::rewindToMidWordBreak to set
m_currentCharacterIsSpace correctly when it rewinded m_current.

Not doing so sets previousCharacterIsSpace incorrectly, and can
collapse whitespaces that should not be collapsed.

BUG=639781

Review-Url: https://codereview.chromium.org/2334143002
Cr-Commit-Position: refs/heads/master@{#418776}

BUG=642302,28515
TEST=as in bug 642302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2339673002
Cr-Commit-Position: refs/heads/master@{#418775}

This CL added code to show an icon for connected device in the
chooser, and show "Paired" text below the device name if the
device is paired.

I uploaded some screenshots in the issue page.

BUG=543466

Review-Url: https://codereview.chromium.org/2304213002
Cr-Commit-Position: refs/heads/master@{#418774}

The DesktopEngagementService measures session length times on desktop.
Its name is very similar to the SiteEngagementService, which measures
how much user interaction a site has in total. This CL renames
DesktopEngagement* to DesktopSessionDuration* to clarify its role and
make it more distinct from Site Engagement.

BUG=646216

Review-Url: https://codereview.chromium.org/2333113002
Cr-Commit-Position: refs/heads/master@{#418773}

https://chromium.googlesource.com/skia.git/+log/95573e4865c9..14e7a602d0ca

$ git log 95573e486..14e7a602d --date=short --no-merges --format='%ad %ae %s'
2016-09-14 djsollen Revert of Bundle common arguments to GrGradientEffect creation (patchset #2 id:20001 of https://codereview.chromium.org/2332213007/ )
2016-09-14 fmalita Fix SkDrawTextBlobCommand null blob crash
2016-09-14 egdaniel Update GN droid script
2016-09-14 fmalita [SVGDom] Expose intrinsic size info
2016-09-14 msarett Don't let the compiler complain that |a| is uninit
2016-09-14 egdaniel Disable ignore discard optimization in Vulkan
2016-09-14 mtklein CQ update
2016-09-14 mtklein GN: add is_official_build
2016-09-14 mtklein merge run and check-rc steps
2016-09-14 msarett Store SkColorSpaceXform gamma LUTs in a malloced field
2016-09-14 mtklein 565 is not this important.
2016-09-14 msarett Convert back to 0-255 scale before storing linear bytes
2016-09-14 fmalita Improved optional command handling in SkParsePath::FromSVGString()
2016-09-14 brianosman Bundle common arguments to GrGradientEffect creation

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2341993002
Cr-Commit-Position: refs/heads/master@{#418772}

Prevents a page from reading or resetting the pose of a
device which is currently being presented to by a
different page, as that potentially creates an
information leak between pages.

Also prevented pages from beginning presentation if another page is already presenting to a device. This is a
little overly aggressive right now, as disallows
presentation to more than one device at a time from any
page, but that's a reasonable limitation at this point
given the rarity of VR hardware.

BUG=389343

Review-Url: https://codereview.chromium.org/2329893002
Cr-Commit-Position: refs/heads/master@{#418771}

The following tests are converted to use testharness.js
from js-test.js in LayoutTests/shadow-dom/.

* attach-shadow-with-parameter.html
* focus-slide-on-shadow-host.html
* focus-shadowhost-display-none.html

For attach-shadow-with-parameter.html, I added some return
value checks, but otherwise almost straightforward conversion
to testharness.js API.

Review-Url: https://codereview.chromium.org/2333623003
Cr-Commit-Position: refs/heads/master@{#418770}

Cr-Commit-Position: refs/heads/master@{#418769}

BUG=

Review-Url: https://codereview.chromium.org/2332193003
Cr-Commit-Position: refs/heads/master@{#418768}

Converts Presentation API to use KURL/WebURL in place of string types for availability and presentation URLs.  Removes several conversions.

BUG=632623

Review-Url: https://codereview.chromium.org/2327993002
Cr-Commit-Position: refs/heads/master@{#418767}

This is the first CL to move memory_coordinator outside components/.
Also, per discussion on [1], this CL removes MemoryCoordinatorClient
from HistoryBackend. We can re-add it if needed.

[1] https://codereview.chromium.org/2297243004/#msg14

BUG=644022

Review-Url: https://codereview.chromium.org/2311723002
Cr-Commit-Position: refs/heads/master@{#418766}

This patch does the plumbing from the animationworklet to the globalscope to import scripts etc.

BUG=567358

Review-Url: https://codereview.chromium.org/2312493002
Cr-Commit-Position: refs/heads/master@{#418765}

This patch converts "editing/inserting/insert-div-010.html" to use w3c test
harness to simplify test script for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2338223002
Cr-Commit-Position: refs/heads/master@{#418764}

This patch converts "editing/inserting/insert-div-009.html" to use w3c test
harness to simplify test script for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2340713002
Cr-Commit-Position: refs/heads/master@{#418763}

For custom built-in elements:

https://html.spec.whatwg.org/multipage/scripting.html#element-definition

7. If an element interface is provided for the extends option, it is assumed to be a customized built-in element.

7.1. If element interface is valid custom element name, throws NotSupportedError DOMException
     https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

7.2. If element interface is HTMLUnknownElement, throws NotSupportedError DOMException
     https://html.spec.whatwg.org/multipage/dom.html#elements-in-the-dom:element-interface

7.3. localName set to extends value and not the define-name

A -expected.txt file was included since this isn't implemented yet.

BUG=

Review-Url: https://codereview.chromium.org/2321363002
Cr-Commit-Position: refs/heads/master@{#418762}

1. attributeChangedCallback should be fired only from
the elements in observedAttributes
2. Checks for cases when converting observedAttributes
to sequence<DOMString> should throw TypeError
https://heycam.github.io/webidl/#create-sequence-from-iterable

BUG=643049

Review-Url: https://codereview.chromium.org/2321903003
Cr-Commit-Position: refs/heads/master@{#418761}

WebShare.ApiCount is needed (in addition to the existing use counter) to
get the total number of calls to the API, not de-duplicated per page
view.

BUG=636288

Review-Url: https://codereview.chromium.org/2228403002
Cr-Commit-Position: refs/heads/master@{#418760}

These buttons will appear in same toolbar as "Add background-color" and
"Add color."

BUG=639095

Review-Url: https://codereview.chromium.org/2324313002
Cr-Commit-Position: refs/heads/master@{#418759}

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746

Review-Url: https://codereview.chromium.org/2331453004
Cr-Commit-Position: refs/heads/master@{#418758}

* Mark collectChildrenAndRemoveFromOldParent |inline|
  There is only one callsite.

* collectChildrenAndRemoveFromOldParentWithCheck() returns bool
  It makes callsites simpler.

* We don't need to return |nullptr| in a case of hadException().
  Callsites should check hadException() before referring the return value.

* Remove useless local variables.

* Use functors in parseInsertBefore() and parserAppendChild().

This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2343513002
Cr-Commit-Position: refs/heads/master@{#418757}