GitLab

It turns out that
roundedIntPoint(LayoutUnit::max()) != LayoutUNit::max()
so disable the assert in BackgroundImageGeometry that is really just
checking that we have pixel snapped the phase. We don't check any other
values for pixel snapping, so there's no reason to keep checking phase.

And there's no danger to having an unrounded value here. Nothing breaks.

R=fmalita@chromium.org
BUG=626745

Review-Url: https://codereview.chromium.org/2180433002
Cr-Commit-Position: refs/heads/master@{#407255}

https://chromium.googlesource.com/chromium/src/+/81de34207

BUG=526594
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2173053003 .

Cr-Commit-Position: refs/heads/master@{#407254}

BUG=572726
TBR=caseq@chromium.org

Review-Url: https://codereview.chromium.org/2174893002
Cr-Commit-Position: refs/heads/master@{#407253}

https://chromium.googlesource.com/skia.git/+log/4c6e47a8a827..f1491693527a

$ git log 4c6e47a8a..f14916935 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 bungeman Correct advances for 'monospace' fonts in PDF.
2016-07-22 mtklein Add SkRasterPipeline blitter.
2016-07-22 brianosman Bundle SkShader::asFragmentProcessor arguments in a struct
2016-07-22 caryclark limit number of searched roots

BUG=630649

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2180483002
Cr-Commit-Position: refs/heads/master@{#407252}

Goma builds necessarily don't use PDBs. That means that symbols have to be put in .obj files. This means that symbols get stored redundantly, which makes the job of the linker much harder - greatly increased linker working sets and greatly increased link times.

gyp deals with this by disabling symbol generation in the compile stage for goma builds. gn has not been doing this, which has made gn goma builds *significantly* slower, unless symbol_level is explicitly set to 1.

gyp has an override switch (win_z7) but it appears that nobody uses it so for now I am leaving it unimplemented in gn.

BUG=630074

Review-Url: https://codereview.chromium.org/2174873002
Cr-Commit-Position: refs/heads/master@{#407251}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/20358d6bf8c9..07aa51b63e8c

$ git log 20358d6bf..07aa51b63 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2176783002
Cr-Commit-Position: refs/heads/master@{#407250}

BUG=None

Review-Url: https://codereview.chromium.org/2173543002
Cr-Commit-Position: refs/heads/master@{#407249}

This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.

BUG=630696,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen

Review-Url: https://codereview.chromium.org/2177623002
Cr-Commit-Position: refs/heads/master@{#407248}

BUG=630719
TEST=N/A

Review-Url: https://codereview.chromium.org/2169173002
Cr-Commit-Position: refs/heads/master@{#407247}

BUG=630001
R=dtapuska@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2167883002
Cr-Commit-Position: refs/heads/master@{#407246}

The old v8::Isolate::GetCpuProfiler API is going to be deprecated soon.

Review-Url: https://codereview.chromium.org/2127423003
Cr-Commit-Position: refs/heads/master@{#407245}

This CL makes sure that MHTMLGenerationManager::JobFinished is
idempotent and doesn't do anything when called for a second time.
This avoids the crash from the linked bug.

BUG=612098

Review-Url: https://codereview.chromium.org/2163073002
Cr-Commit-Position: refs/heads/master@{#407244}

This is required by subsequence caching for spv2. When we copy a cached
subsequence, we won't do actual paint and will use the existing
PaintChunkProperties which points to the paint property nodes created
during the previous paint. We are sure that the values of these property
nodes didn't change since the previous paint because we can use the
cached subsequence.

To meet this requirement, when building the paint property tree, instead
of rebuilding the whole tree by creating all new nodes, we should reuse
the existing nodes if their values don't change. The reused nodes should
be placed in the new tree.

In the future we may also reuse a whole subtree of property nodes.

BUG=596983

Review-Url: https://codereview.chromium.org/2144823006
Cr-Commit-Position: refs/heads/master@{#407243}

Pull out the extensions code drag-and-drop handler in order to reuse it
in the MD extensions page. In the process, closure compiler DragWrapper
and create a real interface for the DragWrapperHandler, which previously
was only specified in comments. Update drag wrapper handler implementors
with @override.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2164693002
Cr-Commit-Position: refs/heads/master@{#407242}

Add a constructFlexItem function that does the computations
for creating a FlexItem, and returns it. Also add a couple more
cached pieces of data to FlexItem which simplifies code in
a couple of places.

constructFlexItem will also be useful for implementing the
new intrinsic size algorithm.

R=eae@chromium.org,dgrogan@chromium.org
TEST=n/a, no change in behavior

Review-Url: https://codereview.chromium.org/2170533002
Cr-Commit-Position: refs/heads/master@{#407241}

TouchPad pinch to zoom on Windows typically works via a WM_MOUSEWHEEL
message with the CONTROL flag in wParam and varying deltas. On touchscreen
Windows devices like Surface, the WM_MOUSEWHEEL event is flagged as a
synthesized message occurring due to a touch.

I think it is safe to allow all WM_MOUSEWHEEL events to be processed by
ignoring the touch flag as they don't appear to get synthesized via
standard touch scrolls.

Changes in this patch are as below:

1. Ignore the touch flag on WM_MOUSEWHEEL and WM_MOUSEHWHEEL messages.
2. Removed dead code in hwnd_message_handler.cc/.h which tried to set
   scroll styles on the window.

BUG=620182

Review-Url: https://codereview.chromium.org/2172843002
Cr-Commit-Position: refs/heads/master@{#407240}

Clearing them at the end of NavigateInternal causes problems when a
ScopedPageLoadDeferrer is in use.

Credit to thestig@ for the test framework changes.

BUG=626838
TEST=See bug for repro steps.

Review-Url: https://codereview.chromium.org/2140393002
Cr-Commit-Position: refs/heads/master@{#407239}

Cr-Commit-Position: refs/heads/master@{#407238}

Current Dockerfiles were written with a misunderstanding of how wildcards and directory sources interact with the ADD command. This was discovered in testing using the generated tarballs.

The change fixes an incorrect comment in the engine Dockerfile.

Additionally, create_bundle.py was updated to tar up the filesystem state from a context other than the build directory.

These changes mean that for the env_tests bundle, running the Dockerfile in the context of the tarball results in a system file structure such that /blimp/ contains the set of dpendencies for the testing binaries in the same directory structure as // (the chromium src directory).

This change does not remove the duplicate ./third_party/blimp_fonts (./fonts is used instead) for the engine environment.

BUG=616945, 608487, 630438

Review-Url: https://codereview.chromium.org/2154873002
Cr-Commit-Position: refs/heads/master@{#407237}

Fixes the Advanced toggle when navigating directly to Advanced.

Make currentRouteChanged_ less confusing. Wrap non-About stuff in a dom-if.

Removes a bunch of redundant properties.

Part of https://codereview.chromium.org/2106013002/

BUG=630010,589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2160713002
Cr-Commit-Position: refs/heads/master@{#407236}

[tools/perf] Disable benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:nytimes

BUG=630686
TBR=mpearson@chromium.org, petrcermak@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2178543002
Cr-Commit-Position: refs/heads/master@{#407235}

BUG=chromedriver:998

Review-Url: https://codereview.chromium.org/2175893002
Cr-Commit-Position: refs/heads/master@{#407234}

This class uses two buffers to decode mutiple frames. It will be used
by the chromoting client OpenGL renderer.

BUG=385924

Review-Url: https://codereview.chromium.org/2156713002
Cr-Commit-Position: refs/heads/master@{#407233}

Adds a missing class to properly space the Cancel button on the
Disconnect dialog in the People section.

BUG=630189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2161363006
Cr-Commit-Position: refs/heads/master@{#407232}

Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero.

BUG=628525

Review-Url: https://codereview.chromium.org/2158173002
Cr-Commit-Position: refs/heads/master@{#407231}

The public PGO builders do not do chrome-branded builds, so
can't reuse the existing 'official' mixin and need to split out
is_official_build from is_chrome_branded.

TBR=sebmarchand@chromium.org
NOTRY=true
BUG=595947

Review-Url: https://codereview.chromium.org/2180513002
Cr-Commit-Position: refs/heads/master@{#407230}

The test is marked as failing, but the baseline right now is clearly wrong,
so maybe it's actually passing. TestExpectations may need to be re-added if
it turns out to still be flakey.

TBR=chrishtr@chromium.org
BUG=526594

Review-Url: https://codereview.chromium.org/2178553002
Cr-Commit-Position: refs/heads/master@{#407229}

Revert of Cancel image loads if decoding failed. (patchset #8 id:140001 of https://codereview.chromium.org/2108033003/ )

Reason for revert:

Likely cause of failures:

webkit_tests webkit_tests:
http/tests/images/restyle-decode-error.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3384

---
10:19:32.937 5109 worker/0 http/tests/images/restyle-decode-error.html started
10:19:32.953 5111 worker/2 accessibility/animation-policy.html passed
10:19:32.955 5111 worker/2 accessibility/anonymous-render-block-in-continuation-causes-crash.html started
10:19:32.999 5109 renderer crash, pid = None, error_line = #CRASHED - renderer
10:19:33.000 5109 killed pid 5357
10:19:33.000 5109 worker/0 http/tests/images/restyle-decode-error.html crashed, (stderr lines):
10:19:33.000 5109   Received signal 11 <unknown> 000000000000
10:19:33.000 5109    [0x0001196ef23e]
...
10:19:33.002 5109   [end of stack trace]
10:19:33.002 5109   [5358:13319:0722/101932:598964195783:ERROR:node_controller.cc(1099)] Could not be introduced to peer C9E4F59A639F0E59.C2F8E762ADA8C89E
10:19:33.006 5084 [4832/40217] http/tests/images/restyle-decode-error.html failed unexpectedly (renderer crashed)
10:19:33.003 5109 worker/0 killing primary driver
10:19:33.004 5109 worker/0 killing secondary driver
10:19:33.004 5109 worker/0 http/tests/images/restyle-decode-error.html failed:
10:19:33.004 5109 worker/0  renderer crashed
---

Also same failure on other bots such as
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21244

(ignore other webkit failures on this bot; those all have a known cause with a fix incoming)

Original issue's description:
> Cancel image loads if decoding failed.
>
> 'Cancel' isn't really the right word for what this change does.
> In the event of an image decoding failure, ImageResource will
> synthesize a call to ResourceLoader::didFinishLoading, killing
> the actual network request but reporting it as a successful
> completion to the rest of blink. This matches our traditional
> behavior of decoding errors looking like a successful
> resource load (for the most part).
>
> This requires some plumbing changes to image decoding, because
> the decoder selection logic doesn't report why it wasn't able to
> create an ImageDecoder. It might be because insufficient data has
> been received to sniff the image type, or it may be that we
> definitely don't have a valid image type. This change exposes enough
> information to tell the difference.
>
> BUG=471272
>
> Committed: https://crrev.com/520519605b961a7d979bc0eaa3c057a973dc26f1
> Cr-Commit-Position: refs/heads/master@{#407171}

TBR=pdr@chromium.org,peter@chromium.org,japhet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471272

Review-Url: https://codereview.chromium.org/2173603003
Cr-Commit-Position: refs/heads/master@{#407228}

The preload scanner currently waits for the Application Cache to be
initialized before sending out any preloads. This is less important for link
rel preloads, which are directives to send a fetch as soon as possible.

This patch bypasses the fetch queuing for these preloads.

For link preloads in headers, we can issue these as early as the commit
point (for those which don't have a media attribute).

BUG=629420

Review-Url: https://codereview.chromium.org/2165653004
Cr-Commit-Position: refs/heads/master@{#407227}

The Android Nougat release is 7.0.

Review-Url: https://codereview.chromium.org/2172073002
Cr-Commit-Position: refs/heads/master@{#407226}

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kwQEHMwI/#gid=712129109).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2148843002
Cr-Commit-Position: refs/heads/master@{#407225}

This patch makes it possible to view and revoke permission to access a
USB device by going to an origin's "site settings" page.

This is a reland of r405887.

BUG=430999,601627

Review-Url: https://codereview.chromium.org/2170123002
Cr-Commit-Position: refs/heads/master@{#407224}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1852b91a..0cea24e0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2172283002
Cr-Commit-Position: refs/heads/master@{#407223}

https://chromium.googlesource.com/skia.git/+log/cbecb082d15d..4c6e47a8a827

$ git log cbecb082d..4c6e47a8a --date=short --no-merges --format='%ad %ae %s'
2016-07-22 jvanverth Recycle small uniform buffers.
2016-07-22 brianosman Connect dst color space in a few places (removing TODOs)
2016-07-22 mtklein Revert of Add SkRasterPipeline blitter. (patchset #18 id:340001 of https://codereview.chromium.org/2146413002/ )
2016-07-22 vjiaoblack Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2171423002
Cr-Commit-Position: refs/heads/master@{#407222}

The new channel will be used with WebRTC protocol to send video stats to
client to make it possible to measure round-trip latency.

BUG=621691

Review-Url: https://codereview.chromium.org/2176443002
Cr-Commit-Position: refs/heads/master@{#407221}

BUG=none

Review-Url: https://codereview.chromium.org/2178483002
Cr-Commit-Position: refs/heads/master@{#407220}

Revert of grit: Automatically replace ... with … (patchset #10 id:180001 of https://codereview.chromium.org/2112653003/ )

Reason for revert:
Likely cause of failures:

---
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/67858

unexpected_failures:
fast/forms/color/color-suggestion-picker-appearance-zoom125.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/color/color-suggestion-picker-appearance-zoom200.html

all with the message
image diff
---

since it appears to replace "..." with a proper ellipsis, which all the three
tests show differences from:

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67858/layout-test-results/results.html

also failures for

also some other bots for tests
fast/forms/color/color-suggestion-picker-appearance.html
fast/forms/color/color-suggestion-picker-one-row-appearance.html
fast/forms/color/color-suggestion-picker-two-row-appearance.html
appear on other bots.

And, for what it's worth,
the bot
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3384
started showing a renderer crash in
http/tests/images/restyle-decode-error.html
in a blamelist that includes this change as well.  Hopefully this revert will fix that too. :-)

Original issue's description:
> grit: Automatically replace ... with … (U+2026)
>
> Android lint tool pointed out that ... should really be … (U+2026).
> Tested that this glyph renders well on Mac + Win as well, so
> applying to all OS's by default.
>
> TBR=flackr
> BUG=621772
>
> Committed: https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43
> Cr-Commit-Position: refs/heads/master@{#407182}

TBR=flackr@chromium.org,asanka@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=621772

Review-Url: https://codereview.chromium.org/2176663003
Cr-Commit-Position: refs/heads/master@{#407219}

This CL changes NotificationPromo's HandleViewed/HandleClosed methods to
not update the current instance variables and just save the updated
values to prefs. This is needed because HandleViewed can be called
in the middle of the chain of CanShow calls made during layout of the
NTP, causing some CanShow calls to return true while others to return
false during the same layout. By not saving the updated values to the
current instance variables, the CanShow calls will remain consistent
during the same layout. To facilitate this change, this CL also changes
the return type of HandleViewed to void since the return value is never
used.

BUG=625192

Review-Url: https://codereview.chromium.org/2140173009
Cr-Commit-Position: refs/heads/master@{#407218}

This CL makes the separator line and hover color shared for MD.
It also shares the [actionable] styling.

BUG=521040
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2169603002
Cr-Commit-Position: refs/heads/master@{#407217}

This will make it easy for different parts of the ash wm code to
register accelerators.

BUG=612331
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2171973003
Cr-Commit-Position: refs/heads/master@{#407216}