GitLab

pageActions.enableForTab was using the same framework as the newer pageAction
API, which expects a tab ID for the first argument.

BUG=122833
TEST=Load the extension from the bug.


Review URL: http://codereview.chromium.org/10034037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132321 0039d316-1c4b-4281-b951-d872f2087c98

Reset tooltip_controller explicitly so that timer stops at shutdown.
Use tray_ reference in SystemTrayDelegate instead of going through ash instance.
Make sure delegates doesn't access tray after the tray has been deleted.

BUG=104998
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131902

Review URL: http://codereview.chromium.org/9968101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122363
TEST=Print webpage using system print dialog on Windows. Output should look normal.

Review URL: http://codereview.chromium.org/10071024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/10020052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132318 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10081026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121580, 122841
TEST=None


Review URL: http://codereview.chromium.org/9969164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132316 0039d316-1c4b-4281-b951-d872f2087c98

```--------------
Reason: build failure on Chromiumos Clang
```

--------------

In file included from chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:27:
./chrome/browser/chromeos/gdata/mock_directory_change_observer.h:17:3:error: [chromium-style] Complex constructor has an inlined body.
  MockDirectoryChangeObserver() {}
  ^
./chrome/browser/chromeos/gdata/mock_directory_change_observer.h:18:3:error: [chromium-style] Complex destructor has an inline body.
  virtual ~MockDirectoryChangeObserver() {}
  ^
2 errors generated.

-----------------

gdata: Remove OnDirectoryChanged from MockGDataSyncClient,
added MockDirectoryChangeObserver for directory change notifications. 

BUG=none
TEST=existing GDataFileSystemTest.*


Review URL: http://codereview.chromium.org/10081032

TBR=zelidrag@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10086027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132315 0039d316-1c4b-4281-b951-d872f2087c98

gdata: Remove OnDirectoryChanged from MockGDataSyncClient,
added MockDirectoryChangeObserver for directory change notifications. 

BUG=none
TEST=existing GDataFileSystemTest.*


Review URL: http://codereview.chromium.org/10081032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132312 0039d316-1c4b-4281-b951-d872f2087c98

R=pkotwicz@chromium.org
BUG=113624
TEST=Local bot run.

Review URL: http://codereview.chromium.org/10080006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123311
TEST=sadrul@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132294

Review URL: https://chromiumcodereview.appspot.com/10082008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132309 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132308 0039d316-1c4b-4281-b951-d872f2087c98

Also update P2PPortAllocator for compatibility with the latest libjingle
changes.

BUG=121613

Review URL: https://chromiumcodereview.appspot.com/10069046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132307 0039d316-1c4b-4281-b951-d872f2087c98

- Ability for WebContents to be replaced.
- Various focus/destruction observers.
- Hook up to BrowserView, replacing TabContentsContainer.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10073014

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10086026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132306 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10082037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132305 0039d316-1c4b-4281-b951-d872f2087c98

Revert 132290 - Remove a dcheck I just added since I apparently don't understand the various circumstances that result in this function being called.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10084027

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10080019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119250
Review URL: https://chromiumcodereview.appspot.com/9958034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123244

Review URL: https://chromiumcodereview.appspot.com/10082025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132302 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sail@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10083017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10007039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29052
TEST=GDataFileSystemTest.ChangeFeed_*

Review URL: https://chromiumcodereview.appspot.com/10006023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123311
TEST=sadrul@chromium.org


Review URL: http://codereview.chromium.org/10082008

TBR=oshima@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132298 0039d316-1c4b-4281-b951-d872f2087c98

Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows.

tim@ for OWNERS review of sync/...

BUG=122740
TEST=Added unit test.
TBR=tim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10031028

TBR=mrossetti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10086021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132297 0039d316-1c4b-4281-b951-d872f2087c98

Docked panels can be resized from all edges except the bottom.
Jianli will create a separate patch for Windows docked Panels.

This patch depends on http://codereview.chromium.org/10020057/ landing first.

BUG=None
TEST=Updated plus manual verification of resizing docked panels.

Review URL: http://codereview.chromium.org/10066032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132296 0039d316-1c4b-4281-b951-d872f2087c98

Don't register more than one 'connect' event handler per HostTableEntry. Don't create more than one HostTableEntry for the daemon UI.

BUG=121509
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10081027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123311
TEST=sadrul@chromium.org


Review URL: http://codereview.chromium.org/10082008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132294 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to make that change in my in-progress CL r131178 after migrating the
CookieTreeModel to use weak ptrs in r130767.

BUG=123393
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10073022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132293 0039d316-1c4b-4281-b951-d872f2087c98

The AppLauncherHandler class is not used on Android and has several
dependencies to the Browser object which is also not available on Android.
So excluding them on Android.

BUG=None
TEST=unit_tests on Android should not report AppLaucherHandler symbols missing
     when compiled.


Review URL: http://codereview.chromium.org/10031052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123205
TEST=This is a test


Review URL: http://codereview.chromium.org/10038027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132291 0039d316-1c4b-4281-b951-d872f2087c98

Remove a dcheck I just added since I apparently don't understand the various circumstances that result in this function being called.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10084027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132290 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the Extension copies in the renderers have the active permissions and not just those defined in the manifest.

BUG=123250
TEST=ExtensionApiTest.ContentScriptPermissionsApi


Review URL: http://codereview.chromium.org/10073011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132289 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132288 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r8250: (jvoung) Also make unsandboxed translator not link in pepper shims for SPEC.
r8251: (bradchen) Partially support running 32-bit glibc tests.
r8252: (jvoung) Remove workaround for __LITTLE_ENDIAN__ now that clang defines it for le32.
r8253: (ncbray) Remove experimental approach for supporting ChromeOS builds.
r8254: (mseaborn) dyncode: Remove some uncalled functions in dynamic_modify_test.c
r8255: (bbudge) Update Chrome revision in NaCl DEPS.
r8257: (mseaborn) Remove tools/modular-build, since it is not used any more
r8258: (jvoung) Update perf expectations for 252.eon transfer size.
r8259: (thakis) Delete run_sigpipe_test.
r8260: (thakis) Fix a typo in validator_x86_32.gyp
r8261: (dschuff) emit testsuite failure results in a format understood by buildbot error extension
r8262: (bradchen) Add a test for sincos and sincosf.
*r8263: (mseaborn) Move the Windows Cygwin x86-32 binutils assembler into deps/third_party
r8264: (mseaborn) NaClAppThread: Remove misleading comment

* This involves adding gnu_binutils to DEPS, since it's not longer under native_client.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2704
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10086013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132286 0039d316-1c4b-4281-b951-d872f2087c98

This also adds some cleanup in the Pepper API to provide typedefs for the three PPP_* functions. I removed some ad-hoc typedefes we had floating around and replaced them with these more "official" ones.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10069035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132285 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132284 0039d316-1c4b-4281-b951-d872f2087c98

There was a crash when disconnecting from a machine via Windows RDP.  RDP injects client machine printers into the host machine.  GetPrinterCapsAndDefaults blocks on these printers.  When the user disconnects, the printer is deleted and then GetPrinterCapsAndDefaults returns.  The failure handler fires and attempts to access the now-freed PrinterJobHandler that was passed with the callback resulting in a crash.

The solution is to pass a WeakPtr to the callback so that if the PrinterJobHandler is destroyed the
callback wont fire.

BUG=122996
TEST=Verify bug.


Review URL: http://codereview.chromium.org/10079017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132283 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10053019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132282 0039d316-1c4b-4281-b951-d872f2087c98

- Ability for WebContents to be replaced.
- Various focus/destruction observers.
- Hook up to BrowserView, replacing TabContentsContainer.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10073014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132281 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate three instances of them, and DCHECK on the condition for the future.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10079021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132279 0039d316-1c4b-4281-b951-d872f2087c98

used by this test for sections and import dlls, needed to be changed. These values
are different for X86 and X64.

BUG=123096
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132278 0039d316-1c4b-4281-b951-d872f2087c98